Changelog fails when viewing an update with relationship type ID change
Overview
This is a regression, but it goes back to 5.42 and isn't high priority so I don't think it needs to go in the RC (especially with a release about to be cut).
Reproduction steps
- Enable advanced logging.
- Make a change to a relationship type ID.
- Go into the contact's Change Log tab, select Update for the relevant change.
Current behaviour
DB Error: Syntax Error
.
Expected behaviour
Well, not that.
Comments
There was a change to return the label for a field where applicable, but done in such a way that any DAO that has the default $_fieldLabel
property of NULL
will get a syntax error. The $_fieldLabel
is used to generate the fields in a SQL SELECT
statement and can't be NULL
.