Financial record processing - extract to new class to faciliate cleanup
The recordFinancialAccounts and associated functions is spaghetti. With the BAO_Contribution class itself being so huge it's also not a great class for it to 'live on' if we are going to clean it up. My plan is
- move all the static functions that belong to this functionality to a new class (internal use only)
- once moved revist making them non-static / other cleanup. There are a bunch of feasible extractions but doing the grouping onto a class first will help
- fix validateAllPayments to run after the test testContributionFormStatusUpdate - this includes fixing the bug reported in #2694 (closed)