Regression: Smart group rebuild in default config crashes cron

When you run cron (job.execute), it crashes because of a recent refactoring that enforces type checking.

Steps to Replicate (can use dmaster.demo.c.o)

• Go to Administer » System Settings » Scheduled Jobs.
• Next to Rebuild Smart Group Cache, click Execute Now.

Expected Result

Job completes successfully.

Actual Result

TypeError: Argument 2 passed to CRM_Contact_BAO_GroupContactCache::getGroupsNeedingRefreshing() must be of the type int, string given, called in /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/BAO/GroupContactCache.php on line 132 in CRM_Contact_BAO_GroupContactCache::getGroupsNeedingRefreshing() (line 715 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contact/BAO/GroupContactCache.php).

In Scheduled Jobs, the default parameters for this job read:

limit=Number optional-Limit the number of smart groups rebuild

So limit is a string, but the new type checking enforces it being an integer.

This new function is only called in two places, and only one specifies a value, so I'm casting to int there.

assigned to @JonGold

added regression label

https://github.com/civicrm/civicrm-core/pull/20835

Since there's at least one Stack Exchange answer posting people here, I'll give some helpful suggestions for folks who need an answer now and don't know how to apply the patch I posted above.

• In Administer menu » System Settings » Scheduled Jobs, edit the Rebuild Smart Group Cache settings to read limit=0 instead of limit=Number optional-Limit the number of smart groups rebuild.
• You may want to read this documentation about optimizations, particularly the part about whether you want Rebuild Smart Group Cache enabled at all.

mentioned in commit 06cc9899

mentioned in commit 906d150f

This is merged to 5.40 and at this stage we are thinking we won't backport to 5.39 (although if someone feels otherwise & puts up a PR against 5.39 we would be OK to revisit that)

closed

changed milestone to %5.40.0

Please backport to 5.39 as this will live as ESR until 5.45, correct? Right now we have to manually change every instance for each client.

We have created a PR - https://github.com/civicrm/civicrm-core/pull/21007

mentioned in commit 61797d14

mentioned in commit 7ac22046