Regression dedupe threshold
From https://github.com/civicrm/civicrm-core/commit/246500181dbfcdc72a528ad4893e51f295fc3124
Code looks right on first glance to am debugging
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
- Show closed items
Link issues together to show that they're related.
Learn more.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- eileen added regression label
added regression label
- Owner
PR for this has been merged closing
- seamuslee closed
closed
A similar regression can be found in
master
at this time.I would be tempted to remove the
break
statement on line 146 which prevents the$actualTreshold
from being computed. Otherwise, only the weight of the first rule is taken into account.- bgm reopened
reopened
To reproduce on dmaster:
- https://dmaster.demo.civicrm.org/civicrm/contact/deduperules?action=update&id=3
- Change the total weight to 20, click save.
Yes it did. I also haven't noticed any side effects.
OK - here it is as a PR https://github.com/civicrm/civicrm-core/pull/20071
- Björn Endres added comp:Dedupe triaged labels
added comp:Dedupe triaged labels
- Björn Endres added sig:bug label
added sig:bug label
- eileen closed
closed
Please register or sign in to reply