Prevent double clicking submit button

Overview

A typical problem with HTML forms that if you click fast enough, you can submit the form twice - or more, mostly if the server response was slow. CiviCRM is no exception.

Reproduction steps

• Any page that has a standard form - without Ajax. (e.g. Find Contributions or New Contribution or Some of the result actions).
• Click submit button fast enough.

Current behaviour

Find Contributions

New Contribution

Send Invoice - Search Action Will send multiple emails.

Expected behaviour

Disable button during submission. Maybe something like Record Contribution (Ajax form Using the jQuery BlockUI Plugin)

Any thoughts on this?

PR: https://github.com/civicrm/civicrm-core/pull/19610

There is a feature for this it's just not on all forms because it was experimental at first. Maybe it's time to make it the default.

See https://github.com/civicrm/civicrm-core/blob/5.34.0/CRM/Core/Form.php#L179

and e.g. a place where it's used https://github.com/civicrm/civicrm-core/blob/5.34.0/CRM/Case/Form/Case.php#L78

changed the description

@DaveD You're right. Just adding submitOnce property to any form will solve the issue

However, For "Thank-you Letter for Contributions" form the button done didn't work - it should return me back to search result page.

Right I think I had that problem with cdntaxreceipts too. Anything that triggers a download might need some adjusting. Although at least the download still works. I don't have a quick answer.

@eileen I want to send PR to enable submitOnce for:

• CRM/Contribute/Form/Task/Invoice.php (Invoices print/email - Search Action)
• CRM/Contribute/Form/Contribution.php (Create new Contribution)
• CRM/Contribute/Form/Search.php (Search page)

Which don't need any adjusting.

Yep - this is a good thing to do - preferably early in the release cycle (which we are) to give it longer in master/rc - I think @DaveD is more up with the implementation details than I am

added ~88 triaged labels

added sig:legacy-ui label

added type:proposal label

changed the description

@DaveD I edited the issue's description with the PR link which enable it for 37 forms if only the form's buttons still work correctly afterwards.

Cooool. Will take a look.

added current sprint label

assigned to @JoeMurray

assigned to @monish.deb and unassigned @JoeMurray

mentioned in commit 88aae6d4

mentioned in commit a9f0c32c

mentioned in issue #2465 (closed)

changed milestone to %5.36.0

This was merged

closed