Remove 'onlinePendingContribution' payment support from membership edit form
I want to proposed removing support for 'onlinePendingContribution' from the Membership Edit form.
What is onlinePendingContribution support you ask? It's this box on the membership edit form
Hey but I've never seen that box! Well you only see if if someone has created a pending pay later membership through an online form which you later complete through the membership edit form
And it allows you to send a customised receipt? No, it says you can, you can't
How else would someone complete that contribution?
Well - they could do it the same way they would for a pending contribution created in any other way - use the link a moment further down the page
And why do you want to remove it
There is considerable code complexity needed to support it - about 85 lines of code. Oh, and it's broken in master
But how do we know no-one is using it
Well I tested on 5.21 & it's broken there too so my guess is is has broken for a long time....