Possible regression on deleted contacts

https://civicrm.stackexchange.com/questions/37931/mailing-to-a-contacts-in-a-group-deleted-contacts-were-included-to-the-list-of

added regression label

Problem also exists in 5.30, emailing a smart group incudes contacts in the trash (that were in the smart group)

To replicate:

Set up a smart group with a contact in it. Create a mailing to that contact. Schedule the mailing Delete the contact Send the mailing

I've only been able to replicate this when the Deletion happens after the mailing has been sent.

However I'm not sure this is a recent regression - I replicated on civicrm 5.25. In fact I'm wondering if this is associated with the mailing recipients not being recalculated on send. i.e. -> https://issues.civicrm.org/jira/browse/CRM-20352

Thanks @luke.stewart that clarifies it - I think this will do it then https://github.com/civicrm/civicrm-core/pull/18763 - there was an old hack that abused acls to add in is_deleted = 0 that got cleaned up a few releases back - it might have been 'protecting' this flow inadvertantly

mentioned in commit 44923226

mentioned in commit 8af44ce5

Fix merged to 5.30 & being ported to 5.31

@luke.stewart pointed out the mailing reports may also need is_deleted filtering

closed

changed milestone to %5.31.0

changed milestone to %5.30.1

mentioned in commit b0ecd18d

mentioned in issue #3098 (closed)