Drupal 7 - Groups children now get shown with SPAN CSS error

Since 5.29.0 this error was introduced. Its only present in edit mode and only present for CHILD Terms

Under View Contact Child groups get shown correctly.

There is some discussion of this on Mattermost here.

@monish.deb @eileen suggested this may be something you could take a look at?

@MikeyMJCO @eileen this seems like a bug with CRM_Contact_BAO_Group::getGroupsHierarchy() where if a spacer (added before a child group title to distinguish the group as a child group) got an HTML tag then its been rendered as a raw text. I can replicate this bug in other places where this fn is been used adding hierarchical group widget. Like on 'Find Contact' search form:

As a workaround we can use this:

diff --git a/CRM/Contact/Form/Edit/TagsAndGroups.php b/CRM/Contact/Form/Edit/TagsAndGroups.php
index 9299246d9b..fc8ca17e82 100644
--- a/CRM/Contact/Form/Edit/TagsAndGroups.php
+++ b/CRM/Contact/Form/Edit/TagsAndGroups.php
@@ -88,7 +88,7 @@ class CRM_Contact_Form_Edit_TagsAndGroups {
       }
 
       if ($groupID || !empty($group)) {
-        $groups = CRM_Contact_BAO_Group::getGroupsHierarchy($ids);
+        $groups = CRM_Contact_BAO_Group::getGroupsHierarchy($ids, NULL, '- ');
 
         $attributes['skiplabel'] = TRUE;
         $elements = [];

But still, the correct fix would be to translate the spacer string into HTML entities.

added regression label

@monish.deb I don't really know this code & I think I won't recover quickly from taking a quick look.... That fix seems similar to other places in the code & if it doesn't have side effects it would be good to get a quick fix out

Agree. Submitted PR https://github.com/civicrm/civicrm-core/pull/18718

https://github.com/civicrm/civicrm-core/pull/18724 5.30 backport

closed

changed milestone to %5.30.0

mentioned in commit baaa0a25

mentioned in commit 94299eb3

mentioned in commit ec6bf8aa

mentioned in commit d928c43b

mentioned in issue #2133 (closed)

with Version 5.30.1 the groups are now FINALLY Fully DEAD.

Please fix

reopened

Please don't reopen closed issues for unrelated behaviour. Also comments like "please fix" are not helpful behaviour. Submit a PR yourself or submit a new issue for the groups not showing.

closed

If the PR is definitely the cause - discussion should happen on the PR for now.

mentioned in issue #2136 (closed)

mentioned in issue #2004 (closed)