Add testcases to civicrm-core PR #11291

Ref. https://github.com/civicrm/civicrm-core/pull/11291

The above PR adds case tokens support to email activities. We need test cases for the above PR to complete it.

I am working on this ticket now. I have written two test cases and have issues with the 2nd one Details:

1. To test case tokens replacement - here I have created a test 'contact' and a 'case', add a html string with case tokens, use CRM_Utils_Token::replaceCaseTokens to verify if the tokens are replaced properly.
2. To test sending email with case tokens in body. Here I have created a test 'case' and used CRM_Activity_BAO_Activity::sendEmail (with $caseId parameter passed) and got the activity id returned from sendEmail. I am expecting to see the caseId being associated with the activity but its not there (I am using an api to get activity with ['return' => 'case_id']) I am not completely sure if this is how this PR needs to be tested. Can someone pls help with this?

added Concept approved triaged type:proposal labels

Giving this concept approved is a no brainer :-)

Looks like you have already pinged @colemanw on gitlab but adding him here too so he will be on the ticket

Hey @varshith can you link to your test so we can take a look?

@colemanw Sorry for the delay I missed the notification. Here are the tests https://github.com/vinuvarshith/civicrm-core/commit/7e2326eef8399a1e716f296b3b79ff6213fc09a8

@varshith @colemanw What is the next step here. Can the tests be added to the PR so they are run by jenkins

mentioned in commit edc10fa4

added 1 deleted label

this was merged a while back & testSendEmailWithCaseId has since been extended to cover what is actually sent out

closed