Advanced Search returns contacts in Trash even if 'Search in Trash' not ticked.

Overview

Advanced Search returns deleted contacts (i.e. contacts in Trash) even if the 'Search in Trash' is not ticked. Also, the Search results don't appear to know that the contact is deleted.

Reproduction steps

1. Click on Advanced Search.
2. Do not tick Search in Trash.
3. Click on "Search".

Current behaviour

Deleted contacts are returned in the list.

and

shows that the contact is in Trash.

Expected behaviour

Deleted contacts should not appear in the list.

Environment information

• Browser: Irrelevant
• CiviCRM: 5.27.0 but also appears in 5.29.alpha1
• PHP: Irrelevant_
• CMS: Joomla 3.9.6 but probably irrelevant
• Database: MySQL 5.7.30 but probably irrelevant
• Web Server: Irrelevant

Comments

It was introduced in 5.27.0. 5.26.2 does not show this behaviour.

added regression label

Seems to be from https://github.com/civicrm/civicrm-core/pull/17379/files

If I revert that change it works again.

@DaveD Many thanks - that saves a lot of troubleshooting.

@DaveD Your input was most helpful. It allowed me to created PR dev/core#1864 Correct problem with returning all records when not specifying Search in Trash #17790 very quickly.

Thanks for the PR. I think the difficulty is trying to reconcile with what the other PR was trying to do which seems to be to fix a problem with the search when used with ACLs, which would now return. So I'm not sure where the fix should go to satisfy both.

Right, as I said on the PR, we need to add the is_deleted clause back in, but in a more appropriate place.

Excluding deleted contacts from search results has nothing to do with ACLs, so putting it in the ACL layer is always going to cause problems.

Maybe a compromise is revert in 5.27/5.28 and then leave it as-is in master for now and think about it? By the way it also affects civireport results.

That makes sense.

Ok have added https://github.com/civicrm/civicrm-core/pull/17793

@DaveD @colemanw Thanks for your efforts. Your knowledge of the process is much greater than mine. Is there anything more you need from me, or should I leave things in your hands?

Thanks. You could close your PR - it will still be in the records. Thanks for reporting the issue.

@DaveD Thanks, done!

See https://github.com/civicrm/civicrm-core/pull/17798

mentioned in commit 3bad60ad

mentioned in commit 3d3b6a38

mentioned in commit 54b8719b

closed

changed milestone to %5.27.2

mentioned in commit b5919dad

mentioned in commit aa6263f0

Thanks for fixing this bug, much appreciated!