Domain specific entities on multisite are not respected after upgrade to 5.23.4
Overview
After upgrading to 5.23.4 on multisite the from email address and membership type that should respect the domain ID are not. After clearing cache with cv flush whichever domain ID I go to first shows 'correctly' but then that would be the membership organization shown on any other domain I'd go to subsequently. Seeing another domain membership types other than the domain's org membership types. Seeing this with the default from address when going to actions > send email and membership when adding or renewing a membership.
Membership Error Reproduction steps
- Run cv flush
- Go to a contact
- Click membership tab > add membership
- AJAX modal pops up and the Membership Organization and Type is that of the domain.
- Go to another domain and run steps 2-4 and it will be the same membership organization (incorrect) in step 4. Repeats on all other domains.
From Email Address Reproduction steps
- Go to a contact
- Click actions > send email
- You'll see incorrect from email address for the domain
Current behaviour
Domain specific entities are not respected
Expected behaviour
You should only see your Membership Organization and Type and its membership types when adding a membership. You should only see from email address of the organization domain when sending an email.
Environment information
- CiviCRM: 5.23.4
- PHP: 7.2.28-3+ubuntu18.04.1+deb.sury.org+1
- CMS: WordPress 5.3.2
- Database: MySQL 5.7.29
- Web Server: Apache/2.4.41 (Ubuntu)
Are others seeing this?