Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 924
    • Issues 924
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #1554

Closed
Open
Opened Jan 28, 2020 by luke.stewart@luke.stewart

URL Encoded values for event pages work but cause style changes

Overview

In Drupal 7

Both: (A) civicrm/event/info%3Freset%3D1%26id%3D7 and (B) civicrm/event/info?reset=1&id=7 appear to show the same page however for anon viewers the custom-civicrm.css is loaded on (A) but not (B) and for logged in users if a different civicrm admin theme is set this is used to render the page instead for (A).

The version (A) is what is provided by default when using drupal views to display a link to events.

Reproduction steps

  1. Change the civicrm admin theme to be different to the default theme.
  2. Add a civicrm custom stylesheet via /civicrm/admin/setting/url?reset=1 or install the shoreditch extension.
  3. Create an event
  4. visit the event info page via the URL encoded link and compare to the non url encoded link.

Current behaviour

EventPage

When viewed logged in with permission to view civicrm admin theme (A) displays using the admin theme (B) using the default theme. When viewed as anon - or logged in civicrm-custom.css is loaded on (A) and not (B)

Expected behaviour

Both pages should be identical.

Environment information

  • CiviCRM: 5.21.1
  • CMS: Drupal 7.x
  • Web Server: Nginx

Comments

Of relevance:

#378 (closed)

https://github.com/civicrm/civicrm-core/pull/14876

https://chat.civicrm.org/civicrm/pl/iqg97j674fbn5d5jsf1n8qjnby

Edited Jan 28, 2020 by luke.stewart
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#1554