Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 920
    • Issues 920
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #1397

Closed
Open
Opened Nov 15, 2019 by Rich@artfulrobotDeveloper

Warnings about missing index during SmartGroup migration in upgrade to 5.19.1

Overview

During an upgrade (from 5.13 to 5.19.1) I saw lots of these errors/notices/warnings:

Uninitialized string offset: 0 SmartGroups.php:178

I don't think this is harmful, but it should be fixed.

CRM_Upgrade_Incremental_SmartGroups::renameField() assumes that the saved form_values is an array with an item at index zero.

For whatever reason we had lots of groups where this wasn't - but presumably this affects all hidden 'smart' groups created when you do a mailing to (selected) search results.

Expected behaviour

Upgrade should run cleanly. We should fix this for the next release.

Environment information

  • PHP: 7.0
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#1397