Skip to content
Snippets Groups Projects
New look: Off

Deprecate Tell a Friend

    • Closed Issue created by Andie Hunt @andie

    Who tells their friends anymore? This really should be removed or deprecated. @JonGold came up with this idea and @bgm thought it would be worth opening an issue for it.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    • bgm
      bgm @bgm ·
      Owner

      Use-case: as a user, I want to email a link to a friend. I won't type in their email address, because I don't remember it. I will open my email, use an autocomplete or contact list, and while I'm there, I may as well send the email directly from my email.

      One practical thing about tell-a-friend: suggesting a message that can be copy-pasted when sending an email.

      On the other hand, I have to admit that one client that uses it with some success. It's a nice feature, but it's missing some key features (import emails from gmail/outlook), and most of those emails end up in the spambox anyway because they will rarely be sent properly (the from cannot be the user's email, it has to be a generic email.

    • jaapjansma added ~88 needs:concept approval triaged labels

      added ~88 needs:concept approval triaged labels

    • jaapjansma
      jaapjansma @jaapjansma ·
      Developer

      Is this the tell a friend on event pages?

    • bgm
      bgm @bgm ·
      Owner

      Yep, Event and Contributions.

    • herbdool
      herbdool @herbdool ·
      Developer

      It also works with Personal campaign pages with a link to their PCP.

      I say strip it down to just providing one thing: a message that can be copy-pasted into an email or other social media. The message can include the unique link for event, contribution page or PCP.

      As it is now we can't use it because it doesn't obey SMTP requirement of the from address using the sending domain.

    • ****
      **** @support_bot_dev ·
      Reporter

      Hi,

      Thank you for raising an issue to help improve CiviCRM. As you may know, this issue has not had any activity for quite some time, so we have closed it.

      We would like you to help us to determine if this issue should be re-opened:

      • If this issue was reporting a bug, can you attempt to reproduce it on a latest version of CiviCRM?
      • If this issue was proposing a new feature, can you verify if the feature proposal is still relevant? Did it get the concept-approved label? Have other people also shown interest? Could it be implemented as an extension?

      If the answer to either question is yes, please feel free to comment or re-open the issue. Please also consider:

      • Is it something that you could help implement, either by sending a patch or hiring someone who can?
      • Would you be willing to fund the work, either through a CiviCRM partner, or the Core Team?

      Thank you for your help and contributions to CiviCRM.

      P.S. This is an automated message, see infra/gitlab issue 20. We understand that automatic responses are annoying, but given the number of open issues as the project evolves, we need a bit of help to triage and prioritise the most relevant issues.

    • **** closed

      closed

    • JonGold
      JonGold @JonGold ·
      Developer

      Reopening this - I think I can work on this if we get the concept approved.

    • JonGold reopened

      reopened

    • bgm
      bgm @bgm ·
      Owner

      I think ultimately it's up to mergers/product-mtce to decide, but personally I'm still in favour:

      • No one types email addresses anymore, they select from their contacts or auto-complete a name
      • Ingesting email addresses that way could cause GDPR/equivalent problems, as we don't have consent for emailing them

      Ideal would be to move it to a core-extension, enable on upgrades, disable on new installs. It might not be easy though, especially since it has a multi-lingual database table.

      (I'll post in the product-mtce channel, see if Eileen can add it to the dev-digest)

    • colemanw
      colemanw @colemanw ·
      Owner

      +1 for a core extension migration. That's a good way to deal with functionality we don't want in core but don't want to delete completely, at least not yet. The upgrade script IMO could be a little more discerning than enabling on all existing sites and only enable on the ones using the feature.

    • Michael McAndrew
      Michael McAndrew @michaelmcandrew ·
      Developer

      Who tells their friends anymore?

      I think people do still tell there friends things - they just don't do it using this functionality. Moving it it an extension sounds like a great idea since I assume any hooks, regions, etc. required to do so could also be used to create more sophisticated sharing tools.

    • bgm removed needs:concept approval label

      removed needs:concept approval label

    • bgm added Concept approved label

      added Concept approved label

    • colemanw
      colemanw @colemanw ·
      Owner

      This issue is now Concept Approved. Be sure to tell your friends.

    • Rich
      Rich @artfulrobot ·
      Developer

      I agree with moving this functionality out. I can't see how it's GDPR compliant anyway!

    • cividesk
      cividesk @cividesk ·
      Developer

      Yes, let's do away with this function and put more emphasis on sharing to social networks.

    • guyiac
      guyiac @guyiac ·

      I think we should have something more like "Share" functionality that allows the user to share that content to any app or program on their device. When I choose "Share" on a piece of content in Facebook on my iPhone, I can share it to on my Facebook page, or someone else's, but I can also share it in Facebook messenger, or text messages, or email, or Google Chat, or Whatsapp, or Skype, or Instagram, or LinkedIn, or.....The point is that where I can share the content is decided by whatever networks I choose to be a part of by having the apps on my device, not just by Facebook. It would be nice if our content had the same functionality.

      Edited by guyiac
    • larsssandergreen
      larsssandergreen @larssg ·
      Developer

      We already have the "Help Spread the Word" Email share link (the mailto: one that goes with Twitter, FB and LinkedIn share links, enabled on the main event settings page), which seems much more likely to be used than a form that you have to enter email addresses into.

      Might be useful to have a suggested message for the mailto: share (we could also have a suggested Tweet, not sure about LinkedIn), but the rest of Tell a Friend can be gotten rid of.

    • ****
      **** @support_bot_dev ·
      Reporter

      Hi,

      Thank you for raising an issue to help improve CiviCRM. As you may know, this issue has not had any activity for quite some time, so we have closed it.

      We would like you to help us to determine if this issue should be re-opened:

      • If this issue was reporting a bug, can you attempt to reproduce it on a latest version of CiviCRM?
      • If this issue was proposing a new feature, can you verify if the feature proposal is still relevant? Did it get the concept-approved label? Have other people also shown interest? Could it be implemented as an extension?

      If the answer to either question is yes, please feel free to comment or re-open the issue. Please also consider:

      • Is it something that you could help implement, either by sending a patch or hiring someone who can?
      • Would you be willing to fund the work, either through a CiviCRM partner, or the Core Team?

      Thank you for your help and contributions to CiviCRM.

      P.S. This is an automated message, see infra/gitlab issue 20. We understand that automatic responses are annoying, but given the number of open issues as the project evolves, we need a bit of help to triage and prioritise the most relevant issues.

    • **** closed

      closed

    • herbdool reopened

      reopened

    • A deleted user added has-pull-request label

      added has-pull-request label

    • bgm
      bgm @bgm ·
      Owner

      I had a go at moving code around: https://github.com/civicrm/civicrm-core/pull/30222

      It's not perfect, since the SQL tables are still in core, and there is a few places in core that would need more cleanup if we wanted it to be fully optional.

      Personally, my procrastination can only go so far. I would not do further work on this (except small bugfixes). If the PR is merged, I would wait a year, and based on feedback, decide what to do with that code.

      Currently in PR#30222, the tellafriend is only enabled if the upgrader found one active "tell a friend" page. Otherwise, it stays inactive. We could add a System Check in tellafriend (only visible to installs have the extension enabled) to let people know that the feature is going to be deprecated, and to provide feedback if they would like to keep it.

    • mattwire mentioned in commit 5aceed84

      mentioned in commit 5aceed84

    • bgm mentioned in commit 5f3cc126

      mentioned in commit 5f3cc126

    • bgm
      bgm @bgm ·
      Owner

      Merged :tada:

    • bgm closed

      closed

    • bgm changed milestone to %5.76.0

      changed milestone to %5.76.0

    Please register or sign in to reply