#723 [REF] extract chunk of code that definitely does something.

[REF] extract getConflicts function

This is a really blunt extraction of a chunk of code whose Raison D'Etre I don't quite know as yet.

I've done the absolute minimum variable cleanup to keep it really clean in the first instance

This is for readability but I also want to add an api that retrieves conflicts without
trying a merge for more control

[REF] Extract get cfields function

#561 Remove last free jcalendar

#830 [REF] Add unit tests on contribution recur trxn_id, contribution recur processor id

This is the last jcalendar outside of buildDateRange instances.

It turns out to be 'just a form' and pretty straight forward

#723 [REF] Declare contactType var rather than using long array syntax.

[cleanup] remove CRM_Report_Form_Extended

#248 - Fixes advanced search mailings results headers

(NFC) Expand unit test to show off double protocol error

Expand test to include situation if the Other protocol is set rather than a specific protocol

Make test portable

This file was added to core around 4.2 but for various reasons the ExtendedReport intiative
moved to an extension & it was never used. This just removes it

Very small tidy up for legibility

 [REF] move gathering of location info to relevant function (towards #723)

#560 Remove a couple of instances of fatal errors in favour of throwing exceptions

[REF] Move the qfbug handling to it's own function (towards #723)

Fixed double protocol being added in link by CKEditor.

#560

We have a loop that parses the migrationInfo to get just location fields which we loop through, but
migrationInfo is already available in the moveLocationInfo fn so we can just handle that param in there
& improve code readability (we do a little less array looping but it's pretty cheap & the code
readabiliity is a real issue here

This is a really toxi function. In order to save the pain or iterating multiple times through a small array
we are dealing with an awful lot of complexity. I'm changing this to iterate through it multiple
times in order to rationalise the code - I think performance is minimal & being able to read the code....

#832 CiviCase: rebuild case activity views during upgrade

Removes language from advanced search results mailings column
headers for non-multilingual sites.

[REF] Use events for CMS resource loading

This is preliminary cleanup towards exposing cancel_reason as a search field, as committed to in proposal to
add the field. This change

- adds unit tests for the trxn_id & processor_id fields
- makes the handling of them more generic
- adds contribution recur field data to the contribution query object so it can be accessed.

Some points about the last of these. Basically we have a situation where the query object needs metadata to
avoid field by field handling. We have done this is some wierd & wonderful ways with dependencies on 'import' &
'export' metadata info to the point where they were given to so many fields as to become meaningless.

I think this method is better - ie. just adding the additional metadata to the query class for all the entities it
deals with. A recently merged PR means 'where' data is still available using this method.

Also I have added uniquenames to the contribution recur fields. Uniquenames no longer really matter outside
- the query object
- profiles
- possibly import & export

We only really expose recurring contribution info through the query object of these so it should be safe. In a future happy
space apiv4 & namespacing will render uniquenames a distant memory.

I couldn't rip out the special handling entirely without dealing with the labels that go into the qill. I figure
we should merge this & then address that - but briefly the issue is that Matt has just changed all the labels
to not quite work in this context so we need to discuss / agree how to manage 'Recurring Contribution Trxn ID' vs
'Trxn ID'.

I also didn't want to rip out the special handling fully in advance of https://github.com/civicrm/civicrm-core/pull/14118
being merged as there could be a performance regression if we let more code hit that unnecessary join line

5.13

Add 5.12.4 release notes

Case activity query performs poorly on large databases

[REF] Use variable for menubar height