[TEST] #1366 Unit test for case audit

Fix api Payment.create to support overpayments

CSV Export: Add deprecation warning

dev/core1329 Reduce number of deceased contacts in the demo data from…

Limit number of deceased contacts to 4 and add in age checks as per Justin

#1366 - Make case activity audit print report work again

Fix potential test glitch when repeatedly calling createLoggedInUser

[REF] Remove unused parameter

5.20

This parameter is always TRUE so it adds no value, removing

#1046 Status check for external case xml files

Remove unused parameter

Fix deprecation warning on Price Set report

Rename activity search field from status_id to activity_status_id

[REF] CSV Export: Remove impossible checks on  var

#1420 Quicksearch with phone filter doesn't work with non-numeric character

Remove unused functions

#1398: Option to open navigation item in new window (if present)

Remove join to civicrm_option_value in favour of using getLabel funct…

These functions are no longer needed now that KAM is merged into core.

[REF] Further cleanup on address handling in merge code.

Enable Case search metadata on Advanced Search Form

This variable is hard-coded to a double quote so checks to see if it is a single quote will never be true.

I've checked this pretty thoroughly & I think the removed IFs are dead code

#560 Replace instances of CRM_Core_Error::fatal with Exceptio…

There are 3 calls to writeCSVFile - none of them pass in saveFile so it can be removed

In 5.20 we added a deprecation warning on searches that are borked WRT filling the prev_next
cache & hence doing searches. The price set search falls into this camp & while it has
been broken forever the deprecation notice is new (& the fix is safe) so targettin 5.20

On digging into this export function I cannot find any way to access these lines.

If no-one else can spot a way I propose adding a deprecation notice & later removing

This is a follow on from https://github.com/civicrm/civicrm-core/pull/15949

This doesn't make any change - it just improves legibility

#560 Replace instances of CRM_Core_Error::fatal with Exceptions or Status bounces in SMS processing and appropriately handle error after

[REF] Minor code cleanup on the setting of contact greetings.

Sort CMS Database Table list

[UI] Ensure that when sorting on columns in the find activity search …

I'm trying to review https://github.com/civicrm/civicrm-core/pull/15725 but through no fault of that PR it hits
on one of the parts of the Export code that I still find unreadable :-( This is a further readability fix & it
starts to point me to how to get past the underlying WTF about this code.

Note that I removed the IF around sharedAddress. From Monish's PR I found out that we have a
fairly long-standing regression where the sharedAddress code doesn't actually work :-( so
I'm comfortable this won't break anything :-). We also have good test cover on this chunk from
probably around when the shared address part got broken....

Looking in the UI there is no implication that the greeting for a shared address would display differently -
which is the only explanation I can think of for different handling here. Of course until we
remove the later IF the shared address would do things differently - erm if it worked.

ALl of which is a long way of saying the removal of the IF won't change anything

Currently this is on the form as 'status_id' but as soon as it's submitted the value is renamed - I think
we might not even need to change the smart group for this one.

The other field that is being renamed is 'priority_id'. Unless we have an appetite to
add a uniqueName for this field (which I kind of feel like not doing more of for some
cycles), I think we could stop renaming it & rely on the default where handling for the
where clause. From what I can see the reason for prefixing is not about
uniqueness but rather about adding a prefix so it gets handled by
Activity_BAO_Query - but in fact Contact_BAO_Query should handle it just fine
based on metadata