5.25.0 release notes: halfway through final edits

fc6522d4 · Andie Hunt · 9a4c3174 · fc6522d4
Commit fc6522d4 authored 4 years ago by Andie Hunt
--- a/release-notes/5.25.0.md
+++ b/release-notes/5.25.0.md
@@ -25,15 +25,6 @@ Released May 6, 2020

 ### Core CiviCRM

- **Replace jcalendar instances with datepicker (Continued
-  Work [dev/core#561](https://lab.civicrm.org/dev/core/issues/561):
-  [15709](https://github.com/civicrm/civicrm-core/pull/15709) and
-  [16863](https://github.com/civicrm/civicrm-core/pull/16863))**
-
-  These changes continue work to move to datepicker from jcalendar by converting
-  report instances from using the legacy jcalendar to using datepicker for date
-  fields and deprecating the `addDateRange` function used by jcalendar.
-
 - **End of life plans for php 7.0 & deprecate php 7.1
  ([dev/core#1528](https://lab.civicrm.org/dev/core/issues/1528):
  [16753](https://github.com/civicrm/civicrm-core/pull/16753),
@@ -45,15 +36,20 @@ Released May 6, 2020
  [187](https://github.com/civicrm/civicrm-wordpress/pull/187) and
  [184](https://github.com/civicrm/civicrm-wordpress/pull/184))**

-  Consolidates to a single constant for minimum PHP version. Sets the Minimum
-  PHP version to be 7.1. Sets the Minimum Install version to be 7.1.
+  CiviCRM now requires PHP 7.1 at a minimum and recommends PHP 7.3.

- **updating misleading labels on buttons to confirmation pages
-  ([dev/core#1613](https://lab.civicrm.org/dev/core/-/issues/1613):
-  [16651](https://github.com/civicrm/civicrm-core/pull/16651))**
+  In the process of making this change, the minimum PHP version is now stored in
+  a single place within the core codebase.  CMS-specific files have this value,
+  too, but tests enforce that it be the same as the single core value.

-  Changes the text of the confirm contribution (and event registration) button
-  to "Review".
+- **Replace jcalendar instances with datepicker (Continued
+  Work [dev/core#561](https://lab.civicrm.org/dev/core/issues/561):
+  [15709](https://github.com/civicrm/civicrm-core/pull/15709) and
+  [16863](https://github.com/civicrm/civicrm-core/pull/16863))**
+
+  These changes continue work to move to datepicker from jcalendar by converting
+  report instances from using the legacy jcalendar to using datepicker for date
+  fields and deprecating the `addDateRange` function used by jcalendar.

 - **APIv4 - Add Dashboard & DashboardContact entities
  ([16867](https://github.com/civicrm/civicrm-core/pull/16867))**
@@ -64,23 +60,26 @@ Released May 6, 2020
 - **add nl_BE language
  ([17014](https://github.com/civicrm/civicrm-core/pull/17014))**

-  Adds a new translation option for "Dutch (Netherlands)".
+  Adds a new translation option for "Dutch (Belgium)".

 - **Add hook to alter display value or Custom field value
  ([16921](https://github.com/civicrm/civicrm-core/pull/16921))**

-  Adds a hook to alter display value or Custom field value.
+  The new hook
+  [`hook_civicrm_alterCustomFieldDisplayValue()`](https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_alterCustomFieldDisplayValue/)
+  allows modification of the displayed value for a custom field value.

 - **APIv4 Query Improvements (Work Towards
-  [dev/report#31](https://lab.civicrm.org/dev/report/-/issues/31):
+  [dev/report#31](https://lab.civicrm.org/dev/report/issues/31):
  [16917](https://github.com/civicrm/civicrm-core/pull/16917) and
  [16947](https://github.com/civicrm/civicrm-core/pull/16947))**

-  Builds out the APIv4 framework to support GROUP BY and different types of
-  expressions in clauses that previously only accepted the names of fields.
-  These expressions can now include numbers, NULL, strings, and whitelisted SQL
-  functions. The framework can in theory handle most SQL functions, but this
-  first PR adds support for the aggregate functions AVG, COUNT, MAX, MIN & SUM.
+  This change builds out the APIv4 framework to support `GROUP BY` and different
+  types of expressions in clauses that previously only accepted the names of
+  fields. These expressions can now include numbers, `NULL`, strings, and
+  whitelisted SQL functions. The framework can in theory handle most SQL
+  functions, but this first PR adds support for the aggregate functions `AVG`,
+  `COUNT`, `MAX`, `MIN`, and `SUM`.

 ### CiviContribute

@@ -88,20 +87,20 @@ Released May 6, 2020
  [dev/financial#87](https://lab.civicrm.org/dev/financial/issues/87):
  [16480](https://github.com/civicrm/civicrm-core/pull/16480))**

-  Alters the "Add Payment" form to permit payments to be added even if a
+  The "Add Payment" form is altered to permit payments to be added even if a
  contribution is fully paid.

- **Add privacy fields to ContributionDetail report
+- **Add privacy fields to Contribution Detail report
  ([16674](https://github.com/civicrm/civicrm-core/pull/16674))**

-   Adds columns for the following fields to the contribution detail report: "Do
-   Not Phone", "Do Not Mail", "Do Not SMS", "Do Not Trade".
+   Columns for the following fields are added to the contribution detail report:
+   "Do Not Phone", "Do Not Mail", "Do Not SMS", "Do Not Trade".

 - **Add "pledge id" as column and filter in Contribution Detail report.
   ([16868](https://github.com/civicrm/civicrm-core/pull/16868))**

-   Improves the Contribution Detail Report by adding "pledge id" as a filter and
-   column.
+   This change improves the Contribution Detail Report by adding "pledge id" as
+   a filter and column.

 ### WordPress Integration

@@ -109,41 +108,12 @@ Released May 6, 2020
  ([185](https://github.com/civicrm/civicrm-wordpress/pull/185) and
  [16695](https://github.com/civicrm/civicrm-core/pull/16695))**

-  Makes Personal Campaign Pages available as a shortcode.
+  Personal Campaign Pages are now available as a shortcode.

 ## <a name="bugs"></a>Bugs resolved

 ### Core CiviCRM

- **Making the poor performance associated with the creditnote_id field opt in
-  rather than opt out (Further Work
-  [dev/financial#84](https://lab.civicrm.org/dev/financial/issues/84):
-  [16971](https://github.com/civicrm/civicrm-core/pull/16971))**
-
-  Fixes an issue for some builds when upgrading caused by the activation of the
-  `sequentialcreditnotes` extension.
-
- **Deleting entities leaves obsolete EntityTag records
-  ([dev/core#667](https://lab.civicrm.org/dev/core/issues/667):
-  [16832](https://github.com/civicrm/civicrm-core/pull/16832))**
-
-  Fixes a bug where deleting a contact does not delete tags associated with the
-  contact.
-
- **Auto-complete search results not consistent with other searches
-  ([dev/core#787](https://lab.civicrm.org/dev/core/issues/787):
-  [13809](https://github.com/civicrm/civicrm-core/pull/13809))**
-
-  Ensures Auto-complete search results are consistent with other searches.
-
- **Don't freeze fields for auto-renew memberships
-  ([dev/core#1331](https://lab.civicrm.org/dev/core/issues/1331):
-  [16881](https://github.com/civicrm/civicrm-core/pull/16881) and
-  [16609](https://github.com/civicrm/civicrm-core/pull/16609))**
-
-  Ensures that the "Cancel auto-renew" button works for translated sites. Makes
-  it possible for admin users to edit all fields on auto-renew memberships.
-
 - **Activity Detail report gives syntax error with force=1 if include case
  activities is on
  ([dev/core#1710](https://lab.civicrm.org/dev/core/issues/1710):
@@ -160,12 +130,32 @@ Released May 6, 2020
  affecting not only direct searches but also smart groups that built with
  Search Builder.  This resolves the regression, which first appeared in 5.24.3.

+- **Deleting entities leaves obsolete EntityTag records
+  ([dev/core#667](https://lab.civicrm.org/dev/core/issues/667):
+  [16832](https://github.com/civicrm/civicrm-core/pull/16832))**
+
+  Fixes a bug where deleting a contact does not delete tags associated with the
+  contact.
+
+- **Profile Public Title (frontend_title column) is not used in profile
+  create/edit mode
+  ([dev/core#1683](https://lab.civicrm.org/dev/core/issues/1683):
+  [16945](https://github.com/civicrm/civicrm-core/pull/16945))**
+
+  The Public Title setting that was recently added for profiles would only
+  replace the profile name on contribution and event forms.  When the profile
+  was used in a standalone context, the name would always appear.
+
+- **Auto-complete search results not consistent with other searches
+  ([dev/core#787](https://lab.civicrm.org/dev/core/issues/787):
+  [13809](https://github.com/civicrm/civicrm-core/pull/13809))**
+
 - **Need to Increase Data Size for `form_values` column on
  civicrm_report_instance table
  ([dev/core#1569](https://lab.civicrm.org/dev/core/issues/1569):
  [16836](https://github.com/civicrm/civicrm-core/pull/16836))**

-  Changes the data type for the `form_values` column on the
+  This hanges the data type for the `form_values` column on the
  `civicrm_report_instance` from TEXT to LONGTEXT.

 - **PHP warning on Add relationship form
@@ -185,19 +175,21 @@ Released May 6, 2020
  ([dev/core#1676](https://lab.civicrm.org/dev/core/issues/1676):
  [16924](https://github.com/civicrm/civicrm-core/pull/16924))**

- **profile Public Title (frontend_title column) is not used in profile
-  create/edit mode
-  ([dev/core#1683](https://lab.civicrm.org/dev/core/-/issues/1683):
-  [16945](https://github.com/civicrm/civicrm-core/pull/16945))**
-
- **[regression] CiviCRM reports smart groups won't work due to deleted custom
-  fields that aren't deleted
-  ([dev/core#1688](https://lab.civicrm.org/dev/core/-/issues/1688):
+- **[regression] CiviCRM reports that smart groups won't work due to deleted
+  custom fields that aren't deleted
+  ([dev/core#1688](https://lab.civicrm.org/dev/core/issues/1688):
  [16961](https://github.com/civicrm/civicrm-core/pull/16961))**

+  A system check would mistakenly report that a smart group was based upon a
+  deleted custom field if it was based upon a checkbox or multi-select custom
+  field.
+
 - **Fix checking permissions in api3 profile get
  ([16848](https://github.com/civicrm/civicrm-core/pull/16848))**

+  This resolves a bug where the API would reverse the value of the option to use
+  a current user's permissions when retrieving the list of fields in a profile.
+
 - **APIv4 - convert Result object to array when running through json_encode
  ([16828](https://github.com/civicrm/civicrm-core/pull/16828))**

@@ -330,6 +322,26 @@ Released May 6, 2020
  filter contributions by date, with the end date being midnight on the current
  date.  That would exclude contributions received on the current day.

+- **Updating misleading labels on buttons to confirmation pages
+  ([dev/core#1613](https://lab.civicrm.org/dev/core/issues/1613):
+  [16651](https://github.com/civicrm/civicrm-core/pull/16651))**
+
+  Some donors and event registrants interpreted the button text "Confirm
+  Contribution" (on contribution pages) and "Continue" (on event registration
+  pages) to mean that this would complete the contribution or registration.  In
+  fact, these would only appear when a confirmation page is used.
+
+  The button text now appears as "Review your contribution" and "Review your
+  registration", respectively.
+
+- **Fix upgrade failure. Thin-out activation logic for `sequentialcreditnotes`.
+  ([16971](https://github.com/civicrm/civicrm-core/pull/16971) following
+  [dev/financial#84](https://lab.civicrm.org/dev/financial/issues/84))**
+
+  This change fixes an issue for some builds when upgrading caused by the
+  activation of the `sequentialcreditnotes` extension to replace core code that
+  generates sequential credit note identifiers.
+
 - **Fix Bug where Payment Balance is sometimes miscalculated
  ([16546](https://github.com/civicrm/civicrm-core/pull/16546))**

@@ -353,7 +365,7 @@ Released May 6, 2020
  [16479](https://github.com/civicrm/civicrm-core/pull/16479))**

 - **Update pending contribution status action also send email without warning
-  ([dev/core#1640](https://lab.civicrm.org/dev/core/-/issues/1640):
+  ([dev/core#1640](https://lab.civicrm.org/dev/core/issues/1640):
  [16742](https://github.com/civicrm/civicrm-core/pull/16742))**

 - **PayPal Express Checkout fails on events
@@ -367,6 +379,14 @@ Released May 6, 2020

 ### CiviMember

+- **Don't freeze fields for auto-renew memberships
+  ([dev/core#1331](https://lab.civicrm.org/dev/core/issues/1331):
+  [16609](https://github.com/civicrm/civicrm-core/pull/16609) and
+  [16881](https://github.com/civicrm/civicrm-core/pull/16881))**
+
+  Previously, many membership fields were frozen for administrators when the
+  membership was set to auto-renew with a recurring contribution.
+
 - **Follow up on fix on updating memberships when a contact is deceased
  ([16787](https://github.com/civicrm/civicrm-core/pull/16787))**

@@ -385,7 +405,7 @@ Released May 6, 2020
  [16724](https://github.com/civicrm/civicrm-core/pull/16724))**

 - **Membership auto-renew is not optional if using price set
-  ([dev/core#1630](https://lab.civicrm.org/dev/core/-/issues/1630):
+  ([dev/core#1630](https://lab.civicrm.org/dev/core/issues/1630):
  [16762](https://github.com/civicrm/civicrm-core/pull/16762))**

 ### Drupal Integration
@@ -399,7 +419,7 @@ Released May 6, 2020
  ([17085](https://github.com/civicrm/civicrm-core/pull/17085))**

 - **civicrm-setup and backward slashes in file paths on windows don't play nice
-  together ([dev/core#1643](https://lab.civicrm.org/dev/core/-/issues/1643):
+  together ([dev/core#1643](https://lab.civicrm.org/dev/core/issues/1643):
  [16886](https://github.com/civicrm/civicrm-core/pull/16886))**

  Fixes installing CiviCRM on Drupal8 sites on windows using civicrm-setup / cv
@@ -408,7 +428,7 @@ Released May 6, 2020
 ### WordPress Integration

 - **5.23 breaks WP admin menu links
-  ([dev/core#1637](https://lab.civicrm.org/dev/core/-/issues/1637):
+  ([dev/core#1637](https://lab.civicrm.org/dev/core/issues/1637):
  [16713](https://github.com/civicrm/civicrm-core/pull/16713))**

 - **Merge REST API wrapper code
@@ -778,7 +798,7 @@ Lutfy; Digitalcourage - Detlev Sieber; Freeform Solutions - S. Gray; Fuzion -
 Jitendra Purohit; Greenpeace Central and Eastern Europe - Patrick Figel; Jamie
 Tillman; JMA Consulting - Monish Deb; Korlon - Stuart Gaston; MJCO - Mikey
 O'Toole; Richard van Oosterhout; Skvare - Mark Hanna; Squiffle Consulting -
-Aidan Saunders; Tadpole Collective - Kevin Cristiano;
+Aidan Saunders; Tadpole Collective - Kevin Cristiano

 ## <a name="feedback"></a>Feedback