Skip to content
Snippets Groups Projects
Commit be18b82b authored by eileen's avatar eileen
Browse files

#2108 fix deprecation notice

This addresses the deprecation warning by moving the text to the tpl layer - we could ease up
on the deprecation for type = 'static' but the pattern didn't seem to make much sense or to be
consistent with how we normally do things
parent 1d1cf83a
No related branches found
No related tags found
No related merge requests found
......@@ -52,7 +52,6 @@ class CRM_Core_Form_Task_PDFLetterCommon {
FALSE
);
$form->add('static', 'pdf_format_header', NULL, ts('Page Format: %1', [1 => '<span class="pdf-format-header-label"></span>']));
$form->addSelect('format_id', [
'label' => ts('Select Format'),
'placeholder' => ts('Default'),
......@@ -68,7 +67,6 @@ class CRM_Core_Form_Task_PDFLetterCommon {
FALSE,
['onChange' => "selectPaper( this.value ); showUpdateFormatChkBox();"]
);
$form->add('static', 'paper_dimensions', NULL, ts('Width x Height'));
$form->add(
'select',
'orientation',
......
......@@ -34,7 +34,7 @@
<div class="crm-accordion-wrapper collapsed crm-pdf-format-accordion">
<div class="crm-accordion-header">
{$form.pdf_format_header.html}
{ts}Page Format:{/ts} <span class="pdf-format-header-label"></span>
</div>
<div class="crm-accordion-body">
<div class="crm-block crm-form-block">
......@@ -52,7 +52,7 @@
<td colspan="2">&nbsp;</td>
</tr>
<tr>
<td>{$form.paper_dimensions.html}</td><td id="paper_dimensions">&nbsp;</td>
<td>{ts}Width x Height{/ts}</td><td id="paper_dimensions">&nbsp;</td>
<td colspan="2">&nbsp;</td>
</tr>
<tr>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment