Skip to content
Snippets Groups Projects
Commit a725865d authored by eileen's avatar eileen
Browse files

#2039 Fix OpenID::add to ensure is_primary is set

In my efforts to determine the the non-performant line of code that makes sure IM is set is
not required I edited tests to track down when is_primary is not correct & determined it
is missing from the add function - same as https://github.com/civicrm/civicrm-core/pull/18489 for IM
parent f7ca027c
No related branches found
No related tags found
No related merge requests found
......@@ -24,9 +24,16 @@ class CRM_Core_BAO_OpenID extends CRM_Core_DAO_OpenID {
* Create or update OpenID record.
*
* @param array $params
*
* @return CRM_Core_DAO_OpenID
*
* @throws \API_Exception
* @throws \CRM_Core_Exception
*/
public static function add($params) {
if (empty($params['id']) || is_numeric($params['is_primary'] ?? NULL)) {
CRM_Core_BAO_Block::handlePrimary($params, __CLASS__);
}
return self::writeRecord($params);
}
......@@ -38,6 +45,7 @@ class CRM_Core_BAO_OpenID extends CRM_Core_DAO_OpenID {
* Input parameters to find object.
*
* @return mixed
* @throws \CRM_Core_Exception
*/
public static function &getValues($entityBlock) {
return CRM_Core_BAO_Block::getValues('openid', $entityBlock);
......
......@@ -18,6 +18,13 @@
*/
class api_v3_OpenIDTest extends CiviUnitTestCase {
/**
* Should location types be checked to ensure primary addresses are correctly assigned after each test.
*
* @var bool
*/
protected $isLocationTypesOnPostAssert = TRUE;
protected $_params;
protected $id;
protected $_entity;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment