Skip to content
Snippets Groups Projects
Unverified Commit 5ee21cd1 authored by Seamus Lee's avatar Seamus Lee Committed by GitHub
Browse files

Merge pull request #18857 from eileenmcnaughton/sort2

#2132 Fix for sort on search results
parents 397e8a94 6dc40f32
No related branches found
No related tags found
No related merge requests found
......@@ -1018,6 +1018,8 @@ class CRM_Contact_Selector extends CRM_Core_Selector_Base implements CRM_Core_Se
*/
public function fillupPrevNextCache($sort, $cacheKey, $start = 0, $end = self::CACHE_SIZE) {
$coreSearch = TRUE;
// This ensures exceptions are caught in the try-catch.
$handling = CRM_Core_TemporaryErrorScope::useException();
// For custom searches, use the contactIDs method
if (is_a($this, 'CRM_Contact_Selector_Custom')) {
$sql = $this->_search->contactIDs($start, $end, $sort, TRUE);
......@@ -1046,7 +1048,7 @@ class CRM_Contact_Selector extends CRM_Core_Selector_Base implements CRM_Core_Se
try {
Civi::service('prevnext')->fillWithSql($cacheKey, $sql);
}
catch (CRM_Core_Exception $e) {
catch (\Exception $e) {
if ($coreSearch) {
// in the case of error, try rebuilding cache using full sql which is used for search selector display
// this fixes the bugs reported in CRM-13996 & CRM-14438
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment