Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
CiviCRM Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container Registry
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Development
CiviCRM Core
Commits
5ee21cd1
Unverified
Commit
5ee21cd1
authored
4 years ago
by
Seamus Lee
Committed by
GitHub
4 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #18857 from eileenmcnaughton/sort2
#2132
Fix for sort on search results
parents
397e8a94
6dc40f32
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
CRM/Contact/Selector.php
+3
-1
3 additions, 1 deletion
CRM/Contact/Selector.php
with
3 additions
and
1 deletion
CRM/Contact/Selector.php
+
3
−
1
View file @
5ee21cd1
...
...
@@ -1018,6 +1018,8 @@ class CRM_Contact_Selector extends CRM_Core_Selector_Base implements CRM_Core_Se
*/
public
function
fillupPrevNextCache
(
$sort
,
$cacheKey
,
$start
=
0
,
$end
=
self
::
CACHE_SIZE
)
{
$coreSearch
=
TRUE
;
// This ensures exceptions are caught in the try-catch.
$handling
=
CRM_Core_TemporaryErrorScope
::
useException
();
// For custom searches, use the contactIDs method
if
(
is_a
(
$this
,
'CRM_Contact_Selector_Custom'
))
{
$sql
=
$this
->
_search
->
contactIDs
(
$start
,
$end
,
$sort
,
TRUE
);
...
...
@@ -1046,7 +1048,7 @@ class CRM_Contact_Selector extends CRM_Core_Selector_Base implements CRM_Core_Se
try
{
Civi
::
service
(
'prevnext'
)
->
fillWithSql
(
$cacheKey
,
$sql
);
}
catch
(
CRM_Core_
Exception
$e
)
{
catch
(
\
Exception
$e
)
{
if
(
$coreSearch
)
{
// in the case of error, try rebuilding cache using full sql which is used for search selector display
// this fixes the bugs reported in CRM-13996 & CRM-14438
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment