-
- Downloads
Fixes getTemplateContribution to use a more reliable way to load line items
My efforts to add testing a 'deprecate weird stuff' have identified an odd and fragile flow for the line items in getTemplateContribution. It calls getLineItemsByContributionID which, as it turns out, substitues the actual entity table with 'civicrm_contribution'. Then this line of weird handling swoops in and saves the day. https://github.com/civicrm/civicrm-core/pull/20775/files#diff-a16d4d7449cf5f3a0616d1d282a32f27ab6d3f7d2726d076c02ad1d4d655af41R393 This switches us to something cleaner than just loads the line items (with v4 LineItem.get) and no weird handling
Showing
- CRM/Contribute/BAO/Contribution.php 0 additions, 1 deletionCRM/Contribute/BAO/Contribution.php
- CRM/Contribute/BAO/ContributionRecur.php 11 additions, 51 deletionsCRM/Contribute/BAO/ContributionRecur.php
- CRM/Financial/BAO/Order.php 212 additions, 27 deletionsCRM/Financial/BAO/Order.php
- tests/phpunit/CRM/Contribute/BAO/ContributionRecurTest.php 0 additions, 1 deletiontests/phpunit/CRM/Contribute/BAO/ContributionRecurTest.php
- tests/phpunit/CRM/Core/Payment/PayPalIPNTest.php 2 additions, 2 deletionstests/phpunit/CRM/Core/Payment/PayPalIPNTest.php
- tests/phpunit/CiviTest/CiviUnitTestCase.php 3 additions, 10 deletionstests/phpunit/CiviTest/CiviUnitTestCase.php
- tests/phpunit/api/v3/ContributionTest.php 13 additions, 11 deletionstests/phpunit/api/v3/ContributionTest.php
Loading
-
mentioned in issue #3134 (closed)
-
mentioned in issue #3150 (closed)
Please register or sign in to comment