-
- Downloads
Fix failure to copy custom fields & add test provided by Agileware
Per https://github.com/civicrm/civicrm-core/pull/13470 custom fields are inconsistently copied where copying entities. This makes the code from BAO_Event called from the genericCopy function. I did a bit of an audit and the places where this is currently called from don't appear to call the copyGeneric function with the 'custom' param that would have activated the old code. I also consistently removed the & when it was being called so I could take it out of the signature. The original PR handled tags as well, but not in a generic way. I've left that out of scope but the test is present, commented out, so it would be easy enough to revist
Showing
- CRM/Contribute/BAO/ContributionPage.php 8 additions, 8 deletionsCRM/Contribute/BAO/ContributionPage.php
- CRM/Core/BAO/Job.php 1 addition, 1 deletionCRM/Core/BAO/Job.php
- CRM/Core/BAO/Location.php 2 additions, 1 deletionCRM/Core/BAO/Location.php
- CRM/Core/BAO/UFGroup.php 3 additions, 3 deletionsCRM/Core/BAO/UFGroup.php
- CRM/Core/DAO.php 5 additions, 6 deletionsCRM/Core/DAO.php
- CRM/Event/BAO/Event.php 0 additions, 1 deletionCRM/Event/BAO/Event.php
- CRM/Price/BAO/PriceSet.php 1 addition, 1 deletionCRM/Price/BAO/PriceSet.php
- tests/phpunit/CRM/Core/BAO/RecurringEntityTest.php 80 additions, 0 deletionstests/phpunit/CRM/Core/BAO/RecurringEntityTest.php
Loading
Please register or sign in to comment