Skip to content
Snippets Groups Projects
Commit 35e0e03e authored by eileen's avatar eileen
Browse files

[REF] move gathering of location info to relevant function

We have a loop that parses the migrationInfo to get just location fields which we loop through, but
migrationInfo is already available in the moveLocationInfo fn so we can just handle that param in there
& improve code readability (we do a little less array looping but it's pretty cheap & the code
readabiliity is a real issue here
parent b632d5ee
No related branches found
No related tags found
No related merge requests found
......@@ -1611,7 +1611,7 @@ INNER JOIN civicrm_membership membership2 ON membership1.membership_type_id = m
$qfZeroBug = 'e8cddb72-a257-11dc-b9cc-0016d3330ee9';
$relTables = CRM_Dedupe_Merger::relTables();
$submittedCustomFields = $moveTables = $locationMigrationInfo = $tableOperations = $removeTables = [];
$submittedCustomFields = $moveTables = $tableOperations = $removeTables = [];
foreach ($migrationInfo as $key => $value) {
if ($value == $qfZeroBug) {
......@@ -1625,10 +1625,6 @@ INNER JOIN civicrm_membership membership2 ON membership1.membership_type_id = m
elseif (in_array(substr($key, 5), CRM_Dedupe_Merger::getContactFields()) && $value != NULL) {
$submitted[substr($key, 5)] = $value;
}
// Set up initial information for handling migration of location blocks
elseif (substr($key, 0, 14) == 'move_location_' and $value != NULL) {
$locationMigrationInfo[$key] = $value;
}
elseif (substr($key, 0, 15) == 'move_rel_table_' and $value == '1') {
$moveTables = array_merge($moveTables, $relTables[substr($key, 5)]['tables']);
if (array_key_exists('operation', $migrationInfo)) {
......@@ -1643,7 +1639,7 @@ INNER JOIN civicrm_membership membership2 ON membership1.membership_type_id = m
$removeTables = array_merge($moveTables, $relTables[substr($key, 5)]['tables']);
}
}
self::mergeLocations($mainId, $otherId, $locationMigrationInfo, $migrationInfo);
self::mergeLocations($mainId, $otherId, $migrationInfo);
// **** Do contact related migrations
$customTablesToCopyValues = self::getAffectedCustomTables($submittedCustomFields);
......@@ -2234,14 +2230,16 @@ INNER JOIN civicrm_membership membership2 ON membership1.membership_type_id = m
*
* @param int $mainId
* @param int $otherId
* @param array $locationMigrationInfo
* Portion of the migration_info that holds location migration information.
*
* @param array $migrationInfo
* Migration info for the merge. This is passed to the hook as informational only.
*/
public static function mergeLocations($mainId, $otherId, $locationMigrationInfo, $migrationInfo) {
foreach ($locationMigrationInfo as $key => $value) {
public static function mergeLocations($mainId, $otherId, $migrationInfo) {
foreach ($migrationInfo as $key => $value) {
$isLocationField = (substr($key, 0, 14) == 'move_location_' and $value != NULL);
if (!$isLocationField) {
continue;
}
$locField = explode('_', $key);
$fieldName = $locField[2];
$fieldCount = $locField[3];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment