-
- Downloads
Do not pass by reference for createRelatedMemberships
There are 2 parameters passed by reference to this function 1) dao - this is not altered 2) params - this IS altered but the calling function (create) does not use it again. While it's possible a function that calls create uses it again the idea that they would want the params to have been altered to refer to a different related relationship does not seem probable. Tests on this are in JobTest & apiv3_MembershipTest
Please register or sign in to comment