Skip to content
Snippets Groups Projects
Unverified Commit 18d905e0 authored by Eileen McNaughton's avatar Eileen McNaughton Committed by GitHub
Browse files

Merge pull request #19263 from civicrm/5.33 

5.33
parents 5974706e 15e8c39e
Branches
Tags
No related merge requests found
Hide whitespace changes
Inline Side-by-side
CRM/Core/BAO/ConfigSetting.php
+ 5
− 3
View file @ 18d905e0
......@@ -205,9 +205,6 @@ class CRM_Core_BAO_ConfigSetting {
$chosenLocale = $defaultLocale;
}
// Always assign the chosen locale to the session.
$session->set('lcMessages', $chosenLocale);
}
else {
......@@ -216,6 +213,11 @@ class CRM_Core_BAO_ConfigSetting {
}
if (!$session->isEmpty()) {
// Always assign the chosen locale to the session.
$session->set('lcMessages', $chosenLocale);
}
/*
* Set suffix for table names in multi-language installs.
* Use views if more than one language.
......
ext/search/ang/crmSearchDisplay.module.js
+ 2
− 2
View file @ 18d905e0
......@@ -29,7 +29,7 @@
result = value;
if (_.isArray(value)) {
return _.map(value, function(val) {
return formatSearchValue(col, val);
return formatSearchValue(row, col, val);
}).join(', ');
}
if (value && (type === 'Date' || type === 'Timestamp') && /^\d{4}-\d{2}-\d{2}/.test(value)) {
......@@ -83,7 +83,7 @@
_.each(params.join, function(join) {
var joinEntity = join[0].split(' AS ')[1],
idField = joinEntity + '.id';
if (!_.includes(params.select, idField) && !searchDisplayUtils.canAggregate('id', joinEntity + '.', params)) {
if (!_.includes(params.select, idField) && !canAggregate('id', joinEntity + '.', params)) {
params.select.push(idField);
}
});
......
release-notes.md
+ 11
− 0
View file @ 18d905e0
......@@ -15,6 +15,17 @@ Other resources for identifying changes are:
* https://github.com/civicrm/civicrm-joomla
* https://github.com/civicrm/civicrm-wordpress
## CiviCRM 5.33.0
Released January 6, 2021
- **[Synopsis](release-notes/5.33.0.md#synopsis)**
- **[Features](release-notes/5.33.0.md#features)**
- **[Bugs resolved](release-notes/5.33.0.md#bugs)**
- **[Miscellany](release-notes/5.33.0.md#misc)**
- **[Credits](release-notes/5.33.0.md#credits)**
- **[Feedback](release-notes/5.33.0.md#feedback)**
## CiviCRM 5.32.2
Released December 12, 2020
......
release-notes/5.33.0.md 0 → 100644
+ 334
− 0
View file @ 18d905e0
# CiviCRM 5.33.0
Released January 6, 2021
- **[Synopsis](#synopsis)**
- **[Features](#features)**
- **[Bugs resolved](#bugs)**
- **[Miscellany](#misc)**
- **[Credits](#credits)**
- **[Feedback](#feedback)**
## <a name="synopsis"></a>Synopsis
| *Does this version...?* | |
|:--------------------------------------------------------------- |:-------:|
| Fix security vulnerabilities? | |
| Change the database schema? | |
| Alter the API? | |
| Require attention to configuration options? | |
| Fix problems installing or upgrading to a previous version? | |
| Introduce features? | |
| Fix bugs? | |
## <a name="features"></a>Features
### Core CiviCRM
- **crm- Missing Summary ([18994](https://github.com/civicrm/civicrm-core/pull/18994))**
## <a name="bugs"></a>Bugs resolved
### Core CiviCRM
- **Fix Invalid argument PHP warning ([19219](https://github.com/civicrm/civicrm-core/pull/19219))**
- **DispatchPolicy - Actively report any upgrade problems with hook_civicrm_permission ([19217](https://github.com/civicrm/civicrm-core/pull/19217))**
- **dev/core#2232 - Upgrade UI contaminates cache via l10n-js. Consolidate isUpgradeMode(). ([19192](https://github.com/civicrm/civicrm-core/pull/19192))**
- **Add release-notes/5.32.2.md ([19195](https://github.com/civicrm/civicrm-core/pull/19195))**
- **Fix failure to assign view tpl variables to view page if context=search is in the url ([19189](https://github.com/civicrm/civicrm-core/pull/19189))**
- **dev/core#1019 Fix currency formatting of Total Amount on Event and Contribution pages (with multi-currency form support) ([19185](https://github.com/civicrm/civicrm-core/pull/19185))**
- **dev/core#2248 Ensure variables are assigned to tpl for urls ([19183](https://github.com/civicrm/civicrm-core/pull/19183))**
- **dev/core#2246 Fix failure to filter exports ([19176](https://github.com/civicrm/civicrm-core/pull/19176))**
- **dev/core#2244 Simplify and consistently apply checking of whether financial acls are enabled ([19173](https://github.com/civicrm/civicrm-core/pull/19173))**
- **APIv4 - Fix dynamic bridge joins (used by Search Kit) ([19159](https://github.com/civicrm/civicrm-core/pull/19159))**
- **Add release-notes/5.32.1 ([19161](https://github.com/civicrm/civicrm-core/pull/19161))**
- **Handle possibility of fee_amount = '' ([19120](https://github.com/civicrm/civicrm-core/pull/19120))**
- **Search kit joins ([19150](https://github.com/civicrm/civicrm-core/pull/19150))**
- **CiviEvent - Error registering participants via search task ([19125](https://github.com/civicrm/civicrm-core/pull/19125))**
- **dev/core#2232 Permit hook_civicrm_container and some other prebootish… ([19141](https://github.com/civicrm/civicrm-core/pull/19141))**
- **[NFC] dev/core#2235 Fix url link to the OrderAPI Documenation ([19139](https://github.com/civicrm/civicrm-core/pull/19139))**
- **Fix mglaman mapping ([19134](https://github.com/civicrm/civicrm-core/pull/19134))**
- **dev/core#2188 - Upgrader - Cleanup any invalid combinations of is_search_range ([19123](https://github.com/civicrm/civicrm-core/pull/19123))**
- **dev/core#2231 fix failure to calculate next_scheduled_date ([19119](https://github.com/civicrm/civicrm-core/pull/19119))**
- **Search Kit: Support robust joins in UI ([19105](https://github.com/civicrm/civicrm-core/pull/19105))**
- **Unhide oauth extension ([19107](https://github.com/civicrm/civicrm-core/pull/19107))**
- **Unable to export contacts in Civi 5.32+ ([19104](https://github.com/civicrm/civicrm-core/pull/19104))**
- **Improve APIv4 metadata for RelationshipCache and Bridge entities in general ([19101](https://github.com/civicrm/civicrm-core/pull/19101))**
- **5.32 ([19093](https://github.com/civicrm/civicrm-core/pull/19093))**
- **5.32 ([19090](https://github.com/civicrm/civicrm-core/pull/19090))**
- **dev/core#927 Add test demonstrating that an extraneous activity is being created & fix ([19014](https://github.com/civicrm/civicrm-core/pull/19014))**
- **Afform - Update fields and HTML mode in web-based editors ([19053](https://github.com/civicrm/civicrm-core/pull/19053))**
- **5.32 ([19087](https://github.com/civicrm/civicrm-core/pull/19087))**
- **dev/core#1790: Add short delay before closing tooltip elements ([19082](https://github.com/civicrm/civicrm-core/pull/19082))**
- **[NFC] Add in an Emoji test for APIv3 as per Eileen's PR ([19078](https://github.com/civicrm/civicrm-core/pull/19078))**
- **Improve schema metadata for Search Kit ([19075](https://github.com/civicrm/civicrm-core/pull/19075))**
- **5.32 ([19081](https://github.com/civicrm/civicrm-core/pull/19081))**
- **5.32 ([19080](https://github.com/civicrm/civicrm-core/pull/19080))**
- **dev/core#2165 Test for Handle emojis less fatally where not supported ([18918](https://github.com/civicrm/civicrm-core/pull/18918))**
- **dev/drupal#149 Override sessionStart function for Drupal8 using appro… ([19044](https://github.com/civicrm/civicrm-core/pull/19044))**
- **Protect against 404s when wpBasePage is mixed case ([19063](https://github.com/civicrm/civicrm-core/pull/19063))**
- **Extract function that generates upgrade link for extensions ([19070](https://github.com/civicrm/civicrm-core/pull/19070))**
- **REF Simplify tokenProcessor code ([18612](https://github.com/civicrm/civicrm-core/pull/18612))**
- **Feature to provide mostly used countries in top section of Country select list ([19025](https://github.com/civicrm/civicrm-core/pull/19025))**
- **Minor tabs cleanup toward fixing dev/core#2215 ([19065](https://github.com/civicrm/civicrm-core/pull/19065))**
- **Remove use of nullArray in delete hooks ([19059](https://github.com/civicrm/civicrm-core/pull/19059))**
- **Deprecate UFGroup::add parameter ids ([19060](https://github.com/civicrm/civicrm-core/pull/19060))**
- **[REF] Remove excess handling around contact_id ([19050](https://github.com/civicrm/civicrm-core/pull/19050))**
- **Remove extra handling around contact id ([19051](https://github.com/civicrm/civicrm-core/pull/19051))**
- **Remove unused hook_civicrm_crudLink and switch to using metadata for crudLinks ([18916](https://github.com/civicrm/civicrm-core/pull/18916))**
- **[REF] Cleanup Ang modules in core to follow conventions ([19052](https://github.com/civicrm/civicrm-core/pull/19052))**
- **wordpress#63 Add action parameter to PCP shortcode ([19058](https://github.com/civicrm/civicrm-core/pull/19058))**
- **Update Resource URL Helptext ([19046](https://github.com/civicrm/civicrm-core/pull/19046))**
- **5.32 ([19056](https://github.com/civicrm/civicrm-core/pull/19056))**
- **Delete outdated/unused crmExample Angular module ([19049](https://github.com/civicrm/civicrm-core/pull/19049))**
- **[REF] Decouple crmD3 angular module from CiviMail ([19047](https://github.com/civicrm/civicrm-core/pull/19047))**
- **[REF] Remove xssString as it is providing a false sense of security ([19045](https://github.com/civicrm/civicrm-core/pull/19045))**
- **[NFC] Remove boilerplate comment from .ang.php files ([19048](https://github.com/civicrm/civicrm-core/pull/19048))**
- **[REF] Simplify sendNotification determination ([19054](https://github.com/civicrm/civicrm-core/pull/19054))**
- **dev/financial#148 fully deprecate validateData function ([19043](https://github.com/civicrm/civicrm-core/pull/19043))**
- **Remove legacy check ([19042](https://github.com/civicrm/civicrm-core/pull/19042))**
- **Afform - Generate dashlets based on `Afform.is_dashlet` property. ([19005](https://github.com/civicrm/civicrm-core/pull/19005))**
- **[REF] remove obscure use of objects from A.net ([19040](https://github.com/civicrm/civicrm-core/pull/19040))**
- **Improve bootstrap3 checkbox theming ([19006](https://github.com/civicrm/civicrm-core/pull/19006))**
- **[REF] Stop passing objects to recur in paypal pro - pass specific objects ([19041](https://github.com/civicrm/civicrm-core/pull/19041))**
- **[REF] remove obscure use of objects from Anet.ipn ([19039](https://github.com/civicrm/civicrm-core/pull/19039))**
- **[REF] Remove code Coleman hates ([19038](https://github.com/civicrm/civicrm-core/pull/19038))**
- **Remove some deprecated code ([19037](https://github.com/civicrm/civicrm-core/pull/19037))**
- **[REF] Simplify single function to receive contribution not objects ([19032](https://github.com/civicrm/civicrm-core/pull/19032))**
- **dev/financial#148 fold call to loadObjects ([19033](https://github.com/civicrm/civicrm-core/pull/19033))**
- **dev/financial#148 fold call to loadObjects - a.net ([19035](https://github.com/civicrm/civicrm-core/pull/19035))**
- **dev/financial#148 duplicate out call to validateObjects ([19034](https://github.com/civicrm/civicrm-core/pull/19034))**
- **5.32 to master ([19036](https://github.com/civicrm/civicrm-core/pull/19036))**
- **5.32 ([19030](https://github.com/civicrm/civicrm-core/pull/19030))**
- **Event Full: fix translation regression ([19027](https://github.com/civicrm/civicrm-core/pull/19027))**
- **dev/core#927 Update ContributionCancelActions to also handle 'failed' ([19015](https://github.com/civicrm/civicrm-core/pull/19015))**
- **Add Grant v4 api ([19020](https://github.com/civicrm/civicrm-core/pull/19020))**
- **5.32 ([19022](https://github.com/civicrm/civicrm-core/pull/19022))**
- **Fix issue #2162: allow reports to filter multi-select fields and find entities with multiple selections ([18978](https://github.com/civicrm/civicrm-core/pull/18978))**
- **Check for membership type fee before applying tax ([19007](https://github.com/civicrm/civicrm-core/pull/19007))**
- **dev/core#927 [REF] Further removal on unreachable code in transitionComponents ([19012](https://github.com/civicrm/civicrm-core/pull/19012))**
- **dev/financial#152 [REF] Pass specific BAO into the recur function rather than the vague 'objects' ([19016](https://github.com/civicrm/civicrm-core/pull/19016))**
- **Use trait instead of class for Entity Bridges; add OptionList trait ([19010](https://github.com/civicrm/civicrm-core/pull/19010))**
- **Remove unused params, return params from processFail ([18998](https://github.com/civicrm/civicrm-core/pull/18998))**
- **Remove unused parameters from cancel ([18997](https://github.com/civicrm/civicrm-core/pull/18997))**
- **changes social media iframes/scripts to links, simplifies markup, adds email & bootstrap classes ([18880](https://github.com/civicrm/civicrm-core/pull/18880))**
- **dev/core#2153 #REF Remove outdated updateCustomValues function ([18959](https://github.com/civicrm/civicrm-core/pull/18959))**
- **Fix APIv4 test to assert an exception is thrown ([19009](https://github.com/civicrm/civicrm-core/pull/19009))**
- **[NFC] Minor margin tidy up ([19013](https://github.com/civicrm/civicrm-core/pull/19013))**
- **Add standard Contact fields to the Bookkeeping report template ([19008](https://github.com/civicrm/civicrm-core/pull/19008))**
- **E_NOTICE when deleting participant ([19011](https://github.com/civicrm/civicrm-core/pull/19011))**
- **5.32 ([19004](https://github.com/civicrm/civicrm-core/pull/19004))**
- **Allow Angular modules to require Resource bundles ([18987](https://github.com/civicrm/civicrm-core/pull/18987))**
- **5.32 to master ([19003](https://github.com/civicrm/civicrm-core/pull/19003))**
- **5.32 ([19000](https://github.com/civicrm/civicrm-core/pull/19000))**
- **dev/core#2066 Extract getSelectedIDs ([18772](https://github.com/civicrm/civicrm-core/pull/18772))**
- **[REF] Remove always FALSE variable from transitionComponents ([18983](https://github.com/civicrm/civicrm-core/pull/18983))**
- **dev/drupal#146 - Wrong link for Drupal 8 permissions page / Make CMS permissions url lookup more OO-ey ([18986](https://github.com/civicrm/civicrm-core/pull/18986))**
- **dev/core#1931 Prevent PayPal from double-encoding the IPN Notify URL ([18980](https://github.com/civicrm/civicrm-core/pull/18980))**
- **dev/financial#153 Fix redirect to PayPal ([18993](https://github.com/civicrm/civicrm-core/pull/18993))**
- **dev/core#2197 Deploy monaco-editor using composer.json / composer dow… ([18988](https://github.com/civicrm/civicrm-core/pull/18988))**
- **dev/core#2196 - serialize E_NOTICE when saving custom field ([18991](https://github.com/civicrm/civicrm-core/pull/18991))**
- **afform - Get default field `<label>` from `label` instead of `title` ([18989](https://github.com/civicrm/civicrm-core/pull/18989))**
- **Extensionsuitweak ([18981](https://github.com/civicrm/civicrm-core/pull/18981))**
- **afform/gui - Fix rendering of the "Form Settings" ([18990](https://github.com/civicrm/civicrm-core/pull/18990))**
- **dev/core#2190 - Remove unused lines, replace CRM_Utils_Array::value ([18985](https://github.com/civicrm/civicrm-core/pull/18985))**
- **Remove return value on transitionComponents ([18979](https://github.com/civicrm/civicrm-core/pull/18979))**
- **Rewrite jquery.dashboard.js as Angular app ([18971](https://github.com/civicrm/civicrm-core/pull/18971))**
- **event#44: Don't allow self-service cancelling after an event when 'hours to cancel' is zero ([18950](https://github.com/civicrm/civicrm-core/pull/18950))**
- **dev/core#2155 Remove obscure broken handling for onlinePendingContribution ([18964](https://github.com/civicrm/civicrm-core/pull/18964))**
- **dev/core#339 Install CiviCRM tables using utf8mb4 ([18960](https://github.com/civicrm/civicrm-core/pull/18960))**
- **5.32 to master ([18977](https://github.com/civicrm/civicrm-core/pull/18977))**
- **Fix undeclared afform requirement of ngRoute ([18975](https://github.com/civicrm/civicrm-core/pull/18975))**
- **5.32 ([18974](https://github.com/civicrm/civicrm-core/pull/18974))**
- **fix default 'is searchable' to prevent breaking advanced search ([18970](https://github.com/civicrm/civicrm-core/pull/18970))**
- **dev/core#2120 Do not attempt to obsolete primary key on log tables ([18748](https://github.com/civicrm/civicrm-core/pull/18748))**
- **Don't break clickthrough URLs when there's leading whitespace ([18965](https://github.com/civicrm/civicrm-core/pull/18965))**
- **[NFC] Follow-on to 18963 to add example setting in civicrm.settings template for setting CMS inheritance for nl_BE ([18966](https://github.com/civicrm/civicrm-core/pull/18966))**
- **API - Finer-grained permisions for the dashboard & dashlet entities ([18962](https://github.com/civicrm/civicrm-core/pull/18962))**
- **Add a way to choose between nl_NL and nl_BE ([18963](https://github.com/civicrm/civicrm-core/pull/18963))**
- **dev/core#2158 Remove detail about updating related components when editing a contribution status ([18961](https://github.com/civicrm/civicrm-core/pull/18961))**
- **Standardise more params in completeOrder ([18952](https://github.com/civicrm/civicrm-core/pull/18952))**
- **(dev/core#2153) BUG: when changing a custom group option value CiviCR… ([18912](https://github.com/civicrm/civicrm-core/pull/18912))**
- **5.32 ([18956](https://github.com/civicrm/civicrm-core/pull/18956))**
- **core#2172 - Fix 'Find Respondents' in CiviCampaigns ([18948](https://github.com/civicrm/civicrm-core/pull/18948))**
- **5.32 ([18953](https://github.com/civicrm/civicrm-core/pull/18953))**
- **APIv3 - Fix legacy handling for html_type Autocomplete-Select ([18949](https://github.com/civicrm/civicrm-core/pull/18949))**
- **Remove always true if ([18946](https://github.com/civicrm/civicrm-core/pull/18946))**
- **dev/financial#148 dev/financial#148 Copy contents of validateDate onto paypalIPN ([18947](https://github.com/civicrm/civicrm-core/pull/18947))**
- **Minor code cleanup - dedupe isNull checks ([18819](https://github.com/civicrm/civicrm-core/pull/18819))**
- **Remove always-true if ([18934](https://github.com/civicrm/civicrm-core/pull/18934))**
- **[REF] Minor variable cleanup ([18935](https://github.com/civicrm/civicrm-core/pull/18935))**
- **[Ref] Use variables directly ([18936](https://github.com/civicrm/civicrm-core/pull/18936))**
- **5.32 ([18944](https://github.com/civicrm/civicrm-core/pull/18944))**
- **5.32 ([18942](https://github.com/civicrm/civicrm-core/pull/18942))**
- **Update doclink trouble as per Mikey's comment ([630](https://github.com/civicrm/civicrm-drupal/pull/630))**
- **Update civicrm.module links ([629](https://github.com/civicrm/civicrm-drupal/pull/629))**
- **Remove support for pre 4.2 Civi in drush ([628](https://github.com/civicrm/civicrm-drupal/pull/628))**
- **[NFC] Refactor plugin for greater clarity ([228](https://github.com/civicrm/civicrm-wordpress/pull/228))**
- **wordpress#63 Add action parameter to PCP shortcode ([226](https://github.com/civicrm/civicrm-wordpress/pull/226))**
- **Fix assignment of base page template ([227](https://github.com/civicrm/civicrm-wordpress/pull/227))**
- **[REF] For the time being have phpcs ignore eval usages ([225](https://github.com/civicrm/civicrm-wordpress/pull/225))**
- **[NFC] Make all files conform to CiviCRM code styling ([223](https://github.com/civicrm/civicrm-wordpress/pull/223))**
- **[NFC] Housekeeping ([222](https://github.com/civicrm/civicrm-wordpress/pull/222))**
- **Ensure "civicrm_initialized" action only fires once ([221](https://github.com/civicrm/civicrm-wordpress/pull/221))**
- **[REF] Remove xssString as it is providing a false sense of security ([312](https://github.com/civicrm/civicrm-packages/pull/312))**
## <a name="misc"></a>Miscellany
## <a name="credits"></a>Credits
This release was developed by the following code authors:
AGH Strategies - Alice Frumin, Andrew Hunt; Alexy Mikhailichenko; AsylumSeekersCentre; Bluehorn Digital - Matt Glaman; Christian Wach; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Sunil Pawar, Yashodha Chaku; CompuCorp - René Olivo; Coop SymbioTIC - Mathieu Lutfy, Samuel Vanhove; Dave D; dwoods-encircle; Giant Rabbit - Peter Haight; JMA Consulting - Seamus Lee; Megaphone Technology Consulting - Jon Goldberg; MJW Consulting - Matthew Wire; Nicol Wistreich; Squiffle Consulting - Aidan Saunders; Tadpole Collective - Kevin Cristiano; Wikimedia Foundation - Eileen McNaughton
Most authors also reviewed code for this release; in addition, the following
reviewers contributed their comments:
a-n The Artists Information Company - William Mortada; AGH Strategies - Alice Frumin; Agileware - Justin Freeman; Alexy Mikhailichenko; Bluehorn Digital - Matt Glaman; Christian Wach; civibot[bot]; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Nicolas Ganivet, Sunil Pawar, Yashodha Chaku; CompuCorp - René Olivo; Coop SymbioTIC - Mathieu Lutfy; Dave D; Freeform Solutions - Herb van den Dool; JMA Consulting - Seamus Lee; MJCO - Mikey O'Toole; MJW Consulting - Matthew Wire; Nicol Wistreich; Semper IT - Karin Gerritsen; Squiffle Consulting - Aidan Saunders; Tadpole Collective - Kevin Cristiano; Wikimedia Foundation - Eileen McNaughton
## <a name="feedback"></a>Feedback
These release notes are edited by Alice Frumin and Andrew Hunt. If you'd like
to provide feedback on them, please log in to https://chat.civicrm.org/civicrm
and contact `@agh1`.
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment