Skip to content
Snippets Groups Projects
Commit 1181545c authored by totten's avatar totten
Browse files

Upgrader - Fix error on Snapshot::cleanupTask

This is a follow-up to #23522.

Before
------

Upgrade works on `cv upgrade:db` but fails on `drush civicrm-upgrade-db`

After
-----

Upgrades on both `cv upgrade:db` and `drush civicrm-upgrade-db`
parent 617e74b5
Branches
Tags
No related merge requests found
......@@ -184,8 +184,9 @@ class CRM_Upgrade_Snapshot {
* How long should we retain old snapshots?
* Time is measured in terms of MINOR versions - eg "4" means "retain for 4 MINOR versions".
* Thus, on v5.60, you could delete any snapshots predating 5.56.
* @return bool
*/
public static function cleanupTask(?CRM_Queue_TaskContext $ctx = NULL, string $owner = 'civicrm', ?string $version = NULL, ?int $cleanupAfter = NULL): void {
public static function cleanupTask(?CRM_Queue_TaskContext $ctx = NULL, string $owner = 'civicrm', ?string $version = NULL, ?int $cleanupAfter = NULL): bool {
$version = $version ?: CRM_Core_BAO_Domain::version();
$cleanupAfter = $cleanupAfter ?: static::$cleanupAfter;
......@@ -213,6 +214,7 @@ class CRM_Upgrade_Snapshot {
});
array_map(['CRM_Core_BAO_SchemaHandler', 'dropTable'], $oldTables);
return TRUE;
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment