Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C CiviCRM Asset Plugin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DevelopmentDevelopment
  • CiviCRM Asset Plugin
  • Merge requests
  • !6

Degrade gracefully during conflict or removal

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged totten requested to merge master-re-warn into master Oct 07, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

This addresses two issues, but they touch the same code and work in similar ways, so it's hard to split them apart. The issues:

  1. Soft Package Conflict: Following civicrm-drupal-8#49 in v5.31+, there is a possibility that early D8 deployments will have both roundearth/civicrm-composer-plugin (b/c that was how earlier templates worked) and civicrm/civicrm-asset-plugin (b/c that'll be added during an upgrade to 5.31). But these aren't designed to work together. Instead, we should show a warning.

  2. Uninstall: If you remove this plugin (in composer v1), the main plugin-class and event-listeners remain momentarily active. But they're not usable (e.g. the class-loader goes away). So we need to take extra measures to avoid ugly errors during uninstallation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-re-warn