Changing flush to clear as the preferred method. I think when it was added there was an assumption devs would be developing against < 5.4 so it made sense to give primacy to flush but times have changed

@totten

Per https://github.com/civicrm/civicrm-core/pull/13762

Add in notes about support for KeyColumn parameter when using option group as part of a setting pseudoconstant

Adding this clause has led to unreliable query results - better to give no information than to lead them wrong - many reports now disable & reenable full group by but that is referred to elsewhere.

Also better to override whereClause & selectClause

Note working through this threw up some ambiguity about help_text vs help which I'll dig into as a follow up. I think there is further text on the page I need to review too about the settings form

dev/core#90 Add in documentation of the disabling and re-enabling of the ONLY_FULL_GROUP_BY sql mode for developers to use

colemanw authored 6 years ago and colemanw committed 6 years ago

See https://github.com/civicrm/civicrm-core/pull/10085
@totten I've added docs for this hook.

Resolve #491 Reference hook_civicrm_coreResourceList in the advanced options in Resource framework reference

We really don't need such an exhaustive list of examples in this context.
That material is better handled in the User Guide, which is hyperlinked.
All we need to do is demonstrate the basic idea of a token.

These documents are misleading -- they talk about CiviMail because, *historically*,
much of this grew out of CiviMail. However, *today*, tokens are used more generally.
Also, in `civicrm-core`, `TokenProcessor` is *not* used by CiviMail. (You have to
install FlexMailer to use it.)