Skip to content
Snippets Groups Projects
Commit e008227d authored by totten's avatar totten
Browse files

standards/review.md - Tweak "Packaging" and "Permissions"

parent a5120425
No related branches found
No related tags found
No related merge requests found
......@@ -89,11 +89,14 @@ _Standard code: `rg-pkg`_
If the PR adds a new top-level file, new top-level folder, or novel file-type, consider whether "distmaker" will properly convey the file in `*.zip/*.tar.gz` builds.
If the PR *removes* a dangerous file, then common package handling may not be enough to remove the file. (This is particularly for Joomla users, but also true for with
manual file management on other platforms.) Consider updating `CRM_Utils_Check_Component_Security::checkFilesAreNotPresent`.
### Permissions {:#rg-perm}
_Standard code: `rg-perm`_
If the PR changes the permissions model, are we sure that demo/test builds and existing installations will continue to work the same?
If the PR changes the permissions model (by adding, removing, or repurposing a permission), are we sure that demo/test builds and existing installations will continue to work as expected?
### Security {:#rg-sec}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment