Skip to content
Snippets Groups Projects
Unverified Commit b18f0c3d authored by totten's avatar totten Committed by GitHub
Browse files

Update review.md

parent 4258a0c7
No related branches found
No related tags found
No related merge requests found
......@@ -28,7 +28,12 @@ If you were a site-builder reading the PR-log/release-notes and drilled into thi
It is strongly encouraged that PR's include URLs/hyperlinks for any explanatory material (when available) -- such as a [JIRA issue](/tools/issue-tracking.md#jira), [Gitlab issue](http://lab.civicrm.org/), [StackExchange question](https://civicrm.stackexchange.com/), related PR, or [Mattermost chat](https://chat.civicrm.org). However, hyperlinks are not a substitute for a description. The PR should still have a description.
Exception: [NFC](/tools/git.md#nfc) and [WIP](/tools/git.md#wip) PRs may not need a detailed explanation.
PR descriptions should generally follow the [pull-request template](https://github.com/civicrm/civicrm-core/blob/master/.github/PULL_REQUEST_TEMPLATE.md), although this could be waived if another structure is more expressive.
__Exception__:
* [WIP](/tools/git.md#wip) PRs do not need a detailed explanation until they're ready for earnest review.
* Genuine [NFC](/tools/git.md#nfc) PRs do not need a detailed explanation.
### Test results {:#r-test}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment