Skip to content
Snippets Groups Projects
Commit 111c23f6 authored by Sean Madsen's avatar Sean Madsen Committed by GitHub
Browse files

Merge pull request #321 from mattwire/patch-12

Add another code construct (Civi::resources)
parents ad965737 3db90228
No related branches found
No related tags found
No related merge requests found
......@@ -53,6 +53,7 @@ Orange light code is code that has the feel that it is wrong and should be refac
* Removing as much as possible passing by reference to functions.
* Increasing code complexity, this has two issues firstly it increase the fragility of the code and also makes it harder to test
* Where ever `$session = CRM_Core_Session(); $userid = $session->get('UserID');` or very similar these calls should be replaced with `CRM_Core_Session::singleton()->getLoggedInContactID();`
* Replace `CRM_Core_Resources->singleton()->add...` and similar with `Civi::resources()->add...`
* Clean up messy code, see if code can be refactored and moved into parent classes and make them more generic, Also elimiate any duplicate code
* Increase the usage of Doc blocks to help with auto generation of code
* Move more business logic out from the Froms and API if possible to the BAO level
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment