Public
Authored by totten

phpoffice/phpword: Fix handling of libxml_disable_entity_loader (CiviCRM circa v5.23)

This patch was previously committed to CiviCRM (tools/scripts/composer/patches/phpword-libxml-fix-global-handling.patch) and applied via cweagans/composer-patches. However, the use of relative-paths to apply patches is problematic when patches are loaded transitively (as in Drupal 8 site-root).

Referencing the patch as a fully-formed URL is said to resolve this. In examples from D8 world, you see composer.json examples which reference patch-files as attachments in the project-management system.

If this patch needs to be changed in the future, then please:

  1. Post the updated patch to lab.civicrm.org or github.com (as an file-attachment/snippet/gist)
  2. Submit a PR to https://github.com/civicrm/civicrm-core to modify composer.json to reference the new patch.

When it comes time to execute tests on PRs, execute tests on RCs, or tag stables releases, this should behave in an intuitive fashion.

Edited
phpword-libxml-fix-global-handling.patch 2.2 KB
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment