Sorry, I'm honestly not involved much anymore so it's hard for me to say either way. I wouldn't be able to add anything useful beyond what's already in the description. So if these tickets look like they match then likely they do. :)
When upgrading the DB from this large jump (on drupal 7) the upgrade fails on 5.16.alpha1:
CiviCRM Upgrade Tasks
[Error: Update smart groups to rename filters on contribution_date to receive_date]
CiviCRM_API3_Exception: "DB Error: no such field"
#0 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Upgrade/Incremental/SmartGroups.php(206): civicrm_api3("SavedSearch", "create", (Array:3))
#1 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Upgrade/Incremental/SmartGroups.php(27): CRM_Upgrade_Incremental_SmartGroups->renameField("contribution_date_low", "receive_date_low")
#2 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Upgrade/Incremental/Base.php(222): CRM_Upgrade_Incremental_SmartGroups->updateGroups((Array:1))
#3 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Queue/Task.php(74): CRM_Upgrade_Incremental_Base::updateSmartGroups(Object(CRM_Queue_TaskContext), (Array:1))
#4 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Queue/Runner.php(201): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
#5 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(36): CRM_Queue_Runner->runNext(TRUE)
#6 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Queue/ErrorPolicy.php(89): CRM_Queue_Page_AJAX::{closure}()
#7 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(38): CRM_Queue_ErrorPolicy->call(Object(Closure))
#8 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(279): CRM_Queue_Page_AJAX::runNext()
#9 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem((Array:13))
#10 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:5))
#11 /var/www/crm.clgw.ca/html/sites/all/modules/civicrm/drupal/civicrm.module(458): CRM_Core_Invoke::invoke((Array:5))
#12 /var/www/crm.clgw.ca/html/includes/menu.inc(527): civicrm_invoke("upgrade", "queue", "ajax", "runNext")
#13 /var/www/crm.clgw.ca/html/index.php(21): menu_execute_active_handler()
#14 {main}
The civi log shows:
UPDATE `civicrm_saved_search`
SET `form_values` = 'my_serialized_data_here' ,
`modified_id` = 1284
WHERE ( `civicrm_saved_search`.`id` = 10 )
[nativecode=1054 ** Unknown column 'modified_id' in 'field list']
Searching around I found this which looks related:
So I downgraded my civi files from 5.36 to 5.34 and the db upgrade then worked. My assumption is that code changes in 5.36 modified some dependencies in the API for the SavedSearch object, which then caused earlier db updates on that object to fail.
I don't know if this is easily fixable, but if nothing else maybe this post will help others in my situation.
TLDR: Update your civi files (and then the db) to 5.34 first, then make the jump to a later version after that.