Extension-SHA: PR tests should run on current base+head
Report/discussion from Mattermost:
(seamuslee) @totten also I'm wondering if we should be doing a similar thing in the Extension-SHA job to be that it applies the commits from the PR ontop of the current branch of the ext rather than as it does now which is a git checkout ping @coleman
(totten) @seamuslee yeah, i think i agree with that behavior, but need an example to be clear so if
civicrm/api4
has PR#1234 with base-branchcivicrm:56.78
and head-branchalice:fix-foo
, then the test should be executed on the merged result ofcivicrm:56.78 + alice:fix-foo
if so, that should be the behavior of https://github.com/civicrm/civicrm-infra/blob/master/jenkins-examples/Extension-SHA.bash#L62-L68
which in turn is responsible for the bits of output for " Build test site...
civibuild download
...git clonebh
..."if it's not behaving that way...then first thing is to check if the given test-run has the right inputs for
GIT_BASE
andGIT_HEAD
(seamuslee) @totten i think @coleman has found that for example PR is created based on commit #5 from master (i.e. that is when it branches) but then we have a PR or something that adds commits #6, #7, #8 to master the PR test on the branch from #5 sometimes works sometimes doesn't because it isn't including the most recent commits