Hi @JonGold, I have applied https://github.com/civicrm/civicrm-core/pull/25129 and can confirm that closing and deleting accounting batches now works. Thanks for your help! So, it would be great if those patches could be incorporated into an upcoming CiviCRM release.
I can confirm that this fixes the Contributions search for new Gift Aid batches. But I manually had to go through and update existing option values in order to fix existing batches. So, an upgrader is indeed needed.
I have come across this issue, was having similar problems not being able to delete or close batches. I tried the patch in https://github.com/civicrm/civicrm-core/pull/24895 , but that doesn't seem to have fixed the problem, in my case.
Hi, I was having a similar issue with a client's CiviCRM installation, the contributions could not be searched by batch. I can confirm that the change in !26 (closed) fixes the problem for new batches.