Extensions issueshttps://lab.civicrm.org/groups/extensions/-/issues2024-03-08T18:01:43Zhttps://lab.civicrm.org/extensions/theisland/-/issues/16Support accordion styles that don't use .crm-accordion-wrapper or .crm-accord...2024-03-08T18:01:43ZnicolSupport accordion styles that don't use .crm-accordion-wrapper or .crm-accordion-headerThere are [two](https://github.com/civicrm/civicrm-core/pull/29447) [large](https://github.com/civicrm/civicrm-core/pull/29448) PRs to change over 60 accordions to `<details><summary>`. Given the amount of testing required, this would be...There are [two](https://github.com/civicrm/civicrm-core/pull/29447) [large](https://github.com/civicrm/civicrm-core/pull/29448) PRs to change over 60 accordions to `<details><summary>`. Given the amount of testing required, this would be a good moment to also remove the CSS classes `.crm-accordion-wrapper` and `.crm-accordion-header` as they can be targeted now with `details` and `summary` respectively (with utility classes on details to change the look of the header/summary).
However to do that the changes described [here](https://lab.civicrm.org/dev/user-interface/-/wikis/DINO:-Notify-themes-+-New-theme/changes-in-5.69) need implementing further, similar to how they have been in Greenwich, Finsbury Park & CAU Radstock. This means describing summary and details without those classes. E.g. Greenwich now includes (mixed in with other classes):
```
.crm-container summary {
display: list-item;
list-style: none;
cursor: pointer;
font-size: 1rem;
padding: 0.5rem;
font-weight: bold;
}
/* default dark bg accordion header style common in Civi */
.crm-container .crm-accordion-bold > summary {
color: #f5f6f1;
font-weight: normal;
padding: 4px 8px;
background-color: #5d677b;
border-radius: 4px;
}
.crm-container .crm-accordion-bold[open] > summary { /* open state */
border-radius: 4px 4px 0 0;
}
.crm-container .crm-accordion-bold > summary.active { /* active state */
font-weight: bold;
background-color: #3e3e3e;
}
.crm-container .crm-accordion-bold > summary:hover,
.crm-container .crm-accordion-bold > summary:focus { /* hover state */
background-color: #2f2f2e;
}
/* transparent bg accordion used in combination*/
.crm-container .crm-accordion-light > summary {
background-color: transparent;
font-weight: normal;
color: #3e3e3e;
}
.crm-container .crm-accordion-light > summary:hover,
.crm-container .crm-accordion-light > summary:focus { /* hover state */
color: #121a2d;
}
```
NB: `.crm-accordion-light` applies the same style that `.crm-master-accordion-header` does - a transparent background header used on the contact dashboard, and in combination with the main, dark bg style, such as on the Advanced Search page. `.crm-accordion-bold` applies Civi's main accordion style.
I looked at making a quick PR [here](https://lab.civicrm.org/extensions/theisland/-/blob/main/scss/civicrm/common/_accordions.scss) around this but couldn't find the `accordion-header` mixin and then got a bit lost by how things were implemented.shaneonabikeshaneonabikehttps://lab.civicrm.org/extensions/cdntaxreceipts/-/issues/145Demo tax receipt2024-03-07T13:33:06ZshaneonabikeDemo tax receipt## Description
Initially, when you install the CDN Tax Receipt you can generate a tax receipt and tweak it as you need. After you launch it officially, some people might want to tweak or modify the way that tax receipts are.
After maki...## Description
Initially, when you install the CDN Tax Receipt you can generate a tax receipt and tweak it as you need. After you launch it officially, some people might want to tweak or modify the way that tax receipts are.
After making modifications, there isn't a way (that I could find) to see a preview of the actual tax receipt. If you go to an existing contribution and view the tax receipt of a test contribution you can't really revert the tax receipt (from what I understand).
Or does it just work by issuing a test, and then afterwards deleting that transaction?
## Potential Solution
Provide a special button for admins or certain permissions to download a sample on any tax receipt that could even have "Sample" marked across it to prevent someone issuing a bunch of fakes.
Thanks again for the awesome extension!https://lab.civicrm.org/extensions/pdfapi/-/issues/37Small typo in the name in the activity display for the e-mail2024-03-07T09:18:27ZGuillaumeSorelSmall typo in the name in the activity display for the e-mailAfter doing some tests with CiviRules and PDF API it appears that the name of the attached file in the activity doubles the file type name of the file with `.pdf.pdf`
![image](/uploads/4e588b987c8062727bc908a63767799e/image.png)
But th...After doing some tests with CiviRules and PDF API it appears that the name of the attached file in the activity doubles the file type name of the file with `.pdf.pdf`
![image](/uploads/4e588b987c8062727bc908a63767799e/image.png)
But the related file's name attached in the E-mail is correct
![image](/uploads/16df6e4589e50969224e0d0a9d543d26/image.png)
So it seems that there's a small typo only for the E-mail activity.
It might be somehow be controlled by this part of the code (555 -> 572) but no extra `pdf` value seems to be added.
```
/**
* Method to create email activity for contact with PDF as attachment
*
* @param int $contactId
* @param array $fileIds
* @param $case_id
*/
protected function createEmailActivity($contactId, $fileIds, $case_id=null) {
$activityTypeId = $this->getActivityTypeId('email');
if ($activityTypeId) {
// first create activity
$activityParams = [
'source_contact_id' => $contactId,
'activity_type_id' => $activityTypeId,
'activity_date_time' => date('YmdHis'),
'details' => $this->_htmlMessageEmail,
'subject' => $this->_emailSubject,
];
```https://lab.civicrm.org/extensions/pdfapi/-/issues/36Weight of the file generated2024-03-07T08:38:32ZGuillaumeSorelWeight of the file generatedI was doing some tests and noticed the weight of the attached file generated par the PDF API: 1.2 MB for a simple page with text and logo.
![image](/uploads/b11cebe9b106b975c9ee66c7319395bb/image.png)
Could it be possible - and how - t...I was doing some tests and noticed the weight of the attached file generated par the PDF API: 1.2 MB for a simple page with text and logo.
![image](/uploads/b11cebe9b106b975c9ee66c7319395bb/image.png)
Could it be possible - and how - to reduce the weight of this file?https://lab.civicrm.org/extensions/eventics/-/issues/14Provide a hook to modify the actual ICS file before it is created2024-03-06T19:46:33ZshaneonabikeProvide a hook to modify the actual ICS file before it is created## Overview
In some cases, clients want the ability to modify the Event ICS prior to it being sent out. This might be different elements of the Event dates, etc.
In my case, I have a client who needs to change the actual Event date dep...## Overview
In some cases, clients want the ability to modify the Event ICS prior to it being sent out. This might be different elements of the Event dates, etc.
In my case, I have a client who needs to change the actual Event date depending on what was selected by the user during registration.
## Solution
Develop a hook that will pre-modify the Event prior to creating the ICS.shaneonabikeshaneonabikehttps://lab.civicrm.org/extensions/documents/-/issues/34PHP 8.1 + CiviCRM: Compatibility and improvements (funded)2024-03-06T14:50:14Zjofranzfranz@systopia.dePHP 8.1 + CiviCRM: Compatibility and improvements (funded)Stiftung Bildung wants to fund some work to avoid problems with recent CiviCRM versions and PHP 8.1 (and higher). Below I summed up some code scans. Some of these results might be false positives. We agreed to not come up with pull reque...Stiftung Bildung wants to fund some work to avoid problems with recent CiviCRM versions and PHP 8.1 (and higher). Below I summed up some code scans. Some of these results might be false positives. We agreed to not come up with pull requests as we lack deeper knowledge of this extension. They will reach out to you via helpdesk@civicoop.org
## Removed core methods ([ref](https://github.com/systopia/legacycode?tab=readme-ov-file#find-out-if-your-extension-might-have-a-compatibility-problem))
```
/CRM/Documents/Form/Searchphp: CRM_Core_Form_Date::buildDateRange($this, 'document_date', 1, '_low', '_high', E::ts('From:'), FALSE);
/CRM/Documents/Upgrader/Basephp: CRM_Core_DAO::executeSql($query, $params);
```
## Some scans (might be some false positives)
```- PHP 8.1 (5)
+-------------------------------------------------------+---------+--------------------------------------------------------+
| File (Line:Column) | Type | Issue |
+-------------------------------------------------------+---------+--------------------------------------------------------+
| /CRM/Documents/Entity/Document.php (370:22) | removed | Function end() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Entity/Document.php (383:22) | removed | Function end() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Entity/DocumentRepository.php (273:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Form/CaseDocuments.php (28:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Page/CaseDocuments.php (53:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
+-------------------------------------------------------+---------+--------------------------------------------------------+
```
## PhpStan scan
```
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/Document.php
------ --------------------------------------------------------------------------------------
84 Access to an undefined property CRM_Documents_DAO_Document::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentCase.php
------ --------------------------------------------------------------------------------------
59 Access to an undefined property CRM_Documents_DAO_DocumentCase::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentContact.php
------ --------------------------------------------------------------------------------------
59 Access to an undefined property CRM_Documents_DAO_DocumentContact::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentEntity.php
------ --------------------------------------------------------------------------------------
66 Access to an undefined property CRM_Documents_DAO_DocumentEntity::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentVersion.php
------ --------------------------------------------------------------------------------------
74 Access to an undefined property CRM_Documents_DAO_DocumentVersion::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Entity/Document.php
------ --------------------------------------------------------------------------------------
127 Function explode invoked with 1 parameter, 2-3 required.
153 Access to an undefined property CRM_Documents_Entity_Document::$case_ids.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
155 Access to an undefined property CRM_Documents_Entity_Document::$case_ids.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
155 Function explode invoked with 1 parameter, 2-3 required.
193 Cannot unset offset *NEVER* on int.
------ --------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------
Line CRM/Documents/Form/Document.php
------ -------------------------------------------------------------------------------------------------------------------------------------
101 Call to an undefined method CRM_Documents_Form_Document::getSubmitValue().
102 Call to deprecated method preProcess() of class CRM_Custom_Form_CustomData:
see https://github.com/civicrm/civicrm-core/pull/29241 for preferred approach - basically
1) at the tpl layer use CRM/common/customDataBlock.tpl
2) to make the fields available for postProcess
if ($this->isSubmitted()) {
$this->addCustomDataFieldsToForm('FinancialAccount');
}
3) pass getSubmittedValues() to CRM_Core_BAO_CustomField::postProcess($this->getSubmittedValues(), $this->_id, 'FinancialAccount');
to ensure any money or number fields are handled for localisation
204 Call to an undefined method CRM_Documents_Form_Document::exportValue().
205 Call to an undefined method CRM_Documents_Form_Document::exportValue().
206 Call to an undefined method CRM_Documents_Form_Document::exportValue().
271 Access to an undefined property CRM_Documents_Form_Document::$_elements.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------
Line CRM/Documents/Form/NewVersion.php
------ ---------------------------------------------------------------------------------------------------------------
58 Method CRM_Documents_Form_NewVersion::setDefaultValues() should return array but return statement is missing.
124 Call to an undefined method CRM_Documents_Form_NewVersion::exportValue().
153 Access to an undefined property CRM_Documents_Form_NewVersion::$_elements.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ ---------------------------------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Form/Search.php
------ --------------------------------------------------------------------------------------
51 Call to an undefined method CRM_Documents_Form_Search::getButtonName().
52 Call to an undefined method CRM_Documents_Form_Search::getButtonName().
69 Access to an undefined property CRM_Documents_Form_Search::$_queryParams.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
90 Call to an undefined method CRM_Documents_Form_Search::addElement().
98 Call to an undefined static method CRM_Core_Form_Date::buildDateRange().
156 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
159 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
159 Access to an undefined property CRM_Documents_Form_Search::$_queryParams.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
161 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Selector/Search.php
------ --------------------------------------------------------------------------------------
118 Call to deprecated method getGroupDetail() of class CRM_Core_BAO_CustomGroup:
Legacy function
142 Access to an undefined property CRM_Documents_Selector_Search::$where.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
146 Call to deprecated method value() of class CRM_Utils_Array.
283 Fetching deprecated class constant ROWCOUNT of class CRM_Utils_Pager.
607 Access to an undefined property CRM_Documents_Selector_Search::$_rangeCache.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Upgrader/Base.php
------ --------------------------------------------------------------------------------------
122 Call to an undefined static method CRM_Core_DAO::executeSql().
142 Access to an undefined property CRM_Documents_Upgrader_Base::$queue.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
170 Access to an undefined property CRM_Documents_Upgrader_Base::$queue.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
234 Call to deprecated method setItem() of class CRM_Core_BAO_Setting:
- refer docs https://docs.civicrm.org/dev/en/latest/framework/setting/
------ --------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line CRM/Documents/Utils/HookInvoker.php
------ ----------------------------------------------------------------------------
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
55 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
------ ----------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Entity/CaseDocuments.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------
37 Parameter $entity of method Civi\CaseArchive\Documents\Entity\CaseDocuments::__construct() has invalid type Civi\CaseArchive\Entity\CaseEntity.
48 Parameter $archiveFile of method Civi\CaseArchive\Documents\Entity\CaseDocuments::onPrepare() has invalid type Civi\CaseArchive\ArchiveFile.
56 Instantiated class Civi\CaseArchive\ArchiveFile\SubHtmlFile not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
58 Class Civi\CaseArchive\Documents\Entity\Document does not have a constructor and must be instantiated without any parameters.
------ -------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Entity/Document.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
27 Class Civi\CaseArchive\Documents\Entity\Document extends unknown class Civi\CaseArchive\Entity\AbstractEntity.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
44 Call to an undefined method Civi\CaseArchive\Documents\Entity\Document::getEntityId().
63 Parameter $archiveFile of method Civi\CaseArchive\Documents\Entity\Document::onPrepare() has invalid type Civi\CaseArchive\ArchiveFile.
64 Call to an undefined method Civi\CaseArchive\Documents\Entity\Document::getHtmlFile().
65 Access to an undefined property Civi\CaseArchive\Documents\Entity\Document::$htmlFile.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
66 Class Civi\CaseArchive\Documents\Section\DocumentSection does not have a constructor and must be instantiated without any parameters.
67 Access to an undefined property Civi\CaseArchive\Documents\Entity\Document::$customData.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
68 Class Civi\CaseArchive\Documents\Section\DocumentVersionsSection does not have a constructor and must be instantiated without any parameters.
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/EventListener.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
32 Parameter $event of method Civi\CaseArchive\Documents\EventListener::onPrepare() has invalid type Civi\CaseArchive\Event\PrepareArchiveEvent.
33 Class Civi\CaseArchive\Entity\CaseEntity not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/CaseDocumentSection.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
29 Class Civi\CaseArchive\Documents\Section\CaseDocumentSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
51 Parameter $entity of method Civi\CaseArchive\Documents\Section\CaseDocumentSection::__construct() has invalid type Civi\CaseArchive\Entity\AbstractEntity.
52 Civi\CaseArchive\Documents\Section\CaseDocumentSection::__construct() calls parent::__construct() but Civi\CaseArchive\Documents\Section\CaseDocumentSection does not extend any class.
82 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\CaseDocumentSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
83 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
88 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
89 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
99 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
99 Call to an undefined method Civi\CaseArchive\Documents\Section\CaseDocumentSection::fetchTemplate().
100 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
101 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/DocumentSection.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
31 Class Civi\CaseArchive\Documents\Section\DocumentSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
69 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\DocumentSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
70 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
74 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
75 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
83 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
83 Call to an undefined method Civi\CaseArchive\Documents\Section\DocumentSection::fetchTemplate().
84 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
85 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
94 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/DocumentVersionsSection.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
30 Class Civi\CaseArchive\Documents\Section\DocumentVersionsSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
65 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\DocumentVersionsSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
66 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
71 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
72 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
87 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
87 Call to an undefined method Civi\CaseArchive\Documents\Section\DocumentVersionsSection::fetchTemplate().
88 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
89 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
98 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------
Line documents.civix.php
------ ---------------------------------------------------------------------------
276 Call to deprecated method mungeCaseType() of class CRM_Case_XMLProcessor.
277 Call to deprecated method mungeCaseType() of class CRM_Case_XMLProcessor.
366 Call to deprecated method value() of class CRM_Utils_Array.
------ ---------------------------------------------------------------------------
------ --------------------------------------------
Line documents.php
------ --------------------------------------------
279 Call to deprecated function civicrm_api().
311 Call to deprecated function civicrm_api().
------ --------------------------------------------
```
___
SYSTOPIA reference: 23657https://lab.civicrm.org/extensions/sparkpost-symbiotic/-/issues/45.70 compatibility: mailing_id should be passed into EventQueue2024-03-05T19:19:19Zbgm5.70 compatibility: mailing_id should be passed into EventQueueIn the CiviCRM log, for transactional emails:
```
[warning] mailing_id should be passed into EventQueue create calls.
Temporary handling has set it for now Caller: ::sparkpost_civicrm_alterMailParams
```In the CiviCRM log, for transactional emails:
```
[warning] mailing_id should be passed into EventQueue create calls.
Temporary handling has set it for now Caller: ::sparkpost_civicrm_alterMailParams
```https://lab.civicrm.org/extensions/civisualize/-/issues/122Fails to register plugins in Smarty32024-03-05T10:36:49ZRichFails to register plugins in Smarty3> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $functi...> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $function, $function, $cacheable, $cache_attrs);`
note that it passes `$function` in twice. So it thinks `crmSQL` is the callable, which it isn't.
Relevant [chat](https://chat.civicrm.org/civicrm/pl/i77pr7o717g4ty3tqzry7ybbyo)https://lab.civicrm.org/extensions/invoicehelper/-/issues/9Possible feature request: Payment link in invoice, and filter for financial type2024-03-04T17:01:01ZUpperholmePossible feature request: Payment link in invoice, and filter for financial typeProvision of a payment link to enable payment by Stripe is potentially really useful. Is that link available as a variable that I can include in the invoice PDF? And if so would it then be possible to only include the link in the invoice...Provision of a payment link to enable payment by Stripe is potentially really useful. Is that link available as a variable that I can include in the invoice PDF? And if so would it then be possible to only include the link in the invoice if, for example, the invoice was for an event registration? (maybe the Smarty code in the invoice template could do that?)https://lab.civicrm.org/extensions/themetest/-/issues/18civix upgrade problem with Smarty mixin2024-03-04T09:05:07ZRichcivix upgrade problem with Smarty mixinThe `civix upgrade` command won't run, it gives
```
...The `civix upgrade` command won't run, it gives
```
Incremental upgrades
====================
Current civix format is v23.02.1.
No incremental upgrades required.
General upgrade
===============
In Mixlib.php line 147:
Received incompatible version (expected="smarty-v2@1.0.1", actual="smarty-v2@1.0.0")
```
I'm not sure what that means.https://lab.civicrm.org/extensions/gdpr/-/issues/342New Version2024-03-03T19:03:09ZrajeshsNew Version*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can fo...*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can for now. In other words, does everything I need. Templates with errors have been updated etc. I'm sure there is more work, but at least now it won't fatal error your server and in my testing (for my needs), it is working.
My main need was to have terms and conditions on events. It works.
Here is the entire patch.
[GDPR.patch](https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/files/14474231/GDPR.patch)
https://lab.civicrm.org/extensions/cividiscount/-/issues/304Discount Code Applies to ALL lines, vs. the specified line in the Price Set F...2024-02-29T20:40:13ZSolasusAdminDiscount Code Applies to ALL lines, vs. the specified line in the Price Set FieldI have set up a discount to apply 100% of the price to specific Price Fields from my Price Set, however, the discount is applied to all lines. We have tried editing the Discount to a specific amount instead of a %, and the result is the ...I have set up a discount to apply 100% of the price to specific Price Fields from my Price Set, however, the discount is applied to all lines. We have tried editing the Discount to a specific amount instead of a %, and the result is the same.
This is a code used applicable to only 2 of the 3 price fields in the Price Set designated for this event.
The Price set field I am using has one mandatory price field and an additional optional price field (there is at least one charge, with the optional second). In this case, we've chosen (in the setup) to apply the discount code to the mandatory field only, but is being applied to both.
*We have also tried changing the Discount Amount Type from a %, to a fixed amount (fixed amount reflecting the on mandatory price field), without success, as the discount 'zeroed' out all amounts.
Currently using CiviCRM v 5.58.1 and CiviDiscount v 3.8.8https://lab.civicrm.org/extensions/gdpr/-/issues/339CRM_Core_Smarty2024-02-28T14:52:18ZrajeshsCRM_Core_Smarty*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/s...*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/sites/default/files/civicrm/ext/uk.co.vedaconsulting.gdpr/gdpr.civix.php on line 100
https://lab.civicrm.org/extensions/documents/-/issues/33Action Provider Action: Upload new document updates the modified date of all ...2024-02-27T15:45:06Zsimon.hermannAction Provider Action: Upload new document updates the modified date of all documents in a case.If I use the Action Provider action to upload a new document to a case, not only the modified date of the new document is set to the current date, but also the modified dates of all previously uploaded documents.
This occurs with release...If I use the Action Provider action to upload a new document to a case, not only the modified date of the new document is set to the current date, but also the modified dates of all previously uploaded documents.
This occurs with release 1.24 and was observed both in CiviCRM 5.68.1 as well as 5.64.4 .
Furhtermore, it would be great if also the time of the upload could be stored instead of just the date.
@jaapjansma if you could give me a hint, where the date is set, I am happy to try my best to provide a PR.https://lab.civicrm.org/extensions/opennorth/-/issues/1On change of settings, update the represent custom entity entries2024-02-27T14:57:59ZAlanDixonOn change of settings, update the represent custom entity entriesThe settings allows an admin to choose which Representative Sets are to be used, e.g. "only Federal Ridings".
After the settings are updated, we want to populate/repopulate the sites corresponding entities of type Representative Sets ->...The settings allows an admin to choose which Representative Sets are to be used, e.g. "only Federal Ridings".
After the settings are updated, we want to populate/repopulate the sites corresponding entities of type Representative Sets -> Boundary Sets -> Boundaries -> Representatives.AlanDixonAlanDixonhttps://lab.civicrm.org/extensions/authnet/-/issues/33Upgrade Error: Could not delete payment processor type2024-02-26T18:54:33ZrbaughUpgrade Error: Could not delete payment processor typeWhen upgrading a staging site from 2.5.2 to 2.5.3, I was presented with a message about not being able to delete a payment processor. Looking at the logs, it seems it was trying to delete the Authnet payment processor which is the only p...When upgrading a staging site from 2.5.2 to 2.5.3, I was presented with a message about not being able to delete a payment processor. Looking at the logs, it seems it was trying to delete the Authnet payment processor which is the only processor set up on the site.
```
Dec 01 07:24:43 [error] (com.donordepot.authnetecheck) Unable to delete managed entity "Authorize.Net (Credit Card)": Could not delete payment processor type
Array
(
[exception] => CRM_Core_Exception: "Could not delete payment processor type"
#0 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/ManagedEntities.php(369): civicrm_api3("payment_processor_type", "delete", (Array:2))
#1 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/ManagedEntities.php(149): CRM_Core_ManagedEntities->removeStaleEntity((Array:8))
#2 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/ManagedEntities.php(113): CRM_Core_ManagedEntities->reconcileEntities((Array:93))
#3 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(417): CRM_Core_ManagedEntities->reconcile()
#4 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Extension/Manager.php(231): CRM_Core_Invoke::rebuildMenuAndCaches(TRUE)
#5 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Extension/Downloader.php(152): CRM_Extension_Manager->replace("/tmp/tmp-xMrj2b//authnet-2.5.3")
#6 /home/www/staging/wp-content/plugins/civicrm/civicrm/api/v3/Extension.php(239): CRM_Extension_Downloader->download("com.donordepot.authnetecheck", "https://lab.civicrm.org/extensions/authnet/-/archive/2.5.3/authnet-2.5.3.zip")
#7 /home/www/staging/wp-content/plugins/civicrm/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_download((Array:4))
#8 /home/www/staging/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(158): Civi\API\Provider\MagicFunctionProvider->invoke((Array:8))
#9 /home/www/staging/wp-content/plugins/civicrm/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest((Array:8))
#10 /home/www/staging/wp-content/plugins/civicrm/civicrm/api/api.php(22): Civi\API\Kernel->runSafe("Extension", "download", (Array:2))
#11 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Admin/Form/Extensions.php(202): civicrm_api("Extension", "download", (Array:2))
#12 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Form.php(624): CRM_Admin_Form_Extensions->postProcess()
#13 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/StateMachine.php(144): CRM_Core_Form->mainProcess()
#14 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/QuickForm/Action/Next.php(43): CRM_Core_StateMachine->perform(Object(CRM_Admin_Form_Extensions), "next", "Next")
#15 /home/www/staging/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Admin_Form_Extensions), "next")
#16 /home/www/staging/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Admin_Form_Extensions), "next")
#17 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle("next")
#18 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Page/Basic.php(364): CRM_Core_Controller->run()
#19 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Page/Basic.php(170): CRM_Core_Page_Basic->edit(2, NULL)
#20 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Admin/Page/Extensions.php(105): CRM_Core_Page_Basic->run()
#21 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(319): CRM_Admin_Page_Extensions->run((Array:3), NULL)
#22 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem((Array:19))
#23 /home/www/staging/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#24 /home/www/staging/wp-content/plugins/civicrm/civicrm.php(1199): CRM_Core_Invoke::invoke((Array:3))
#25 /home/www/staging/wp-includes/class-wp-hook.php(308): CiviCRM_For_WordPress->invoke("")
#26 /home/www/staging/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters("", (Array:1))
#27 /home/www/staging/wp-includes/plugin.php(517): WP_Hook->do_action((Array:1))
#28 /home/www/staging/wp-admin/admin.php(259): do_action("toplevel_page_CiviCRM")
#29 {main}
)
```https://lab.civicrm.org/extensions/stripe/-/issues/4716.10 - Stripe API 2023-08-16 'and force it to be used', not in all cases2024-02-26T11:35:39ZJKingsnorth6.10 - Stripe API 2023-08-16 'and force it to be used', not in all casesWe've upgraded to 6.10.2 and can see that Stripe API version 2023-08-16 is being used for the majority of requests, but POST requests to `POST /v1/payment_methods` are still going to the 'default' API for the account (which in our case i...We've upgraded to 6.10.2 and can see that Stripe API version 2023-08-16 is being used for the majority of requests, but POST requests to `POST /v1/payment_methods` are still going to the 'default' API for the account (which in our case is 2020-08-27).
This doesn't seem to cause any problems, but just wanted to flag it if we were expecting all API calls to be forced to the latest version, as suggested in the release notes:
> 6.10 release notes: Supports Stripe API version 2023-08-16 (and will force it to be used).
Also, the _latest_ version is 2023-10-16 - but API calls are still going to 2023-08-16.https://lab.civicrm.org/extensions/cdntaxreceipts/-/issues/42Queue processing for large receipt runs2024-02-23T20:55:51ZKarinGQueue processing for large receipt runs*Created by: jake-mw*
The root issue in #38 -- timeouts when running large batches of receipts on certain servers -- means that large batches of tax receipts can be lost if the server times out half way through processing. Once the ser...*Created by: jake-mw*
The root issue in #38 -- timeouts when running large batches of receipts on certain servers -- means that large batches of tax receipts can be lost if the server times out half way through processing. Once the server times out, the receipts that were already issued can't be issued again. But the printout hasn't yet been downloaded. So there's a lot of cleanup that needs to happen in order to rescue a half-finished process: need to clean up the tax archive, remove entries from the database log (through the mysql backend) and then try to issue again using a smaller batch size.
While some folks can change their server settings to allow longer execution time, this isn't available to everyone. Nor are most users able (nor should they) manually clean up the underlying database tables. And if it's a mix of hardcopy & email receipts that are being issued when the timeout occurred, it becomes a real mess.
We should probably queue up the expensive operations when issuing large batches of receipts (e.g. the individual emails sent to the email archive), and process the queue in a separate process.
https://lab.civicrm.org/extensions/findpayments/-/issues/6Incompatible with CiviCRM 5.48.0+2024-02-22T15:43:13ZJKingsnorthIncompatible with CiviCRM 5.48.0+> Fatal error: Cannot make static method CRM_Contact_BAO_Query_Interface::from() non static in class CRM_Findpayment_BAO_Query in .../CRM/Findpayment/BAO/Query.php on line 29
I'm working on a fix now.> Fatal error: Cannot make static method CRM_Contact_BAO_Query_Interface::from() non static in class CRM_Findpayment_BAO_Query in .../CRM/Findpayment/BAO/Query.php on line 29
I'm working on a fix now.https://lab.civicrm.org/extensions/multisite/-/issues/1New release?2024-02-22T11:21:44ZkcristianoNew release?I just ran into an issue where updating to the git version was the fix. Any chance we can get a release tagged for distribution via the admin UI?I just ran into an issue where updating to the git version was the fix. Any chance we can get a release tagged for distribution via the admin UI?