Extensions issueshttps://lab.civicrm.org/groups/extensions/-/issues2024-03-05T10:36:49Zhttps://lab.civicrm.org/extensions/civisualize/-/issues/122Fails to register plugins in Smarty32024-03-05T10:36:49ZRichFails to register plugins in Smarty3> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $functi...> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $function, $function, $cacheable, $cache_attrs);`
note that it passes `$function` in twice. So it thinks `crmSQL` is the callable, which it isn't.
Relevant [chat](https://chat.civicrm.org/civicrm/pl/i77pr7o717g4ty3tqzry7ybbyo)https://lab.civicrm.org/extensions/gdpr/-/issues/342New Version2024-03-03T19:03:09ZrajeshsNew Version*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can fo...*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can for now. In other words, does everything I need. Templates with errors have been updated etc. I'm sure there is more work, but at least now it won't fatal error your server and in my testing (for my needs), it is working.
My main need was to have terms and conditions on events. It works.
Here is the entire patch.
[GDPR.patch](https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/files/14474231/GDPR.patch)
https://lab.civicrm.org/extensions/gdpr/-/issues/341Missing Template File TermsAndConditions.tpl Causes Fatal Error2024-02-14T20:21:31ZrajeshsMissing Template File TermsAndConditions.tpl Causes Fatal Error*Created by: tresero*
## Description:
When attempting to access or modify event settings within CiviCRM, a fatal error is triggered due to the system being unable to load a required template file for the GDPR extension. The specific fi...*Created by: tresero*
## Description:
When attempting to access or modify event settings within CiviCRM, a fatal error is triggered due to the system being unable to load a required template file for the GDPR extension. The specific file CRM/Gdpr/Form/ManageEvent/TermsAndConditions.tpl appears to be missing from the extension's directory, resulting in a SmartyException and preventing successful page loads.
## Steps to Reproduce:
Navigate to the WordPress admin dashboard.
Go to CiviCRM > Events > Manage Events.
Select an event and attempt to access its settings.
The error occurs at this point, with CiviCRM unable to proceed due to the missing template file.
Expected Behavior:
The expected behavior is for the event settings page to load without issues, allowing for the management of GDPR-related settings for events.
## Actual Behavior:
A fatal error occurs, with the following details captured in the logs:
```
Fatal Error Details = array:3 [
"message" => "Unable to load template 'file:CRM/Gdpr/Form/ManageEvent/TermsAndConditions.tpl' in 'file:CRM/Form/default.tpl'"
"code" => null
"exception" => SmartyException {#17487
...
]
```
## Environment:
CiviCRM Version: 5.70.0
GDPR Extension Version: 3.5
CMS: WordPress
PHP Version: [Specify version]
## Troubleshooting Steps Already Taken:
Verified the GDPR extension is correctly installed and up to date.
Checked the file system for the presence of TermsAndConditions.tpl in the expected directory (CRM/Gdpr/Form/ManageEvent/) and confirmed it is missing.
Cleared CiviCRM caches.
Checked file and directory permissions to rule out access issues.
## Suggested Fix:
It appears this issue may be due to the file either being accidentally omitted from the extension package or a reference to a deprecated or renamed file that hasn't been updated. A review and correction of the extension's file structure and references to TermsAndConditions.tpl would likely resolve this issue.https://lab.civicrm.org/extensions/gdpr/-/issues/335Incompatible with 5.61+?2023-10-25T08:13:58Zjofranzfranz@systopia.deIncompatible with 5.61+?```
➜ uk.co.vedaconsulting.gdpr (master) check-extensions-for-removed-core-code.sh -d . ✭
./CRM/Gdpr/Form/Sear...```
➜ uk.co.vedaconsulting.gdpr (master) check-extensions-for-removed-core-code.sh -d . ✭
./CRM/Gdpr/Form/Search/GroupcontactDetails.php:
CRM_Core_Form_Date::buildDateRange($form, 'subscription_date', 1, '_low', '_high', E::ts('From'), FALSE);
```
@eileenmcnaughton
Touches #330https://lab.civicrm.org/extensions/gdpr/-/issues/339CRM_Core_Smarty2024-02-28T14:52:18ZrajeshsCRM_Core_Smarty*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/s...*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/sites/default/files/civicrm/ext/uk.co.vedaconsulting.gdpr/gdpr.civix.php on line 100
https://lab.civicrm.org/extensions/gdpr/-/issues/336Manage Event: cannot save "Info and Settings" when T&C are set on CiviCRM 5.662023-11-06T10:33:54ZrajeshsManage Event: cannot save "Info and Settings" when T&C are set on CiviCRM 5.66*Created by: mlutfy*
Can be reproduced on CiviCRM 5.66 (rc) or dmaster:
- Enable the GDPR extension
- Go to Manage Events, edit an event
- Go to the Terms & Conditions tab, set "Enable terms and Conditions Acceptance" = "no"
- Go ...*Created by: mlutfy*
Can be reproduced on CiviCRM 5.66 (rc) or dmaster:
- Enable the GDPR extension
- Go to Manage Events, edit an event
- Go to the Terms & Conditions tab, set "Enable terms and Conditions Acceptance" = "no"
- Go to the Info and Settings tab, click save.
You will get an error "Checkbox text is a required field." and "Link Label is a required field."https://lab.civicrm.org/extensions/gdpr/-/issues/334Error when saving gdpr preference form2023-08-15T16:03:18ZrajeshsError when saving gdpr preference form*Created by: tapashdatta*
Running civi latest, Gdpr 3.5
When saving the gdpr preference form https://example.com/civicrm/gdpr/comms-prefs/update getting this error
<img width="1214" alt="Screenshot 2023-08-15 at 21 29 55" src="https...*Created by: tapashdatta*
Running civi latest, Gdpr 3.5
When saving the gdpr preference form https://example.com/civicrm/gdpr/comms-prefs/update getting this error
<img width="1214" alt="Screenshot 2023-08-15 at 21 29 55" src="https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/assets/5366545/67039223-2a5c-4405-bb21-a728cac929ec">
https://lab.civicrm.org/extensions/gdpr/-/issues/330Core deprecation affecting this extension2023-08-21T21:08:38ZrajeshsCore deprecation affecting this extension*Created by: eileenmcnaughton*
We are deprecating a function this extension calls - https://github.com/civicrm/civicrm-core/pull/26829/files#diff-931e65674ed680adf93d7ba4727419ec32b5fd4636ac84109dd9621f89e20e0dR231
It's not actually...*Created by: eileenmcnaughton*
We are deprecating a function this extension calls - https://github.com/civicrm/civicrm-core/pull/26829/files#diff-931e65674ed680adf93d7ba4727419ec32b5fd4636ac84109dd9621f89e20e0dR231
It's not actually a function that is supported for use outside of core but since I discovered that GDPR DOES call it I have deprecated rather than remove it.
You can just copy the contents back to your code rather than calling core functions that are not intended to be used from outside of corehttps://lab.civicrm.org/extensions/gdpr/-/issues/324Error when enabling Terms and Conditions in an Event online registration page2024-01-22T10:19:52ZrajeshsError when enabling Terms and Conditions in an Event online registration page*Created by: calbasi*
I get an error when enabling Terms and Conditions in an Event online registration page.
CiviCRM 5.60-alpha1
Drupal 10
php 8.1
From drupal logs:
```
Localization: civicrm/event/register?id=8&reset=1
Re...*Created by: calbasi*
I get an error when enabling Terms and Conditions in an Event online registration page.
CiviCRM 5.60-alpha1
Drupal 10
php 8.1
From drupal logs:
```
Localization: civicrm/event/register?id=8&reset=1
Reference: civicrm/event/info?reset=1&id=8
TypeError: strlen(): Argument #1 ($string) must be of type string, array given in HTML_QuickForm_checkbox->toHtml() (line 138 of vendor/civicrm/civicrm-packages/HTML/QuickForm/checkbox.php).
Severity: Error
```
https://lab.civicrm.org/extensions/gdpr/-/issues/320Date format of "Terms & Conditions" acceptance date2023-01-11T16:03:23ZrajeshsDate format of "Terms & Conditions" acceptance date*Created by: palur76*
In `CRM/Gdpr/Form/UpdatePreference.php`, in line 135. is set, that the date format of the agree date of the "Terms & Conditions" is `d/m/Y`.
It would be nice to be able to set it by the admin - eg. to CiviCRM s...*Created by: palur76*
In `CRM/Gdpr/Form/UpdatePreference.php`, in line 135. is set, that the date format of the agree date of the "Terms & Conditions" is `d/m/Y`.
It would be nice to be able to set it by the admin - eg. to CiviCRM short / middle / long date, or with the PHP date setting methods.https://lab.civicrm.org/extensions/gdpr/-/issues/331Error 'Class "CRM_Gdpr_Utils" not found' has broken front-end CRM pages2023-07-17T11:38:42ZrajeshsError 'Class "CRM_Gdpr_Utils" not found' has broken front-end CRM pages*Created by: vingle*
Front-end contribution pages stopped working and show 'Class "CRM_Gdpr_Utils" not found'.
When I try to disable the extension in the backend I got the same error. When I disable it via the dbse then try to uninst...*Created by: vingle*
Front-end contribution pages stopped working and show 'Class "CRM_Gdpr_Utils" not found'.
When I try to disable the extension in the backend I got the same error. When I disable it via the dbse then try to uninstall, I get the same error. This was only fixed by deleting the gdpr extension dir and flushing the cache.
CiviCRM 5.59.4 & Joomla 4.3.3 (it had been working on Joomla 4).https://lab.civicrm.org/extensions/gdpr/-/issues/310Add "Terms & Condition" in a profile2022-07-15T12:29:43ZmasettoAdd "Terms & Condition" in a profileThe original question of @robbrandt was:
> Is it possible to add a GDPR Terms & Conditions checkbox to any profile?
@tapashdatta, the checkbox "Use as the mailing subscribe page" add Communication preferences but does not add Terms &...The original question of @robbrandt was:
> Is it possible to add a GDPR Terms & Conditions checkbox to any profile?
@tapashdatta, the checkbox "Use as the mailing subscribe page" add Communication preferences but does not add Terms & Conditions checkbox which is used instead in contribution and event pages.
How can I add "Terms & Condition" in a profile? (for example "Become a volunteer", signup form...)
_Originally posted by @masetto in https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/issues/126#issuecomment-1138612663_https://lab.civicrm.org/extensions/gdpr/-/issues/321ln10/fr_FR2023-02-23T12:25:23ZUsha Matisson775-usha.makoa@users.noreply.lab.civicrm.orgln10/fr_FR@mattwire
Is it possible to add the gdpr.mo french localization file to this beautiful extension please? I've already translated in transifex but need to add it manually on each upgrade.
And to add a ts() on the navigation menus > ...@mattwire
Is it possible to add the gdpr.mo french localization file to this beautiful extension please? I've already translated in transifex but need to add it manually on each upgrade.
And to add a ts() on the navigation menus > Contacts > GDPR Dashboard and in Administer ?
thankshttps://lab.civicrm.org/extensions/gdpr/-/issues/311Mailing Subscribe Page: missing check if user exists2022-07-15T13:18:19ZmasettoMailing Subscribe Page: missing check if user existsIf I check `Check to use the Communications Preferences page instead of the default Mailing Subscribe page.` when a user registers to
`/civicrm/gdpr/comms-prefs/update` page, no check is made on the existance of the contact and **a ne...If I check `Check to use the Communications Preferences page instead of the default Mailing Subscribe page.` when a user registers to
`/civicrm/gdpr/comms-prefs/update` page, no check is made on the existance of the contact and **a new one is always created**.
https://lab.civicrm.org/extensions/gdpr/-/issues/315Error updating comms-prefs in other language (CiviCRM localized in spanish)2022-08-31T16:01:22ZrajeshsError updating comms-prefs in other language (CiviCRM localized in spanish)*Created by: rubofvil*
## Summary
In form -> `/civicrm/gdpr/comms-prefs/update`
When you make a submission, the next error is reported
```
Sorry, due to an error, we are unable to fulfill your request at the moment. You may...*Created by: rubofvil*
## Summary
In form -> `/civicrm/gdpr/comms-prefs/update`
When you make a submission, the next error is reported
```
Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
'Teléfono' is not a valid option for field preferred_communication_method
```
Ref: "Teléfono" is "Phone" in Spanish
### Screenshot
![error_gdpr](https://user-images.githubusercontent.com/2327763/187721261-58a67a86-da77-45d7-8738-911e6f3534ef.png)
### Error in ConfigAndLog
```
$Fatal Error Details = array:3 [
"message" => "'Teléfono' is not a valid option for field preferred_communication_method"
"code" => null
"exception" => CiviCRM_API3_Exception {#2178
-extraParams: array:6 [
"error_field" => "preferred_communication_method"
"error_code" => 2001
"entity" => "Contact"
"action" => "create"
"is_error" => 1
"error_message" => "'Teléfono' is not a valid option for field preferred_communication_method"
]
#message: "'Teléfono' is not a valid option for field preferred_communication_method"
#code: 0
#file: "/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/api/api.php"
#line: 133
trace: {
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/api/api.php:133 {
› if (is_array($result) && !empty($result['is_error'])) {
› throw new CiviCRM_API3_Exception($result['error_message'], CRM_Utils_Array::value('error_code', $result, 'undefined'), $result);
› }
}
/data/disk/rpineda/static/repositories/ext/uk.co.vedaconsulting.gdpr/CRM/Gdpr/CommunicationsPreferences/Utils.php:568 { …}
/data/disk/rpineda/static/repositories/ext/uk.co.vedaconsulting.gdpr/CRM/Gdpr/Form/UpdatePreference.php:326 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/Form.php:513 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/QuickForm/Action/Submit.php:56 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/packages/HTML/QuickForm/Controller.php:203 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/packages/HTML/QuickForm/Page.php:103 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/Controller.php:347 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Utils/Wrapper.php:98 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/Invoke.php:285 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/Invoke.php:68 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/CRM/Core/Invoke.php:36 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/profiles/commons/modules/contrib/civicrm/drupal/civicrm.module:458 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/includes/menu.inc:527 { …}
/data/disk/rpineda/static/platforms/civigo_commons/7.91.1-3.50-5.35.2-2.3.2/index.php:21 { …}
}
}
]
```https://lab.civicrm.org/extensions/gdpr/-/issues/301[civi.tag] => deprecated on log2021-10-21T16:41:57Zrajeshs[civi.tag] => deprecated on log*Created by: pk825*
There is this message on the log
```
[warning] Attributes passed to CRM_Core_Form::add() are not an array. Caller: CRM_Gdpr_SLA_Entity::addField
Array
(
[civi.tag] => deprecated
)
```
is it a real problem?*Created by: pk825*
There is this message on the log
```
[warning] Attributes passed to CRM_Core_Form::add() are not an array. Caller: CRM_Gdpr_SLA_Entity::addField
Array
(
[civi.tag] => deprecated
)
```
is it a real problem?https://lab.civicrm.org/extensions/gdpr/-/issues/308Contribution page not showing GDPR2022-05-02T10:55:57ZrajeshsContribution page not showing GDPR*Created by: rubofvil*
- In CiviCRM 5.35 at least, there isn't showing the GDPR when you are in form of the contribution page.
- When you are in form `CRM_Contribute_Form_Contribution_Main` the method `isEnabled(TRUE)` not validating...*Created by: rubofvil*
- In CiviCRM 5.35 at least, there isn't showing the GDPR when you are in form of the contribution page.
- When you are in form `CRM_Contribute_Form_Contribution_Main` the method `isEnabled(TRUE)` not validating correctly.
- https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/blob/master/gdpr.php#L272
- The `$result = civicrm_api3($this->type, 'get', $params);` With entity type -> `ContributionPage` not return the custom_fields if the 'return' pararameter isn't set
- https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/blob/master/CRM/Gdpr/SLA/Entity.php#L150https://lab.civicrm.org/extensions/gdpr/-/issues/298Remove function gdpr_civicrm_tokens?2021-10-13T10:03:50ZrajeshsRemove function gdpr_civicrm_tokens?*Created by: magnolia61*
It seems there is some legacy code on tokens in gdpr.php
`function gdpr_civicrm_tokens(&$tokens)`
// Keeping this token only to sustain the old tokens otherwise,
This code conflicts with all kind of change...*Created by: magnolia61*
It seems there is some legacy code on tokens in gdpr.php
`function gdpr_civicrm_tokens(&$tokens)`
// Keeping this token only to sustain the old tokens otherwise,
This code conflicts with all kind of changes around tokens in 5.43
Any objections to remove `function gdpr_civicrm_tokens`?https://lab.civicrm.org/extensions/gdpr/-/issues/272No notification on thank you pages if selected a email channel but selected N...2021-04-02T22:48:45ZrajeshsNo notification on thank you pages if selected a email channel but selected NO for email preferences.*Created by: tapashdatta*
*Created by: tapashdatta*
https://lab.civicrm.org/extensions/gdpr/-/issues/279Submitting CommPreferences form without checksum creates activity records2021-04-09T16:15:59ZrajeshsSubmitting CommPreferences form without checksum creates activity records*Created by: alantgpl*
If a visitor were to strip away the checksum in the URL, eg. just visiting directly /civicrm/gdpr/comms-prefs/update, and then submitting the form, GDPR activity records are created with no contact reference.
C...*Created by: alantgpl*
If a visitor were to strip away the checksum in the URL, eg. just visiting directly /civicrm/gdpr/comms-prefs/update, and then submitting the form, GDPR activity records are created with no contact reference.
Can the lack of checksum, or an expired one, be blocked from creating records?