Extensions issueshttps://lab.civicrm.org/groups/extensions/-/issues2023-06-23T10:00:06Zhttps://lab.civicrm.org/extensions/finsburypark/-/issues/17Can't add dashlets on empty dashboard2023-06-23T10:00:06Zjan.ciriack@posteo.deCan't add dashlets on empty dashboardWhen I remove all dashlets from my dashboard the droppable areas seems to be gone and I can no longer add any dashlets to it. There is no javascript error in the browser console. Having a least one dashlet in each column works fine. It d...When I remove all dashlets from my dashboard the droppable areas seems to be gone and I can no longer add any dashlets to it. There is no javascript error in the browser console. Having a least one dashlet in each column works fine. It doesn't occur on the default Theme and Shoreditch.
I am on Drupal 9 and CiviCRM 5.62.0.https://lab.civicrm.org/extensions/prettyworkflowmessages/-/issues/9Fatal error on event signup2023-06-23T06:09:19ZKurund JalmiFatal error on event signupSorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
Message was not parse...Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
Message was not parsed due to invalid smarty syntax : Smarty error: [in evaluated template line 9]: syntax error: unrecognized tag: Margin: 0; padding: 0; (Smarty_Compiler.class.php, line 440)
Return to home page.
This might be related to fixes done in https://lab.civicrm.org/extensions/prettyworkflowmessages/-/issues/6
CiviCRM 5.61.3, PW 1.7, Mosaico 2.11.Kurund JalmiKurund Jalmihttps://lab.civicrm.org/extensions/prettyworkflowmessages/-/issues/6`{literal}{/literal} {literal}{/literal} {literal}{/literal} ` in received em...2023-06-23T06:09:04Zmasetto`{literal}{/literal} {literal}{/literal} {literal}{/literal} ` in received emailsI'm using Mosaico Template as Pretty Workflow Template (I installed [mosaicomsgtpl extension](https://lab.civicrm.org/extensions/mosaicomsgtpl).
All received messages have this writing in header: `{literal}{/literal} {literal}{/literal}...I'm using Mosaico Template as Pretty Workflow Template (I installed [mosaicomsgtpl extension](https://lab.civicrm.org/extensions/mosaicomsgtpl).
All received messages have this writing in header: `{literal}{/literal} {literal}{/literal} {literal}{/literal} `
![image](/uploads/63070ea5c11a3615c209c2e16644c5ed/image.png)
I have noticed that at row 246 of `prettyworkflowmessages.php` there are these row:
```
// add literal tags for style tag, this is to prevent smarty errors
// mosaico template adds style tag to the html content
$prettyHTML = str_replace('<style type="text/css">', '{literal}<style type="text/css">', $prettyHTML);
$prettyHTML = str_replace('</style>', '</style>{/literal}', $prettyHTML);
```
Why? `{literal}` remains in delivered email...https://lab.civicrm.org/extensions/gocardless/-/issues/136Unable to alter financial type of recurring contribution2023-06-22T14:42:36ZwmortadaUnable to alter financial type of recurring contributionIt is not possible to change the financial type of a recurring contribution without also changing the amount. In this scenario we only want to change the financial type in CiviCRM. We don't want to make any changes to the subscription in...It is not possible to change the financial type of a recurring contribution without also changing the amount. In this scenario we only want to change the financial type in CiviCRM. We don't want to make any changes to the subscription in GoCardless.
We are unable to do this because of the logic in `CRM_Core_Payment_GoCardless::changeSubscriptionAmount()`.
See: https://lab.civicrm.org/extensions/gocardless/-/blob/963b6a07b0461e21340c0088b3484dcf31ae8f3d/CRM/Core/Payment/GoCardless.php#L223-225
Steps to reproduce:
- Visit the recurring contribution tab of a contact record
- Click edit next to a recurring contribution
- Change the financial type of the recurring contribution only
- Click save
- You will see the following error: "The given amount is the same as the current amount. Refusing to update subscription without a change in amount."
I understand the logic of not touching the GoCardless subscription if the amount doesn't change. However, in this case we only want to change the CiviCRM record and not update anything in GoCardless. I think the logic should be changed to identify if the change only affects CiviCRM and in which case just update the CiviCRM record without making a change in GoCardless.wmortadawmortadahttps://lab.civicrm.org/extensions/dataprocessor/-/issues/125Assigning a value to a filter is broken in new version2023-06-22T12:46:53ZJonGoldAssigning a value to a filter is broken in new versionI've experienced several issues with filters. My Data Processor is attached. There are two custom fields in the field list but it should be fine to remove those.
This Data Processor has a filter that is pre-set in the configuration, w...I've experienced several issues with filters. My Data Processor is attached. There are two custom fields in the field list but it should be fine to remove those.
This Data Processor has a filter that is pre-set in the configuration, which seems to no longer work:
When I try to set the filter value, I get a fatal error (backtrace below). Removing and re-adding the filter allows me to access the filter once, but not again.
More importantly, the filter is ignored, for at least three reasons.
* `CRM_Dataprocessor_BAO_DataProcessor::dataProcessorToClass()` doesn't assign the `filterHandler` to the `$dataProcessorClass`. There's `$filterHandler->setDataProcessor($dataProcessorClass);` but that's not the same.
* `Civi\DataProcessor\Output\AbstractApi::runDataProcessor()` only processes exposed filters.
* Even after adding `$dataProcessorClass->addFilterHandler($filterHandler);` to `dataProcessorToClass()` it still is ignored - `if (isset($params[$filterSpec->alias])) {` evaluates to `FALSE` because the filter isn't in `$params`.
The workaround was to add a filter in "Data Sources".
```
Error: Call to a member function addWhere() on null in Civi\DataProcessor\FilterHandler\SimpleSqlFilter->setFilter() (line 36 of
/home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/dataprocessor/Civi/DataProcessor/FilterHandler/SimpleSqlFilter.php) #0
/home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/dataprocessor/Civi/DataProcessor/FilterHandler/AbstractFilterHandler.php(290):
Civi\DataProcessor\FilterHandler\SimpleSqlFilter->setFilter()
#1 /home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/dataprocessor/Civi/DataProcessor/FilterHandler/AbstractFilterHandler.php(138):
Civi\DataProcessor\FilterHandler\AbstractFilterHandler->applyFilterFromSubmittedFilterParams()
#2 /home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/dataprocessor/Civi/DataProcessor/FilterHandler/AbstractFilterHandler.php(127):
Civi\DataProcessor\FilterHandler\AbstractFilterHandler->setDefaultFilterValues()
#3 /home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/dataprocessor/CRM/Dataprocessor/Form/FilterValue.php(61):
Civi\DataProcessor\FilterHandler\AbstractFilterHandler->initialize()
#4 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Form.php(668): CRM_Dataprocessor_Form_FilterValue->preProcess()
#5 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/QuickForm/Action/Display.php(76): CRM_Core_Form->buildForm()
#6 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform()
#7 /home/jon/local/mysite/vendor/civicrm/civicrm-packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle()
#8 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle()
#9 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Utils/Wrapper.php(98): CRM_Core_Controller->run()
#10 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(292): CRM_Utils_Wrapper->run()
#11 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#12 /home/jon/local/mysite/vendor/civicrm/civicrm-core/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#13 /home/jon/local/mysite/web/modules/contrib/civicrm/src/Civicrm.php(88): CRM_Core_Invoke::invoke()
#14 /home/jon/local/mysite/web/modules/contrib/civicrm/src/Controller/CivicrmController.php(80): Drupal\civicrm\Civicrm->invoke()
#15 [internal function]: Drupal\civicrm\Controller\CivicrmController->main()
#16 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#17 /home/jon/local/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(580):
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#18 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext()
#19 /home/jon/local/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97):
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#20 /home/jon/local/mysite/vendor/symfony/http-kernel/HttpKernel.php(169):
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#21 /home/jon/local/mysite/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#22 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#23 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#24 /home/jon/local/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#25 /home/jon/local/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#26 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#27 /home/jon/local/mysite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#28 /home/jon/local/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#29 /home/jon/local/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(718): Stack\StackedHttpKernel->handle()
#30 /home/jon/local/mysite/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#31 {main}.
```https://lab.civicrm.org/extensions/fixoptiontranslations/-/issues/4Where do translations come from?2023-06-19T13:54:33Zthoni56Where do translations come from?The README states 'by attempting to translate them'.
- In which way is this translation done? Using the existing translations in the installation? So a recent set of translations should propagate to the options?
- Will a disable/enable ...The README states 'by attempting to translate them'.
- In which way is this translation done? Using the existing translations in the installation? So a recent set of translations should propagate to the options?
- Will a disable/enable of this extension trigger another "fix"?
I see translations that are in Transifex but are not used to "fix" option group names.https://lab.civicrm.org/extensions/cividiscount/-/issues/414.5 - need to remove ref to CRM/common/enableDisable.tpl2023-06-14T13:39:35Zbgm4.5 - need to remove ref to CRM/common/enableDisable.tpl*Created by: eileenmcnaughton*
for the 4.5 release the reference to above tpl needs removing - probably best done right before doing first 4.5 release to prevent having to branch prematurely
*Created by: eileenmcnaughton*
for the 4.5 release the reference to above tpl needs removing - probably best done right before doing first 4.5 release to prevent having to branch prematurely
https://lab.civicrm.org/extensions/cividiscount/-/issues/39Extend Event discount inclusion options2023-06-14T13:39:35ZbgmExtend Event discount inclusion options*Created by: eileenmcnaughton*
We have been looking at cividiscount for a customer who would like to be able to apply discounts to events without having to go back & configure every event they add with a discount.
My expectation was t...*Created by: eileenmcnaughton*
We have been looking at cividiscount for a customer who would like to be able to apply discounts to events without having to go back & configure every event they add with a discount.
My expectation was that if you configured a price set in the section "If you use price sets for your events, you also need to select any discountable price sets below." and did not select any event then that would mean that the discount would be applied to 'ALL events that have that price set item configured'. This doesn't appear to happen - is it a bug I can patch or is it a feature?
If the latter I guess I could potentially add an 'apply to all events' checkbox - or a select box for events types (we may do this as well any way). I think the event select select would need to grey out if an event type is selected - & vice versa
https://lab.civicrm.org/extensions/cividiscount/-/issues/38Multiple Criteria Matching For Discounts2023-06-14T13:39:35ZbgmMultiple Criteria Matching For Discounts*Created by: galileo81580*
I have a discount scenario where a "customer" is only eligible for the discount if they're purchasing two memberships (different programs in our organization). It's a $25/each or $35 for two situation.
It do...*Created by: galileo81580*
I have a discount scenario where a "customer" is only eligible for the discount if they're purchasing two memberships (different programs in our organization). It's a $25/each or $35 for two situation.
It doesn't look like there's any facility for checking discount eligibility based on "and" criteria instead of "or" criteria. I'd be interested in working on that, but I've never written for Civi before. Any estimation of how complex that would be?
https://lab.civicrm.org/extensions/cividiscount/-/issues/37Description changes don't migrate2023-06-14T13:39:34ZbgmDescription changes don't migrate*Created by: rmalerman*
Changing the description of a discount does not change the text in the message displayed.
We would like to have a discount that will be useful once per person with the description text "Want a discount? Use c...*Created by: rmalerman*
Changing the description of a discount does not change the text in the message displayed.
We would like to have a discount that will be useful once per person with the description text "Want a discount? Use code -insertcodehere- and you will get one!" or something like that. Changing the description code does not change the displayed text in the discount section of the contribution.
https://lab.civicrm.org/extensions/cividiscount/-/issues/35Event Discount applied to whole priceset instead of selected fields2023-06-14T13:39:34ZbgmEvent Discount applied to whole priceset instead of selected fields*Created by: randomseb*
When applying discount to price set for Event, the entire priceset is being discounted, instead of the selected fields
CiviCRM 4.4.3
CiviDiscount 2.5
*Created by: randomseb*
When applying discount to price set for Event, the entire priceset is being discounted, instead of the selected fields
CiviCRM 4.4.3
CiviDiscount 2.5
https://lab.civicrm.org/extensions/cividiscount/-/issues/32CiviDiscount doesn't work for events in 4.32023-06-14T13:39:34ZbgmCiviDiscount doesn't work for events in 4.3*Created by: sdragnev*
Not sure if this is a 4.3 issue or it's also broken in 4.4
Seems like the discount is completely dependent on the priceset ID of the event, however that priceset is not saved when creating a discount.
The "prices...*Created by: sdragnev*
Not sure if this is a 4.3 issue or it's also broken in 4.4
Seems like the discount is completely dependent on the priceset ID of the event, however that priceset is not saved when creating a discount.
The "priceset" field in the database is null yet the code only applies the discount if the price set ID is set.
See cividiscount.php:434:
```
if (CRM_Utils_Array::value($option['id'], $discount['pricesets'])) {
// apply discount
}
```
CiviDiscount either has to save the price set ID when creating the discount or that if statement has to change.
Of course the former will only work for new discounts and will break any current ones so it's not much of a solution.
I'll take a look at it today and report back.
https://lab.civicrm.org/extensions/cividiscount/-/issues/27Priceset problem with Civi 4.4.02023-06-14T13:39:34ZbgmPriceset problem with Civi 4.4.0*Created by: saparker*
I encountered a problem with CiviDiscount v2.2 with Civi 4.4.0.
In extensions/org.civicrm.module.cividiscount-2.1/CDM/Utils.php you need this patch if you want to run CiviDiscount v2.2, since the name has change...*Created by: saparker*
I encountered a problem with CiviDiscount v2.2 with Civi 4.4.0.
In extensions/org.civicrm.module.cividiscount-2.1/CDM/Utils.php you need this patch if you want to run CiviDiscount v2.2, since the name has changed:
- if (CRM_Core_DAO::getFieldValue('CRM_Price_DAO_Set', $priceSetId, 'is_quick_config')) {
- if (CRM_Core_DAO::getFieldValue('CRM_Price_DAO_PriceSet', $priceSetId, 'is_quick_config')) {
https://lab.civicrm.org/extensions/cividiscount/-/issues/24Ability to duplicate a discount code2023-06-14T13:39:34ZbgmAbility to duplicate a discount code*Created by: ghost*
Create a new discount with a newly generated code but the same settings.
This is useful if (event) discounts are usually based on the same multiple membership types. It would save on having to readd membership types...*Created by: ghost*
Create a new discount with a newly generated code but the same settings.
This is useful if (event) discounts are usually based on the same multiple membership types. It would save on having to readd membership types for each event discount.
I'll initiate a pull request that adds this.
https://lab.civicrm.org/extensions/cividiscount/-/issues/23CiviDiscount doesn't work for Membership Contribution pages2023-06-14T13:39:33ZbgmCiviDiscount doesn't work for Membership Contribution pages*Created by: mcgeehon*
Adding a discount code to a Membership does not seem to work when checking out. If you input the code on the contribution page the discounted price will be reflected. However, when you check out, the full price ...*Created by: mcgeehon*
Adding a discount code to a Membership does not seem to work when checking out. If you input the code on the contribution page the discounted price will be reflected. However, when you check out, the full price is shown even though it says the discount is included and subsequently you will always be charged the full price.
https://lab.civicrm.org/extensions/cividiscount/-/issues/13Link to paypal contains incorrectly formatted item amount2023-06-14T13:39:33ZbgmLink to paypal contains incorrectly formatted item amount*Created by: rowjamesrow*
Hi, have a site on Drupal 7.18, CiviCRM 4.2.7, and cloned the latest Cividiscount module from here, but when I apply a discount to an event I'm setting up, the link that gets sent to Paypal "contains an incorr...*Created by: rowjamesrow*
Hi, have a site on Drupal 7.18, CiviCRM 4.2.7, and cloned the latest Cividiscount module from here, but when I apply a discount to an event I'm setting up, the link that gets sent to Paypal "contains an incorrectly formatted item amount". I removed the discount and it works. Any idea why this might be occuring?
https://lab.civicrm.org/extensions/cividiscount/-/issues/12Bottom "Edit" button on View Discount page gives malformed URL2023-06-14T13:39:33ZbgmBottom "Edit" button on View Discount page gives malformed URL*Created by: patrickg2*
View a discount code at:
http://www.example.com/civicrm/cividiscount/discount/view?id=1&reset=1
Click on Edit button at top of page, and it works, with this URL:
http://www.example.com/civicrm/cividiscount/disco...*Created by: patrickg2*
View a discount code at:
http://www.example.com/civicrm/cividiscount/discount/view?id=1&reset=1
Click on Edit button at top of page, and it works, with this URL:
http://www.example.com/civicrm/cividiscount/discount/edit?reset=1&id=1
Click on Edit button at bottom of page, and it doesn't work, with this URL:
http://www.example.com/civicrm/contact/view/contribution?reset=1&id=1&cid=&action=update&context=
gives this error:
Sorry but we are not able to provide this at the moment.
cid (value: ) is not of the type Positive
Return to home page.
https://lab.civicrm.org/extensions/cividiscount/-/issues/11Monetary turns into percentage2023-06-14T13:39:33ZbgmMonetary turns into percentage*Created by: patrickg2*
This module is precisely what we need for an event we're doing (each teacher gets a discount code and that's how we track referrals).
I installed CiviDiscount on a fresh Drupal 7 + CiviCRM 4.1.6 this evening, an...*Created by: patrickg2*
This module is precisely what we need for an event we're doing (each teacher gets a discount code and that's how we track referrals).
I installed CiviDiscount on a fresh Drupal 7 + CiviCRM 4.1.6 this evening, and I installed CiviDiscount, and it mostly works. Bug: I put in Discount: 80, and Amount Type: Monetary, and when I go through registration I get 80% discount. I tried switching to Percentage to see if they got switched, but that gave 80% discount as well. I tried a different discount code, same results.
If there's a way to hack a fix of this in the next day or week, I'm willing to play. I have experience configuring web software, but not coding it (yet).
https://lab.civicrm.org/extensions/cividiscount/-/issues/10Make credit card not required for 100% discount2023-06-14T13:39:33ZbgmMake credit card not required for 100% discount*Created by: joshfttb*
Current setup works well with the Paypal Standard payment processor. However, processors that require credit card info on page (such as Stripe) cannot be submitted without CC info, even if the discount is 100%. ...*Created by: joshfttb*
Current setup works well with the Paypal Standard payment processor. However, processors that require credit card info on page (such as Stripe) cannot be submitted without CC info, even if the discount is 100%. Most people with 100% discounts will not want to enter their credit card information. These field should not be required (and possibly hidden) when the discount is 100%. Some possible approaches are described here: http://drupal.org/node/1140220
https://lab.civicrm.org/extensions/cividiscount/-/issues/4Amount type "Monetary" ignored2023-06-14T13:39:33ZGhost UserAmount type "Monetary" ignoredGot the latest CiviDiscount last night (Aug 8) and installed. I'm using CiviCRM 4.2beta4 on Drupal 7.
I have created an automatic discount, which is given to people who are registering for an event and who have an active membership.
The ...Got the latest CiviDiscount last night (Aug 8) and installed. I'm using CiviCRM 4.2beta4 on Drupal 7.
I have created an automatic discount, which is given to people who are registering for an event and who have an active membership.
The discount is displayed correctly in the listing, but when I register for an event, the discount is given as a percentage of the base amount, not as a dollar amount discount.
On line 809 of cividiscount.php
if ( $code['amount_type'] == 'M' ) {
should be
if ( $code['amount_type'] == '2' ) {