Extensions issueshttps://lab.civicrm.org/groups/extensions/-/issues2024-03-25T20:04:28Zhttps://lab.civicrm.org/extensions/stripe/-/issues/473Drupal 9 + WebForm: "Bad Request" after upgrading to CiviCRM 5.71.02024-03-25T20:04:28ZmasettoDrupal 9 + WebForm: "Bad Request" after upgrading to CiviCRM 5.71.0I don't know if this is a Stripe or Firewall issue, I write what happened to me.
I have a CiviCRM installation with Drupal 9.5.11 and WebForm 6.2.4. After upgrading to CiviCRM 5.71.0 (I had the same problem on v5.70.0), the webform conn...I don't know if this is a Stripe or Firewall issue, I write what happened to me.
I have a CiviCRM installation with Drupal 9.5.11 and WebForm 6.2.4. After upgrading to CiviCRM 5.71.0 (I had the same problem on v5.70.0), the webform connected with Stripe payment processor give me an error
![image](/uploads/fb6448037d868c3d01be677fec1b1d14/image.png)
I debugged and found that the error is generated in `Civi/Api4/Action/StripePaymentintent/ProcessPublic.php`:
```php
$event = \Civi::dispatcher()->dispatch('civi.stripe.authorize', $authorizeEvent);`
if ($event->isAuthorized() === FALSE) {
throw new \CRM_Core_Exception('Bad Request');
}
```
The API4 is `StripePaymentintent.ProcessPublic` and these are the parameters:
```
Array
(
[paymentMethodID] => pm_1OrhO7GYnf18AbeR11Ftobfo
[amount] => 4.00
[currency] => EUR
[paymentProcessorID] => 3
[description] => Donate Now
[extraData] =>
[csrfToken] => 1709820194.b23530a1ab275ce872a9271d.3454a517e3658a9bbf1e380ec4a9228d49d0c618efaa7fb13dbfc41e860f7445
[captcha] =>
[checkPermissions] => 1
)
```
My IP finished in `civicrm_firewall_ipaddress` table, event_type "InvalidCSRFEvent" and source "tampered hash".
Sorry if I wrote in the wrong place, but I don't know how to untangle myself to understand and fix it.https://lab.civicrm.org/extensions/pdfapi/-/issues/37Small typo in the name in the activity display for the e-mail2024-03-07T09:18:27ZGuillaumeSorelSmall typo in the name in the activity display for the e-mailAfter doing some tests with CiviRules and PDF API it appears that the name of the attached file in the activity doubles the file type name of the file with `.pdf.pdf`
![image](/uploads/4e588b987c8062727bc908a63767799e/image.png)
But th...After doing some tests with CiviRules and PDF API it appears that the name of the attached file in the activity doubles the file type name of the file with `.pdf.pdf`
![image](/uploads/4e588b987c8062727bc908a63767799e/image.png)
But the related file's name attached in the E-mail is correct
![image](/uploads/16df6e4589e50969224e0d0a9d543d26/image.png)
So it seems that there's a small typo only for the E-mail activity.
It might be somehow be controlled by this part of the code (555 -> 572) but no extra `pdf` value seems to be added.
```
/**
* Method to create email activity for contact with PDF as attachment
*
* @param int $contactId
* @param array $fileIds
* @param $case_id
*/
protected function createEmailActivity($contactId, $fileIds, $case_id=null) {
$activityTypeId = $this->getActivityTypeId('email');
if ($activityTypeId) {
// first create activity
$activityParams = [
'source_contact_id' => $contactId,
'activity_type_id' => $activityTypeId,
'activity_date_time' => date('YmdHis'),
'details' => $this->_htmlMessageEmail,
'subject' => $this->_emailSubject,
];
```https://lab.civicrm.org/extensions/pdfapi/-/issues/36Weight of the file generated2024-03-07T08:38:32ZGuillaumeSorelWeight of the file generatedI was doing some tests and noticed the weight of the attached file generated par the PDF API: 1.2 MB for a simple page with text and logo.
![image](/uploads/b11cebe9b106b975c9ee66c7319395bb/image.png)
Could it be possible - and how - t...I was doing some tests and noticed the weight of the attached file generated par the PDF API: 1.2 MB for a simple page with text and logo.
![image](/uploads/b11cebe9b106b975c9ee66c7319395bb/image.png)
Could it be possible - and how - to reduce the weight of this file?https://lab.civicrm.org/extensions/eventics/-/issues/14Provide a hook to modify the actual ICS file before it is created2024-03-06T19:46:33ZshaneonabikeProvide a hook to modify the actual ICS file before it is created## Overview
In some cases, clients want the ability to modify the Event ICS prior to it being sent out. This might be different elements of the Event dates, etc.
In my case, I have a client who needs to change the actual Event date dep...## Overview
In some cases, clients want the ability to modify the Event ICS prior to it being sent out. This might be different elements of the Event dates, etc.
In my case, I have a client who needs to change the actual Event date depending on what was selected by the user during registration.
## Solution
Develop a hook that will pre-modify the Event prior to creating the ICS.shaneonabikeshaneonabikehttps://lab.civicrm.org/extensions/documents/-/issues/34PHP 8.1 + CiviCRM: Compatibility and improvements (funded)2024-03-06T14:50:14Zjofranzfranz@systopia.dePHP 8.1 + CiviCRM: Compatibility and improvements (funded)Stiftung Bildung wants to fund some work to avoid problems with recent CiviCRM versions and PHP 8.1 (and higher). Below I summed up some code scans. Some of these results might be false positives. We agreed to not come up with pull reque...Stiftung Bildung wants to fund some work to avoid problems with recent CiviCRM versions and PHP 8.1 (and higher). Below I summed up some code scans. Some of these results might be false positives. We agreed to not come up with pull requests as we lack deeper knowledge of this extension. They will reach out to you via helpdesk@civicoop.org
## Removed core methods ([ref](https://github.com/systopia/legacycode?tab=readme-ov-file#find-out-if-your-extension-might-have-a-compatibility-problem))
```
/CRM/Documents/Form/Searchphp: CRM_Core_Form_Date::buildDateRange($this, 'document_date', 1, '_low', '_high', E::ts('From:'), FALSE);
/CRM/Documents/Upgrader/Basephp: CRM_Core_DAO::executeSql($query, $params);
```
## Some scans (might be some false positives)
```- PHP 8.1 (5)
+-------------------------------------------------------+---------+--------------------------------------------------------+
| File (Line:Column) | Type | Issue |
+-------------------------------------------------------+---------+--------------------------------------------------------+
| /CRM/Documents/Entity/Document.php (370:22) | removed | Function end() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Entity/Document.php (383:22) | removed | Function end() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Entity/DocumentRepository.php (273:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Form/CaseDocuments.php (28:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
| /CRM/Documents/Page/CaseDocuments.php (53:23) | removed | Function reset() is removed. |
| | | Consider replace with use with objects is deprecated() |
+-------------------------------------------------------+---------+--------------------------------------------------------+
```
## PhpStan scan
```
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/Document.php
------ --------------------------------------------------------------------------------------
84 Access to an undefined property CRM_Documents_DAO_Document::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentCase.php
------ --------------------------------------------------------------------------------------
59 Access to an undefined property CRM_Documents_DAO_DocumentCase::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentContact.php
------ --------------------------------------------------------------------------------------
59 Access to an undefined property CRM_Documents_DAO_DocumentContact::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentEntity.php
------ --------------------------------------------------------------------------------------
66 Access to an undefined property CRM_Documents_DAO_DocumentEntity::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/DAO/DocumentVersion.php
------ --------------------------------------------------------------------------------------
74 Access to an undefined property CRM_Documents_DAO_DocumentVersion::$__table.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Entity/Document.php
------ --------------------------------------------------------------------------------------
127 Function explode invoked with 1 parameter, 2-3 required.
153 Access to an undefined property CRM_Documents_Entity_Document::$case_ids.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
155 Access to an undefined property CRM_Documents_Entity_Document::$case_ids.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
155 Function explode invoked with 1 parameter, 2-3 required.
193 Cannot unset offset *NEVER* on int.
------ --------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------
Line CRM/Documents/Form/Document.php
------ -------------------------------------------------------------------------------------------------------------------------------------
101 Call to an undefined method CRM_Documents_Form_Document::getSubmitValue().
102 Call to deprecated method preProcess() of class CRM_Custom_Form_CustomData:
see https://github.com/civicrm/civicrm-core/pull/29241 for preferred approach - basically
1) at the tpl layer use CRM/common/customDataBlock.tpl
2) to make the fields available for postProcess
if ($this->isSubmitted()) {
$this->addCustomDataFieldsToForm('FinancialAccount');
}
3) pass getSubmittedValues() to CRM_Core_BAO_CustomField::postProcess($this->getSubmittedValues(), $this->_id, 'FinancialAccount');
to ensure any money or number fields are handled for localisation
204 Call to an undefined method CRM_Documents_Form_Document::exportValue().
205 Call to an undefined method CRM_Documents_Form_Document::exportValue().
206 Call to an undefined method CRM_Documents_Form_Document::exportValue().
271 Access to an undefined property CRM_Documents_Form_Document::$_elements.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------
Line CRM/Documents/Form/NewVersion.php
------ ---------------------------------------------------------------------------------------------------------------
58 Method CRM_Documents_Form_NewVersion::setDefaultValues() should return array but return statement is missing.
124 Call to an undefined method CRM_Documents_Form_NewVersion::exportValue().
153 Access to an undefined property CRM_Documents_Form_NewVersion::$_elements.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ ---------------------------------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Form/Search.php
------ --------------------------------------------------------------------------------------
51 Call to an undefined method CRM_Documents_Form_Search::getButtonName().
52 Call to an undefined method CRM_Documents_Form_Search::getButtonName().
69 Access to an undefined property CRM_Documents_Form_Search::$_queryParams.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
90 Call to an undefined method CRM_Documents_Form_Search::addElement().
98 Call to an undefined static method CRM_Core_Form_Date::buildDateRange().
156 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
159 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
159 Access to an undefined property CRM_Documents_Form_Search::$_queryParams.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
161 Access to an undefined property CRM_Documents_Form_Search::$_formValues.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Selector/Search.php
------ --------------------------------------------------------------------------------------
118 Call to deprecated method getGroupDetail() of class CRM_Core_BAO_CustomGroup:
Legacy function
142 Access to an undefined property CRM_Documents_Selector_Search::$where.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
146 Call to deprecated method value() of class CRM_Utils_Array.
283 Fetching deprecated class constant ROWCOUNT of class CRM_Utils_Pager.
607 Access to an undefined property CRM_Documents_Selector_Search::$_rangeCache.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------------------
Line CRM/Documents/Upgrader/Base.php
------ --------------------------------------------------------------------------------------
122 Call to an undefined static method CRM_Core_DAO::executeSql().
142 Access to an undefined property CRM_Documents_Upgrader_Base::$queue.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
170 Access to an undefined property CRM_Documents_Upgrader_Base::$queue.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
234 Call to deprecated method setItem() of class CRM_Core_BAO_Setting:
- refer docs https://docs.civicrm.org/dev/en/latest/framework/setting/
------ --------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line CRM/Documents/Utils/HookInvoker.php
------ ----------------------------------------------------------------------------
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
30 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
43 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
55 Access to deprecated static property $_nullObject of class CRM_Utils_Hook.
------ ----------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Entity/CaseDocuments.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------
37 Parameter $entity of method Civi\CaseArchive\Documents\Entity\CaseDocuments::__construct() has invalid type Civi\CaseArchive\Entity\CaseEntity.
48 Parameter $archiveFile of method Civi\CaseArchive\Documents\Entity\CaseDocuments::onPrepare() has invalid type Civi\CaseArchive\ArchiveFile.
56 Instantiated class Civi\CaseArchive\ArchiveFile\SubHtmlFile not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
58 Class Civi\CaseArchive\Documents\Entity\Document does not have a constructor and must be instantiated without any parameters.
------ -------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Entity/Document.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
27 Class Civi\CaseArchive\Documents\Entity\Document extends unknown class Civi\CaseArchive\Entity\AbstractEntity.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
44 Call to an undefined method Civi\CaseArchive\Documents\Entity\Document::getEntityId().
63 Parameter $archiveFile of method Civi\CaseArchive\Documents\Entity\Document::onPrepare() has invalid type Civi\CaseArchive\ArchiveFile.
64 Call to an undefined method Civi\CaseArchive\Documents\Entity\Document::getHtmlFile().
65 Access to an undefined property Civi\CaseArchive\Documents\Entity\Document::$htmlFile.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
66 Class Civi\CaseArchive\Documents\Section\DocumentSection does not have a constructor and must be instantiated without any parameters.
67 Access to an undefined property Civi\CaseArchive\Documents\Entity\Document::$customData.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
68 Class Civi\CaseArchive\Documents\Section\DocumentVersionsSection does not have a constructor and must be instantiated without any parameters.
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/EventListener.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
32 Parameter $event of method Civi\CaseArchive\Documents\EventListener::onPrepare() has invalid type Civi\CaseArchive\Event\PrepareArchiveEvent.
33 Class Civi\CaseArchive\Entity\CaseEntity not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/CaseDocumentSection.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
29 Class Civi\CaseArchive\Documents\Section\CaseDocumentSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
51 Parameter $entity of method Civi\CaseArchive\Documents\Section\CaseDocumentSection::__construct() has invalid type Civi\CaseArchive\Entity\AbstractEntity.
52 Civi\CaseArchive\Documents\Section\CaseDocumentSection::__construct() calls parent::__construct() but Civi\CaseArchive\Documents\Section\CaseDocumentSection does not extend any class.
82 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\CaseDocumentSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
83 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
88 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
89 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
99 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
99 Call to an undefined method Civi\CaseArchive\Documents\Section\CaseDocumentSection::fetchTemplate().
100 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
101 Access to an undefined property Civi\CaseArchive\Documents\Section\CaseDocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/DocumentSection.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
31 Class Civi\CaseArchive\Documents\Section\DocumentSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
69 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\DocumentSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
70 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
74 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
75 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
83 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
83 Call to an undefined method Civi\CaseArchive\Documents\Section\DocumentSection::fetchTemplate().
84 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
85 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
94 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -----------------------------------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
Line Civi/CaseArchive/Documents/Section/DocumentVersionsSection.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
30 Class Civi\CaseArchive\Documents\Section\DocumentVersionsSection extends unknown class Civi\CaseArchive\Section\AbstractSection.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
65 Parameter $archiveFile of method Civi\CaseArchive\Documents\Section\DocumentVersionsSection::onBuild() has invalid type Civi\CaseArchive\ArchiveFile.
66 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
71 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
72 Instantiated class Civi\CaseArchive\ArchiveFile\FileAttachment not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
87 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$content.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
87 Call to an undefined method Civi\CaseArchive\Documents\Section\DocumentVersionsSection::fetchTemplate().
88 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
89 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
98 Access to an undefined property Civi\CaseArchive\Documents\Section\DocumentVersionsSection::$entity.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------
Line documents.civix.php
------ ---------------------------------------------------------------------------
276 Call to deprecated method mungeCaseType() of class CRM_Case_XMLProcessor.
277 Call to deprecated method mungeCaseType() of class CRM_Case_XMLProcessor.
366 Call to deprecated method value() of class CRM_Utils_Array.
------ ---------------------------------------------------------------------------
------ --------------------------------------------
Line documents.php
------ --------------------------------------------
279 Call to deprecated function civicrm_api().
311 Call to deprecated function civicrm_api().
------ --------------------------------------------
```
___
SYSTOPIA reference: 23657https://lab.civicrm.org/extensions/sparkpost-symbiotic/-/issues/45.70 compatibility: mailing_id should be passed into EventQueue2024-03-05T19:19:19Zbgm5.70 compatibility: mailing_id should be passed into EventQueueIn the CiviCRM log, for transactional emails:
```
[warning] mailing_id should be passed into EventQueue create calls.
Temporary handling has set it for now Caller: ::sparkpost_civicrm_alterMailParams
```In the CiviCRM log, for transactional emails:
```
[warning] mailing_id should be passed into EventQueue create calls.
Temporary handling has set it for now Caller: ::sparkpost_civicrm_alterMailParams
```https://lab.civicrm.org/extensions/cdntaxreceipts/-/issues/145Demo tax receipt2024-03-07T13:33:06ZshaneonabikeDemo tax receipt## Description
Initially, when you install the CDN Tax Receipt you can generate a tax receipt and tweak it as you need. After you launch it officially, some people might want to tweak or modify the way that tax receipts are.
After maki...## Description
Initially, when you install the CDN Tax Receipt you can generate a tax receipt and tweak it as you need. After you launch it officially, some people might want to tweak or modify the way that tax receipts are.
After making modifications, there isn't a way (that I could find) to see a preview of the actual tax receipt. If you go to an existing contribution and view the tax receipt of a test contribution you can't really revert the tax receipt (from what I understand).
Or does it just work by issuing a test, and then afterwards deleting that transaction?
## Potential Solution
Provide a special button for admins or certain permissions to download a sample on any tax receipt that could even have "Sample" marked across it to prevent someone issuing a bunch of fakes.
Thanks again for the awesome extension!https://lab.civicrm.org/extensions/civisualize/-/issues/122Fails to register plugins in Smarty32024-03-05T10:36:49ZRichFails to register plugins in Smarty3> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $functi...> Fatal error: "Plugin 'crmSQL' not callable"SmartyException: "Plugin 'crmSQL' not callable"
This is because, as of 5.70.1 `CRM_Core_SmartyCompatibility::register_function` maps this call to
`parent::registerPlugin('function', $function, $function, $cacheable, $cache_attrs);`
note that it passes `$function` in twice. So it thinks `crmSQL` is the callable, which it isn't.
Relevant [chat](https://chat.civicrm.org/civicrm/pl/i77pr7o717g4ty3tqzry7ybbyo)https://lab.civicrm.org/extensions/gdpr/-/issues/342New Version2024-03-03T19:03:09ZrajeshsNew Version*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can fo...*Created by: tresero*
Since it appears that this extension is no longer maintained, I will probably setup a dev server and fork it to a new version/name etc.
In the meantime, I did some work, and have this working as well as I can for now. In other words, does everything I need. Templates with errors have been updated etc. I'm sure there is more work, but at least now it won't fatal error your server and in my testing (for my needs), it is working.
My main need was to have terms and conditions on events. It works.
Here is the entire patch.
[GDPR.patch](https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/files/14474231/GDPR.patch)
https://lab.civicrm.org/extensions/gdpr/-/issues/341Missing Template File TermsAndConditions.tpl Causes Fatal Error2024-02-14T20:21:31ZrajeshsMissing Template File TermsAndConditions.tpl Causes Fatal Error*Created by: tresero*
## Description:
When attempting to access or modify event settings within CiviCRM, a fatal error is triggered due to the system being unable to load a required template file for the GDPR extension. The specific fi...*Created by: tresero*
## Description:
When attempting to access or modify event settings within CiviCRM, a fatal error is triggered due to the system being unable to load a required template file for the GDPR extension. The specific file CRM/Gdpr/Form/ManageEvent/TermsAndConditions.tpl appears to be missing from the extension's directory, resulting in a SmartyException and preventing successful page loads.
## Steps to Reproduce:
Navigate to the WordPress admin dashboard.
Go to CiviCRM > Events > Manage Events.
Select an event and attempt to access its settings.
The error occurs at this point, with CiviCRM unable to proceed due to the missing template file.
Expected Behavior:
The expected behavior is for the event settings page to load without issues, allowing for the management of GDPR-related settings for events.
## Actual Behavior:
A fatal error occurs, with the following details captured in the logs:
```
Fatal Error Details = array:3 [
"message" => "Unable to load template 'file:CRM/Gdpr/Form/ManageEvent/TermsAndConditions.tpl' in 'file:CRM/Form/default.tpl'"
"code" => null
"exception" => SmartyException {#17487
...
]
```
## Environment:
CiviCRM Version: 5.70.0
GDPR Extension Version: 3.5
CMS: WordPress
PHP Version: [Specify version]
## Troubleshooting Steps Already Taken:
Verified the GDPR extension is correctly installed and up to date.
Checked the file system for the presence of TermsAndConditions.tpl in the expected directory (CRM/Gdpr/Form/ManageEvent/) and confirmed it is missing.
Cleared CiviCRM caches.
Checked file and directory permissions to rule out access issues.
## Suggested Fix:
It appears this issue may be due to the file either being accidentally omitted from the extension package or a reference to a deprecated or renamed file that hasn't been updated. A review and correction of the extension's file structure and references to TermsAndConditions.tpl would likely resolve this issue.https://lab.civicrm.org/extensions/gdpr/-/issues/335Incompatible with 5.61+?2023-10-25T08:13:58Zjofranzfranz@systopia.deIncompatible with 5.61+?```
âžœ uk.co.vedaconsulting.gdpr (master) check-extensions-for-removed-core-code.sh -d . âœ
./CRM/Gdpr/Form/Sear...```
âžœ uk.co.vedaconsulting.gdpr (master) check-extensions-for-removed-core-code.sh -d . âœ
./CRM/Gdpr/Form/Search/GroupcontactDetails.php:
CRM_Core_Form_Date::buildDateRange($form, 'subscription_date', 1, '_low', '_high', E::ts('From'), FALSE);
```
@eileenmcnaughton
Touches #330https://lab.civicrm.org/extensions/gdpr/-/issues/339CRM_Core_Smarty2024-02-28T14:52:18ZrajeshsCRM_Core_Smarty*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/s...*Created by: Rar9*
CiviCRM 5.69.1 with enabled if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')).... gives
PHP Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in /var/www/vhosts/xxx/sites/default/files/civicrm/ext/uk.co.vedaconsulting.gdpr/gdpr.civix.php on line 100
https://lab.civicrm.org/extensions/gdpr/-/issues/336Manage Event: cannot save "Info and Settings" when T&C are set on CiviCRM 5.662023-11-06T10:33:54ZrajeshsManage Event: cannot save "Info and Settings" when T&C are set on CiviCRM 5.66*Created by: mlutfy*
Can be reproduced on CiviCRM 5.66 (rc) or dmaster:
- Enable the GDPR extension
- Go to Manage Events, edit an event
- Go to the Terms & Conditions tab, set "Enable terms and Conditions Acceptance" = "no"
- Go ...*Created by: mlutfy*
Can be reproduced on CiviCRM 5.66 (rc) or dmaster:
- Enable the GDPR extension
- Go to Manage Events, edit an event
- Go to the Terms & Conditions tab, set "Enable terms and Conditions Acceptance" = "no"
- Go to the Info and Settings tab, click save.
You will get an error "Checkbox text is a required field." and "Link Label is a required field."https://lab.civicrm.org/extensions/gdpr/-/issues/334Error when saving gdpr preference form2023-08-15T16:03:18ZrajeshsError when saving gdpr preference form*Created by: tapashdatta*
Running civi latest, Gdpr 3.5
When saving the gdpr preference form https://example.com/civicrm/gdpr/comms-prefs/update getting this error
<img width="1214" alt="Screenshot 2023-08-15 at 21 29 55" src="https...*Created by: tapashdatta*
Running civi latest, Gdpr 3.5
When saving the gdpr preference form https://example.com/civicrm/gdpr/comms-prefs/update getting this error
<img width="1214" alt="Screenshot 2023-08-15 at 21 29 55" src="https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/assets/5366545/67039223-2a5c-4405-bb21-a728cac929ec">
https://lab.civicrm.org/extensions/gdpr/-/issues/330Core deprecation affecting this extension2023-08-21T21:08:38ZrajeshsCore deprecation affecting this extension*Created by: eileenmcnaughton*
We are deprecating a function this extension calls - https://github.com/civicrm/civicrm-core/pull/26829/files#diff-931e65674ed680adf93d7ba4727419ec32b5fd4636ac84109dd9621f89e20e0dR231
It's not actually...*Created by: eileenmcnaughton*
We are deprecating a function this extension calls - https://github.com/civicrm/civicrm-core/pull/26829/files#diff-931e65674ed680adf93d7ba4727419ec32b5fd4636ac84109dd9621f89e20e0dR231
It's not actually a function that is supported for use outside of core but since I discovered that GDPR DOES call it I have deprecated rather than remove it.
You can just copy the contents back to your code rather than calling core functions that are not intended to be used from outside of corehttps://lab.civicrm.org/extensions/gdpr/-/issues/324Error when enabling Terms and Conditions in an Event online registration page2024-01-22T10:19:52ZrajeshsError when enabling Terms and Conditions in an Event online registration page*Created by: calbasi*
I get an error when enabling Terms and Conditions in an Event online registration page.
CiviCRM 5.60-alpha1
Drupal 10
php 8.1
From drupal logs:
```
Localization: civicrm/event/register?id=8&reset=1
Re...*Created by: calbasi*
I get an error when enabling Terms and Conditions in an Event online registration page.
CiviCRM 5.60-alpha1
Drupal 10
php 8.1
From drupal logs:
```
Localization: civicrm/event/register?id=8&reset=1
Reference: civicrm/event/info?reset=1&id=8
TypeError: strlen(): Argument #1 ($string) must be of type string, array given in HTML_QuickForm_checkbox->toHtml() (line 138 of vendor/civicrm/civicrm-packages/HTML/QuickForm/checkbox.php).
Severity: Error
```
https://lab.civicrm.org/extensions/gdpr/-/issues/320Date format of "Terms & Conditions" acceptance date2023-01-11T16:03:23ZrajeshsDate format of "Terms & Conditions" acceptance date*Created by: palur76*
In `CRM/Gdpr/Form/UpdatePreference.php`, in line 135. is set, that the date format of the agree date of the "Terms & Conditions" is `d/m/Y`.
It would be nice to be able to set it by the admin - eg. to CiviCRM s...*Created by: palur76*
In `CRM/Gdpr/Form/UpdatePreference.php`, in line 135. is set, that the date format of the agree date of the "Terms & Conditions" is `d/m/Y`.
It would be nice to be able to set it by the admin - eg. to CiviCRM short / middle / long date, or with the PHP date setting methods.https://lab.civicrm.org/extensions/gdpr/-/issues/331Error 'Class "CRM_Gdpr_Utils" not found' has broken front-end CRM pages2023-07-17T11:38:42ZrajeshsError 'Class "CRM_Gdpr_Utils" not found' has broken front-end CRM pages*Created by: vingle*
Front-end contribution pages stopped working and show 'Class "CRM_Gdpr_Utils" not found'.
When I try to disable the extension in the backend I got the same error. When I disable it via the dbse then try to uninst...*Created by: vingle*
Front-end contribution pages stopped working and show 'Class "CRM_Gdpr_Utils" not found'.
When I try to disable the extension in the backend I got the same error. When I disable it via the dbse then try to uninstall, I get the same error. This was only fixed by deleting the gdpr extension dir and flushing the cache.
CiviCRM 5.59.4 & Joomla 4.3.3 (it had been working on Joomla 4).https://lab.civicrm.org/extensions/gdpr/-/issues/310Add "Terms & Condition" in a profile2022-07-15T12:29:43ZmasettoAdd "Terms & Condition" in a profileThe original question of @robbrandt was:
> Is it possible to add a GDPR Terms & Conditions checkbox to any profile?
@tapashdatta, the checkbox "Use as the mailing subscribe page" add Communication preferences but does not add Terms &...The original question of @robbrandt was:
> Is it possible to add a GDPR Terms & Conditions checkbox to any profile?
@tapashdatta, the checkbox "Use as the mailing subscribe page" add Communication preferences but does not add Terms & Conditions checkbox which is used instead in contribution and event pages.
How can I add "Terms & Condition" in a profile? (for example "Become a volunteer", signup form...)
_Originally posted by @masetto in https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr/issues/126#issuecomment-1138612663_https://lab.civicrm.org/extensions/gdpr/-/issues/321ln10/fr_FR2023-02-23T12:25:23ZUsha Matisson775-usha.makoa@users.noreply.lab.civicrm.orgln10/fr_FR@mattwire
Is it possible to add the gdpr.mo french localization file to this beautiful extension please? I've already translated in transifex but need to add it manually on each upgrade.
And to add a ts() on the navigation menus > ...@mattwire
Is it possible to add the gdpr.mo french localization file to this beautiful extension please? I've already translated in transifex but need to add it manually on each upgrade.
And to add a ts() on the navigation menus > Contacts > GDPR Dashboard and in Administer ?
thanks