Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-05-27T13:21:37Zhttps://lab.civicrm.org/dev/financial/-/issues/1On new contribution, when priceset chosen remove 'Alternatively, you can use ...2020-05-27T13:21:37ZJoeMurrayOn new contribution, when priceset chosen remove 'Alternatively, you can use a price set.'On backoffice new contribution screen, there is on screen help text under Total Amount field saying 'Alternatively, you can use a price set.' Clicking button to choose a price set incorrectly leaves the text there after the price set is ...On backoffice new contribution screen, there is on screen help text under Total Amount field saying 'Alternatively, you can use a price set.' Clicking button to choose a price set incorrectly leaves the text there after the price set is displayed. Clicking the Price Set field toggles to make it disappear even if the selection is 'Choose price set' which removes price set.
Fix to display this text when price set is not (yet) selected, and to hide it when a price set is selected.Monish DebMonish Deb2018-02-07https://lab.civicrm.org/dev/core/-/issues/2020Revert 20202022-10-11T14:54:01ZeileenRevert 2020Entirely. PleaseEntirely. Please2020-01-01https://lab.civicrm.org/dev/drupal/-/issues/115Let's make some D8 upgrade documentation2020-10-20T21:12:09ZStoobLet's make some D8 upgrade documentation[This single stack exchange](https://civicrm.stackexchange.com/questions/33945/how-can-i-update-civicrm-installed-with-drupal-8-using-composer) the best documentation yet I've found about upgrading Drupal 8 and it is varied and cluttered...[This single stack exchange](https://civicrm.stackexchange.com/questions/33945/how-can-i-update-civicrm-installed-with-drupal-8-using-composer) the best documentation yet I've found about upgrading Drupal 8 and it is varied and cluttered. With a security update of Civi planned for April, we need to provide a more consolidated way to provide upgrade instructions. I volunteer to help, but since I have not yet been successful upgrading my Composer-installed Civi on D8 (hosted by CiviHosting) myself I am not qualified to write it. I am currently looking for solutions and collaborators.2020-04-11https://lab.civicrm.org/dev/core/-/issues/1775civicrm_financial_trxn.fee_amount reversals mixed up2023-03-22T05:03:26ZJoeMurraycivicrm_financial_trxn.fee_amount reversals mixed upOverview
----------------------------------------
When doing reversal bookkeeping entry as part of changing a financial type, the fee_amount field does not have its sign reversed. This results in an incorrect net_amount field. See bug 1 ...Overview
----------------------------------------
When doing reversal bookkeeping entry as part of changing a financial type, the fee_amount field does not have its sign reversed. This results in an incorrect net_amount field. See bug 1 in https://gist.github.com/JoeMurray/6db6a82ff6c9e593ca5301b5f8708f52
Current behaviour
----------------------------------------
civicrm_financial_trxn.fee_amount has same value as original record in the reversal record. This results in net_amount not being a correct reversal of the original record's net_amount.
Expected behaviour
----------------------------------------
civicrm_financial_trxn.fee_amount has negative of value in original record in the reversal record. This results in net_amount being the negative in the reversal record of that field in the original record.
Comments
----------------------------------------
We should check for this issue wherever the code creates reversal transactions.
Make unit tests for all of the areas in the code where this occurs.seamusleeseamuslee2020-05-26https://lab.civicrm.org/dev/core/-/issues/1810Can't blank out help_pre2023-03-28T05:03:43ZJoeMurrayCan't blank out help_preOverview
----------------------------------------
_On multilingual site (eg dmaster with ca_FR enabled), it is not possible to blank out help_pre or help_post in the browser for a profile field._
I reported this years ago but never got ...Overview
----------------------------------------
_On multilingual site (eg dmaster with ca_FR enabled), it is not possible to blank out help_pre or help_post in the browser for a profile field._
I reported this years ago but never got around to fixing it.
Reproduction steps
----------------------------------------
1. Enable an additional language.
2. Go to a profile field, edit it, and add some help_pre and help_post text. Save.
3. Re-edit the field, delete the help_pre and help_post text. Save.
4. Re-edit the field, and observe that the help_pre and help_post text has not been deleted.
Current behaviour
----------------------------------------
_help_pre and help_post for profile fields on multilingual sites cannot be set to nothing._
Expected behaviour
----------------------------------------
_help_pre and help_post for profile fields on multilingual sites can be set to nothing._
Comments
----------------------------------------
_Works fine when multilingual not enabled._Monish DebMonish Deb2020-06-13https://lab.civicrm.org/dev/core/-/issues/3284APIv4 Query Improvements2022-04-22T15:53:45Zjoshjosh@civicrm.orgAPIv4 Query ImprovementsThis project will expand the query language of APIv4 to increase functionality. Implementing this will enhance the capabilities of APIv4-based Smart Groups; without this their utility will be limited to simple queries. This is also a pre...This project will expand the query language of APIv4 to increase functionality. Implementing this will enhance the capabilities of APIv4-based Smart Groups; without this their utility will be limited to simple queries. This is also a prerequisite to the Search Builder UI project.
Tasks:
- Implement Having, Group By parameters.
- Enable use of SQL Functions like SUM().
- Implement explicit joins.
- Implement a way to add subquery expressions to an API call.
Related pull-requests:
* [#16947 - Support GROUP BY and aggregate functions](https://github.com/civicrm/civicrm-core/pull/16947) (merged)
* [#17047 - Api4 Explorer: Support SQL functions and HAVING clause ](https://github.com/civicrm/civicrm-core/pull/17047) (merged)colemanwcolemanw2020-06-30https://lab.civicrm.org/dev/core/-/issues/3243Search Builder UI2022-04-22T15:52:31Zjoshjosh@civicrm.orgSearch Builder UIThis project will create a unified interface that replaces the current Advanced Search and Search Builder forms. This requires the APIv4 Query Improvements project to be done (or at least underway). This is a prerequisite to the Form-Bui...This project will create a unified interface that replaces the current Advanced Search and Search Builder forms. This requires the APIv4 Query Improvements project to be done (or at least underway). This is a prerequisite to the Form-Builder-based reports and custom searches projects.
The mockup for this interface is available at the bottom of https://lab.civicrm.org/dev/report/-/wikis/Search-Builder-Overhaul
Tasks:
- Selection of base table + joins
- Drag-n-drop nested and/or where clauses supporting all fields and operators
- Controls for grouping and sorting
- Display and paging of search results
- Configurable output columns with drag-n-droppable table headers
- Selection of actions to act upon output rows (e.g. “Add Tags”)
- Button to save query as APIv4-based smart group.colemanwcolemanw2020-06-30https://lab.civicrm.org/dev/core/-/issues/3242APIv4-Based Smart(er) Groups2022-04-22T15:52:29Zjoshjosh@civicrm.orgAPIv4-Based Smart(er) GroupsThis project will allow smart groups to be built from APIv4 criteria. The MVP would include a button in the API Explorer to save an api4 query as a smart group. This will also connect with the new Search Builder UI when that project is c...This project will allow smart groups to be built from APIv4 criteria. The MVP would include a button in the API Explorer to save an api4 query as a smart group. This will also connect with the new Search Builder UI when that project is complete.
Tasks:
- Allow swappable backend to smart groups
- Extend smart group schema to store api4 query parameters
- Add support for saving smart groups to API explorer UI.colemanwcolemanw2020-06-30https://lab.civicrm.org/dev/core/-/issues/3015Undefined Index2023-11-03T05:03:19ZJoeMurrayUndefined IndexOverview
----------------------------------------
_Update multiple participants caused undefined index error on dmaster._
Reproduction steps
----------------------------------------
1. Create custom alphanumeric field for participants,...Overview
----------------------------------------
_Update multiple participants caused undefined index error on dmaster._
Reproduction steps
----------------------------------------
1. Create custom alphanumeric field for participants, eg add Idea to Food Preference custom field set on dmaster.
1. Create profile with just this new field, eg test.
1. Find all participants, select a couple, then choose Update multiple participants search results action.
1. Select profile created above. Click continue.
1. See Notice: Undefined index: size in CRM_Event_Form_Task_Batch->buildQuickForm() (line 108 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Task/Batch.php).
1. Note that the Idea field has a column but there is no field provided to enter data.
Current behaviour
----------------------------------------
![2022-01-03_11-51-42](/uploads/3b007e3aa61eb2b3cc00bd3d10e36360/2022-01-03_11-51-42.png)
Expected behaviour
----------------------------------------
No error. Ability to enter / edit data in Idea field.
Environment information
----------------------------------------
dmaster on mac chrome.EdselopezEdselopez2022-01-05https://lab.civicrm.org/dev/core/-/issues/5115a11y errors2024-03-28T20:43:12ZJoeMurraya11y errorsRunning a very vanilla setup we get the following accessibility errors (D10.2.3 / Civi 5.70.2 site, Finsbury Park theme enabled and Backend theme set to Finsbury Park and Aah disabled/alternating with Finsbury Park theme disabled and Aah...Running a very vanilla setup we get the following accessibility errors (D10.2.3 / Civi 5.70.2 site, Finsbury Park theme enabled and Backend theme set to Finsbury Park and Aah disabled/alternating with Finsbury Park theme disabled and Aah enabled and Backend theme set to Aah, Frontend Theme to Automatic. Using WAVE Web Accessibility Evaluation Tool 3.2.5.3 in Chrome browser 123.0.6312.86 on macOS Sonoma 14.4.1).
CiviCRM Home Page Errors:
- [ ] Missing form label on the QuickSearch element (Finsbury Park, Aah)
`<input type="text" id="crm-qsearch-input" name="sort_name" placeholder=" Name/Email" accesskey="q" class="ui-autocomplete-input" autocomplete="off">`
- [ ] Missing form label on Find menu item... (Finsbury Park, Aah)
`<input type="text" id="crm-menubar-drilldown" placeholder="Find menu item...">`
- [ ] Empty link (Finsbury Park, Aah)
```
<a href="#" class="has-submenu" id="sm-17116551805997053-1" aria-haspopup="true" aria-controls="sm-17116551805997053-2" aria-expanded="false">
<form action="/civicrm/contact/search/advanced" name="search_block" method="post">
<div>
AccesskeyMissing form label
<input type="text" id="crm-qsearch-input" name="sort_name" placeholder=" Name/Email" accesskey="q" class="ui-autocomplete-input" autocomplete="off">
<input type="hidden" name="hidden_location" value="1">
<input type="hidden" name="hidden_custom" value="1">
<input type="hidden" name="qfKey" value="CRMContactControllerSearch1nrj4735k2cgk8kgcos44c4800cwc800o8gk00w8so0gko004s_8998">
<input type="hidden" name="_qf_Advanced_refresh" value="Search">
</div>
</form>
<span class="sub-arrow"></span>
</a>
```
- [ ] Empty link (Finsbury Park, Aah)
```
<a accesskey="m" href="#" class="has-submenu" id="sm-17116551805997053-3" aria-haspopup="true" aria-controls="sm-17116551805997053-4" aria-expanded="false">
<i class="crm-logo-sm"></i>
<span class="sub-arrow"></span>
</a>
```
- [ ] Empty link (Finsbury Park, Aah)
```
<a href="#" class="has-submenu" id="sm-17116551805997053-5" aria-haspopup="true" aria-controls="sm-17116551805997053-6" aria-expanded="false">
Missing form label
<input type="text" id="crm-menubar-drilldown" placeholder="Find menu item...">
<span class="sub-arrow"></span>
</a>
```
- [ ] Very low contrast (Aah)
```
<button class="trigger visually-hidden focusable" type="button" aria-pressed="false">
Open configuration options
</button>
```
- [ ] Very low contrast (Finsbury Park, Aah)
```
<label class="crm-menubar-toggle-btn" for="crm-menubar-state">
<span class="crm-menu-logo"></span>
<span class="crm-menubar-toggle-btn-icon"></span>
Toggle main menu
</label>
```
- [ ] Very low contrast (Finsbury Park, Aah)
```
<div id="drupal-live-announce" class="visually-hidden" aria-live="polite" aria-busy="false">
Tray opened.
</div>
```
Simple Search (Search > Find Contacts) Errors not present above:
- [ ] Missing form label
```
<select placeholder="- any group -" multiple="multiple" class="big big crm-select2 crm-form-multiselect" name="group[]" id="group" tabindex="-1" style="display: none;">
<option value="1">
My site group 1
</option>
<option value="2">
My site group 2
</option>
</select>
```
- [ ] Empty form label (see next task for Empty link that contains this)
`<label for="s2id_autogen2" class="select2-offscreen"></label>`
- [ ] Empty link
```
<a href="#" class="has-submenu" id="sm-17116579339791917-1" aria-haspopup="true" aria-controls="sm-17116579339791917-2" aria-expanded="false">
<form action="/civicrm/contact/search/advanced" name="search_block" method="post">
<div>
<input type="text" id="crm-qsearch-input" name="sort_name" placeholder=" Name/Email" accesskey="q" class="ui-autocomplete-input" autocomplete="off">
<input type="hidden" name="hidden_location" value="1">
<input type="hidden" name="hidden_custom" value="1">
<input type="hidden" name="qfKey" value="CRMContactControllerSearch1nrj4735k2cgk8kgcos44c4800cwc800o8gk00w8so0gko004s_4570">
<input type="hidden" name="_qf_Advanced_refresh" value="Search">
</div>
</form>
<span class="sub-arrow"></span>
</a>
```
- [ ] Empty link
```
<a accesskey="m" href="#" class="has-submenu" id="sm-17116579339791917-3" aria-haspopup="true" aria-controls="sm-17116579339791917-4" aria-expanded="false">
<i class="crm-logo-sm"></i>
<span class="sub-arrow"></span>
</a>
```
- [ ] Empty link
```
<a href="#" class="has-submenu" id="sm-17116579339791917-5" aria-haspopup="true" aria-controls="sm-17116579339791917-6" aria-expanded="false">
<input type="text" id="crm-menubar-drilldown" placeholder="Find menu item...">
<span class="sub-arrow"></span>
</a>
```
- [ ] Very low contrast
```
<span class="select2-chosen" id="select2-chosen-1">
- any contact type -
</span>
```
- [ ] Very low contrast
```
<button class="crm-form-submit default validate crm-button crm-button-type-refresh crm-button_qf_Basic_refresh" value="1" type="submit" name="_qf_Basic_refresh" id="_qf_Basic_refresh-bottom">
<i aria-hidden="true" class="crm-i fa-check"></i>
Search
</button>
```Monish DebMonish Deb2024-03-29https://lab.civicrm.org/dev/core/-/issues/5116Scheduled Reminders: with multi-lingual, the language filters are empty2024-03-28T21:51:08ZbgmScheduled Reminders: with multi-lingual, the language filters are emptyTo reproduce:
- Enable multi-lingual from Administer > Localization > Languages, the checkbox at the bottom of the screen
- Then go to Administer > Communications > Scheduled Reminders
- Add a new Reminder
Ignore everything, scroll dow...To reproduce:
- Enable multi-lingual from Administer > Localization > Languages, the checkbox at the bottom of the screen
- Then go to Administer > Communications > Scheduled Reminders
- Add a new Reminder
Ignore everything, scroll down to the "Recipients language", and notice that the list is empty:
![image](/uploads/1f83b3ccfd0c755f0609509c4172594a/image.png)
The regression was caused by: https://github.com/civicrm/civicrm-core/commit/de00a2b14f60a7f6fef59b5b3331c17fc1e3e061 - part of CiviCRM 5.66 (Symbiotic was on 5.65 and didn't see this until 5.70).
I don't know what's the best way of fixing it:
- The DAO correctly defines the callback for the `filter_contact_language` field
- QuickForm uses `addField()` to add the field using metadata
- `addField()` calls `ActionSchedule.getfields`, which fetches the metadata from the DAO
- `civicrm_api3_generic_getfields()` has code like this:
```
if (function_exists($helper)) {
// alter
$helper($metadata, $apiRequest);
}
```
which basically calls `_civicrm_api3_action_schedule_create_spec()`, and that then NULLs the callbacks, so the options are hidden in the UI.
@colemanw Any thoughts?
Bug found by @mmyriamcolemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/5114Managed domain-aware entities with multisite configuration2024-03-28T12:37:16ZJKingsnorthManaged domain-aware entities with multisite configurationWe've come across an edge-case in a multi-site setup.
In our setup, we have a master domain which does not have 'Enable Multi Site Configuration' enabled. And subdomains which do.
This is allowed configuration according to the docs: ht...We've come across an edge-case in a multi-site setup.
In our setup, we have a master domain which does not have 'Enable Multi Site Configuration' enabled. And subdomains which do.
This is allowed configuration according to the docs: https://docs.civicrm.org/installation/en/latest/multisite/drupal/#:~:text=It%20is%20not,or%20website%20administrators.
We also have a managed 'job' entity (provided by https://lab.civicrm.org/extensions/mjwshared/-/blob/master/managed/ProcessPaymentprocessorWebhooks.mgd.php?ref_type=heads)
The managed entity is set to 'always' update.
---
1) We run Managed->Reconcile on domain ID 1 (multisite not enabled)
- The job row is created
- An entry in civicrm_managed is created
```
# id, module, name, entity_type, entity_id, cleanup, entity_modified_date
'1796', 'mjwshared', 'ProcessPaymentProcessorWebhooks', 'Job', '116', 'always', NULL
```
- The job in civicrm_job is created
```
# id, domain_id, run_frequency, last_run, scheduled_run_date, name, description, api_entity, api_action, parameters, is_active
'116', '1', 'Always', NULL, NULL, 'Process PaymentProcessor Webhooks', 'Process incomplete payment processor webhooks', 'Job', 'process_paymentprocessor_webhooks', 'delete_old=-3 month', '1'
```
2) Managed->Reconcile run on domain ID 43 (multisite enabled)
- The entries in civicrm_managed are converted into 'domain-aware' entries:
```
# id, module, name, entity_type, entity_id, cleanup, entity_modified_date
'1803', 'mjwshared', 'ProcessPaymentProcessorWebhooks_32', 'Job', '116', 'always', NULL
'1804', 'mjwshared', 'ProcessPaymentProcessorWebhooks_42', 'Job', '116', 'always', NULL
'1805', 'mjwshared', 'ProcessPaymentProcessorWebhooks_43', 'Job', '116', 'always', NULL
```
- The job in civicrm_job is 'moved' to another domain:
```
# id, domain_id, run_frequency, last_run, scheduled_run_date, name, description, api_entity, api_action, parameters, is_active
'116', '43', 'Always', NULL, NULL, 'Process PaymentProcessor Webhooks', 'Process incomplete payment processor webhooks', 'Job', 'process_paymentprocessor_webhooks', 'delete_old=-3 month', '1'
```
3) Managed->Reconcile run on domain ID 1 again (not multisite enabled)
- The entry in civicrm_job has been deleted - no more essential scheduled job!
- The entry in civicrm_managed changes back to not domain aware, and references a deleted row
```
# id, module, name, entity_type, entity_id, cleanup, entity_modified_date
'1796', 'mjwshared', 'ProcessPaymentProcessorWebhooks', 'Job', '116', 'always', NULL
```
---
So we need to either:
- Update the docs to say that the 'master' domain _does_ need to be multisite aware
- Update the handling of domain-aware managed entities to work correctly when reconciled in either domainhttps://lab.civicrm.org/dev/core/-/issues/5113Change Start Date link broken on open case activity edit2024-03-28T00:59:58ZDaveDChange Start Date link broken on open case activity editThere's a warning Undefined array key "changeStartURL" and clicking the link just reloads the page.There's a warning Undefined array key "changeStartURL" and clicking the link just reloads the page.https://lab.civicrm.org/dev/core/-/issues/5112Blank custom fields accordion appears on Find XXX search forms2024-03-28T15:06:49ZDaveDBlank custom fields accordion appears on Find XXX search formse.g. Find Activities, Find Cases. An accordion appears, but there's nothing in it. I don't think it ever used to appear. Started maybe in 5.72?e.g. Find Activities, Find Cases. An accordion appears, but there's nothing in it. I don't think it ever used to appear. Started maybe in 5.72?5.72.0https://lab.civicrm.org/dev/core/-/issues/5111PHP8.1 Deprecated function: fseek():2024-03-26T21:44:23ZbobisHDPHP8.1 Deprecated function: fseek():Overview
----------------------------------------
On php8.1 the below error will appear:
```Deprecated function: fseek(): Passing null to parameter #2 ($offset) of type int is deprecated in FileReader->seekto() (line 125 of /opt/bitnam...Overview
----------------------------------------
On php8.1 the below error will appear:
```Deprecated function: fseek(): Passing null to parameter #2 ($offset) of type int is deprecated in FileReader->seekto() (line 125 of /opt/bitnami/apps/civicrm/htdocs/sites/all/modules/civicrm/packages/PHPgettext/streams.php)```
The code in this file that causes the error is:
```php
function seekto($pos) {
fseek($this->_fd, $pos);
$this->_pos = ftell($this->_fd);
return $this->_pos;
}
```
After changing this to
```php
function seekto($pos) {
fseek($this->_fd, $this->_pos);
$this->_pos = ftell($this->_fd);
return $this->_pos;
}
```
It seems to make the error go away.
If you have already posted on:
- https://civicrm.stackexchange.com
- https://chat.civicrm.org/civicrm/pl/yfx7e3un4f8nifxq1iknj5amjw
Environment information
----------------------------------------
* __Browser:__ Firefox
* __CiviCRM:__ 5.71.0
* __PHP:__ 8.1
* __CMS:__ Drupal 7.100
* __Database:__ MariaDB 10.6.16
* __Web Server:__ Apache/2.4.52https://lab.civicrm.org/dev/core/-/issues/5110afform: Display option "Remember Filters" not keeping value2024-03-25T15:01:10Zjensschuppeafform: Display option "Remember Filters" not keeping value## Overview
The display option "Remember Filters" in search displays does not retain its value when the configuration form is being reloaded.
## Reproduction steps
1. Create a _SearchKit_ search with a search form
2. Add a form displa...## Overview
The display option "Remember Filters" in search displays does not retain its value when the configuration form is being reloaded.
## Reproduction steps
1. Create a _SearchKit_ search with a search form
2. Add a form display (e.g. _Table_)
3. add some exposed filters
4. Check _Remember Filters_
5. Reload the configuration form for that form display
## Current behaviour
The option seems to be stored and filter values are being stored per user. The option field (checkbox) however is not set when reloading the config form of the form display. Saving the config form without changing that option still seems to retain its value (still storing filter values). So the config form does not reflect the actual option value.
## Expected behaviour
The option should be set when re-visiting the form display config form. Saving the form should respect the value (unchecked: unset the option).
## Environment information
* **Browser:** _Chromium 123.0.6312.58_
* **CiviCRM:** _5.71.0_https://lab.civicrm.org/dev/core/-/issues/5109Smarty 3 causes crash if exception thrown, e.g. by crmAPI2024-03-22T15:10:45ZRichSmarty 3 causes crash if exception thrown, e.g. by crmAPIOverview
----------------------------------------
I think this is a general problem that could occur if a smarty function throws an exception. The page crashes with:
> undefined extension class 'Smarty_Internal_Method_Trigger_Error'
[...Overview
----------------------------------------
I think this is a general problem that could occur if a smarty function throws an exception. The page crashes with:
> undefined extension class 'Smarty_Internal_Method_Trigger_Error'
[chat mention](https://chat.civicrm.org/civicrm/pl/gnqn1rihnprc7er1fcssqd1j6r)
Reproduction steps
----------------------------------------
I edited EventInfo.tpl to put this in:
```
{crmAPI var='local_date_time' entity='Event' action='getvalue' return="custom_115" id=$event.id}
```
Note that I had a custom_115 field defined for all events, but this event did not have a value for that field.
Visit the page that uses that template.
Crash.
Environment information
----------------------------------------
* __CiviCRM:__ 5.70 - 5.71.1
* __PHP:__ 8.1
* __CMS:__ D7
Comments
----------------------------------------
I'm not sure, but from memory api3 getvalue has changed; it now gives an *error* saying:
> "error_message": "field custom_115 unset or not existing"
I'm sure before it just used to return nothing.
Or it could be that before Smarty 3, it was happy to treat nothing as '' and now it's more picky.
I think the main problem seems to be that the exception/error handling is broken in Smarty3. Obviously if there's a bug in the template, it's going not to work, but it oughtn't crash the whole page.
The code that throws the error that causes the crash is CRM/Core/Smarty/plugins/function.crmAPI.php L35:
$smarty->trigger_error('{crmAPI} ' . $e->getMessage());https://lab.civicrm.org/dev/core/-/issues/5108Inconsistent handling of tag name and tag label2024-03-23T14:15:54ZDetlev SieberInconsistent handling of tag name and tag label## Overview
When you change a tag in the tag tree, only the label is changed, the name remains the old entry. So after changing and reloading, in the tag tree the old entry is still shown - despite the previous change.
In the contact s...## Overview
When you change a tag in the tag tree, only the label is changed, the name remains the old entry. So after changing and reloading, in the tag tree the old entry is still shown - despite the previous change.
In the contact summary, the change is not reflected: Because there, the tag name is used, not the tag label. Which also seems, hmm..., interesting...
## Reproduction steps
1. Tag a contact with a specific tag from the tag tree
2. Click on **Contacts -\> Manage Tags**
3. Rename the previously selected tag
4. Reload the tag list -\> again, the old label/name is shown
5. Reload the contact from step 1.: -\> again, the old label/name is shown
## Current behaviour
Renaming the tag in the tag tree only changes the field civicrm_tag.label, not the field civicrm\_tag.name.
This "might" be what we want - however, on several occasions, the tag name is used instead of the tag name.
## Expected behaviour
I would recommend, that both name and label should be changed.
## Environment information
* **CiviCRM:** 5.69.5https://lab.civicrm.org/dev/core/-/issues/5107Premiums configuration gives a 500 error2024-03-28T20:00:10ZJonGoldPremiums configuration gives a 500 errorOverview
----------------------------------------
In "Manage Contribution Pages", clicking on the "Premiums" page gives a 500 error. This happens in 5.71 and master, not in 5.70.
Reproduction steps
-------------------------------------...Overview
----------------------------------------
In "Manage Contribution Pages", clicking on the "Premiums" page gives a 500 error. This happens in 5.71 and master, not in 5.70.
Reproduction steps
----------------------------------------
See above.
Comments
----------------------------------------
This seems Smarty-related. I tried a `git bisect` but there's a different issue that breaks this page that makes that difficult. However, below is the error and backtrace I get when I set XDebug to pause on error:
```
"Type of SmartyCompilerException:: must be int (as in class Exception)"
include (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smartycompilerexception.php:8)
Composer\Autoload\{closure:/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/composer/ClassLoader.php:575-577} (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/composer/ClassLoader.php:576)
Composer\Autoload\ClassLoader->loadClass (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/composer/ClassLoader.php:427)
Smarty_Internal_TemplateCompilerBase->trigger_template_error (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:1153)
Smarty_Internal_CompileBase->closeTag (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_compilebase.php:196)
Smarty_Internal_Compile_Private_Block_Plugin->compile (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_compile_private_block_plugin.php:77)
Smarty_Internal_TemplateCompilerBase->callTagCompiler (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:768)
Smarty_Internal_TemplateCompilerBase->compileTag2 (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:1722)
Smarty_Internal_TemplateCompilerBase->compileTag (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:565)
Smarty_Internal_Templateparser->yy_r45 (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templateparser.php:2559)
Smarty_Internal_Templateparser->yy_reduce (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templateparser.php:3481)
Smarty_Internal_Templateparser->doParse (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templateparser.php:3573)
Smarty_Internal_SmartyTemplateCompiler->doCompile (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_smartytemplatecompiler.php:128)
Smarty_Internal_TemplateCompilerBase->compileTemplateSource (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:481)
Smarty_Internal_TemplateCompilerBase->compileTemplate (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php:402)
Smarty_Template_Compiled->compileTemplateSource (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php:184)
Smarty_Template_Compiled->process (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php:141)
Smarty_Template_Compiled->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php:105)
Smarty_Internal_Template->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:216)
Smarty_Internal_Template->_subTemplateRender (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:385)
content_65fa056d841377_41904664 (/home/jon/local/civicrm-buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/3f/b3/c1/3fb3c10824e8bcce0275790f5b54d852eeb8a4d7_0.file.default.tpl.php:53)
Smarty_Template_Resource_Base->getRenderedTemplateCode (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php:123)
Smarty_Template_Compiled->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php:114)
Smarty_Internal_Template->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:216)
Smarty_Internal_Template->_subTemplateRender (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:385)
content_65fc658f02ae61_03133634 (/home/jon/local/civicrm-buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/7e/52/3d/7e523d898add0d1ddbfb9d731ea772b38ca3b855_0.file.snippet.tpl.php:73)
Smarty_Template_Resource_Base->getRenderedTemplateCode (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php:123)
Smarty_Template_Compiled->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php:114)
Smarty_Internal_Template->render (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:216)
Smarty_Internal_TemplateBase->_execute (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php:232)
Smarty_Internal_TemplateBase->fetch (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php:116)
CRM_Core_QuickForm_Action_Display->renderForm (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php:117)
CRM_Core_QuickForm_Action_Display->perform (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php:83)
HTML_QuickForm_Controller->handle (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php:203)
HTML_QuickForm_Page->handle (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php:103)
CRM_Core_Controller->run (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Controller.php:355)
CRM_Utils_Wrapper->run (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Wrapper.php:98)
CRM_Core_Invoke::runItem (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:298)
CRM_Core_Invoke::_invoke (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:69)
CRM_Core_Invoke::invoke (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:36)
civicrm_invoke (/home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/drupal/civicrm.module:471)
menu_execute_active_handler (/home/jon/local/civicrm-buildkit/build/dmaster/web/includes/menu.inc:527)
{main} (/home/jon/local/civicrm-buildkit/build/dmaster/web/index.php:21)https://lab.civicrm.org/dev/core/-/issues/5106Admin UI extension breaks contact summary if CiviMember extension is disabled2024-03-27T15:25:42ZKurund JalmiAdmin UI extension breaks contact summary if CiviMember extension is disabledContact summary results in fatal error if Admin UI extension is enabled and CiviMember extension is disabled.
```bash
Civi\API\Exception\NotImplementedException: API (Membership, get) does not exist (or the extension it belongs to is no...Contact summary results in fatal error if Admin UI extension is enabled and CiviMember extension is disabled.
```bash
Civi\API\Exception\NotImplementedException: API (Membership, get) does not exist (or the extension it belongs to is not enabled). in Civi\API\Request::create() (line 51 of /var/www/html/sites/all/modules/civicrm/Civi/API/Request.php).
```