Development issueshttps://lab.civicrm.org/groups/dev/-/issues2018-08-28T11:40:25Zhttps://lab.civicrm.org/dev/core/-/issues/342Activity Search does not show any results because the default option "With" i...2018-08-28T11:40:25Zjustinfreeman (Agileware)Activity Search does not show any results because the default option "With" is included in the search criteria despite no "Name or Email" being definedActivity Search does not show any results because the default option "With" is included in the search criteria despite no "Name or Email" being defined.
Applies to CiviCRM 5.4.0.
**Steps to reproduce**
1. Go to Find Activities
2. Selec...Activity Search does not show any results because the default option "With" is included in the search criteria despite no "Name or Email" being defined.
Applies to CiviCRM 5.4.0.
**Steps to reproduce**
1. Go to Find Activities
2. Select an Activity Type for which Activities exist
3. Click Search
4. No Activities are shown in the search results.
5. Scroll down and view the search criteria, you can see that "Activity targeted to ...AND..." has been added to the criteria
6. Click the X next to the "With" criteria
7. Click Search
8. Activities ARE shown in the search results.
**Fix required**
The "With" criteria should be unselected by default.
![Find_Activities_Default](/uploads/8432837978fe0b88a0ced521ca7ddc00/Find_Activities_Default.png)
Our reference SUP-5948https://lab.civicrm.org/dev/core/-/issues/350SMS immediate send not working in 5.4.02018-08-28T11:48:01ZAndy ClarkSMS immediate send not working in 5.4.0In 5.4.0 (Drupal) users couldn't send immediate SMS messages (using Twilio), with a message something like "recipients phone number invalid or they do not want to receive SMS delivery" BUT they could still send SMSs via batch. Similar pr...In 5.4.0 (Drupal) users couldn't send immediate SMS messages (using Twilio), with a message something like "recipients phone number invalid or they do not want to receive SMS delivery" BUT they could still send SMSs via batch. Similar problem was raised on Stackexchange at https://civicrm.stackexchange.com/questions/25478/clickatell-sms-recipient-phone-number-is-invalid-or-recipient-does-not-want-to but seems to be discussed as a Clickatell problem - but we're using Twilio. Problem is at line 1829 of activity.php where $doNotSms = TRUE; Changing this to $doNotSms = NULL; does temporarily fix the problem but ignores user preferences (I think). From discussions at https://github.com/veda-consulting/org.civicrm.sms.clickatell/issues/20 it also affects 5.3.0 and 5.3.15.5.0https://lab.civicrm.org/dev/core/-/issues/299Decimal point error.2018-08-28T21:41:11ZmarcineqDecimal point error.When I try to register a payment for contribute "pending", automatically in the "amount" field instead of the set decimal point "," "." Appears.
The problem hinders the work, because I have to manually correct it with "," although it app...When I try to register a payment for contribute "pending", automatically in the "amount" field instead of the set decimal point "," "." Appears.
The problem hinders the work, because I have to manually correct it with "," although it appears correctly next to it.
The error also appears when I want to edit the "completed" payment - by changing the payment method - the problem with writing, because the wrong separator.
I tried to change to "." but then it does not pass "," written from habit in Poland.
I noticed the error on Drupal 7.59, CiviCRM 5.3.1 on two independent versions.
I also played it right after installing "fresh" and changing the decimal separator in the location settings.
Please forgive me for passing with Polish translation, but my English is not very good, I prefer to use CiviCRM in my language.
![1](/uploads/2b98e3a599901c060afac3eaf17203fa/1.png)
![2](/uploads/da7181c616936e0bc1bd34f278b548ed/2.png)
Second issue with decimal pointer.
![b2_1](/uploads/c0e6a8688af063e5b14b8c520d639682/b2_1.png)
![b2_2](/uploads/cbb75f1a1ca00fa9f4aedbf2da9c4721/b2_2.png)
![b2_3](/uploads/d15d726313e38e75097ebed1f902a04c/b2_3.png)
![b2_4](/uploads/06257bd92c0577065ffcf01bdf0b78d6/b2_4.png)5.6https://lab.civicrm.org/dev/core/-/issues/351ERROR: LoadForm Pop-up w/out Params in URL2018-08-28T21:41:11Zlee.goodingERROR: LoadForm Pop-up w/out Params in URLWhen the loadForm function is used to open a form in a pop-up it will throw an error if NO parameters are included in the URL. If I include a dummy parameter (such as dummy=1) then it will not give me the error.
The function should not...When the loadForm function is used to open a form in a pop-up it will throw an error if NO parameters are included in the URL. If I include a dummy parameter (such as dummy=1) then it will not give me the error.
The function should not require parameters in the URL.
Here is my full error:
`Uncaught TypeError: Cannot read property 'split' of undefined at $.(anonymous function).(anonymous function).isOriginalUrl (http://dev.civicrmdev/sites/all/modules/civicrm/js/crm.ajax.js?pd7a7l:167:34) at $.(anonymous function).(anonymous function).isOriginalUrl (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:144:25) at HTMLDivElement.<anonymous> (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:256:40) at Function.each (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:370:19) at jQuery.fn.init.each (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:137:17) at jQuery.fn.init.$.fn.(anonymous function) [as crmSnippet] (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:236:10) at HTMLDivElement.<anonymous> (http://dev.civicrmdev/sites/all/modules/civicrm/js/crm.ajax.js?pd7a7l:441:34) at HTMLDivElement.dispatch (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:5226:27) at HTMLDivElement.elemData.handle (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:4878:28) at Object.trigger (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:5130:12) isOriginalUrl @ crm.ajax.js?pd7a7l:167 (anonymous) @ jquery-ui.js?pd7a7l:144 (anonymous) @ jquery-ui.js?pd7a7l:256 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 $.fn.(anonymous function) @ jquery-ui.js?pd7a7l:236 (anonymous) @ crm.ajax.js?pd7a7l:441 dispatch @ jquery.js?pd7a7l:5226 elemData.handle @ jquery.js?pd7a7l:4878 trigger @ jquery.js?pd7a7l:5130 (anonymous) @ jquery.js?pd7a7l:5860 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 trigger @ jquery.js?pd7a7l:5859 (anonymous) @ crm.ajax.js?pd7a7l:262 fire @ jquery.js?pd7a7l:3232 fireWith @ jquery.js?pd7a7l:3362 done @ jquery.js?pd7a7l:9840 callback @ jquery.js?pd7a7l:10311 XMLHttpRequest.send (async) send @ jquery.js?pd7a7l:10254 ajax @ jquery.js?pd7a7l:9738 jQuery.(anonymous function) @ jquery.js?pd7a7l:9890 getJSON @ jquery.js?pd7a7l:9871 refresh @ crm.ajax.js?pd7a7l:242 (anonymous) @ jquery-ui.js?pd7a7l:144 (anonymous) @ jquery-ui.js?pd7a7l:256 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 $.fn.(anonymous function) @ jquery-ui.js?pd7a7l:236 CRM.loadPage @ crm.ajax.js?pd7a7l:330 CRM.loadForm @ crm.ajax.js?pd7a7l:355 (anonymous) @ sgt_sgDcGroupManage.js?r=RMsXR:66 dispatch @ jquery.js?pd7a7l:5226 elemData.handle @ jquery.js?pd7a7l:4878`5.6https://lab.civicrm.org/dev/core/-/issues/352Ensure that when adding recipients of previous mailings that contacts who are...2018-08-28T21:41:11ZseamusleeEnsure that when adding recipients of previous mailings that contacts who are being excluded are removedAt present in the mailing code base when adding in recipients or a previous mailing there is no checking to ensure that contacts that are to be excluded are properly excludedAt present in the mailing code base when adding in recipients or a previous mailing there is no checking to ensure that contacts that are to be excluded are properly excluded5.6seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/325Fatal error 'DB Error: no such field' on Contribution detail report2018-08-28T21:55:40ZPradeep Nayakpradpnayak@gmail.comFatal error 'DB Error: no such field' on Contribution detail report![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/12660![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/126605.6https://lab.civicrm.org/dev/core/-/issues/367Fatal error / SQL timeout in A-Z pager for advanced search by relationship wi...2018-08-29T14:26:22ZAllenShawFatal error / SQL timeout in A-Z pager for advanced search by relationship with target group for reciprocal relationship typesPull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site h...Pull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site has, the more likely it happens (and not just spouse; this applies for "partner of" and any other reciprocally named relationship type).
**Steps to reproduce:**
1. Start with a site having:
1. Several thousand active relationships of a reciprocal type (where the name for both related positions is the same – e.g., "spouse of" <=> "spouse of"; "sibling of" <=> "sibling of"; "partner of" <=> "partner of"). This recipe uses "Spouse of".
1. At least one group (smart group or static group).
1. Perform an Advanced Search with these criteria:
1. Relationships > Relationship Type: "Spouse of"
1. Relationships > Target Contact(s) in Group: [any one or more groups]
1. Submit the search form and observe a very long page load; depending on the number of relationships, server configuration, and server resources, this search may end in a WSOD, or take dozens of minutes to complete.
**Analysis:**
* When this actually times out, you get a fatal error from MySQL: "Query execution was interrupted (max_statement_time exceeded)"
* Backtrace indicates that the long-running query is the one used to generate the A-Z pager controls in search results; this query includes as join to a temporary table which is created without indices.
**Proposed solution:**
Add indices and column definitions to the temporary table, so that the join can use the indices and run in a timely manner.5.6https://lab.civicrm.org/dev/core/-/issues/344Tell a Friend mail does not include event title2018-08-30T09:19:36ZchriscantTell a Friend mail does not include event titleWhen using the Tell-a-Friend by mail option I found that the event title wasn't appearing in the mail subject.
This is configured in the System Workflow Message "Tell-a-Friend Email" as follows:
`{ts 1=$senderContactName 2=$title}%1 wa...When using the Tell-a-Friend by mail option I found that the event title wasn't appearing in the mail subject.
This is configured in the System Workflow Message "Tell-a-Friend Email" as follows:
`{ts 1=$senderContactName 2=$title}%1 wants you to know about %2{/ts}`
I eventually found that the title was not set up in CRM_Friend_Form /CRM/Friend/Form.php.
Adding this line after line 97 should fix this:
`$this->_title = CRM_Core_DAO::getFieldValue('CRM_Event_DAO_Event', $this->_entityId, 'title');`
I have added this code in my live version 5.4.0 code in the equivalent place ie after line 91 and it works in a WordPress site.
I'll submit a PR with this change.5.6https://lab.civicrm.org/dev/core/-/issues/343Long lines in contact name or address overflow mailing labels2018-08-30T12:07:06ZAndrew ThompsonLong lines in contact name or address overflow mailing labelsIf very long lines (long enough to wrap to next line) are present in the address or addressee, PDF mailing labels will overflow the right boundary of the label. This is due to the code not subtracting the left & right padding from the wi...If very long lines (long enough to wrap to next line) are present in the address or addressee, PDF mailing labels will overflow the right boundary of the label. This is due to the code not subtracting the left & right padding from the width.
PR coming soon.
Steps to reproduce:
1. Create a contact with a name and/or street address long enough to wrap to a new line
2. Create mailing labels. I used Avery L7163.
3. Compare to official Avery template, e.g. https://www.averyproducts.com.au/word-template-l7163. The right side of the label will overflow the label.https://lab.civicrm.org/dev/core/-/issues/368Scheduled Reminder edit form does not populate date criteria correctly when e...2018-09-03T00:42:54ZandrewcormickdockeryScheduled Reminder edit form does not populate date criteria correctly when editing old remindersWhen editing an old scheduled reminder as shown here (note, to be sent 30 days before membership end date):
![image](/uploads/186749b711bc60889055e8a84994584e/image.png)
the edit form populates incorrectly as shown:
![image](/uploads/24...When editing an old scheduled reminder as shown here (note, to be sent 30 days before membership end date):
![image](/uploads/186749b711bc60889055e8a84994584e/image.png)
the edit form populates incorrectly as shown:
![image](/uploads/24c30ad7f8b8004032b8de5f06aded6a/image.png)
This has caused our users to inadvertently render their reminder ineffective when editing unrelated items on the reminder (for example, the email text).
The log tables show what's happened here (extract from log_civicrm_action_schedule):
![image](/uploads/ae7d5c9d851d81bd7626317c87d1e908/image.png)
Apparently at some point, the coding for membership end date changed from "membership_end_date" to "end_date" but there was no accompanying database update performed to retrospectively change legacy reminders.
I should note that the reminders are actually still sent, but this bug with the edit form has caused grief for some users.5.5.0https://lab.civicrm.org/dev/core/-/issues/353As of 5.4.0, Activity Search gives an empty result set2018-09-03T01:56:12ZPradeep Nayakpradpnayak@gmail.comAs of 5.4.0, Activity Search gives an empty result setFrom SE: https://civicrm.stackexchange.com/questions/26208/as-of-5-4-0-activity-search-gives-an-empty-result-set-confirmation-anyone
Probably this might have caused regression https://github.com/civicrm/civicrm-core/commit/fd95406da80
...From SE: https://civicrm.stackexchange.com/questions/26208/as-of-5-4-0-activity-search-gives-an-empty-result-set-confirmation-anyone
Probably this might have caused regression https://github.com/civicrm/civicrm-core/commit/fd95406da80
PR: https://github.com/civicrm/civicrm-core/pull/127135.5.0https://lab.civicrm.org/dev/wordpress/-/issues/10After Installing CiviCRM 5.4.0 under IIS on Windows Server, Dashboard Returns...2018-09-08T19:04:56ZfrankfazzioAfter Installing CiviCRM 5.4.0 under IIS on Windows Server, Dashboard Returns White ScreenThe following message was found in the php error log:
Uncaught Symfony\Component\Filesystem\Exception\IOException: Cannot rename ...
The file path in the rename contains the two characters "\\/" as a folder delimiter, instead of just on...The following message was found in the php error log:
Uncaught Symfony\Component\Filesystem\Exception\IOException: Cannot rename ...
The file path in the rename contains the two characters "\\/" as a folder delimiter, instead of just one, "\\". This causes cached files that are created to not be retrieved. There are other placed where the path containing the two characters "\\\\" as a folder delimiter, instead of just one, "\\", is found in Smarty.
Not sure if this behavior is specific to Windows Server 2012, Azure, or what. Patched problem by changing three files:
Symfony -
Filesystem.php line 272
```php
if (true !== @rename(str_replace(array("\\\\", "\\/"), "\\", $origin), str_replace(array("\\\\", "\\/"), "\\", $target))) {
```
Smarty -
Smarty.class.php line 1253
```php
$_smarty_compile_path = str_replace(array("\\\\", "\\/"), "\\", $this->_get_compile_path($resource_name));`
```
Smarty -
core.write_file.php line 45
```php
@rename(str_replace(array("\\\\", "\\/"), "\\", $_tmp_file), str_replace(array("\\\\", "\\/"), "\\", $params['filename']));
```
I realize that Symphony and Smarty are third party code, but I wanted to report it.https://lab.civicrm.org/dev/translation/-/issues/11Transifex localization strings out of date2018-09-11T20:28:33ZfrancescbassasTransifex localization strings out of dateTransifex strings are not updated since CiviCRM 4.7.12 version.Transifex strings are not updated since CiviCRM 4.7.12 version.bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/393OptionGroup check doesn't like option values of zero in a group of integers2018-09-14T00:36:37ZJonGoldOptionGroup check doesn't like option values of zero in a group of integersThe check for invalid option values gives a false positive when the option group's `data_type` is `Integer` and the value is `0`. This is particularly noticeable when you have the "Related Permissions" extension version 1.5 installed.
...The check for invalid option values gives a false positive when the option group's `data_type` is `Integer` and the value is `0`. This is particularly noticeable when you have the "Related Permissions" extension version 1.5 installed.
To test:
* Go to **Administer » System Settings » Option Groups**.
* Create a new option group with a data type of "Integer".
* Create an option value in that group with a value of "0".
* Run the `System.check` API (or visit the System Status screen).
* A notice is thrown.
Expected behavior:
* No notice is thrown.5.7JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/390Smart groups created before 5.5.0 using "relation_permission" break on upgrad...2018-09-14T04:15:23ZnoahSmart groups created before 5.5.0 using "relation_permission" break on upgrade to 5.5.0Because of changes introduced by https://github.com/civicrm/civicrm-core/pull/12415, CiviCRM 5.5.0 generates fatal SQL when running some smart groups created in previous versions.Because of changes introduced by https://github.com/civicrm/civicrm-core/pull/12415, CiviCRM 5.5.0 generates fatal SQL when running some smart groups created in previous versions.5.5.1https://lab.civicrm.org/dev/core/-/issues/379View Activity: extraneous newlines by nl2br on HTML content2018-09-14T04:15:46ZbgmView Activity: extraneous newlines by nl2br on HTML contentThis a regression that was caused a while back by #2 (for I take responsibility, since I mentored/reviewed). We added a nl2br that was a bit too bread in scope, but should have only affected Inbound HTML activities.
How to reproduce on ...This a regression that was caused a while back by #2 (for I take responsibility, since I mentored/reviewed). We added a nl2br that was a bit too bread in scope, but should have only affected Inbound HTML activities.
How to reproduce on http://dcase.demo.civicrm.org :
* Go to a contact record
* Create an activity
* In the details field, add 3 separate lines (by hitting 'enter' once, to create a new paragraph).
![44817615-028c1d00-abb4-11e8-9eba-07b9eb96c029](/uploads/ccb4d0f8a636c37869d0d93455629967/44817615-028c1d00-abb4-11e8-9eba-07b9eb96c029.png)
In the above, you can see that "Line 1" and "Line 2" have a lot of space between them. Inspecting the HTML, it shows that some extra 'br' tags were added between the paragraphs.
If we edit the activity again, the HTML looks OK:
![44817687-3109f800-abb4-11e8-88a4-dccb3b1b957e](/uploads/f69ce244868ea5f50384aa2861f75a7b/44817687-3109f800-abb4-11e8-88a4-dccb3b1b957e.png)
(the newlines in the above screenshot are what made me assume this is a nl2br bug)
PS: this issue was initially reported here: https://github.com/civicrm/org.civicrm.civicase/issues/116 -- but it is not specific to civicase v5.
cc @Detlev5.7bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/376Contact Detail report breaks when adding clause using selectWhereClause()2018-09-14T04:16:17ZPradeep Nayakpradpnayak@gmail.comContact Detail report breaks when adding clause using selectWhereClause()5.7https://lab.civicrm.org/dev/core/-/issues/382DB Error generated when updating a group with an organisation record attached...2018-09-16T20:36:52ZseamusleeDB Error generated when updating a group with an organisation record attached where the id in the civicrm_group_organisation does not match the id in civicrm_groupIf the id of the group does not = the id of its civicrm_group_organisation record then a db error can be generated when trying to update the group.If the id of the group does not = the id of its civicrm_group_organisation record then a db error can be generated when trying to update the group.5.7seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/370No new tasks and documents get added to workflow if all built-in ones are del...2018-09-21T01:46:12ZajesamsonNo new tasks and documents get added to workflow if all built-in ones are deletedIn civi case types, when all built-in tasks and documents are deleted from the Standard Timeline of a workflow, no new tasks and documents get saved to that workflow.
![case_type](/uploads/61dbf15272ad0c9d65312b10977c1e88/case_type.gif...In civi case types, when all built-in tasks and documents are deleted from the Standard Timeline of a workflow, no new tasks and documents get saved to that workflow.
![case_type](/uploads/61dbf15272ad0c9d65312b10977c1e88/case_type.gif)
The desired result would be ability to add new task(s) after existing tasks are deleted.5.7https://lab.civicrm.org/dev/core/-/issues/281Fix invoice number in message template2018-09-22T20:38:51ZyashodhaFix invoice number in message templateSteps to replicate:
-------------------
1. Find Contributions with status *Pending*.
2. Choose a contribution record and from bulk actions choose *Invoices - Print or Email*.
3. The invoice still shows invoice id instead of human readab...Steps to replicate:
-------------------
1. Find Contributions with status *Pending*.
2. Choose a contribution record and from bulk actions choose *Invoices - Print or Email*.
3. The invoice still shows invoice id instead of human readable invoice id.
![inv_pending_before](/uploads/64692c28aa1df83078dad24401e15f81/inv_pending_before.png)5.7yashodhayashodha