Development issueshttps://lab.civicrm.org/groups/dev/-/issues2020-03-01T20:27:10Zhttps://lab.civicrm.org/dev/financial/-/issues/109Invoice does not assign/display the contact's country2020-03-01T20:27:10ZbgmInvoice does not assign/display the contact's countryTo reproduce:
* Enable Taxes and Invoicing
* Edit the "Contribution Invoice Receipt" message template to include `{$country}` (other related contact tokens are called `{$street_address}`, `{$email}`, etc.
* Go to a contact, create a con...To reproduce:
* Enable Taxes and Invoicing
* Edit the "Contribution Invoice Receipt" message template to include `{$country}` (other related contact tokens are called `{$street_address}`, `{$email}`, etc.
* Go to a contact, create a contribution, and from "view contribution", click "print PDF invoice" to view an invoice.
The country will be empty.5.24.0https://lab.civicrm.org/dev/core/-/issues/1422Event Participants actions (Print Name Badges, Export...) ignores search crit...2019-12-09T01:47:09ZalainbEvent Participants actions (Print Name Badges, Export...) ignores search criteriaOverview
----------------------------------------
After a participant search from an event, the actions ignore the search criteria.
Reproduction steps
----------------------------------------
In the CiviCRM demo environment:
1. Click on...Overview
----------------------------------------
After a participant search from an event, the actions ignore the search criteria.
Reproduction steps
----------------------------------------
In the CiviCRM demo environment:
1. Click on **Events -> Manage Events**.
1. For e.g. the Rain-forest Cup Youth Soccer Tournament, click on the right-hand side, click on **Participants -> Registered, Attended, Pending...**.
1. Got 8 participants.
1. Click on **All 8 records -> Actions -> Name Badges Print**
1. The next screen shows **Number of selected participants: 18** instead of **8**.
Similar problem if you select the export action: the confirmation screen shows 8, but the actual export contains 18 lines.
Comments
----------------------------------------
I noticed that the function setDefaults() was removed from the file CRM/Event/Form/Search.php
between these changes:
* still there: https://lab.civicrm.org/dev/core/blob/8a6fde27c69f5e6e51fa91060fa67124d9ca9e18/CRM/Event/Form/Search.php
* removed: https://lab.civicrm.org/dev/core/blob/6fbf3a31a162dd5bdaff0db876360bc4e0f09a49/CRM/Event/Form/Search.php
when I add the function setDefaults() again in CRM/Event/Form/Search.php, the problem seems to be solved.
Can anyone confirm this?5.19.4https://lab.civicrm.org/dev/core/-/issues/1420Quicksearch with phone filter doesn't work with non-numeric character2020-01-10T07:23:49ZMonish DebQuicksearch with phone filter doesn't work with non-numeric characterSteps to replicate:
1. Say a contact A has a phone number : 876-123-234
2. Go to quicksearch bar and select 'Phone' filter
3. Type '876-123' in the search field.
Bug: It doesn't return contact A, because the code doesn't trim non-numeri...Steps to replicate:
1. Say a contact A has a phone number : 876-123-234
2. Go to quicksearch bar and select 'Phone' filter
3. Type '876-123' in the search field.
Bug: It doesn't return contact A, because the code doesn't trim non-numeric character for the phone_numeric filter which expects only numeric digits.5.21.0Monish DebMonish Debhttps://lab.civicrm.org/dev/drupal/-/issues/95Participant is_test field was missing from drupal views2019-11-22T23:37:05Zmagnolia61Participant is_test field was missing from drupal viewsThe Participant is_test field was missing from drupal views
I used the same approach as the membership is_test field to add it.
https://github.com/civicrm/civicrm-drupal/pull/590The Participant is_test field was missing from drupal views
I used the same approach as the membership is_test field to add it.
https://github.com/civicrm/civicrm-drupal/pull/5905.21.0magnolia61magnolia61https://lab.civicrm.org/dev/core/-/issues/1414Url search with `civicrm/case/search?case_owner=2&force=1` gives an E_NOTICE2019-11-22T02:47:10ZDaveDUrl search with `civicrm/case/search?case_owner=2&force=1` gives an E_NOTICEThis just started in master recently and I can't reproduce in 5.20 but I can on the public demo which is 5.21alpha1.
Running a url search `civicrm/case/search?reset=1&case_owner=2&force=1` gives
`Notice: Undefined index: html in CRM_Co...This just started in master recently and I can't reproduce in 5.20 but I can on the public demo which is 5.21alpha1.
Running a url search `civicrm/case/search?reset=1&case_owner=2&force=1` gives
`Notice: Undefined index: html in CRM_Core_Form_Search->getEntityDefaults() (line 291 of ...\CRM\Core\Form\Search.php)`
ping @seamuslee5.21.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/1412CiviMail sent via wp-cli and cron mangles mailing urls on WP2019-11-26T20:23:49ZkcristianoCiviMail sent via wp-cli and cron mangles mailing urls on WPStarting in 5.19 we have an issue with URLs in CiviMail. If Track links is on the URLs get mangled. Dradt Emails are fine, as well as if you kick off the scheduled job manually (UI or CLI).
However, if cron runs the job the URLS are b...Starting in 5.19 we have an issue with URLs in CiviMail. If Track links is on the URLs get mangled. Dradt Emails are fine, as well as if you kick off the scheduled job manually (UI or CLI).
However, if cron runs the job the URLS are broken:
Mailing Urls expected:
https://example.org//wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
But we get:
https://example.org/home/example/public_html/wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
Tested Enviornments:
CiviCRM 5.19.x
WP: 5.3
wp-cli : 2.3 or 2.4
php 7.1 or 7.2 or 7.3
Cron run via script:
```sh
#!/bin/bash
/usr/local/bin/wp --user=civicron --url=https://example.org --path=/home/example/public_html --timezone="America/New_York" civicrm api job.execute auth=0
```
On Single site we can work around using `cv` or `cli.php` That fails on Multi-Domain
```sh
#/usr/local/bin/php /usr/local/bin/cv api job.execute --user=civicron --cwd=/home/example/public_html
```
Multi-Site Example:
WP MS 5.3
CiviCRM 5.19.1
php 7.1 (also tested 7.2)
wp-cli 2.4 (also tested 2.3)
cli.php results
```
you need to configure site : PHP Fatal error: Uncaught RuntimeException: Undefined constant: CIVICRM_UF_BASEURL in /home/members/example/sites/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress
.php:105
```
cv results
```
you need to configure site : PHP Fatal error: Uncaught RuntimeException: Undefined constant: CIVICRM_UF_BASEURL in /home/members/example/sites/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress
.php:105
```
script:
```sh
#!/bin/bash
#/usr/bin/php /home/members/example/sites/example.org/users/example/bin/cv api job.execute --user=civicron --cwd=/home/members/example/sites/example.org/users/example/web
#/usr/bin/php /home/members/example/sites/example.org/users/example/web/wp-content/plugins/civicrm/civicrm/bin/cli.php -s https://example-la.org -u civicron -p "civicrm" -e Job -a execute
#/usr/bin/php /home/members/example/sites/example.org/users/example/web/wp-content/plugins/civicrm/civicrm/bin/cli.php -s https://www.example.org -u civicron -p "civicrm" -e Job -a execute
/home/members/example/sites/example.org/users/example/bin/wp --user=tadpole --url=https://www.example.org --timezone="America/New_York" civicrm api job.execute auth=0
/home/members/example/sites/example.org/users/example/bin/wp --user=tadpole --url=https://another-example.org --timezone="America/New_York" civicrm api job.execute auth=0
```
We can fix the mangled URLS with a Work Around via .htaccess
```
#email redirect
RewriteEngine On
RewriteCond %{HTTP_HOST} ^example-la\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/example-la\.org\/$1" [R=301,L,QSA]
RewriteEngine On
RewriteCond %{HTTP_HOST} ^www.example\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/www\.example\.org\/$1" [R=301,L,QSA]
RewriteEngine On
RewriteCond %{HTTP_HOST} ^example\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/example\.org\/$1" [R=301,L,QSA]
```
Reviewed with @haystack and @andrei Chritian came up with this Patch that I added to our local repo: https://github.com/tadpolecc/civicrm/commit/9470e1fb51ef317ee6d3f211af1bbf99e91431db
PR will be coming as this is a regression5.19.3https://lab.civicrm.org/dev/core/-/issues/1411Can't search for activity subjects starting with 1 - and many more caching is...2019-12-02T18:54:32ZJonGoldCan't search for activity subjects starting with 1 - and many more caching issuesOverview
----------------------------------------
Due to how the query that fills the SQL cache is built, it fails under some very common circumstances. Some of those are hidden by the fact that Civi will fall back to an uncached search...Overview
----------------------------------------
Due to how the query that fills the SQL cache is built, it fails under some very common circumstances. Some of those are hidden by the fact that Civi will fall back to an uncached search; some simply show no results.
Reproduction steps
----------------------------------------
1. Create a new activity with a subject of `12345`.
1. On **Advanced Search**, search **Activity Text** for `12345`.
1. Observe no results found.
1. Search **Activity Text** for `2345`.
1. Observe the the activity is found.
Why this happens
----------------------------------------
* The SQL created is something like `SELECT contact_a.id FROM civicrm_activity WHERE activity_subject like '%12345%'`.
* `CRM_Contact_Selector` has [this code snippet](https://github.com/civicrm/civicrm-core/blob/cf70a3eee02b1f46b23435b882d261fd400713b0/CRM/Contact/Selector.php#L1042-L1046) which replaces `SELECT contact_a.id` with `"SELECT DISTINCT %1, contact_a.id, contact_a.sort_name"`, which yields `SELECT DISTINCT %1, contact_a.id, contact_a.sort_name FROM civicrm_activity WHERE activity_subject like '%12345%'`.
* It then passes this SQL to a function that does variable substitution - but the `%1` in `%12345%` gets substituted with the cache key!
This problem manifests with any Advanced Search field that prepends a wildcard (`%`) to the form value. However, if you search for a contact named `12345` the search will still complete, because there's a fallback query in case of exceptions.
Additional Note(s)
----------------------------------------
I'm going to break my PR into two parts to make it easier to review. The first part will deal with the bug itself; I'll follow up with a cleanup PR to simplily the `fillWithSQL` signature.
The `fillWithSQL` method is only called in [one other place in the code](https://github.com/civicrm/civicrm-core/blob/1cf214fd05844767bb1b9587cca796ac47102042/CRM/Campaign/Selector/Search.php#L268-L274), in CiviCampaign. However, this query ALWAYS fails, because it puts `FROM` twice in a row. So this will always fail to populate the cache.5.21.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/1410civicrm/case/search?reset=1&force=1&case_subject=test gives php warning2019-11-22T01:47:09ZDaveDcivicrm/case/search?reset=1&force=1&case_subject=test gives php warningI know there's still ongoing work related to force=1 in urls for search, but reporting that `civicrm/case/search?reset=1&force=1&case_subject=test` gives `Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_...I know there's still ongoing work related to force=1 in urls for search, but reporting that `civicrm/case/search?reset=1&force=1&case_subject=test` gives `Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_Common->_getAttrString()`
The results seem correct, there's just the php warning.5.21.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/1409Record Refund fails due to thousands separator in amount2019-11-20T22:38:55ZkcristianoRecord Refund fails due to thousands separator in amountOverview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the...Overview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the number
Reproduction steps
----------------------------------------
- Create an event Price set with two fee levels 5,000 and 1,000 $ € currency is not material
- Assign Price set to an event
- Add a Participant at 5,000 level and record payment
- Edit the event and change selections to the 1,000 level
- Go to the Contribution and Record Refund
- Choose Payment Method
- Enter Fee Amount
- Save
Current behaviour
----------------------------------------
The form does not save. A message appaears that the Net Amount should be equal to difference between the payment amount and the fee amount
![image](/uploads/33dc65dcfcbfddbb228f897cb2fbb4ca/image.png)
Expected behaviour
----------------------------------------
This error occurs due to the thousands separator. Remove it and it will save.
Expected behavior would be to either handle the thousands separator properly or not display it.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* Browser: FireFox 70
* CiviCRM: 5.19.1
* PHP: Tested on 7.2 and 7.3 (same behavior)
* CMS:WP 5.3_
* Database: MariaDB 10.1
* Web Server: Apache 2.4
Comments
----------------------------------------
There is a work around here, but this is a regression. Tested in 5.14.2 and it worked fine. I have not tested on 5.18 yet, as I wanted to get the report in.5.19.2https://lab.civicrm.org/dev/core/-/issues/1406Cannot filter by 'Member Since' in Membership Summary Report2019-11-20T21:46:44Zm robimorgan@palantetech.coopCannot filter by 'Member Since' in Membership Summary Report
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this is...
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this issue as I don't have time to dig into it now.
```
Nov 18 12:10:26 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -19
[message] => DB Error: no such field
[mode] => 16
[debug_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[type] => DB_Error
[user_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[to_string] => [db_error: message="DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']"]
)
```5.19.2https://lab.civicrm.org/dev/core/-/issues/1405CiviCRM Option Group with a name containing spaces cannot have any options ad...2019-12-02T06:07:08Zjustinfreeman (Agileware)CiviCRM Option Group with a name containing spaces cannot have any options added, error message is shown also impacts the in-place option editorCiviCRM Option Group with a name containing spaces cannot have any options added, error message is shown also impacts the in-place option editor.
The Name field is mandatory on an Option Group and no guidance is given to the user about ...CiviCRM Option Group with a name containing spaces cannot have any options added, error message is shown also impacts the in-place option editor.
The Name field is mandatory on an Option Group and no guidance is given to the user about what value should be entered. No validation is performed on this field to prevent an invalid value from being entered.
The workaround is to **remove the spaces from the Name field value**.
Bug is shown in the screen recording below. Reproduced on CiviCRM 5.21.alpha1 - https://dmaster.demo.civicrm.org/
Agileware Ref: CIVICRM-1373
![in-place-editor-option-group](/uploads/ff54799f03f1af4926c1692548ab2d28/in-place-editor-option-group.png)
![jKq5sOxNx2](/uploads/542b18ecfe68ab3d957f00eda58ecc32/jKq5sOxNx2.gif)5.21.0justinfreeman (Agileware)justinfreeman (Agileware)https://lab.civicrm.org/dev/core/-/issues/1400Users with 'view own cases' permission can't open resolved cases2021-03-02T14:00:16ZgrahamsmithUsers with 'view own cases' permission can't open resolved cases**Originally referenced here:** [https://civicrm.stackexchange.com/questions/33742/users-with-view-own-cases-permission-cant-access-resolved-cases](https://civicrm.stackexchange.com/questions/33742/users-with-view-own-cases-permission-ca...**Originally referenced here:** [https://civicrm.stackexchange.com/questions/33742/users-with-view-own-cases-permission-cant-access-resolved-cases](https://civicrm.stackexchange.com/questions/33742/users-with-view-own-cases-permission-cant-access-resolved-cases)
**Version:** 5.19.1 & Drupal 7.67
**Problem:** Users with 'view own cases' permission can't access closed cases. Does not affect users with 'view all cases' permissions. Unable to replicate on demo site due to being unable to edit role permissions.
**Backtrace:**
`Nov 16 00:39:28 [error] $Fatal Error Details = Array
(
[message] => You are not authorized to access this page.
[code] =>
)
Nov 16 00:39:28 [debug] $backTrace = #0 .../public/sites/all/modules/civicrm/CRM/Core/Error.php(385): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 .../public/sites/all/modules/civicrm/CRM/Case/Page/Tab.php(72): CRM_Core_Error::fatal("You are not authorized to access this page.")
#2 .../public/sites/all/modules/civicrm/CRM/Case/Page/Tab.php(188): CRM_Case_Page_Tab->preProcess()
#3 .../public/sites/all/modules/civicrm/CRM/Core/Invoke.php(290): CRM_Case_Page_Tab->run((Array:4), NULL)
#4 .../public/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:13))
#5 .../public/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#6 .../public/sites/all/modules/civicrm/drupal/civicrm.module(444): CRM_Core_Invoke::invoke((Array:4))
#7 .../public/includes/menu.inc(527): civicrm_invoke("contact", "view", "case")
#8 .../public/index.php(21): menu_execute_active_handler()
#9 {main}`5.36.0https://lab.civicrm.org/dev/core/-/issues/1398Option to open navigation item in new window (if present)2019-11-26T20:25:31ZMonish DebOption to open navigation item in new window (if present)Currently, the ```target``` attribute of submenus are ignored whereas the menu item adds this property in the anchor links [here](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/Navigation.php#L443)Currently, the ```target``` attribute of submenus are ignored whereas the menu item adds this property in the anchor links [here](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/Navigation.php#L443)5.21.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/1396No membership tokens available in mailing2021-10-12T02:23:59ZmarcelklehrNo membership tokens available in mailingOverview
----------------------------------------
When selecting memberships using "find memberships" and drafting an email to them, I would like to have membership tokens like membership.fee available.
Reproduction steps
--------------...Overview
----------------------------------------
When selecting memberships using "find memberships" and drafting an email to them, I would like to have membership tokens like membership.fee available.
Reproduction steps
----------------------------------------
1. Click on **Membership -> Find memberships**.
1. Select some memberships
1. Create an email using the actions
1. Try to add a membership token
Current behaviour
----------------------------------------
No membership tokens are available and using them anyway doesn't work.
Expected behaviour
----------------------------------------
Membership tokens should be available for use.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 70.0.1_
* __CiviCRM:__ _5.18.4_
* __PHP:__ _7.2...__
* __CMS:__ _Drupal 7.30..._
* __Database:__ _MariaDB 10.4_
* __Web Server:__ _Nginx 1.16_
Comments
----------------------------------------
My organisation is quite dependent on this feature for our yearly membership fees, so any help is appreciated.5.43.0https://lab.civicrm.org/dev/core/-/issues/1395Clear asset builder cache when clearing cache2020-01-18T00:07:13ZDaveDClear asset builder cache when clearing cacheIs there a reason it doesn't? There's a function AssetBuilder::clear() available but doesn't seem to be used anywhere.
See also
* https://civicrm.stackexchange.com/questions/33696/civicrm-angular-module-system-generated-files-keeps-grow...Is there a reason it doesn't? There's a function AssetBuilder::clear() available but doesn't seem to be used anywhere.
See also
* https://civicrm.stackexchange.com/questions/33696/civicrm-angular-module-system-generated-files-keeps-growing-exponentially
* https://chat.civicrm.org/civicrm/pl/g5xguuqo7fnt3pd8dgwyatxutw
PR coming.5.23.0https://lab.civicrm.org/dev/core/-/issues/1394CiviCaseTestCase setup() can make duplicate activity type option values2019-11-18T06:54:19ZDaveDCiviCaseTestCase setup() can make duplicate activity type option valuesSee these lines https://github.com/civicrm/civicrm-core/blob/5.19.1/tests/phpunit/CiviTest/CiviCaseTestCase.php#L57-L71 and note that setup() also uses quickCleanup().
```
$optionValues = array(
'Medical evaluation' => 'Medica...See these lines https://github.com/civicrm/civicrm-core/blob/5.19.1/tests/phpunit/CiviTest/CiviCaseTestCase.php#L57-L71 and note that setup() also uses quickCleanup().
```
$optionValues = array(
'Medical evaluation' => 'Medical evaluation',
'Mental health evaluation' => "Mental health evaluation",
'Secure temporary housing' => 'Secure temporary housing',
'Long-term housing plan' => 'Long-term housing plan',
'ADC referral' => 'ADC referral',
'Income and benefits stabilization' => 'Income and benefits stabilization',
);
foreach ($optionValues as $name => $label) {
$activityTypes = $this->callAPISuccess('option_value', 'Create', array(
'option_group_id' => 2,
'name' => $name,
'label' => $label,
'component_id' => 7,
));
```
So for example if you have a dataprovider that calls your test multiple times, it keeps creating new duplicate activity types with the same `name`.
PR coming
In the option_value table definition maybe these keys should be unique keys, but that's extra.
```
KEY `index_option_group_id_value` (`value`(128),`option_group_id`),
KEY `index_option_group_id_name` (`name`(128),`option_group_id`),
```5.21.0https://lab.civicrm.org/dev/core/-/issues/1393Tarball includes a symlink that goes nowhere, which causes alternate drupal i...2020-10-02T03:27:08ZDaveDTarball includes a symlink that goes nowhere, which causes alternate drupal install method to failIn the docs (https://docs.civicrm.org/sysadmin/en/latest/install/drupal7/#directory) if you choose the first bullet point method of getting the tarball, it can fail because of a symlink that goes nowhere. See https://civicrm.stackexchang...In the docs (https://docs.civicrm.org/sysadmin/en/latest/install/drupal7/#directory) if you choose the first bullet point method of getting the tarball, it can fail because of a symlink that goes nowhere. See https://civicrm.stackexchange.com/questions/33708/get-unable-to-extract-symbolic-link-error-message-when-trying-to-install-civic
I believe it's because this line excludes the docs folder: https://github.com/civicrm/civicrm-core/blob/5.19.1/distmaker/dists/common.sh#L166
I don't think this is a recent thing.
One way to solve it might be to have that same line exclude `README.rst`.5.31.0https://lab.civicrm.org/dev/financial/-/issues/107notice errors: undefined index discounted_value, invalid arg for foreach()2020-08-25T15:12:11ZJoeMurraynotice errors: undefined index discounted_value, invalid arg for foreach()On dmaster just now, on Fees tab for Manage Event, click Add Discount Set for Fee Table, result is errors:
Notice: Undefined index: discounted_value in CRM_Event_Form_ManageEvent_Fee->cleanMoneyFields() (line 813 of /srv/buildkit/build/...On dmaster just now, on Fees tab for Manage Event, click Add Discount Set for Fee Table, result is errors:
Notice: Undefined index: discounted_value in CRM_Event_Form_ManageEvent_Fee->cleanMoneyFields() (line 813 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/ManageEvent/Fee.php).
Warning: Invalid argument supplied for foreach() in CRM_Event_Form_ManageEvent_Fee->cleanMoneyFields() (line 813 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/ManageEvent/Fee.php).5.30.0https://lab.civicrm.org/dev/core/-/issues/1391Cancelled contributions are not greyed out in contribution lists2019-11-20T22:39:10ZPatrick Figelpfigel@greenpeace.orgCancelled contributions are not greyed out in contribution listsOverview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Sear...Overview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Search for any cancelled contribution or open the contribution tab of a contact with a cancelled contribution.
Current behaviour
----------------------------------------
The contribution is not greyed out and does not show the cancellation date below the contribution status.
Expected behaviour
----------------------------------------
The contribution should be greyed out and show the cancellation date below the contribution status.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.19/5.18_
Comments
----------------------------------------
This seems to have regressed somewhere between 5.13 (where it works) and 5.18 (where it doesn't). I'm thinking it might have to do with the introduction of `cancel_date` in `civicrm_contribution_recur`.5.19.2https://lab.civicrm.org/dev/financial/-/issues/105Proposal: Add in payment_processor-{payment processor type} class attribute t...2020-05-28T06:44:33ZseamusleeProposal: Add in payment_processor-{payment processor type} class attribute to Radio HTMLWhen more than one payment processor is included on a contribution or event form. a set of radio buttons is added to set the payment processor to use. There is an issue in that each radio input uses the same name - payment_processor_id t...When more than one payment processor is included on a contribution or event form. a set of radio buttons is added to set the payment processor to use. There is an issue in that each radio input uses the same name - payment_processor_id the only difference is that the id of each radio button includes the payment processor.id However that doesn't give you any idea what the type is so hypothecitally if you had a PayPal and say Eway Procesors or PayPal and Pay Later option and wanted to theme the PayPal option using a PayPal button there is no obvious way of determining which is Paypal. The proposal would be to add in the payment processor type name in as a class so it was like payment_processor_type-{type name} as a class to the radio so that5.24.0seamusleeseamuslee