Development issueshttps://lab.civicrm.org/groups/dev/-/issues2022-09-26T20:24:23Zhttps://lab.civicrm.org/dev/core/-/issues/3872Search on pledge payments on Find contributions screen2022-09-26T20:24:23ZyashodhaSearch on pledge payments on Find contributions screenIn _Find contributions_, if _CiviPledge_ is enabled, add search on pledge payments.
![se](/uploads/37de92cf4ea25288db09be94e60df203/se.png)
We do have bunch of options for search on contributions that are recurring or not, pay later o...In _Find contributions_, if _CiviPledge_ is enabled, add search on pledge payments.
![se](/uploads/37de92cf4ea25288db09be94e60df203/se.png)
We do have bunch of options for search on contributions that are recurring or not, pay later or not, would be helpful to check if the contribution is a pledge payment or not.
And based on the components enabled, we can have for event/membership as well.yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3871Write-off feature for pledges2022-10-11T13:07:54ZyashodhaWrite-off feature for pledges**Functional specifications:**
On a pledge, in _Edit Scheduled Payment_, we can delete a pledge payment. The total pledge amount is reduced by the amount of the scheduled payment and the balance due is recalculated.
But in this scenar...**Functional specifications:**
On a pledge, in _Edit Scheduled Payment_, we can delete a pledge payment. The total pledge amount is reduced by the amount of the scheduled payment and the balance due is recalculated.
But in this scenario, the pledge status is left as is.
We can also cancel a pledge. All scheduled payments are canceled but the pledge status is set to canceled and the pledge balance and the total pledge amount are not recalculated. So I propose a new feature for the write-off.
- Add the menu option “Write Off” before Cancel.
- All scheduled payments are canceled like for a pledge cancellation.
- Pledge status is changed to Completed.
- Total pledge amount is reduced by the existing pledge balance amount.
- Pledge balance is set to $0.
- An activity of type “Pledge write-off” is created and recorded on the contact.
- Activity Subject=total pledge amount
- Activity Date and time = date and time of the action
- Activity Status=Completed
- Actions available on the activity should be View and File on case only like for the activity type Contribution.
- The option _Write-Off_ is available only for a pledge that has at least one pledge payment. If no pledge payment has been recorded with a pledge, write-off doesn’t make any sense, so we should have only the options to delete or cancel a pledge.
- if pledge status =Pending or Overdue > Show only Cancel and Delete
- if pledge status = In progress > show only Write-Off and Delete
- if pledge status = Completed or Canceled > show only Deleteyashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3870Price set pre and post help display is inconsistent2022-09-27T15:07:07ZlarsssandergreenPrice set pre and post help display is inconsistentPrice set display can get a little wonky. One issue is that for checkboxes and radios, pre and post help for price options is displayed when Display amounts? is checked, but is not displayed when it is not checked. These are the same pri...Price set display can get a little wonky. One issue is that for checkboxes and radios, pre and post help for price options is displayed when Display amounts? is checked, but is not displayed when it is not checked. These are the same price fields, the only difference is Display amounts has been unchecked:
![image](/uploads/37ade20a98ecded410890b394a6fcb18/image.png)
![image](/uploads/7c74ddb8c9221921c0834a0eaf4a0dc6/image.png)
Similarly, pre and post help are never displayed for select options.
I propose to fix these so pre and post help are always displayed when present. This might make for a long select element, but if the fields are going to exist, they should work. Alternately, we could remove pre and post help for select options, but it seems better to keep the fields on all the price option types consistent.5.55.0https://lab.civicrm.org/dev/core/-/issues/3869Cannot update contacts via profile from Search Kit results2023-09-22T02:06:27ZlarsssandergreenCannot update contacts via profile from Search Kit resultsIf you select contacts from Search Kit results and then select Profile Update from the Action menu, you are able to select a profile in the dialog box, but after clicking Continue, the dialog simply closes.
Tested on dmaster (5.55.alpha...If you select contacts from Search Kit results and then select Profile Update from the Action menu, you are able to select a profile in the dialog box, but after clicking Continue, the dialog simply closes.
Tested on dmaster (5.55.alpha1) and 5.49.5.https://lab.civicrm.org/dev/core/-/issues/3868Link contribution view with asssociated entity2023-05-18T23:37:57ZyashodhaLink contribution view with asssociated entityWhen you view a contribution, there's no way to know whether this contribution was done as a part of membership, pledge or an event registration.
I propose provide this additional data. Display this under total amount
e,g
![Screens...When you view a contribution, there's no way to know whether this contribution was done as a part of membership, pledge or an event registration.
I propose provide this additional data. Display this under total amount
e,g
![Screenshot_from_2022-09-23_19-15-29](/uploads/24028770f5b17e20ab40334973061b05/Screenshot_from_2022-09-23_19-15-29.png)
Membership will be a link to membership view page.
(depending on the related entity we display the link)yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3867Subscription do-not-reply email causing issues with some mail servers connect...2023-11-20T23:59:49Znikola.mladenovicSubscription do-not-reply email causing issues with some mail servers connecting via SMTPOverview
----------------------------------------
We used integration via Contact Form 7 integration to connect Contact Form 7 in order to send data directly to CiviCRM. This works when server is connected to mail() but not via SMTP for ...Overview
----------------------------------------
We used integration via Contact Form 7 integration to connect Contact Form 7 in order to send data directly to CiviCRM. This works when server is connected to mail() but not via SMTP for some servers.
This issue is only present when you use Mailing Event: Subscribe to mailing list as Action in form processor.
The client uses cPanel, which by default has setup to decline all emails that do not exist (ex do-not-reply@domain.com). They do not use catchall. The issue itself is CiviCRM related, not FormProcessor.
When its set to SMTP, it tries to send email stimulating address do-not-reply@domain.com
Since it doesn't exist and SMTP is directly connected to only one email that wont work, as it tries to use that address for Subscribing process. When you send via mail() function you get email from proper email, but since server stimulates it, it doesn't cause a bug in that state.
Reproduction steps
----------------------------------------
1. Connect via SMTP to some cPanel SMTP or similar host that doesn't have catchall/VERP/do-not-reply@domain.com address present
2. Click on Administration -> Automation -> Form processor
2. Create Form processor that only has email for value
3. Add XCM contact matcher to match contact
4. Add type Mailing Event: Subscribe to mailing list
5. Save and Close -> Try out out
Current behaviour
----------------------------------------
When you try to fill out Contact Form 7 and it has SMTP connected, data is submitted but submission itself is not sent to the user.
When you use Try Out option for Form Processor you get error from the system: Unable to send email. Please report this message to the site administrator
In logs you can find this:
`[error] Mailing error: Failed to add recipient: user@website.org [SMTP: Invalid response code received from SMTP server while sending email. This is often caused by a misconfiguration in Outbound Email settings. Please verify the settings at Administer CiviCRM >> Global Settings >> Outbound Email (SMTP). (code: 550, response: Verification failed for...`
SMTP and bounce processing is functioning perfectly for newsletter.
Expected behaviour
----------------------------------------
It should by default use SMTP address not ask for do-not-reply@domain.com address as it sends even via SMTP with our hotfix. This causes issues for some SMTP connections, from some hosts. In this case from cPanel which does not have catchall setup or do-not-reply@domain.com address.
Current hotfix for client's needs
----------------------------------------
We made an edit in file civicrm/CRM/Mailing/Event/BAO/Subscribe.php on line 208 on master ('returnPath' => CRM_Core_BAO_Domain::getNoReplyEmailAddress()) to force to use same address as SMTP one and that works when subscription is received.
` 'returnPath' => 'smtp@domain.com',//CRM_Core_BAO_Domain::getNoReplyEmailAddress(), `
Environment information
----------------------------------------
* __Browser:__ _Firefox 105.0/Chrome 105.0.5195.127_
* __CiviCRM:__ _5.47.4_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _Php-7.4_
* __CMS:__ _Drupal-7.91_
* __Database:__ _mysql-8.0.30-0ubuntu0.20.04.2_
* __Web Server:__ _apache2-2.4.41_
Comments
----------------------------------------
Chat link of discussion:
https://chat.civicrm.org/civicrm/pl/1sqat1uwo3befca91akhmdzsre
Creating do-not-reply@domain.com address is also another fix, but its not noted anywhere but it should exist, either fixing this for global use or adding in CiviCRM to report that do-not-reply@domain.com doesn't exists should suffice.https://lab.civicrm.org/dev/core/-/issues/3866API - CustomGroup - extends_entity_column_value2022-09-26T23:06:37ZtschuettlerAPI - CustomGroup - extends_entity_column_valueOverview
----------------------------------------
Filtering custom field groupy by `extends_entity_column_value` is not possible via API. It is also not possible to create a custom field group via API explorer when trying to limit it by ...Overview
----------------------------------------
Filtering custom field groupy by `extends_entity_column_value` is not possible via API. It is also not possible to create a custom field group via API explorer when trying to limit it by `extends_entity_column_value`, because you have no option value to select.
Reproduction steps
----------------------------------------
1. Create a new Custom Field Group via UI.
* Let it extend `Activity` and limit it to `Phone Call`
1. Try to retrieve that Custom Field Group via APIv3 or APIv4 by adding a filter on `extends_entity_column_value`
1. The field for the Option list will remain empty with a loading gif in the API Explorer
Current behaviour
----------------------------------------
``` php
\Civi\Api4\CustomGroup::get()
->addWhere('extends', '=', 'Activity')
->addWhere('extends_entity_column_value:name', '=', 'Phone Call')
->execute();
```
Returns an empty result. The value for `extends_entity_column_value` seems to get dropped in the process of executing the query.
Creating the Custom Group via API works via code or browser, by creating the request manually.
https://dmaster.demo.civicrm.org/civicrm/api4#/explorer/CustomGroup/create?values=%5B%5B%22title%22,%22Phone%20Call%20Fields%22%5D,%5B%22extends%22,%22Activity%22%5D,%5B%22extends_entity_column_value:name%22,%22Phone%20Call%22%5D%5D
There is no drop down option in the API Explorer.
``` php
\Civi\Api4\CustomGroup::create()
->addValue('title', 'Phone Call Fields')
->addValue('extends', 'Activity')
->addValue('extends_entity_column_value:name', 'Phone Call')
->execute();
```
Expected behaviour
----------------------------------------
Existing custom field groups should be filterable by `extends_entity_column_value` via API.
Environment information
----------------------------------------
* __Browser:__ _Firefox 102.2.0
* https://dmaster.demo.civicrm.org
Comments
----------------------------------------
This seems to fail both with APIv3 and APIv4.https://lab.civicrm.org/dev/core/-/issues/3865Fix css for price fields of html type Select with long labels2022-10-07T17:07:08ZyashodhaFix css for price fields of html type Select with long labelsFix css for price fields of html type Select with long labels
Currently, the option labels are long the display looks something like this
![priceset_display](/uploads/1a388f9d0a0ce1cd146945bb0724b0b9/priceset_display.png)
this is on dm...Fix css for price fields of html type Select with long labels
Currently, the option labels are long the display looks something like this
![priceset_display](/uploads/1a388f9d0a0ce1cd146945bb0724b0b9/priceset_display.png)
this is on dmaster
I propose based on the string length of the longest option we should provide the display,so it doesn't look wrapped for some options.5.55.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3864Localisation lost when upgrading to 5.53.02022-10-10T13:38:35Zthoni56Localisation lost when upgrading to 5.53.0Overview
----------------------------------------
When upgrading to 5.53.0 from 5.50 (possibly) every menu, dialogue, screen and form has reverted back to English. Only custom texts remain in Swedish (obviously).
Reproduction steps
----...Overview
----------------------------------------
When upgrading to 5.53.0 from 5.50 (possibly) every menu, dialogue, screen and form has reverted back to English. Only custom texts remain in Swedish (obviously).
Reproduction steps
----------------------------------------
Unknown
Current behaviour
----------------------------------------
As above.
Expected behaviour
----------------------------------------
All texts that have been localized to Swedish should show up in Swedish.
Environment information
----------------------------------------
Joomla 3.10, Ubuntu 20.04, Apache 2.4.41, PHP 7.4.3
Comments
----------------------------------------
After upgrade "Default Language" had been reset to English, resetting it to Swedish did not help.
Everything in the backend is in English. I have tried "follow CMS", which is in Swedish, no change.
Having mixed languages makes our site look amateurish...
![image](/uploads/1d72f3d3306812c7dfe04b0ae2222ec3/image.png)
![image](/uploads/ed9ff4bfdc2e996451f91b502f2f3b4d/image.png)https://lab.civicrm.org/dev/core/-/issues/3863Default location type for email seems to have become Billing, even if Home is...2022-09-22T12:22:51ZDaveDDefault location type for email seems to have become Billing, even if Home is set as the default.1. Go to customize - dropdown options - location types and note that Home is the default.
1. Create a new individual.
1. Note the location type for email is Billing not Home.
Ok in 5.53, not ok in 5.54.1. Go to customize - dropdown options - location types and note that Home is the default.
1. Create a new individual.
1. Note the location type for email is Billing not Home.
Ok in 5.53, not ok in 5.54.5.54.0https://lab.civicrm.org/dev/core/-/issues/3862Error when creating a message template2022-09-26T19:48:49ZDaveDError when creating a message templateSteps to reproduce
----
1. Create a message template
Expected result
----
Not this
```
CRM_Core_Exception: One of parameters (value: null) is not of the type Integer in /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Cor...Steps to reproduce
----
1. Create a message template
Expected result
----
Not this
```
CRM_Core_Exception: One of parameters (value: null) is not of the type Integer in /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/DAO.php on line 1750
Exception trace
Function Location
0 CRM_Utils_Type::validate() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/DAO.php:1750
1 CRM_Core_DAO::composeQuery() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/DAO.php:1714
2 CRM_Core_DAO::singleValueQuery() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/RecurringEntity.php:506
3 CRM_Core_BAO_RecurringEntity::getParentFor() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/RecurringEntity.php:469
4 CRM_Core_BAO_RecurringEntity::getEntitiesFor() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/RecurringEntity.php:605
5 CRM_Core_BAO_RecurringEntity::triggerUpdate() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php:264
6 Symfony\Component\EventDispatcher\EventDispatcher->doDispatch() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php:239
7 Symfony\Component\EventDispatcher\EventDispatcher->callListeners() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php:73
8 Symfony\Component\EventDispatcher\EventDispatcher->dispatch() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php:217
9 Civi\Core\CiviEventDispatcher->dispatch() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/DAO.php:660
10 CRM_Core_DAO->save() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/MessageTemplate.php:139
11 CRM_Core_BAO_MessageTemplate::add() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/Traits/DAOActionTrait.php:163
12 Civi\Api4\Generic\DAOSaveAction->write() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/Traits/DAOActionTrait.php:134
13 Civi\Api4\Generic\DAOSaveAction->writeObjects() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOSaveAction.php:38
14 Civi\Api4\Generic\DAOSaveAction->_run() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php:72
15 Civi\Api4\Provider\ActionObjectProvider->invoke() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php:149
16 Civi\API\Kernel->runRequest() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php:250
17 Civi\Api4\Generic\AbstractAction->execute() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Admin/Form/MessageTemplates.php:316
18 CRM_Admin_Form_MessageTemplates->postProcess() /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php:573
```5.54.0https://lab.civicrm.org/dev/core/-/issues/3861add message template id to sendmail function2022-09-23T02:19:02Zmagnolia61add message template id to sendmail functionOverview
----------------------------------------
In trying to use AlterMailParams I ran into this 'bug'. The MessageTemplateID is a field that is used in the email workflow functions, but when manually sending an email using a message t...Overview
----------------------------------------
In trying to use AlterMailParams I ran into this 'bug'. The MessageTemplateID is a field that is used in the email workflow functions, but when manually sending an email using a message template the ID is not passed on.
Reproduction steps
----------------------------------------
1. Send email manually to a contact using a message template
2. the message template ID is not passed from submit function to sendmail function in CRM/Contact/Form/Task/EmailTrait.php
3. AlterMailParams cannot use the message template ID for the kind of mails
Current behaviour
----------------------------------------
Message Template ID is not passed on to send email functions
Expected behaviour
----------------------------------------
Message Template ID is not passed on to send email functions
Environment information
----------------------------------------
- CiviCRM: 5.53.0
- CMS: Drupal 7.92
- PHP: 7.4.30 (fpm-fcgi)
- Database: 10.5.15-MariaDB-0+deb11u1-log engine: InnoDB 10 row format: Dynamic, Compressed
- Webserver: Apache/2.4.54 (Debian)
Comments
----------------------------------------
PR: https://github.com/civicrm/civicrm-core/pull/24583https://lab.civicrm.org/dev/core/-/issues/3860{event.location} token in scheduled reminders doesn't include supplemental lines2022-09-23T15:32:31ZDaveD{event.location} token in scheduled reminders doesn't include supplemental linesWhen composing a scheduled reminder for events there's a choice of token `{event.location}`. If your event location uses the supplemental address lines they are not included in this token.
It's the same in 5.44 so not a recent change.When composing a scheduled reminder for events there's a choice of token `{event.location}`. If your event location uses the supplemental address lines they are not included in this token.
It's the same in 5.44 so not a recent change.https://lab.civicrm.org/dev/core/-/issues/3859Participant's fee amount changes when saving the associated contribution2023-10-12T20:08:01ZJonGoldParticipant's fee amount changes when saving the associated contributionWhen someone registers multiple participants for an event, saving the contribution will change the participant's `fee_amount` for the last participant.
### Replication Steps
* Create a new paid event with online registration (let's say ...When someone registers multiple participants for an event, saving the contribution will change the participant's `fee_amount` for the last participant.
### Replication Steps
* Create a new paid event with online registration (let's say tickets are $5).
* Allow registering multiple participants.
* Register for the event with at least one additional registrant (let's assume one additional person, so $10 total).
* Look at both contact's participant records - their fee amount (on the "Events" tab) will show $5.
* Click **Edit** for the contribution record on the primary registrant and then **Save** with no changes.
### Expected Result
The fee amount on both participant records remains at $5.
### Actual Result
The fee amount on the second participant records changes to $10.
### Analysis
This happens at `CRM_Contribute_Form_Contribution::submit()` [line 1580](https://github.com/civicrm/civicrm-core/blob/76fd5a1cea97f280e24604e741dafa0dad303af5/CRM/Contribute/Form/Contribution.php#L1580).
We call `CRM_Contribute_BAO_Contribution::getComponentDetails()` which claims it "Returns all contribution related object ids" but assumes that there is only one participant (and membership) record tied to a contribution. So it returns the participant ID of the last person registered, and then at line 1611-1614, resaves the participant record with the total amount of the contribution.
### Next Steps
Line 1602 claims we are "updating the line items for participants", and I understand updating the `fee_amount` if the price changes. However, lines 1610-1614 are better out than in - they're more liable to give a wrong answer than a right one. Alternatively, we can limit it to only work on single line item contributions.
The next step would be to deprecate `CRM_Contribute_BAO_Contribution::getComponentDetails($this->_id)` since it can't handle multiple membership/participant records, and replace it with a function that does. Then we can fix the code that calls the deprecated function.
I realize none of this code should be at the form layer - but that's a much larger job.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3858Email displays twice on Contribution Confirmation/Thank-you pages2023-11-23T07:47:00ZJonGoldEmail displays twice on Contribution Confirmation/Thank-you pagesOverview
----------------------------------------
If you have a profile on your contribution page that includes an email field, the email appears twice on the Confirmation and Thank-You pages.
Reproduction steps
------------------------...Overview
----------------------------------------
If you have a profile on your contribution page that includes an email field, the email appears twice on the Confirmation and Thank-You pages.
Reproduction steps
----------------------------------------
1. Create a contribution page.
1. Add a profile to the page that contains an email.
1. Submit a contribution.
Current behaviour
----------------------------------------
![Selection_1638](/uploads/e0bfd95675953dadba161aa20e658a99/Selection_1638.png)
Expected behaviour
----------------------------------------
![Selection_1637](/uploads/9c06ec7dc2f1537c860e904ba02f76d4/Selection_1637.png)
Comments
----------------------------------------
When an email field is present in a profile, we correctly hide the email field from the main contribution page. This extends that behavior to the confirmation and thank-you.JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3857Only public custom groups should be shown in offline contribution receipts2022-10-01T01:07:07ZyashodhaOnly public custom groups should be shown in offline contribution receiptsIf a custom group is public, by definition it says : Check this box if you want this custom group to be displayed on public forms e.g. Event Information page. Only public custom groups will be included in event receipts.
But when you ha...If a custom group is public, by definition it says : Check this box if you want this custom group to be displayed on public forms e.g. Event Information page. Only public custom groups will be included in event receipts.
But when you have non public custom groups on contributions they show up in the offline receipts.5.55.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3856Discrepency in total with tax between Registration and Confirmation screen2022-09-23T14:22:14ZsamuelsovDiscrepency in total with tax between Registration and Confirmation screen# Overview
When using taxes, the total amount on the registration page of an event is not always the same as the total amount on the confirmation screen, which makes Stripe crashes.
# To reproduce
(reproduced in https://dmaster.demo.c...# Overview
When using taxes, the total amount on the registration page of an event is not always the same as the total amount on the confirmation screen, which makes Stripe crashes.
# To reproduce
(reproduced in https://dmaster.demo.civicrm.org/)
- set a financial account defining the taxes as 14.975 (i.e. Quebec taxes)
- add the taxes on one financial type
- create a price set with 1 checkboxes field with 3 options (using the taxable financial type) :
- $41.69
- $63.25
- $63.25
- create an event with this price set
When a user register on this event, on the registration page :
![ksnip_20220919-111927](/uploads/af2fa11c5cdfcae9c9f5aa79081bea99/ksnip_20220919-111927.png)
On the confirmation page :
![ksnip_20220919-112049](/uploads/9140ad148f42ae8a21d0123ed4d0efb5/ksnip_20220919-112049.png)
# Error in Stripe
For Stripe, this is a big deal because the payment is done in 2 steps and the amount must be the same, giving the following error :
```
This PaymentIntent's amount could not be updated because it has a status of requires_capture. You may only update the amount of a PaymentIntent with one of the following statuses: requires_payment_method, requires_confirmation, requires_action.
```
# Reason of the problem
My understanding so far:
- The registration page is doing a sum of all non rounded prices + taxes and do a rounding on the total.
- The confirmation page is doing the rounding on the prices and taxes and then do the sum
My preference is to have the behavior of the confirmation page. The rounding should happen on each item individually and then summed to have a total.https://lab.civicrm.org/dev/core/-/issues/3855Add membership status as a filter for scheduled reminders2023-11-23T19:06:27Zpallavi_compucoAdd membership status as a filter for scheduled reminders**Current Behaviour** : At the moment, Under Schedule Reminders(Administer->Communication->Schedule Reminders) for Memberships, there is an option to filter the memberships by the type (as shown in the screenshot attached).
![Screenshot...**Current Behaviour** : At the moment, Under Schedule Reminders(Administer->Communication->Schedule Reminders) for Memberships, there is an option to filter the memberships by the type (as shown in the screenshot attached).
![Screenshot_2022-09-19_at_7.41.00_PM](/uploads/4298414cd4f52fb03b8c1dafb0d356c5/Screenshot_2022-09-19_at_7.41.00_PM.png)
**Proposal for addition** : We would like to add another filter "Membership Status" next to membership type which will allow the Civi Admin to schedule the reminders for memberships with selected status so only the memberships having the selected status will be applicable for the scheduled reminders and will be sent an email.
The status filter will allow multiple status selection
![Screenshot_2022-09-19_at_7.41.39_PM](/uploads/b4ade89c0b04328ddbb6059447b89892/Screenshot_2022-09-19_at_7.41.39_PM.png)https://lab.civicrm.org/dev/core/-/issues/3854admin-ui extension: contact types doesn't work2022-09-20T00:04:38ZDaveDadmin-ui extension: contact types doesn't work```
TypeError: ctrl.settings is undefined
Angular 11
angular.js:15697:15
TypeError: this.settings is undefined
Angular 8
angular.js:15697:15
```
Came up while reviewing https://github.com/civicrm/civicrm-core/pull/24553 earlier....```
TypeError: ctrl.settings is undefined
Angular 11
angular.js:15697:15
TypeError: this.settings is undefined
Angular 8
angular.js:15697:15
```
Came up while reviewing https://github.com/civicrm/civicrm-core/pull/24553 earlier. It's not because of that PR.
@colemanw5.55.0https://lab.civicrm.org/dev/core/-/issues/3853Can no longer install civirules2022-09-18T14:05:21ZDaveDCan no longer install civirulesThis must be something merged yesterday, and in fact dmaster.demo and others failed to build today for the same reason.
Error is `Expected one OptionGroup but found 0 ... CRM/Civirules/Utils/OptionGroup.php(70)`This must be something merged yesterday, and in fact dmaster.demo and others failed to build today for the same reason.
Error is `Expected one OptionGroup but found 0 ... CRM/Civirules/Utils/OptionGroup.php(70)`5.55.0