Development issueshttps://lab.civicrm.org/groups/dev/-/issues2024-02-22T05:03:26Zhttps://lab.civicrm.org/dev/core/-/issues/3638Provide a fullPage property for message templates2024-02-22T05:03:26ZmfbProvide a fullPage property for message templatesIn various parts of the UI, CiviCRM allows users to send a message template either on its own, or wrapped in a header and footer.
e.g. you can send a message template to a contact.
Or, you can create a mailing based on a message templa...In various parts of the UI, CiviCRM allows users to send a message template either on its own, or wrapped in a header and footer.
e.g. you can send a message template to a contact.
Or, you can create a mailing based on a message template, with additional header and footer.
CKEditor needs different settings at civicrm/admin/ckeditor?preset=civimail re: allowed HTML tags to support these two scenarios. With fullPage = true, the HTML is forcibly wrapped with html/head/body tags, and so a message template that includes its header and footer can be composed. With fullPage = false, html/head/body are silently stripped, so this is useful for message templates that should be used with a header and footer.
However, there is only one CKEditor setting for both of these scenarios.
I would propose a new database column where we can indicate if a message template is "fullPage" - i.e. includes header and footer, or not fullPage, i.e. designed to be used with header and footer.
This would allow us to toggle the fullPage setting appropriately. It would also allow us to prevent a user from sending a message template that needs a header and footer without one, or wrapping a message template that includes its header and footer with an additional header and footer.https://lab.civicrm.org/dev/core/-/issues/864Provide a fullPage property for message templates2019-04-11T02:18:09ZmfbProvide a fullPage property for message templatesIn various parts of the UI, CiviCRM allows users to send a message template either on its own, or wrapped in a header and footer.
e.g. you can send a message template to a contact.
Or, you can create a mailing based on a message templa...In various parts of the UI, CiviCRM allows users to send a message template either on its own, or wrapped in a header and footer.
e.g. you can send a message template to a contact.
Or, you can create a mailing based on a message template, with additional header and footer.
CKEditor needs different settings at civicrm/admin/ckeditor?preset=civimail re: allowed HTML tags to support these two scenarios. With fullPage = true, the HTML is forcibly wrapped with html/head/body tags, and so a message template that includes its header and footer can be composed. With fullPage = false, html/head/body are silently stripped, so this is useful for message templates that should be used with a header and footer.
However, there is only one CKEditor setting for both of these scenarios.
I would propose a new database column where we can indicate if a message template is "fullPage" - i.e. includes header and footer, or not fullPage, i.e. designed to be used with header and footer.
This would allow us to toggle the fullPage setting appropriately. It would also allow us to prevent a user from sending a message template that needs a header and footer without one, or wrapping a message template that includes its header and footer with an additional header and footer.https://lab.civicrm.org/dev/core/-/issues/865Result filter criteria doesn't show IS NULL/IS NOT NULL for operations2019-04-15T05:32:20ZyashodhaResult filter criteria doesn't show IS NULL/IS NOT NULL for operationsWe can not search all contributions that are not associated with a campaign currently in report. We should expose IS NULL/IS NOT NULL for other operators as wellWe can not search all contributions that are not associated with a campaign currently in report. We should expose IS NULL/IS NOT NULL for other operators as well5.13.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/866Issue with importing to checkbox type fields where label is the same as datab...2021-01-28T23:07:08ZidmacdonaldIssue with importing to checkbox type fields where label is the same as database value (may affect other types too)Importing to checkbox type fields currently has some problems. This bug was originally reported here in 2015: https://issues.civicrm.org/jira/browse/CRM-17493
There is a pull request with code that seems to fix the problem:
https://gith...Importing to checkbox type fields currently has some problems. This bug was originally reported here in 2015: https://issues.civicrm.org/jira/browse/CRM-17493
There is a pull request with code that seems to fix the problem:
https://github.com/civicrm/civicrm-core/pull/9393
There were doubts about whether the code in question is still used in the latest CiviCRM versions. I can confirm that when importing contributions from a CSV file into CiviCRM 5.10.4, I ran into this bug. The code in the pull request fixed the problem.https://lab.civicrm.org/dev/core/-/issues/867Expose line item name on search2023-04-30T05:03:21ZmaduraExpose line item name on search## Problem
On Advanced Search and Find Contributions there is currently no field to search for the line items. If an admin wants to be able to search for the contacts or contributions based on line items information there is no other se...## Problem
On Advanced Search and Find Contributions there is currently no field to search for the line items. If an admin wants to be able to search for the contacts or contributions based on line items information there is no other search parameters available.
## Proposed Solution
Introduce the "line item name" field in search.
Technical Steps:
- Add a new field to contribution search form and in postprocess, handle it and add suitable where clauses using existing fields as reference.
- Add a new textfield for line item search in CRM_Contribute_BAO_Query::buildSearchForm()
- In CRM_Contribute_BAO_Query::whereClauseSingle add logic for including condition for line item name.https://lab.civicrm.org/dev/core/-/issues/868Contribution summary misleading results when filter cuts through a group2022-10-24T05:03:35ZJKingsnorthContribution summary misleading results when filter cuts through a groupWhen combining a grouping and a filter on the contribution summary report, the results are misleading. Because it cuts of donations that are before the filter, even though they are part of the group being displayed.
For example (on dmas...When combining a grouping and a filter on the contribution summary report, the results are misleading. Because it cuts of donations that are before the filter, even though they are part of the group being displayed.
For example (on dmaster):
Create a contribution on 7 Feb 2017
Create a contribution on 9 Feb 2017
(Two contributions in the same week).
Contribution summary, add a grouping by frequency: Week, view results:
![image](/uploads/9408ab7cdb3d9439ee7558ae5506a126/image.png)
Note - w/c 6 Feb 2017 has 2 donations (correct)
Add a filter for date received 'after' 8 Feb 2017, view results.
![image](/uploads/45d57dbfef1c1b83af0778933817bc09/image.png)
The contribution count is listed as 1 now.
Although this is correct in terms of the filter, it is misleading in the context of the report.
Suggestion solution:
Where a grouping (week, month, fiscalyear, anything) is 'cut' by a filter - extend the filter so that it goes to the start of that grouping. ie: in the example above, all of the values from w/c 6 Feb would still be included in the report.https://lab.civicrm.org/dev/core/-/issues/869Contribution summary report graphs do not work2020-10-07T23:51:43ZJKingsnorthContribution summary report graphs do not workWhen viewing the Contribution Summary report, with its default settings, neither of the 'graph' displays work (Bar Chart, Pie Chart):
![image](/uploads/242c9edabc604e8511114af6cc31fe3b/image.png)When viewing the Contribution Summary report, with its default settings, neither of the 'graph' displays work (Bar Chart, Pie Chart):
![image](/uploads/242c9edabc604e8511114af6cc31fe3b/image.png)https://lab.civicrm.org/dev/drupal/-/issues/54Drupal8 CiviCRM conflicts with Masquerade module2022-02-24T00:33:50ZJonGoldDrupal8 CiviCRM conflicts with Masquerade moduleReported on d.o originally by jptillman (who is on chat.c.o with the same name) in the Masquerade queue: https://www.drupal.org/project/masquerade/issues/3019665
I confirmed the same issue, and also confirmed that uninstalling CiviCRM r...Reported on d.o originally by jptillman (who is on chat.c.o with the same name) in the Masquerade queue: https://www.drupal.org/project/masquerade/issues/3019665
I confirmed the same issue, and also confirmed that uninstalling CiviCRM resolves this issue. This fits a pattern of Civi having some sort of incorrect interaction with the D8 user login - see #53, core#231, and [CRM-19878](https://issues.civicrm.org/jira/browse/CRM-19878) for other examples.5.41.0https://lab.civicrm.org/dev/financial/-/issues/51Proposal: "Administer CiviContribute" and "Administer CiviMail" permissions.2024-01-29T10:05:24ZJonGoldProposal: "Administer CiviContribute" and "Administer CiviMail" permissions.Over the years, we've added permissions such that no menu option outside of the "Administer" menu needs the "Administer CiviCRM" permission. There's a valid use case for allowing a fundraising staffer to administer contribution pages wi...Over the years, we've added permissions such that no menu option outside of the "Administer" menu needs the "Administer CiviCRM" permission. There's a valid use case for allowing a fundraising staffer to administer contribution pages without giving them access to administer all of CiviCRM, particularly in a multi-site configuration. Likewise, a communications staffer shouldn't need administrative permissions to edit headers/footers.
I ran the following SQL to identify menu items outside of the Administer menu that require Administer CiviCRM (`110` is the id for the "Administer CiviCRM" menu):
```sql
SELECT label
FROM civicrm_navigation WHERE NOT (
parent_id = 110
OR parent_id IN (SELECT id from civicrm_navigation WHERE parent_id = 110)
OR parent_id IN (SELECT id from civicrm_navigation WHERE parent_id IN (select id from civicrm_navigation WHERE parent_id = 110))
)
AND permission LIKE '%administer CiviCRM%';
```
This yields:
```
+------------------------------------------+
| label |
+------------------------------------------+
| New Contribution Page |
| Manage Contribution Pages |
| Personal Campaign Pages |
| Premiums (Thank-you Gifts) |
| New Price Set |
| Manage Price Sets |
| Personal Campaign Pages |
| Headers, Footers, and Automated Messages |
| From Email Addresses |
| New Price Set |
| Manage Price Sets |
| Developer |
| Api Explorer v3 |
| Developer Docs |
| Contact Reports |
| Api Explorer v4 |
+------------------------------------------+
```
The **Support ยป Developer** items are fine as-is.
"New Contribution Page", "Manage Contribution Pages", "Personal Campaign Pages", "Premiums", "New Price Set", and "Manage Price Sets" should all be granted under "Administer CiviContribute". "Headers, Footers and Automated Messages" and "From Email Addresses" should be granted with "Administer CiviCRM".
The only question I have is how to deal with PCPs and price sets being applicable to both events and contributions. Rather than make things overly complicated, perhaps "Administer CiviContribute" should be "Administer online payment pages" instead.
If this gets approval, I can submit the work.https://lab.civicrm.org/dev/core/-/issues/870Add pre/post hooks for price set / field/option2019-10-14T17:55:01ZyashodhaAdd pre/post hooks for price set / field/optionAdd pre/post hooks for price set/field/option.Add pre/post hooks for price set/field/option.5.18.2yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/871CIVICRM References SF ISSUE2019-04-16T16:29:51ZVirenmageCIVICRM References SF ISSUEI want to display all REFERENCES SF on front-end of login user's dashboard with contact ID in wordpress but I am unable to display REFERENCES SF.
whenever I login with admin and hit below url with php function "file_get_contents" then i...I want to display all REFERENCES SF on front-end of login user's dashboard with contact ID in wordpress but I am unable to display REFERENCES SF.
whenever I login with admin and hit below url with php function "file_get_contents" then it return data in json formate and logout from admin then it does not return any data.I think civicrm check admin login.
url : https://xyz.com/?page=CiviCRM&q=civicrm%2Fajax%2Fmultirecordfieldlist&snippet=4&cid=213&cgid=11&draw=1&columns%5B0%5D%5Bdata%5D=year_26&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=type_of_provider_27&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=country_28&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=action&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=false&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&start=0&length=25&search%5Bvalue%5D=&search%5Bregex%5D=false
I have used below code as well but I am unable to get REFERENCES SF. Please check and confirm where I am lacking and which code good to go with. Please guide me as I am stuck in it badly .
$contact_id = get_user_meta($userID, 'contact_id', true);
require_once WP_PLUGIN_DIR . '/civicrm/civicrm/api/class.api.php';
civicrm_initialize();
$result = civicrm_api3(
'Contact',
'get',
[
'sequential' => 1,
'return' => [
"custom_23",
"custom_16",
"organization_name",
"custom_17",
"email",
"phone",
"custom_29",
"custom_25",
"custom_26",
"custom_27",
"custom_24",
"custom_22",
"custom_21",
"custom_20",
"custom_19",
"custom_18",
"custom_28",
"city",
"street_address",
"address_id"
],
'id' => $contact_id,
]
);https://lab.civicrm.org/dev/core/-/issues/872New colours for menu look like a regression (shoreditch)2019-04-13T17:46:01ZeileenNew colours for menu look like a regression (shoreditch)@colemanw I deployed 5.13 on staging and with shoreditch it looks really bad. However, if I change the menu colour to white it looks OK. The default for the new setting doesn't seem to be white....
![Screen_Shot_2019-04-13_at_1.41.30_PM...@colemanw I deployed 5.13 on staging and with shoreditch it looks really bad. However, if I change the menu colour to white it looks OK. The default for the new setting doesn't seem to be white....
![Screen_Shot_2019-04-13_at_1.41.30_PM](/uploads/712fc1b5aa4b9c3b2de06bf6f469d453/Screen_Shot_2019-04-13_at_1.41.30_PM.png)https://lab.civicrm.org/dev/core/-/issues/873Mosaico A/B testing for "Subject" line2022-05-12T22:15:51ZtottenMosaico A/B testing for "Subject" line> This is catch-all issue for linking together various changes in https://github.com/veda-consulting/uk.co.vedaconsulting.mosaico/ and https://github.com/civicrm/civicrm-core.
## General goal
When composing a new mailing in Mosaico, al...> This is catch-all issue for linking together various changes in https://github.com/veda-consulting/uk.co.vedaconsulting.mosaico/ and https://github.com/civicrm/civicrm-core.
## General goal
When composing a new mailing in Mosaico, allow the user to enter multiple subject lines. Each subject will be delivered to a different set of users as part of an A/B test.
## Related documents
* [Wiki: ABn testing v2](https://wiki.civicrm.org/confluence/display/CRM/ABn+testing+v2): This is a specification developed at a previous sprint near Cologne, DE. This issue is targetting the same UI spec, and some of the data-structures anticipate the ABn v2, but it only tackles Mosaico Subject UI - not all the other requirements.
* [Gist: Mosaico A/B planning](https://gist.github.com/totten/cb4ef069b57b90eb4090b4123f5eabb6): Comparison of a few project plans (tasks, trade-offs, etc). We're pursuing A2.
## Exploratory branches
The purpose of an exploratory branch is to allow varied experimentation (tweaking multiple parts with the aim of reaching a cogent/working approach) before submitting each individual change to the full review. Exploratory branches may have frequent/unplanned changes (rebasing, squashing, more commits, etc).
There are a couple exploratory branches:
* https://github.com/totten/civicrm-core/tree/5.7-mosaico-ab-exp
* https://github.com/totten/uk.co.vedaconsulting.mosaico/tree/2.x-ab
## Pull Requests
As specific items from the exploratory changes firm up, they're submitted as full PRs.
* [14044: CiviUnitTestCase - Extract traits to facilitate extension testing](https://github.com/civicrm/civicrm-core/pull/14044)
* [14045: MailingAB - Migrate "copy winner" logic from JS to PHP](https://github.com/civicrm/civicrm-core/pull/14045)
* [14047: civi.api.prepare - Allow dynamic wrappers](https://github.com/civicrm/civicrm-core/pull/14047)https://lab.civicrm.org/dev/core/-/issues/874New Accessible Menu Color Picker display issue on Joomla2019-11-30T21:33:17ZkcristianoNew Accessible Menu Color Picker display issue on JoomlaThe Color picker appears OK on D7 and WP, But css needs tweaking on Joomla
![image](/uploads/360b6809febdf6da997632fe09cc9541/image.png)
@colemanw can you take a look?The Color picker appears OK on D7 and WP, But css needs tweaking on Joomla
![image](/uploads/360b6809febdf6da997632fe09cc9541/image.png)
@colemanw can you take a look?5.21.0https://lab.civicrm.org/dev/core/-/issues/875Accessible Menu Overlap with Pop Up forms2019-04-20T07:40:06ZkcristianoAccessible Menu Overlap with Pop Up formsMenu in below website position causes angular forms to be 'blocked' on D7 and WP
![image](/uploads/0bd37663d54ee90688d0fa88ee5a1a0e/image.png)
![image](/uploads/a42a22c7c88a5f6a6e6bf40753076f83/image.png)
But is OK on Joomla:
![image...Menu in below website position causes angular forms to be 'blocked' on D7 and WP
![image](/uploads/0bd37663d54ee90688d0fa88ee5a1a0e/image.png)
![image](/uploads/a42a22c7c88a5f6a6e6bf40753076f83/image.png)
But is OK on Joomla:
![image](/uploads/aec976ee0e759dca3429fc365bcf729f/image.png)
In Joomla Traditional position (above content) we have some overlap
![image](/uploads/51897bb0da4f39671aafb8b854b44381/image.png)
@colemanw Can you take a look?5.12.3https://lab.civicrm.org/dev/core/-/issues/876Allow url to set IS NULL/ NOT NULL in report for operations2019-04-20T01:07:19ZyashodhaAllow url to set IS NULL/ NOT NULL in report for operationsThis depends on https://lab.civicrm.org/dev/core/issues/865
Now that we allow IS NULL/ NOT NULL for filters like campaign, we should also allow the params to be passed via url.
Before
![op_before](/uploads/7c2e6230fb126eb4baf04b5a1d42de...This depends on https://lab.civicrm.org/dev/core/issues/865
Now that we allow IS NULL/ NOT NULL for filters like campaign, we should also allow the params to be passed via url.
Before
![op_before](/uploads/7c2e6230fb126eb4baf04b5a1d42de14/op_before.png)
After
![op_after](/uploads/cc88aa0e97c5f474ea76aa0bb15679c1/op_after.png)yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/877Export Multi-Value custom field result in DB error when label length is great...2023-04-24T05:03:23ZsunilExport Multi-Value custom field result in DB error when label length is greater than 255 char.custom field id xx is of multi-select (Alphanumeric) and having field length 255 char in DB.
If we choose multiple option in select field (assuming total label length is greater than 255 char).
(all multi-select option value length sum ...custom field id xx is of multi-select (Alphanumeric) and having field length 255 char in DB.
If we choose multiple option in select field (assuming total label length is greater than 255 char).
(all multi-select option value length sum come under 255 charter but label length goes beyond that.)
When we export the data, label get stored in temporary table and same get exported.
During the Export process temporary table get created in database and column data length get decided on field length of custom field. in our case it was 255 charter but label goes around 300 character. When Data length is greater than size, query get failed.
To avoid such situation we can increase custom field size from 255 char to 512 char. and code for export
need to changes, column length of temp. table will get adjusted based on custom field length.https://lab.civicrm.org/dev/core/-/issues/878Remove copyright & years from all code, except LICENSE.md etc2020-04-15T06:55:32ZxurizaemonRemove copyright & years from all code, except LICENSE.md etcI'm browsing for a small change made to a template, and I'm navigating through a bunch of NFC changes like 2a73d3b and 6b83d5b. (Clicking on those commits may even WSoD Gitlab, so here's [2a73d3b on Github](https://github.com/civicrm/civ...I'm browsing for a small change made to a template, and I'm navigating through a bunch of NFC changes like 2a73d3b and 6b83d5b. (Clicking on those commits may even WSoD Gitlab, so here's [2a73d3b on Github](https://github.com/civicrm/civicrm-core/commit/2a73d3b).)
Credit to those doing the busywork, but those changes contribute little to the software while adding noise to the commit history of every file in CiviCRM.
The commit messages are fairly inconsistent over time, so someone browsing history can't be 100% sure that any given commit is safe to ignore.
I say it's time to stop changing hundreds of^W^W [thousands of](https://github.com/civicrm/civicrm-core/commit/6b83d5) (?!) files over and over just to update the copyright & CiviCRM version.
Let's make one final commit and remove them all, removing those comments in favour of references to licensing via COPYRIGHT.md (copyright year and owner), LICENSE.md (contents of the AGPL), and https://civicrm.org/licensing instead.
No shortage of other projects demonstrating this - I don't think it's legally contentious based on the number of projects using that approach.https://lab.civicrm.org/dev/core/-/issues/879SMTP help text is misleading - references the wrong admin screen2019-09-04T01:55:36ZMichael McAndrewSMTP help text is misleading - references the wrong admin screen```php
- CRM_Core_Error::fatal(ts('The site administrator needs to enter a valid \'FROM Email Address\' in <a href="%1">Administer CiviCRM &raquo; Communications &raquo; FROM Email Addresses</a>. The email address used may need ...```php
- CRM_Core_Error::fatal(ts('The site administrator needs to enter a valid \'FROM Email Address\' in <a href="%1">Administer CiviCRM » Communications » FROM Email Addresses</a>. The email address used may need to be a valid mail account with your email service provider.', array(1 => $fixUrl)));
+ CRM_Core_Error::fatal(ts('The site administrator needs to enter a valid \'email address\' in <a href="%1">Administer CiviCRM » Communications » Organization Address and Contact Info</a>. The email address used may need to be a valid mail account with your email service provider.', array(1 => $fixUrl)));
```5.18.0https://lab.civicrm.org/dev/core/-/issues/880utf8mb4 warning keeps coming back up2019-04-24T21:47:11Zjohnkutf8mb4 warning keeps coming back upI run CiviCRM 5.12.0 on Drupal 8.6.14 with PHP 7.2.15 and Apache2. I use postgres for my Drupal database, so the databases are split.
When I upgraded to the recent version that added the Mysql utf8mb4 check (5.12, I think), at the Drupa...I run CiviCRM 5.12.0 on Drupal 8.6.14 with PHP 7.2.15 and Apache2. I use postgres for my Drupal database, so the databases are split.
When I upgraded to the recent version that added the Mysql utf8mb4 check (5.12, I think), at the Drupal status page it began showing the message: "It is recommended, though not yet required, to configure your MySQL server for utf8mb4 support. You will need the following MySQL server configuration: innodb_large_prefix=true innodb_file_format=barracuda innodb_file_per_table=true." I added this configuration to my mysqld.cnf, and then restarted and saw that the message was gone. However, when I restarted my Apache server the next time, the message came back, and I found that the civicrm_utf8mb4_test table was present in the database and needed to be dropped. From code inspection, I concluded this could only come about as a result of a race condition with civicrm-core/Civi/Install/Requirements.php, where the table is created as a non-temporary table. So I changed that code to 'CREATE TEMPORARY TABLE ...' and 'DROP TEMPORARY TABLE ...', which caused the problem to go away.
However, my attempts to capture debug_backtrace() at this point in the code have all failed. I don't understand why that is. I tried printing it to the apache error log, as well as writing it to a file in '/tmp'. I have a dev version of the site, which uses the same CiviCRM database connection, so I also have disabled this site in my Apache configuration, as it seems like it could have been a complicating factor. The bug still occurs, with that original Civi/Install/Requirements.php.5.14.0