Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-01-05T13:47:00Zhttps://lab.civicrm.org/dev/core/-/issues/482New Organization: There is no possible to add another website after deleting2019-01-05T13:47:00ZPradeep Nayakpradpnayak@gmail.comNew Organization: There is no possible to add another website after deleting1. Log in to CRM
2. Select menu item "Contacts"
3. Click submenu item "New Organization:"
4. Click "Delete" near the field "Website Type"
5. Click "Add another website"
Result: The link "Add another website" isn't work, fields for add...1. Log in to CRM
2. Select menu item "Contacts"
3. Click submenu item "New Organization:"
4. Click "Delete" near the field "Website Type"
5. Click "Add another website"
Result: The link "Add another website" isn't work, fields for adding new website isn't displayed (Link Website.png)
Note: the same on New Individual
Expected result: The link "Add another website" should adds fields for new website
![Link_Website](/uploads/1b48f4ccd156c0fd3de456b7dc00b021/Link_Website.png)https://lab.civicrm.org/dev/core/-/issues/483New Individual: Unfilled fields "Custom Email Greeting", "Custom Postal Greet...2023-11-07T05:03:22ZPradeep Nayakpradpnayak@gmail.comNew Individual: Unfilled fields "Custom Email Greeting", "Custom Postal Greeting", "Custom Addressee" are hiddenLog in to CRM
Select menu item "Contacts"
Click submenu item "New Individual"
Input the data to the fields "First Name" and "Last Name" : [Test @name__of__creator]
Open block "Communication Preferences"
Choose for fields "Email Greeting"...Log in to CRM
Select menu item "Contacts"
Click submenu item "New Individual"
Input the data to the fields "First Name" and "Last Name" : [Test @name__of__creator]
Open block "Communication Preferences"
Choose for fields "Email Greeting", "Postal Greeting" and "Addressee": Customized
Click the button "Save"
Result: The fields "Custom Email Greeting", "Custom Postal Greeting", "Custom Addressee" are hidden (see Custom.png). The fields are visible after choosing another data in the fields "Custom Email Greeting", "Custom Postal Greeting", "Custom Addressee" then choosing 'Customized'. (see custom1.png)
Note: The same for page "New Organization"
Expected result: This fields are required. The user should be warned that the fields are required.
![custom1](/uploads/8d7265787c9266bf152b82fb607fe1ee/custom1.png)
![Custom](/uploads/63f96c694e860d5bbe0188378112f973/Custom.png)https://lab.civicrm.org/dev/core/-/issues/484New Individual: All fields in the block "Address" are deleted2022-09-10T05:03:24ZPradeep Nayakpradpnayak@gmail.comNew Individual: All fields in the block "Address" are deletedLog in to CRM
Select menu item "Contacts"
Click submenu item "New Individual"
Click the button "Another Address"
Click 'Delete this address' for first address
Click 'Delete this address' for second address
Result: All fields are delete...Log in to CRM
Select menu item "Contacts"
Click submenu item "New Individual"
Click the button "Another Address"
Click 'Delete this address' for first address
Click 'Delete this address' for second address
Result: All fields are deleted (see delete_address.png)
Note: The same for page "New Organization"
Expected result: There is no possible deleted all fields
![delete_address](/uploads/1dfa921b254664f4d6febed828014f72/delete_address.png)https://lab.civicrm.org/dev/core/-/issues/485New Organization's profile: From time to time data in the field "Website" is ...2019-01-04T21:13:39ZPradeep Nayakpradpnayak@gmail.comNew Organization's profile: From time to time data in the field "Website" is deleted if nothing choose in the drop-down "Website Type"Precondition: There is an Organization with 2 website with website type
Steps to reproduce:
Log in to CRM
Go to Organization's profile
Click "Add or edit website"
Delete website type for first website
Click the button "Save"
Result: Th...Precondition: There is an Organization with 2 website with website type
Steps to reproduce:
Log in to CRM
Go to Organization's profile
Click "Add or edit website"
Delete website type for first website
Click the button "Save"
Result: The information aboute first website is deleted
Expected result: The information about the website is saved without website type
Note: The same for Individual and full editing (button Edit).https://lab.civicrm.org/dev/core/-/issues/486Track payment-processor-specific contact IDs2022-09-08T05:03:25ZElliott EgglestonTrack payment-processor-specific contact IDsPayPal, for example, has a unique 'payer_id' for each donor. We could store that in a table similar to civicrm_payment_token, with foreign keys to civicrm_contact and civicrm_payment_processor, plus a varchar 255 field for the payment_pr...PayPal, for example, has a unique 'payer_id' for each donor. We could store that in a table similar to civicrm_payment_token, with foreign keys to civicrm_contact and civicrm_payment_processor, plus a varchar 255 field for the payment_processor_contact_id.
This could assist in figuring out which contact an incoming payment is from.https://lab.civicrm.org/dev/core/-/issues/58Running the send_reminder job produces a smarty error using a HTML body2023-03-18T05:23:28ZgremblebeanRunning the send_reminder job produces a smarty error using a HTML bodyRunning the send_reminder job produces a smarty error using a HTML body. It appears Smarty is taking the raw HTML (e.g. <p> in the message from the body_html column and escaping it (e.g. &lt;p&gt;), at least in the error output. I'm not ...Running the send_reminder job produces a smarty error using a HTML body. It appears Smarty is taking the raw HTML (e.g. <p> in the message from the body_html column and escaping it (e.g. <p>), at least in the error output. I'm not sure why the tags don't just pass through. It appears the text editor has added a <p> tag at the start of the document. I'm not sure how to handle this in terms of how people might edit documents and have them successfully schedule. As it is the send_reminder process simply fails, and the only way to spot this is to check in the "scheduled jobs". Essentially any user could break send_reminder simply by adding a bit of HTML Smarty does like:
```
/usr/bin/php /var/www/my.3ca.org.uk/web/wp-content/plugins/civicrm/civicrm/bin/cli.php -s my.3ca.org.uk -u admin -p ***** -e Job -a send_reminder
PHP Warning: array_diff(): Argument #1 is not an array in /var/www/my.3ca.org.uk/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/Token.php on line 1454
PHP Warning: array_diff(): Argument #1 is not an array in /var/www/my.3ca.org.uk/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/Token.php on line 1457
PHP Fatal error: Smarty error: [in string:<p><!-- Created By Divink Ltd --><meta http-equiv="Content-Type" content="text/html; charset=utf-8" /><meta http-equiv="X-UA-Compatible" content="IE=edge" /><meta name="viewport" content="width=device-width, initial-scale=1.0 " /><meta name="format-detection" content="telephone=no" /><!--[if !mso]><!--><!--<![endif]-->
<style type="text/css">body {
margin: 0 !important;
padding: 0 !important;
-webkit-text-size-adjust: 100% !important;
-ms-text-size-adjust: 100% !important;
-webkit-font-smoothing: antialiased !important;
}
img {
border: 0 !important;
outline: none !important;
}
p {
Margin: 0px !important;
Padding: 0px !important;
}
.ExternalClass * {
line-height: 100%;
}
.em_defaultlink a {
color: inherit !important;
text-decoration: none !important;
}
span.MsoHyperlink {
mso-style-priority: 99;
color: inherit;
}
span.Mso in /var/www/my.3ca.org.uk/web/wp-content/plugins/civicrm/civicrm/packages/Smarty/Smarty.class.php on line 1100
```
Seems the release of Smarty in CiviCRM is not the latest, being 2.6.30, with the latest release being 2.6.31:
https://github.com/smarty-php/smarty/releases/tag/v2.6.31https://lab.civicrm.org/dev/core/-/issues/487Replace ancient menubar plugin with something responsive2023-09-19T00:35:47ZcolemanwReplace ancient menubar plugin with something responsiveThe current menubar jQuery plugin dates back to prehistoric times.
There have been some attempts to work around it with styling in Shoreditch and adding a hamburger menu for small screens with the [slicknav extension](https://github.com/...The current menubar jQuery plugin dates back to prehistoric times.
There have been some attempts to work around it with styling in Shoreditch and adding a hamburger menu for small screens with the [slicknav extension](https://github.com/aghstrategies/com.aghstrategies.slicknav) but IMO we need something better for core.
Plan o' action:
* [x] Create an extension implementing SmartMenus (thanks @ayduns!) https://github.com/aydun/uk.squiffle.kam
* [x] Migrate the [QuickSearch](https://civicrm.org/extensions/quicksearch) extension into core (see https://github.com/civicrm/civicrm-core/pull/13039).
* [x] Add `CRM.menubar` abstraction layer to provide a client-side api for adding/removing menu items, etc.
* [x] Fix click-to-open behavior (interaction is a bit confusing because the menubar opens on hover but closes on click)
* [x] Adjust icon spacing in the markup
* [x] Fix the CMS-specific placement issues (right margin for D7, admin region for Joomla)
* [x] Migrate the extension into Core.
* [ ] Consider bundling the extension into ESR (may not be possible due to core patches required).https://lab.civicrm.org/dev/core/-/issues/488Add in a property to addresses which describes what level of disability acces...2022-09-07T05:03:51ZseamusleeAdd in a property to addresses which describes what level of disability access is availablehttps://lab.civicrm.org/dev/core/-/issues/489Contribution reports don't show Custom Field Sets that extend Organizations o...2022-09-07T05:03:51ZguyiacContribution reports don't show Custom Field Sets that extend Organizations or HouseholdsNone of the contribution reports will show any custom field sets that are used explicitly for extending Organization or Household contact types. The same custom field set will show up if you change it in the database to extend All Contac...None of the contribution reports will show any custom field sets that are used explicitly for extending Organization or Household contact types. The same custom field set will show up if you change it in the database to extend All Contacts or Individuals.
I experienced this on a client site running CiviCRm 5.3.1 under WordPress, and tested it on the WordPress Civi master running 5.8.alpha1 at https://wpmaster.demo.civicrm.org/.https://lab.civicrm.org/dev/core/-/issues/490Contact import: -_2018-10-30T14:13:41ZAllenShawContact import: -_https://lab.civicrm.org/dev/core/-/issues/491Report results don't show inactive campaigns2019-03-13T20:07:10ZyashodhaReport results don't show inactive campaignsReport results don't show inactive campaigns. The results can be searched properly via *Find Contributions*.Report results don't show inactive campaigns. The results can be searched properly via *Find Contributions*.5.8yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/492Dedupe rule creation should display labels of contact types, in case they hav...2022-05-15T13:07:07ZJKingsnorthDedupe rule creation should display labels of contact types, in case they have been customised![image](/uploads/4b4bfac0be6bbb6d653f01a231843ba5/image.png)
The dedupe rule creation screens always use the 'hardcoded' names of the contact types, even if you have customised the labels for these in Administer > Custom data > Contact...![image](/uploads/4b4bfac0be6bbb6d653f01a231843ba5/image.png)
The dedupe rule creation screens always use the 'hardcoded' names of the contact types, even if you have customised the labels for these in Administer > Custom data > Contact types.
The change would need to be made on the listing page (https://dmaster.demo.civicrm.org/civicrm/contact/deduperules?reset=1) and the creating a rule page (https://dmaster.demo.civicrm.org/civicrm/contact/deduperules?action=add&contact_type=Individual&reset=1).
In the background it should still use the 'hardcoded' names, so that we don't regress https://issues.civicrm.org/jira/browse/CRM-21444 - but it would be nice if the correct labels appeared in the UI.5.51.0https://lab.civicrm.org/dev/core/-/issues/493Disabling "Search Primary Details Only" does not affect the menu search bar2023-02-14T05:04:05ZromainDisabling "Search Primary Details Only" does not affect the menu search barWhen I disable the setting `Search Primary Details Only` in the search preferences, secondary emails are searched when using the contact search forms (simple or advanced), but not when using the search field of the CiviCRM menu.When I disable the setting `Search Primary Details Only` in the search preferences, secondary emails are searched when using the contact search forms (simple or advanced), but not when using the search field of the CiviCRM menu.https://lab.civicrm.org/dev/core/-/issues/494New permission 'Export data'2018-11-01T00:02:09ZeileenNew permission 'Export data'Per https://issues.civicrm.org/jira/browse/CRM-16326 we have a request to be able to block some users from exporting from CiviCRM. I would like to propose a new permission 'export data' which would control the display of links to export ...Per https://issues.civicrm.org/jira/browse/CRM-16326 we have a request to be able to block some users from exporting from CiviCRM. I would like to propose a new permission 'export data' which would control the display of links to export as csv & pdf from reports & to export from searcheshttps://lab.civicrm.org/dev/core/-/issues/495CQ: Migrate simple Preferences & Settings forms to using a Generic class.2023-06-27T05:03:25ZeileenCQ: Migrate simple Preferences & Settings forms to using a Generic class.Per https://github.com/civicrm/civicrm-core/pull/13023 @mattwire & myself have recently worked on consolidating some of the setting form metadata handling. This is mostly done however our end goal is worth spelling out.
Basically the cl...Per https://github.com/civicrm/civicrm-core/pull/13023 @mattwire & myself have recently worked on consolidating some of the setting form metadata handling. This is mostly done however our end goal is worth spelling out.
Basically the class 'CRM_Admin_Form_Preferences_Event' and all classes that don't need special sauce would be removed & the xml would be altered to
```
<item>
<path>civicrm/admin/setting/preferences/event</path>
<title>CiviEvent Component Settings</title>
<page_callback>CRM_Admin_Form_Generic</page_callback>
</item>
```
This page would load settings based on filtering setting metadata - so any fields with a key in their metadata like this
```
settings_pages => [
'event' => ['weight' => 10]
]
```
would show up at the url above (note the last value on the url is the filter).
Extensions could use the existing alterSettingMetadata hook to add & remove fields from any pages that use the Generic form to choose their settings and extensions could add settings pages by just adding an xml entry & their metadata
We would convert simple forms & for more complex forms we would attempt to break the inheritance on the 2 existing forms (CRM_Admin_Form_Preferences & CRM_Admin_Form_Setting) in favour of using just the CRM_Admin_Form_SettingTrait in an attempt to grandfather them out.https://lab.civicrm.org/dev/core/-/issues/496Disable expired relationships cronjob error after deleting a contact subtype ...2023-11-01T05:03:23ZfrancescbassasDisable expired relationships cronjob error after deleting a contact subtype of a contactIt is a case quite isolated but it can happen.
If a relationship type is restricted between two contact types and one of them as a contact subtype, after a relationship is created it's possible to remove a contact subtype of a contact w...It is a case quite isolated but it can happen.
If a relationship type is restricted between two contact types and one of them as a contact subtype, after a relationship is created it's possible to remove a contact subtype of a contact without removing the existing relationship. After this, the Disable expired relationships cronjob can fail if tries to disable this relationship.
`Finished execution of Disable expired relationships with result: Error, Error message: Invalid Relationship`
throwed by https://lab.civicrm.org/dev/core/blob/5.5/CRM/Contact/BAO/Relationship.php#L68
**How to reproduce**
1. Define a relationship like:
contact subtype of relationship contact A = Student
contact subtype of relationship contact B = School
relationship type studies at / has a student
2. Create a relationship studies at between a contact Student and a contact School with end date at the past
3. Remove contact subtype for the contact Student
4. Execute Disable expired relationships cronjobhttps://lab.civicrm.org/dev/core/-/issues/497Form rendering entityRef field with api params doesn't properly handle 'IN' f...2020-05-17T13:07:46ZelilisseckForm rendering entityRef field with api params doesn't properly handle 'IN' filter when default values are setThis is a REALLY narrow issue that I experienced on 5.8.alpha1 when developing an extension that uses addEntityRef() fields in a settings form that sets default values, and the fields were filtered via API so that only valid results were...This is a REALLY narrow issue that I experienced on 5.8.alpha1 when developing an extension that uses addEntityRef() fields in a settings form that sets default values, and the fields were filtered via API so that only valid results were options. The field was added as such where $priceFieldIDs is an array of valid IDs `[1,3]` (full settings form attached - [OtherAmountSettings.php](/uploads/9e6f5a8551d1333ae39d6378169c9c8a/OtherAmountSettings.php)):
`$this->addEntityRef('other_amount_price_fields', ts('Other Amount Price Fields'), array(
'entity' => 'PriceField',
'api' => array(
'params' => array(
'id' => ['IN' => $priceFieldIDs],
),
),
'select' => array('minimumInputLength' => 0),
'multiple' => TRUE,
));`
## Current Behavior
IF there are any default values (i.e. a value was set before), all valid values appear in the field on form load. For example if I save ID 1 out of choices 1,2, & 3... the form reloads and displays IDs 1,2,3 in the form (if I save again with no changes it will set all 3 IDs that it displays).
## Desired Behavior
IF there are any default values, only the previously saved values appear in the field on form load. For example if I save ID 1 out of choice 1,2, & 3... the form reloads and displays only ID 1, so if you re-save the form without changes.. no changes will be made.
## Replication
Add an entityRef field to a form as above through an extension and using the api params and an 'IN' parameter. You can add this field to a custom settings form, or to a contribution page via hook_civicrm_buildForm (to see the behavior there, submit the form and then click 'go back'). Observe described behavior.
## Proposed Solution
PR link: https://github.com/civicrm/civicrm-core/pull/13045
I've tried a solution that seems to work well which you'll see there, but i'm not super confident in it because it's removing some lines that I don't really understand the impetus behind writing... so any discussion on that is very welcome!
https://lab.civicrm.org/dev/core/-/issues/498Undefined index in mailing report for mailing_modified_date; and room for ref...2018-12-14T23:17:06ZJKingsnorthUndefined index in mailing report for mailing_modified_date; and room for refactoringNotice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on ...Notice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on pages like: /civicrm/mailing/report?mid=7&reset=1
This is because the DAO key for the field is 'mailing_modified_date' - but the name is 'modified_date'.
And the way the field values are assigned to the object does not account for this difference.
This is a very minor issue as the modified date doesn't actually get used in the report!
We should probably refactor the query/code to only load the fields we're actually interested in; and get rid of the raw SQL in the file at the same time: https://github.com/civicrm/civicrm-core/blob/f87c35c7308fc6876e1a4fea8ac3ea908d3d9453/CRM/Mailing/BAO/Mailing.php#L18075.9https://lab.civicrm.org/dev/core/-/issues/499Custom Field Checkbox value renders empty if the values are randomly sorted2019-04-05T21:12:33ZbgmCustom Field Checkbox value renders empty if the values are randomly sortedHow to reproduce:
* Create a new Alphanumeric/Checkbox custom field
* Create new options with this specific order:
![Capture_d_écran_de_2018-11-01_14-36-36](/uploads/5f8e93a00ed763c5ec3b835de68b4ae5/Capture_d_écran_de_2018-11-01_14-36-...How to reproduce:
* Create a new Alphanumeric/Checkbox custom field
* Create new options with this specific order:
![Capture_d_écran_de_2018-11-01_14-36-36](/uploads/5f8e93a00ed763c5ec3b835de68b4ae5/Capture_d_écran_de_2018-11-01_14-36-36.png)
(Values are prefixed with '0' because back in the day, the advanced search would consider that, for example, "9" also matches "99", because of the sql query `custom_field like '%9%'`, but that's another topic.)
Result: the custom field renders empty.
![custom-fields-rendering-empty](/uploads/ba015b59f0ad1e188b9884c1d0601008/custom-fields-rendering-empty.gif)
PS: this seems related, but is not the same issue: #286 (and that issue is for 4.6)5.13.0bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/500CiviCase: dashboard summary count includes cases from inactive relationships2019-11-24T19:59:34ZbgmCiviCase: dashboard summary count includes cases from inactive relationshipsHow to reproduce:
* Create a case
* Assign it to someone, view their dashboard, it will show X cases
* Then re-assign it to someone else, view their dashboard, it will still show X cases (instead of X-1).How to reproduce:
* Create a case
* Assign it to someone, view their dashboard, it will show X cases
* Then re-assign it to someone else, view their dashboard, it will still show X cases (instead of X-1).5.11bgmbgm