Development issueshttps://lab.civicrm.org/groups/dev/-/issues2018-06-21T21:41:15Zhttps://lab.civicrm.org/dev/core/-/issues/187Fix typo in CRM_Grant_Form_Task that prevents retrieving session key from URL2018-06-21T21:41:15Zmattwiremjw@mjwconsult.co.ukFix typo in CRM_Grant_Form_Task that prevents retrieving session key from URLOverview
----------------------------------------
Identified during investigation for dev/core#158
Before
----------------------------------------
Cannot retrieve session key for Grant form task.
After
---------------------------------...Overview
----------------------------------------
Identified during investigation for dev/core#158
Before
----------------------------------------
Cannot retrieve session key for Grant form task.
After
----------------------------------------
Session key for Grant form task is retrieved just like all other tasks.
Technical Details
----------------------------------------
The wrong object was being used in static context ($this instead of $form).5.4.0https://lab.civicrm.org/dev/core/-/issues/203Cruft code in CRM_Core_BAO_OptionGroup::add()2018-06-23T02:30:00ZPradeep Nayakpradpnayak@gmail.comCruft code in CRM_Core_BAO_OptionGroup::add()PR at https://github.com/civicrm/civicrm-core/pull/12357/filesPR at https://github.com/civicrm/civicrm-core/pull/12357/files5.4.0https://lab.civicrm.org/dev/core/-/issues/96Expose source column in booking report2018-06-29T18:52:04ZyashodhaExpose source column in booking reportExpose source column in booking report and as filter as well.Expose source column in booking report and as filter as well.5.4.0yashodhayashodhahttps://lab.civicrm.org/dev/financial/-/issues/26Payment processor: Allow for a different label shown on events and contributi...2018-07-01T10:10:45ZherbdoolPayment processor: Allow for a different label shown on events and contribution pages from the backendThis is what we wish to show on contribution pages and events:
![Screenshot_from_2018-06-28_00-53-39](/uploads/b5e12fca8239df62a5a54e78d9fdea53/Screenshot_from_2018-06-28_00-53-39.png)
We'd like the ability set the label displayed to t...This is what we wish to show on contribution pages and events:
![Screenshot_from_2018-06-28_00-53-39](/uploads/b5e12fca8239df62a5a54e78d9fdea53/Screenshot_from_2018-06-28_00-53-39.png)
We'd like the ability set the label displayed to the public to something like "Pay Now", without having to change the payment processor name in the backend to the same.
Currently, we have to change the payment processor name. And if there's more than one payment processor then they may all end up with the same name.
I'm not sure of the best way, but since contribution pages and events already have a Pay Later label field then putting a Pay Now label field there might make the most sense. Though I'm not sure of the best way to handle multiple payment processors (is this common?).https://lab.civicrm.org/dev/core/-/issues/222Importing contacts with dedupe rule does not use the rule2018-07-02T20:41:13ZscardiniusImporting contacts with dedupe rule does not use the ruleImporting contacts with dedupe rule does not use the rule because of invalid call to getDuplicateContacts() method
## how to reproduce
* open *Import Contacts* page
* choose csv file with contact with name and address already exists in...Importing contacts with dedupe rule does not use the rule because of invalid call to getDuplicateContacts() method
## how to reproduce
* open *Import Contacts* page
* choose csv file with contact with name and address already exists in db
* fill the form with *Dedupu rule* = **Name and Address (reserved) - General**
* ...several steps later ;-) at the end of importing you have additional contact with the same name and address
## technical aspect
```php
// current, invalid call
$ids = CRM_Contact_BAO_Contact::getDuplicateContacts($params, $params['contact_type'], 'Unsupervised', array(), CRM_Utils_Array::value('check_permissions', $params, $dedupeRuleGroupID));
// fixed
$ids = CRM_Contact_BAO_Contact::getDuplicateContacts($params, $params['contact_type'], 'Unsupervised', array(), CRM_Utils_Array::value('check_permissions', $params), $dedupeRuleGroupID);
```5.4.0https://lab.civicrm.org/dev/core/-/issues/2275.3 beta - cannot update custom group of fields without backtrace2018-07-03T14:10:12Zjamie5.3 beta - cannot update custom group of fields without backtraceTo reproduce:
* Create a custom group that is used for Activities and don't pick any activity types.
* Don't add any fields
* Edit the settings for the custom group and select an activity type for it to apply to
Result is a back trace ...To reproduce:
* Create a custom group that is used for Activities and don't pick any activity types.
* Don't add any fields
* Edit the settings for the custom group and select an activity type for it to apply to
Result is a back trace (but the changes are saved).
This seems to be a regression from c746070e750af03108bc267ed3a583a5943c0f97.
In particular - `CRM_Core_BAO_SchemaHandler::changeUniqueToIndex` is called from line 207. is_multiple is false (I'm not entirely sure what that means) which causes CRM_Core_BAO_SchemaHandler::changeUniqueToIndex to pass $dropUnique as FALSE, which then tries to drop a foreign key that doesn't exist.
If $dropUnique is TRUE there is no backtrace.
Thanks to everyone for the amazing 5.3 work - our first bug after a week of roll outs!
jamie
```
#0 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Error.php(190): CRM_Core_Error::backtrace()
#1 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(921): CRM_Core_Error::handle(Object(DB_Error))
#2 /var/www/powerbase/sites/all/modules/civicrm/packages/DB.php(985): PEAR_Error->__construct("DB Error: not found", -4, 16, (Array:2), " ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#3 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(575): DB_Error->__construct(-4, 16, (Array:2), " ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#4 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -4, 16, (Array:2), " ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...", "DB_Error", TRUE)
#5 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/common.php(1905): PEAR->__call("raiseError", (Array:7))
#6 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/mysqli.php(933): DB_common->raiseError(-4, NULL, NULL, " ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...", "1091 ** Can't DROP 'FK_civicrm_value_proposal_info_8_entity_id'; check that c...")
#7 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/mysqli.php(403): DB_mysqli->mysqliRaiseError()
#8 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/common.php(1216): DB_mysqli->simpleQuery(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#9 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/DataObject.php(2443): DB_common->query(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#10 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/DataObject.php(1635): DB_DataObject->_query(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#11 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/DAO.php(415): DB_DataObject->query(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#12 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/DAO.php(1371): CRM_Core_DAO->query(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...", TRUE)
#13 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/BAO/SchemaHandler.php(411): CRM_Core_DAO::executeQuery(" ALTER TABLE civicrm_value_proposal_info_8\nDROP INDEX `FK_civicrm_value_prop...")
#14 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/BAO/CustomGroup.php(207): CRM_Core_BAO_SchemaHandler::changeUniqueToIndex("civicrm_value_proposal_info_8", "")
#15 /var/www/powerbase/sites/all/modules/civicrm/CRM/Custom/Form/Group.php(458): CRM_Core_BAO_CustomGroup::create((Array:16))
#16 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Form.php(466): CRM_Custom_Form_Group->postProcess()
#17 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/StateMachine.php(160): CRM_Core_Form->mainProcess()
#18 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Next.php(61): CRM_Core_StateMachine->perform(Object(CRM_Custom_Form_Group), "next", "Next")
#19 /var/www/powerbase/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Custom_Form_Group), "next")
#20 /var/www/powerbase/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Custom_Form_Group), "next")
#21 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("next")
#22 /var/www/powerbase/sites/all/modules/civicrm/CRM/Custom/Page/Group.php(172): CRM_Core_Controller->run()
#23 /var/www/powerbase/sites/all/modules/civicrm/CRM/Custom/Page/Group.php(139): CRM_Custom_Page_Group->edit("8", 2)
#24 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(309): CRM_Custom_Page_Group->run((Array:4), NULL)
#25 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:16))
#26 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#27 /var/www/powerbase/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:4))
#28 /var/www/powerbase/includes/menu.inc(527): civicrm_invoke("admin", "custom", "group")
#29 /var/www/powerbase/index.php(21): menu_execute_active_handler()
#30 {main}
```5.3.0https://lab.civicrm.org/dev/joomla/-/issues/1CiviEvent menu listing showing old events2018-07-03T22:53:01Zaydunsaidan.saunders@squiffle.ukCiviEvent menu listing showing old eventsCiviCRM 5.1.2 on Joomla 3.8.10.
Problem as reported: Trying to create a menu item for an event info page, and the drop-down in the Joomla menu manager is only displaying past events. The drop-down for the Event Registration Page shows ...CiviCRM 5.1.2 on Joomla 3.8.10.
Problem as reported: Trying to create a menu item for an event info page, and the drop-down in the Joomla menu manager is only displaying past events. The drop-down for the Event Registration Page shows the currently active and upcoming events - there are only 2 of them.
(From https://civicrm.stackexchange.com/questions/25555/civievent-menu-listing-not-finding-active-event)
Investigation: the selector for showing events filters by 'active' and shows at most 100 events, but it does not filter by date - so when there are more than 100 events, new ones are not shown.5.4.0https://lab.civicrm.org/dev/core/-/issues/229sending test email fails with: Error in call to Mailing_send_test : job_id is...2018-07-03T23:26:03Zjamiesending test email fails with: Error in call to Mailing_send_test : job_id is not valid : 440Since upgrading from 4.28 to 5.3 beta, sending a test message results in the error above and the callback documented below.
https://github.com/civicrm/civicrm-core/pull/12399
It seems that the API call to create the mailing_job is pass...Since upgrading from 4.28 to 5.3 beta, sending a test message results in the error above and the callback documented below.
https://github.com/civicrm/civicrm-core/pull/12399
It seems that the API call to create the mailing_job is passed (as the 'id' parameter) the mailing_id.
As a result, it either fails with the message above (if there is no mailing job id that matches) or worse, it overwrites an existing mailing_job row if it exists. Yipes.
My quick and dirty fix is:
```
0 jamie@turkey:civicrm$ diff -u api/v3/Mailing.php.orig api/v3/Mailing.php
--- api/v3/Mailing.php.orig 2018-07-02 15:32:28.317320362 -0400
+++ api/v3/Mailing.php 2018-07-02 15:32:48.988913106 -0400
@@ -620,6 +620,7 @@
);
$testEmailParams = _civicrm_api3_generic_replace_base_params($params);
+ unset($testEmailParams['id']);
$testEmailParams['is_test'] = 1;
$testEmailParams['status'] = 'Scheduled';
$testEmailParams['scheduled_date'] = CRM_Utils_Date::processDate(date('Y-m-d'), date('H:i:s'));
1 jamie@turkey:civicrm$
```
But since that code has not changed much recently I suspect a breaking change may have happened else where.
```
Jul 02 15:23:35 [info] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => exceptionHandler
)
[code] => -3
[message] => DB Error: constraint violation
[mode] => 16
[debug_info] => INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , hash ) VALUES ( 440 , 8326 , 8138 , 'f48d1f63168a98f3' ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`southernvision`.`civicrm_mailing_event_queue`, CONSTRAINT `FK_civicrm_mailing_event_queue_job_id` FOREIGN KEY (`job_id`) REFERENCES `civicrm_mailing_job` (`id`) ON DELETE CASCADE)]
[type] => DB_Error
[user_info] => INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , hash ) VALUES ( 440 , 8326 , 8138 , 'f48d1f63168a98f3' ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`southernvision`.`civicrm_mailing_event_queue`, CONSTRAINT `FK_civicrm_mailing_event_queue_job_id` FOREIGN KEY (`job_id`) REFERENCES `civicrm_mailing_job` (`id`) ON DELETE CASCADE)]
[to_string] => [db_error: message="DB Error: constraint violation" code=-3 mode=callback callback=CRM_Core_Error::exceptionHandler prefix="" info="INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , hash ) VALUES ( 440 , 8326 , 8138 , 'f48d1f63168a98f3' ) [nativecode=1452 ** Cannot add or update a child row: a foreign key constraint fails (`southernvision`.`civicrm_mailing_event_queue`, CONSTRAINT `FK_civicrm_mailing_event_queue_job_id` FOREIGN KEY (`job_id`) REFERENCES `civicrm_mailing_job` (`id`) ON DELETE CASCADE)]"]
)
Jul 02 15:23:35 [info] $backTrace = #0 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Error.php(948): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(921): CRM_Core_Error::exceptionHandler(Object(DB_Error))
#2 /var/www/powerbase/sites/all/modules/civicrm/packages/DB.php(985): PEAR_Error->__construct("DB Error: constraint violation", -3, 16, (Array:2), "INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...")
#3 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(575): DB_Error->__construct(-3, 16, (Array:2), "INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...")
#4 /var/www/powerbase/sites/all/modules/civicrm/packages/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -3, 16, (Array:2), "INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...", "DB_Error", TRUE)
#5 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/common.php(1905): PEAR->__call("raiseError", (Array:7))
#6 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/mysqli.php(933): DB_common->raiseError(-3, NULL, NULL, "INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...", "1452 ** Cannot add or update a child row: a foreign key constraint fails (`so...")
#7 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/mysqli.php(403): DB_mysqli->mysqliRaiseError()
#8 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/common.php(1216): DB_mysqli->simpleQuery("INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...")
#9 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/DataObject.php(2443): DB_common->query("INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...")
#10 /var/www/powerbase/sites/all/modules/civicrm/packages/DB/DataObject.php(1068): DB_DataObject->_query("INSERT INTO civicrm_mailing_event_queue (job_id , email_id , contact_id , has...")
#11 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/DAO.php(548): DB_DataObject->insert()
#12 /var/www/powerbase/sites/all/modules/civicrm/CRM/Mailing/Event/BAO/Queue.php(57): CRM_Core_DAO->save()
#13 /var/www/powerbase/sites/all/modules/civicrm/api/v3/utils.php(1288): CRM_Mailing_Event_BAO_Queue::create((Array:4), (Array:1))
#14 /var/www/powerbase/sites/all/modules/civicrm/api/v3/MailingEventQueue.php(53): _civicrm_api3_basic_create("CRM_Mailing_Event_BAO_Queue", (Array:4), "Queue")
#15 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_event_queue_create((Array:4))
#16 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(169): Civi\API\Provider\MagicFunctionProvider->invoke((Array:9))
#17 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(100): Civi\API\Kernel->runRequest((Array:9))
#18 /var/www/powerbase/sites/all/modules/civicrm/api/api.php(43): Civi\API\Kernel->runSafe("MailingEventQueue", "create", (Array:4))
#19 /var/www/powerbase/sites/all/modules/civicrm/api/v3/Mailing.php(679): civicrm_api3("MailingEventQueue", "create", (Array:4))
#20 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_mailing_send_test((Array:10))
#21 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(169): Civi\API\Provider\MagicFunctionProvider->invoke((Array:9))
#22 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(100): Civi\API\Kernel->runRequest((Array:9))
#23 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(77): Civi\API\Kernel->runSafe("mailing", "send_test", (Array:10), NULL)
#24 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Subscriber/ChainSubscriber.php(211): Civi\API\Kernel->run("mailing", "send_test", (Array:10))
#25 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Subscriber/ChainSubscriber.php(73): Civi\API\Subscriber\ChainSubscriber->callNestedApi(Object(Civi\API\Kernel), (Array:35), (Array:5), "create", "Mailing", 3)
#26 [internal function](): Civi\API\Subscriber\ChainSubscriber->onApiRespond(Object(Civi\API\Event\RespondEvent), "civi.api.respond", Object(Civi\Core\CiviEventDispatcher))
#27 /var/www/powerbase/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php(164): call_user_func((Array:2), Object(Civi\API\Event\RespondEvent), "civi.api.respond", Object(Civi\Core\CiviEventDispatcher))
#28 /var/www/powerbase/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php(53): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch((Array:4), "civi.api.respond", Object(Civi\API\Event\RespondEvent))
#29 /var/www/powerbase/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/ContainerAwareEventDispatcher.php(167): Symfony\Component\EventDispatcher\EventDispatcher->dispatch("civi.api.respond", Object(Civi\API\Event\RespondEvent))
#30 /var/www/powerbase/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php(47): Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch("civi.api.respond", Object(Civi\API\Event\RespondEvent))
#31 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(276): Civi\Core\CiviEventDispatcher->dispatch("civi.api.respond", Object(Civi\API\Event\RespondEvent))
#32 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(171): Civi\API\Kernel->respond(Object(Civi\API\Provider\MagicFunctionProvider), (Array:9), (Array:5))
#33 /var/www/powerbase/sites/all/modules/civicrm/Civi/API/Kernel.php(100): Civi\API\Kernel->runRequest((Array:9))
#34 /var/www/powerbase/sites/all/modules/civicrm/api/api.php(23): Civi\API\Kernel->runSafe("Mailing", "create", (Array:35), NULL)
#35 /var/www/powerbase/sites/all/modules/civicrm/CRM/Utils/REST.php(311): civicrm_api("Mailing", "create", (Array:35))
#36 /var/www/powerbase/sites/all/modules/civicrm/CRM/Utils/REST.php(548): CRM_Utils_REST::process((Array:3), (Array:35))
#37 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(275): CRM_Utils_REST::ajax()
#38 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:12))
#39 /var/www/powerbase/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:3))
#40 /var/www/powerbase/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:3))
#41 /var/www/powerbase/includes/menu.inc(527): civicrm_invoke("ajax", "rest")
#42 /var/www/powerbase/index.php(21): menu_execute_active_handler()
#43 {main}
```5.3.0https://lab.civicrm.org/dev/core/-/issues/211Update to payment instrument shows incorrect type(a/c) for all transaction2018-07-04T15:06:09ZPradeep Nayakpradpnayak@gmail.comUpdate to payment instrument shows incorrect type(a/c) for all transaction**To replicate:**
* Create completed contribution with payment method as 'Check' using New contribution form.
* Change the payment method from Check to cash for above contribution using edit contribution form.
**Civi version:** 5.2.1
...**To replicate:**
* Create completed contribution with payment method as 'Check' using New contribution form.
* Change the payment method from Check to cash for above contribution using edit contribution form.
**Civi version:** 5.2.1
**CMS:** Drupal 7.59
![Under_contribution_tab](/uploads/64798523fc9d2032b6182f08fb4efa5b/Under_contribution_tab.png)
![bookkeeping_report](/uploads/a485a6085c3ec368a011037abaf12ba7/bookkeeping_report.png)
**Civi version:** 4.7.12
**CMS:** Drupal 7.59
![Bookkeeping_report](/uploads/88482694f125cc46bec0223c5b6e14c9/Bookkeeping_report.png)
![Contribution_tab](/uploads/66c8bf22e294e11cfaa17ca50724419c/Contribution_tab.png)5.3.0https://lab.civicrm.org/dev/core/-/issues/212Contribution Details report fails when "Is not one of" condition is used for ...2018-07-05T23:11:11ZscardiniusContribution Details report fails when "Is not one of" condition is used for Groups field# how to reproduce
* run CiviCRM 5.1.2
* open Report > Contribution Reports > Contribution Details
* click on Filters tab
* scroll down to Groups field
* change condition to "Is not one of"
* choose at least one group
* click Refresh re...# how to reproduce
* run CiviCRM 5.1.2
* open Report > Contribution Reports > Contribution Details
* click on Filters tab
* scroll down to Groups field
* change condition to "Is not one of"
* choose at least one group
* click Refresh results
* result: DB Error: no such field
# sql
sql error `Unknown column 'group_temp_table.id' in 'where clause'`
```
[db_error: message="DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="
CREATE TEMPORARY TABLE civireport_contribution_detail_temp2 DEFAULT
CHARACTER SET utf8 COLLATE utf8_unicode_ci AS SELECT SQL_CALC_FOUND_ROWS contact_civireport.sort_name as civicrm_contact_sort_name, contact_civireport.id as civicrm_contact_id, email_civireport.email as c
ivicrm_email_email, phone_civireport.phone as civicrm_phone_phone, contribution_civireport.id as civicrm_contribution_contribution_id, contribution_civireport.financial_type_id as civicrm_contribution_fin
ancial_type_id, contribution_civireport.currency as civicrm_contribution_currency, contribution_civireport.receive_date as civicrm_contribution_receive_date, contribution_soft_civireport.amount as civicrm
_contribution_total_amount, 'Soft Credit' as civicrm_contribution_contribution_or_soft, address_civireport.country_id as civicrm_address_country_id
FROM civireport_contribution_detail_temp1 temp1_civireport
INNER JOIN civicrm_contribution contribution_civireport
ON temp1_civireport.civicrm_contribution_contribution_id = contribution_civireport.id
INNER JOIN civicrm_contribution_soft contribution_soft_civireport
ON contribution_soft_civireport.contribution_id = contribution_civireport.id
INNER JOIN civicrm_contact contact_civireport
ON contact_civireport.id = contribution_soft_civireport.contact_id
LEFT JOIN civicrm_phone phone_civireport
ON (contact_civireport.id =
phone_civireport.contact_id) AND
phone_civireport.is_primary = 1
LEFT JOIN civicrm_address address_civireport
ON (contact_civireport.id =
address_civireport.contact_id) AND
address_civireport.is_primary = 1
LEFT JOIN civicrm_email email_civireport
ON contact_civireport.id = email_civireport.contact_id AND
email_civireport.is_primary = 1
WHERE (1) AND ( contribution_civireport.contribution_status_id IN (1) )
AND group_temp_table.id IS NULL
GROUP BY contact_civireport.id, contribution_civireport.id
[nativecode=1054 ** Unknown column 'group_temp_table.id' in 'where clause']"
]
```5.5.0https://lab.civicrm.org/dev/core/-/issues/239Huge title dialog box on hovering form element on Event's configuration backe...2018-07-06T22:11:10ZMonish DebHuge title dialog box on hovering form element on Event's configuration backend formSteps to replicate:
1. Go to 'Manage Event' page
2. Click on 'Online Registration' of any existing/new event configuration page.
3. Hover on any helpicon
![test-multiple-after](/uploads/06a04ef0f58d2b69e78846c93d14a467/test-multiple-afte...Steps to replicate:
1. Go to 'Manage Event' page
2. Click on 'Online Registration' of any existing/new event configuration page.
3. Hover on any helpicon
![test-multiple-after](/uploads/06a04ef0f58d2b69e78846c93d14a467/test-multiple-after.gif)5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/176Odd / Even street number sorting column missing from Reports2018-07-06T22:11:10Zjoels341Odd / Even street number sorting column missing from ReportsWhen trying to make a walk list in reports (odd/even street numbers), there is no option to sort by odd or even. I am using Civicrm in English on Joomla.
The French demo on Drupal has "Numéro de rue pair/impair" in the "column" dropdown...When trying to make a walk list in reports (odd/even street numbers), there is no option to sort by odd or even. I am using Civicrm in English on Joomla.
The French demo on Drupal has "Numéro de rue pair/impair" in the "column" dropdown, but I do not see it in the English version.![street-number](/uploads/f74556e4b99a646ee3aa1c9fdaacd96c/street-number.jpg)5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/243Backdrop authentication function missing in kcfinder package.2018-07-08T00:13:43ZherbdoolBackdrop authentication function missing in kcfinder package.Reported here https://civicrm.stackexchange.com/questions/25619/backdrop-authentication-function-missing.
It might be possible to update it to use the Drupal authentication function since Backdrop is similar enough. But this needs testing.Reported here https://civicrm.stackexchange.com/questions/25619/backdrop-authentication-function-missing.
It might be possible to update it to use the Drupal authentication function since Backdrop is similar enough. But this needs testing.5.5.0https://lab.civicrm.org/dev/core/-/issues/218On Case Type listing page, for reserved ones the, 'More' link doesn't show an...2018-07-09T22:42:08ZMonish DebOn Case Type listing page, for reserved ones the, 'More' link doesn't show any optionsSteps to replicate:
1. Enable CiviCase component.
2. Go to Administer >> CiviCase >> Case Types
3. Click on 'More' action against any reserved Case type
![test-multiple-before](/uploads/c14d32b041c69c2b9c1941615214d1ac/test-multiple-befo...Steps to replicate:
1. Enable CiviCase component.
2. Go to Administer >> CiviCase >> Case Types
3. Click on 'More' action against any reserved Case type
![test-multiple-before](/uploads/c14d32b041c69c2b9c1941615214d1ac/test-multiple-before.gif)
**Proposal**:
Show the 'More' action only when
1. the case type is not reserved because then you have 'Delete' and Enable/Disable action OR
2. If case-type is reserved then show the more action only if the case-type is forked and/or disable, because then you got 'Revert' and/or 'Enable' option to show5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/financial/-/issues/21Invoice Address blocks is missing country2018-07-10T11:09:34ZmvuInvoice Address blocks is missing countryWhen downloading invoice in the latest version, it is missing the country in the from-address block, see attached sample
[INV_16.pdf](/uploads/27ba68f60955365957a907c3fe342a2a/INV_16.pdf).
I have checked the following:
* Country field...When downloading invoice in the latest version, it is missing the country in the from-address block, see attached sample
[INV_16.pdf](/uploads/27ba68f60955365957a907c3fe342a2a/INV_16.pdf).
I have checked the following:
* Country field filled in contact record - yes
* Address block is set to billing - yes
* Message template - there is no $country added, but when I try to add it, it still doesn't render the country of the contact.
Have checked on latest 5.x and traced back up to 4.6.x and the issue is there, can you let us know how to proceed?https://lab.civicrm.org/dev/core/-/issues/228Option group disabled on update2018-07-11T00:47:58ZajesamsonOption group disabled on updateWhen updating option group attributes (excluding `is_active`), the updated option group gets disabled. This is because option group was [defaulted](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/OptionGroup.php#L95) to ...When updating option group attributes (excluding `is_active`), the updated option group gets disabled. This is because option group was [defaulted](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/OptionGroup.php#L95) to `FALSE` when adding or updating record without specifying desired `is_active` status.
![option_group](/uploads/d8291f18e46149d5852335749ca473e3/option_group.gif)
The desired result would have been leaving the `is_active` status untouched, if not required to be updated during attributes update.5.5.0https://lab.civicrm.org/dev/core/-/issues/250fatal error after upgrade to 5.3 when not using paypal2018-07-11T04:28:00Zericgfatal error after upgrade to 5.3 when not using paypalas detailed here: https://civicrm.stackexchange.com/questions/25648/error-on-upgrade-to-5-3
on a site that has never used paypal, but has multiple authorizenet processors setup, after upgrade from 4.7.31 to 5.3, all civi pages throw fat...as detailed here: https://civicrm.stackexchange.com/questions/25648/error-on-upgrade-to-5-3
on a site that has never used paypal, but has multiple authorizenet processors setup, after upgrade from 4.7.31 to 5.3, all civi pages throw fatal errors because no paypal processor is defined.
Civi\Payment\Exception\PaymentProcessorException: CRM_Core_Payment_PayPalImpl: Payment processor type is not defined! in CRM_Core_Payment_PayPalImpl->__construct() (line 73 of /var/www/xxxxxx/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php).
when I comment out line 73, everything works. it seems that the isPayPalType function needs to be aware of possible non-paypal processors?https://lab.civicrm.org/dev/core/-/issues/246Avoid overwrite only first field with last value for fields with multiple values2018-07-11T17:47:38Zbeto_aveigaAvoid overwrite only first field with last value for fields with multiple valuesOverview
----------------------------------------
Webforms with multiple emails values are not being saved correctly. The last submitted value is written to the first email field. Other emails are not being updated.
Before
-------------...Overview
----------------------------------------
Webforms with multiple emails values are not being saved correctly. The last submitted value is written to the first email field. Other emails are not being updated.
Before
----------------------------------------
1. Data before submission
![image](https://user-images.githubusercontent.com/3916979/42423357-8901cb6a-82be-11e8-9f86-78b79e039f5d.png)
2. Example configuration of the webform
![image](https://user-images.githubusercontent.com/3916979/42423359-8e547efa-82be-11e8-947a-b467b056601a.png)
3. Data when visiting the webform
![image](https://user-images.githubusercontent.com/3916979/42423367-a24b8d18-82be-11e8-8b4a-0f1a183e9459.png)
4. Filling the webform with a second email
![image](https://user-images.githubusercontent.com/3916979/42423370-a7b84b42-82be-11e8-9862-81b010feec5d.png)
5. Visiting the webform again we can see that first email was overwritten with last email
![image](https://user-images.githubusercontent.com/3916979/42423373-ad120d12-82be-11e8-8d89-a76c2d70fbf9.png)
6. From the Admin UI it confirms what the webform was showing: first email overwritten with last email.
![image](https://user-images.githubusercontent.com/3916979/42423375-b2dea9c6-82be-11e8-9d54-96b4ff2c9af2.png)
After
----------------------------------------
1. Repeat steps 1 to 4 from "Before" for initial data, filling the webform and saving.
2. Data was stored correctly.
![image](https://user-images.githubusercontent.com/3916979/42423592-4475a77e-82c2-11e8-8edc-652a4be23a69.png)
Technical Details
----------------------------------------
- Attaching exported webform with node export:
[webform-multiple-emails.txt](https://github.com/colemanw/webform_civicrm/files/2174088/webform-multiple-emails.txt)
- Site created for testing with civibuild using this command
`civibuild create civi12 --type drupal-demo --civi-ver 4.7.27 --url http://civi12 --web-root /home/beto/buildkit/build/civi12`
- CiviCRM currently uses civicrm_webform 7.20, however this module was replaced with the last version found here https://github.com/colemanw/webform_civicrm
Comments
----------------------------------------
Base on the modifed code (shown below) this is probably not only applicable to emails but for fields which are not addresses.
![image](https://user-images.githubusercontent.com/3916979/42423678-ea5e5ec8-82c3-11e8-9fe7-8fe4365f1077.png)
https://lab.civicrm.org/dev/core/-/issues/108unable to create new event location without impacting other events2018-07-12T14:34:52Zlcdwebunable to create new event location without impacting other eventsto reproduce this issue:
* create an event. on the location tab, create a new location with the street address "test address 1"
* return to the manage event screen. click more > copy to copy the newly created event
* select the location...to reproduce this issue:
* create an event. on the location tab, create a new location with the street address "test address 1"
* return to the manage event screen. click more > copy to copy the newly created event
* select the location tab -- it will already have "test address 1" selected. click the option to "create new location" and add a street address "test address 2". save the event.
* return to the event management screen and click configure > location for the first event. note that the address now references "test address 2"
you should be able to create a new location for an event and it should have no effect on existing events that previously shared the location.lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/249Contact Export fails in 5.4 when trying to export using the All radio button2018-07-12T22:29:35ZseamusleeContact Export fails in 5.4 when trying to export using the All radio buttonAs per https://chat.civicrm.org/civicrm/pl/a8myronnftgt8mcehfa8ohcnbo when using the all contacts radio button to do an export the export fails in 5.4As per https://chat.civicrm.org/civicrm/pl/a8myronnftgt8mcehfa8ohcnbo when using the all contacts radio button to do an export the export fails in 5.45.4.0