Development issueshttps://lab.civicrm.org/groups/dev/-/issues2023-11-15T18:37:43Zhttps://lab.civicrm.org/dev/financial/-/issues/220With tax enabled Total Amount is confusing in online receipt and tax amount l...2023-11-15T18:37:43ZDaveDWith tax enabled Total Amount is confusing in online receipt and tax amount line is wrongIt used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/i...It used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/issues/206 just in the interim changes have caused the problem to shift.
Also the confirm and thankyou pages make no mention of the tax and there's now a php warning about a missing tax var on those pages.
![untitled7](/uploads/8fcb99238d074a7dd4a53ec000bf51b1/untitled7.png)
![untitled8](/uploads/ebb164e557d99a76bb0f90381b0525c9/untitled8.png)
One way to reproduce:
1. Turn on tax and invoicing. https://docs.civicrm.org/user/en/latest/contributions/sales-tax-and-vat/
* In my case I set up a non-deductible financial type called t-shirts and a corresponding sales tax account that has 5% tax.
2. Create a price set for it.
* There's one price field. I used type text/quantity. Field is required although that's not relevant just makes sense here. Financial type t-shirts.
3. Set up the dummy payment processor.
4. Create a contribution page with that processor and financial type t-shirts and use the price set. Set it to send a receipt.
5. Buy a t-shirt.5.68.0https://lab.civicrm.org/dev/core/-/issues/4758[PHP 8.0] Curly brace syntax for accessing array elements2023-11-08T16:24:07Zjofranzfranz@systopia.de[PHP 8.0] Curly brace syntax for accessing array elements```
FILE: civicrm-core/tools/extensions/org.civicrm.angularex/angularex.civix.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------...```
FILE: civicrm-core/tools/extensions/org.civicrm.angularex/angularex.civix.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
247 | ERROR | [x] Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4 and removed in PHP 8.0. Found: $entry{0}
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------
``5.69.0https://lab.civicrm.org/dev/core/-/issues/4757[PHP 8.2] Using ${var} in strings is deprecated2023-11-08T02:24:46Zjofranzfranz@systopia.de[PHP 8.2] Using ${var} in strings is deprecated```
FILE: civicrm-core/CRM/Profile/Selector/Listings.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------...```
FILE: civicrm-core/CRM/Profile/Selector/Listings.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
601 | WARNING | Using ${var} in strings is deprecated since PHP 8.2, use {$var} instead. Found: ${typeName}
-------------------------------------------------------------------------------------------------------------
```5.69.0https://lab.civicrm.org/dev/core/-/issues/4756CV crashes if LoginSecurity extension is enabled on Drupal8/9/102023-11-08T00:49:16ZufundoCV crashes if LoginSecurity extension is enabled on Drupal8/9/10Any cv call crashes if the [LoginSecurity](https://lab.civicrm.org/extensions/loginsecurity/-/issues) extension is enabled on D8+.
```
civicrm@c307847fd84a:/var/www/html$ cv -vvv vars:show
... [all looks good until] ...
[Bootstrap:no...Any cv call crashes if the [LoginSecurity](https://lab.civicrm.org/extensions/loginsecurity/-/issues) extension is enabled on D8+.
```
civicrm@c307847fd84a:/var/www/html$ cv -vvv vars:show
... [all looks good until] ...
[Bootstrap:notice] Call core bootstrap
In Drupal.php line 169:
[Drupal\Core\DependencyInjection\ContainerNotInitializedException]
\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.
Exception trace:
at /var/www/html/web/core/lib/Drupal.php:169
Drupal::getContainer() at /var/www/html/web/core/lib/Drupal.php:267
Drupal::request() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/System/Drupal8.php:945
CRM_Utils_System_Drupal8->ipAddress() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/System.php:1292
CRM_Utils_System::ipAddress() at /var/www/html/web/modules/civicrm/ext/loginsecurity/CRM/Loginsecurity/BAO/LoginSecurityDevice.php:37
CRM_Loginsecurity_BAO_LoginSecurityDevice::logCurrentSession() at /var/www/html/web/modules/civicrm/ext/loginsecurity/loginsecurity.php:16
loginsecurity_civicrm_config() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/Hook.php:272
CRM_Utils_Hook->runHooks() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/Hook/DrupalBase.php:73
CRM_Utils_Hook_DrupalBase->invokeViaUF() at /var/www/html/vendor/civicrm/civicrm-core/Civi/Core/CiviEventDispatcher.php:310
Civi\Core\CiviEventDispatcher::delegateToUF() at /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:220
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() at /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:56
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() at /var/www/html/vendor/civicrm/civicrm-core/Civi/Core/CiviEventDispatcher.php:263
Civi\Core\CiviEventDispatcher->dispatch() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/Hook.php:168
CRM_Utils_Hook->invoke() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Utils/Hook.php:1440
CRM_Utils_Hook::config() at /var/www/html/vendor/civicrm/civicrm-core/CRM/Core/Config.php:94
CRM_Core_Config::singleton() at phar:///usr/local/bin/cv/lib/src/Bootstrap.php:97
Civi\Cv\Bootstrap->boot() at phar:///usr/local/bin/cv/lib/src/Util/BootTrait.php:73
Civi\Cv\Command\ShowCommand->_boot_full() at phar:///usr/local/bin/cv/lib/src/Util/BootTrait.php:47
Civi\Cv\Command\ShowCommand->boot() at phar:///usr/local/bin/cv/src/Command/ShowCommand.php:21
Civi\Cv\Command\ShowCommand->execute() at phar:///usr/local/bin/cv/vendor/symfony/console/Command/Command.php:127
Cvphar\Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:637
Cvphar\Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:190
Cvphar\Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/cv/src/Application.php:67
Civi\Cv\Application->doRun() at phar:///usr/local/bin/cv/vendor/symfony/console/Application.php:101
Cvphar\Symfony\Component\Console\Application->run() at phar:///usr/local/bin/cv/src/Application.php:33
Civi\Cv\Application::main() at phar:///usr/local/bin/cv/bin/cv:28
require() at /usr/local/bin/cv:14
```
It looks to me like the extension is trying to call the `CRM_Utils_System::ipAddress()` function before the Drupal container is ready.
And that something like https://lab.civicrm.org/dev/core/-/commit/5e383d9d992335f2f6e743c3e1f3d0ce1b175ab9 should fix it?5.69.0https://lab.civicrm.org/dev/core/-/issues/4752Notice: Undefined index: weight in CRM_Core_Action::{closure}()2023-11-10T13:56:37ZRobert J. LangNotice: Undefined index: weight in CRM_Core_Action::{closure}()Overview
----------------------------------------
The dblog is filling up with errors with this message:
Notice: Undefined index: weight in CRM_Core_Action::{closure}() (line 317 of /mysite/modules/contrib/civicrm/CRM/Core/Action.php).
...Overview
----------------------------------------
The dblog is filling up with errors with this message:
Notice: Undefined index: weight in CRM_Core_Action::{closure}() (line 317 of /mysite/modules/contrib/civicrm/CRM/Core/Action.php).
Reproduction steps
----------------------------------------
I can reproduce this on my site by visiting any contact tab (not just 1195):
https://mysite.org/civicrm/contact/view?reset=1&cid=1195&selectedChild=mailing
Current behaviour
----------------------------------------
The dblog fills up with something like 20 (the number varies) instances of a PHP notice:
Message: Notice: Undefined index: weight in CRM_Core_Action::{closure}() (line 317 of /mysite/modules/contrib/civicrm/CRM/Core/Action.php).
Location: https://mysite.org/civicrm/ajax/contactmailing?contact_id=1195&draw=1&columns%5B0%5D%5Bdata%5D=subject&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=creator_name&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=recipients&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=false&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=start_date&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=true&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=openstats&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=true&columns%5B4%5D%5Borderable%5D=false&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=links&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=true&columns%5B5%5D%5Borderable%5D=false&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&start=0&length=25&search%5Bvalue%5D=&search%5Bregex%5D=false&_=1699213951856
Referrer: https://mysite.org/civicrm/contact/view?reset=1&cid=1195&selectedChild=mailing
Expected behaviour
----------------------------------------
No dblog entries.
Environment information
----------------------------------------
* __Browser:__ Safari (Desktop)
* __CiviCRM:__ 5.67.0
* __PHP:__ 7.4.31
* __CMS:__ Backdrop 1.26.1
Comments
----------------------------------------
The relevant code is:
```
usort($seqLinks, static function ($a, $b) {
return (int) ((int) ($a['weight']) > (int) ($b['weight']));
});
```
Seems like it should perhaps be
```
usort($seqLinks, static function ($a, $b) {
return (int) ((int) ($a['weight'] ?? 0) > (int) ($b['weight'] ?? 0));
});
```5.67.1https://lab.civicrm.org/dev/core/-/issues/4750clear cache does not reliably remove durable temp tables2023-11-04T16:45:03Zlcdwebclear cache does not reliably remove durable temp tablesDurable (civicrm_tmp_d%) temp tables are intended for use when the table must be used in multiple transactions and therefore cannot be a true MySQL temp table. These should be cleared out when the clean cache function is triggered from t...Durable (civicrm_tmp_d%) temp tables are intended for use when the table must be used in multiple transactions and therefore cannot be a true MySQL temp table. These should be cleared out when the clean cache function is triggered from the UI, scheduled jobs, or CLI -- with a few exceptions for those created within the last two days or that are tied to the civicrm_user_job table. Currently there is faulty logic that causes them to persist much longer than necessary, thus cluttering the DB.lcdweblcdwebhttps://lab.civicrm.org/dev/financial/-/issues/219the Price Set labels are showing html2023-11-02T00:23:16ZJoeMurraythe Price Set labels are showing htmlDmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)Dmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)5.68.0eileeneileenhttps://lab.civicrm.org/dev/core/-/issues/4742[PHP 8.1] CRM_Admin_Form_Generic warnings2023-10-31T20:38:36Zjofranzfranz@systopia.de[PHP 8.1] CRM_Admin_Form_Generic warnings## Having
- CiviCRM 5.66.2
- Drupal 10.1.5
- PHP 8.1
## Visiting
- `.../admin/config/development/logging` to enable logs in UI
- `.../civicrm/admin/setting/theisland`
## Expecting
No erros
## Seeing
```
Warning: Undefined array key ...## Having
- CiviCRM 5.66.2
- Drupal 10.1.5
- PHP 8.1
## Visiting
- `.../admin/config/development/logging` to enable logs in UI
- `.../civicrm/admin/setting/theisland`
## Expecting
No erros
## Seeing
```
Warning: Undefined array key "template" in include() (line 5 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "help" in include() (line 14 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 14 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "pre_html_text" in include() (line 23 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "post_html_text" in include() (line 26 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Undefined array key "documentation_link" in include() (line 30 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 30 of sites/default/files/civicrm/templates_c/de_DE/%%0B/0B9/0B956D8A%%Field.tpl.php).
```
---
_internal ref 23127_https://lab.civicrm.org/dev/core/-/issues/4741Error: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR2023-11-02T11:56:43Zaydunsaidan.saunders@squiffle.ukError: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROROverview
----------------------------------------
Trying to access some civicrm pages produces "datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR"
This is being encountered with php8.1, but not php7.4. It is on Joomla 4, but I d...Overview
----------------------------------------
Trying to access some civicrm pages produces "datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR"
This is being encountered with php8.1, but not php7.4. It is on Joomla 4, but I don't think that is the problem.
The Joomla stacktrace is:
```
| # | Function | Location |
|-----|-------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------|
| 1 | () | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:106 |
| 2 | IntlDateFormatter->__construct() | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:106 |
| 3 | PHP81_BC\{closure}() | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:205 |
| 4 | PHP81_BC\{closure}() | |
| 5 | preg_replace_callback() | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:186 |
| 6 | PHP81_BC\strftime() | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/Log.php:887 |
| 7 | Log->formatTime() | JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/Log/file.php:294 |
| 8 | Log_file->log() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Error.php:601 |
| 9 | CRM_Core_Error::debug_log_message() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Error.php:573 |
| 10 | CRM_Core_Error::debug_var() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Error.php:442 |
| 11 | CRM_Core_Error::handleUnhandledException() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Invoke.php:39 |
| 12 | CRM_Core_Invoke::invoke() | JROOT/components/com_civicrm/civicrm.php:84 |
| 13 | civicrm_invoke() | JROOT/components/com_civicrm/civicrm.php:11 |
| 14 | require_once() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:71 |
| 15 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher::Joomla\CMS\Dispatcher\{closure}() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:73 |
| 16 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361 |
| 17 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:208 |
| 18 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:249 |
| 19 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:293 |
| 20 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:61 |
| 21 | require_once() | JROOT/index.php:32 |
```
The error occurs when CRM_Core_Error() tries to write to a logfile - so something should be written to the log, but the act of writing creates a new separate error.
In `JROOT/administrator/components/com_civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:106` right before the call to `IntlDateFormatter()` `$locale` has the value 'C' which is determined from a call to `setlocale(LC_TIME, '0')`
Other uses of `IntlDateFormatter()` call `CRM_Core_I18n::getLocale()` to find the locale but this call is in the pear log module's compatibility layer for the deprecated `strftime()`.
As an ugly hack, setting `$locale = "en_US";` gets things working again.
Environment information
----------------------------------------
* __CiviCRM:__ _5.66.1_
* __PHP:__ _8.1_ - does not occur with 7.4
* __CMS:__ _Joomla 4_5.67.0https://lab.civicrm.org/dev/core/-/issues/4739Fatal Error "invalid locale" with scheduled jobs and tax receipts (and others...2023-11-07T12:25:25ZkcristianoFatal Error "invalid locale" with scheduled jobs and tax receipts (and others) and php 8.1.25 & civicrm 5.66.xAfter updating to php 8.1.25
```
PHP 8.1.25 (cli) (built: Oct 27 2023 13:02:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.25, Copyright (c) Zend Technologies
with Zend OPcache v8.1.25, Copyright (c), by Zend Technologies
``...After updating to php 8.1.25
```
PHP 8.1.25 (cli) (built: Oct 27 2023 13:02:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.25, Copyright (c) Zend Technologies
with Zend OPcache v8.1.25, Copyright (c), by Zend Technologies
```
Any attempt to call cron (cli with cv, or in the UI) fails with the following erro:
```
[28-Oct-2023 10:50:42 America/New_York] PHP Fatal error: Uncaught IntlException: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR in /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php:105
Stack trace:
#0 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(105): IntlDateFormatter->__construct()
#1 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(204): PHP81_BC\{closure}()
#2 [internal function]: PHP81_BC\{closure}()
#3 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php(185): preg_replace_callback()
#4 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/Log.php(887): PHP81_BC\strftime()
#5 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/Log/file.php(294): Log->formatTime()
#6 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(590): Log_file->log()
#7 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(562): CRM_Core_Error::debug_log_message()
#8 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(442): CRM_Core_Error::debug_var()
#9 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(39): CRM_Core_Error::handleUnhandledException()
#10 /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm.php(1199): CRM_Core_Invoke::invoke()
#11 /home/cvdemo/public_html/wp-includes/class-wp-hook.php(310): CiviCRM_For_WordPress->invoke()
#12 /home/cvdemo/public_html/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#13 /home/cvdemo/public_html/wp-includes/plugin.php(517): WP_Hook->do_action()
#14 /home/cvdemo/public_html/wp-admin/admin.php(259): do_action()
#15 {main}
thrown in /home/cvdemo/public_html/wp-content/plugins/civicrm/civicrm/vendor/pear/log/php-8.1-strftime.php on line 105
```
I am finding this on:
WP 6.3.2
CiviCRM 5.64.x and greater
The only workaround I could find was temporarily reverting to php 7.45.67.0https://lab.civicrm.org/dev/core/-/issues/4735Event Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid...2023-12-06T16:06:38Zdarren.woodsEvent Registration Error on Wordpress 6.3.1 Civi 5.63.4 "Could not find valid value for id"Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/qu...Overview
----------------------------------------
When registering for an event, users do not see the configured thank you messge, but instead are shown the error: "Could not find valid value for id"
https://civicrm.stackexchange.com/questions/45729/event-registration-error-on-wordpress-6-3-1-civi-5-63-4-could-not-find-valid-va
Reproduction steps
----------------------------------------
1. Configure an event with free online registration and a thankyou message.
2. Register for the event from the event info page.
Current behaviour
----------------------------------------
Users are shown an error: "Could not find valid value for id"
Expected behaviour
----------------------------------------
Thank you message configured in the event should be shown.
Environment information
----------------------------------------
* __Browser: Browser independent.
* __CiviCRM: 5.63.4
* __PHP: 8.1
* __CMS: WordPress 6.3.1
* __Database: MariaDB
* __Web Server: Nginx
Comments
----------------------------------------
This only happens with registering for events using the Civi event info page. If you embed a shortcode for the specific event in a WordPress page then the error is not shown.https://lab.civicrm.org/dev/core/-/issues/4734ADMIN_UI: default checkbox2023-11-03T15:31:20ZGuillaumeSorelADMIN_UI: default checkboxCould it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially del...Could it be possible to have checkboxes per default for each new admin screen using SK, so it becomes possible to select multiple lines (for mailings, messages templates, custom fields...) and proceed bulk actions on them, especially delete?
New SK screens are sweet but actions still need to be proceeded one-by-one.https://lab.civicrm.org/dev/core/-/issues/4726On Import in Non English Mode do not import field in saved field mapping is n...2023-11-29T20:14:33ZseamusleeOn Import in Non English Mode do not import field in saved field mapping is not correctly set as default when re-using importOverview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set cor...Overview
----------------------------------------
When using import contacts for example with a saved field mapping where one of the fields is set to be marked as `do_not_import` in languages other than English this is not always set correctly when the MapField form is loaded as per the screenshot below showing the saving of the saved mapping field with the 2nd field as do not import but then when I go to re-use the saved mapping the mapped column does not match do not import
![save_import_map](/uploads/a652dc803fecadde0d5ec7fe0f202f58/save_import_map.jpg)
![use_import_map](/uploads/a2ae9251dbc67491276567473e4668c7/use_import_map.jpg)
Reproduction steps
----------------------------------------
1. Navigate to Administer -> localisation -> Languages ... and Set current language to be French (France)
1. Go to contacts -> Import contacts and proceed to the map field step. Create a mapping and save it making sure that one of the fields is marked as do not import
1. Repeat step 2 but this time re-use the saved mapping from before and find that the field is not mapped to the selection of do not import
ping @eileen @JoeMurray5.67.0https://lab.civicrm.org/dev/core/-/issues/4724Contribution fails mid-donation with geocoding, "on behalf of", and no state/...2023-10-30T02:57:00ZJonGoldContribution fails mid-donation with geocoding, "on behalf of", and no state/provinceOverview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
-------------------------------------...Overview
----------------------------------------
The "On Behalf of Organization" code causes a bug in geocoding when a state is not submitted, but other address info is present.
Reproduction steps
----------------------------------------
1. Create a contribution page that allows giving "on behalf of an organization". The Organization profile should include state/province and at least one other address field. The state/province must not be required.
2. Submit the form with an organization. Provide at least one part of the address but leave the state blank.
Current behaviour
----------------------------------------
Crashes in geocoding.
Expected behaviour
----------------------------------------
Submits successfully.
Comments
----------------------------------------
This wouldn't be such a big deal but for https://lab.civicrm.org/dev/core/-/issues/2929.
A partial backtrace is below, though there are other ways to reach this code path (e.g. if confirm pages are present/absent).
```
#0 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/DAO.php(1419): strtolower()
#1 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Utils/Geocode/Google.php(76): CRM_Core_DAO::getFieldValue()
#2 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1287): CRM_Utils_Geocode_Google::format()
#3 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(276): CRM_Core_BAO_Address::addGeocoderData()
#4 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Address.php(1365): CRM_Core_BAO_Address::fixAddress()
#5 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/BAO/Location.php(52): CRM_Core_BAO_Address::legacyCreate()
#6 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(327): CRM_Core_BAO_Location::create()
#7 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contact/BAO/Contact.php(1921): CRM_Contact_BAO_Contact::create()
#8 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(1296): CRM_Contact_BAO_Contact::createProfileContact()
#9 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(2312): CRM_Contribute_Form_Contribution_Confirm::processOnBehalfOrganization()
#10 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Confirm.php(836): CRM_Contribute_Form_Contribution_Confirm->processFormSubmission()
#11 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Core/Form.php(617): CRM_Contribute_Form_Contribution_Confirm->postProcess()
#12 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1318): CRM_Core_Form->mainProcess()
#13 /var/www/connect.mysite.org/vendor/civicrm/civicrm-core/CRM/Contribute/Form/Contribution/Main.php(1076): CRM_Contribute_Form_Contribution_Main->skipToThankYouPage()
```5.68.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4723SearchKit joins to custom fields appear to be broken2023-11-02T20:48:31ZScottMasonSearchKit joins to custom fields appear to be brokenThe latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom fi...The latest version of SearchKit allows you to join to custom fields. However, if you try to do this and then add data to a display from the joined entity the data is not shown.
Steps to recreate.
1. Create a contact reference custom field for activities (for example Activities details > products)
2. Create a new SK search for activities and join to the custom field
![image](/uploads/ebbeb025d909e2df4b8c87d97d7a9ada/image.png)
3. Add info from the linked entity to the display
4. The info is not shown.
![image](/uploads/870046a2cf17c723bfff75917401beb0/image.png)
I have tested this on the lastest demo site and it appears to be an issue there.
fyi @kurundhttps://lab.civicrm.org/dev/core/-/issues/4722[PHP 8.1] fseek deprecation in PHPgettext2023-12-04T21:08:50Zjofranzfranz@systopia.de[PHP 8.1] fseek deprecation in PHPgettextOverview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Depre...Overview
----------------------------------------
Noisy error on cli
Reproduction steps
----------------------------------------
Performing a cache clear on cli
Current behaviour
----------------------------------------
```[PHP Deprecation] fseek(): Passing null to parameter #2 ($offset) of type int is deprecated at .../drupal/vendor/civicrm/civicrm-packages/PHPgettext/streams.php:125```
Expected behaviour
----------------------------------------
There should be no deprecation warnings.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __CiviCRM:__ _5.66.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.1_
* __CMS:__ _Drupal 9.5.11_https://lab.civicrm.org/dev/core/-/issues/4720[PHP 8.1] New Organization: 4x Undefined array key2023-10-27T11:41:07Zjofranzfranz@systopia.de[PHP 8.1] New Organization: 4x Undefined array key## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/4...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/contact/add?reset=1&ct=Organization
## Seeing
```
Warning: Undefined array key "contact_sub_type" in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 32 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Undefined array key "contact_sub_type" in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
Warning: Trying to access array offset on value of type null in include() (line 34 of sites/default/files/civicrm/templates_c/en_US/%%47/472/472C7800%%Organization.tpl.php).
```https://lab.civicrm.org/dev/core/-/issues/4719[PHP 8.1] New Contribution: 4x Undefined array key2023-12-12T20:43:31Zjofranzfranz@systopia.de[PHP 8.1] New Contribution: 4x Undefined array key## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicr...## Having
- PHP 8.1
- Drupal 9.5.11
- 5.67.0
## Visiting
.../civicrm/contribute/add?reset=1&action=add&context=standalone
## Seeing
```
Warning: Undefined array key "buildRecurBlock" in include() (line 5 of sites/default/files/civicrm/templates_c/en_US/%%60/60A/60A6E1C6%%Payment.tpl.php).
Warning: Undefined array key "buildRecurBlock" in include() (line 125 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "urlPathVar" in include() (line 90 of sites/default/files/civicrm/templates_c/en_US/%%51/516/51624B60%%paymentBlock.tpl.php).
Warning: Undefined array key "dataUrl" in include() (line 477 of sites/default/files/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
```
---
_Internal ref: sci_https://lab.civicrm.org/dev/core/-/issues/4718[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in...2023-11-03T02:04:37Zjofranzfranz@systopia.de[PHP 8.1] Find and Merge Duplicate Contacts: Undefined array key "weight" in CRM_Core_Action## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
.../civicrm/contact/deduperules?reset=1
## Seeing
22x:
```Warning: Undefined array key "weight" in CRM_Core_Action::{closure}() (line 318 of /var/www/civicrm_env/autophpdrupalextupdate/drupal/vendor/civicrm/civicrm-core/CRM/Core/Action.php).```5.67.0https://lab.civicrm.org/dev/core/-/issues/4717[PHP 8.1] Organization Address and Contact Info: foreach() argument must be ...2023-12-11T23:15:39Zjofranzfranz@systopia.de[PHP 8.1] Organization Address and Contact Info: foreach() argument must be of type array|object, string given## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en...## Having
- Drupal 9.5.11
- 5.66.0
## Visiting
...civicrm/admin/domain?action=update&reset=1
## Seeing
2x:
```Warning: Undefined array key "defaultCurrencySymbol" in include() (line 155 of sites/default/files/civicrm/templates_c/en_US/%%24/24E/24E27851%%jsortable.tpl.php).```