Development issueshttps://lab.civicrm.org/groups/dev/-/issues2021-01-15T15:42:56Zhttps://lab.civicrm.org/dev/translation/-/issues/62Updated State list for Taiwan2021-01-15T15:42:56ZsudomanUpdated State list for TaiwanOne of our site users would like to recommend updating the "State list" of "Country: Taiwan". Below is the recommended list from the Office of the President (<https://english.president.gov.tw/Page/106>). Our user says that it's ok to put...One of our site users would like to recommend updating the "State list" of "Country: Taiwan". Below is the recommended list from the Office of the President (<https://english.president.gov.tw/Page/106>). Our user says that it's ok to put the list under "State", even though they actually only call them city or county.
```
Taipei City
New Taipei City
Keelung City
Taoyuan City
Hsinchu City
Hsinchu County
Miaoli County
Taichung City
Changhua County
Nantou County
Yunlin County
Chiayi City
Chiayi County
Tainan City
Kaohsiung City
Pingtung County
Yilan County
Hualien County
Taitung County
Penghu County
Kinmen County
Lienchiang County
```
Thanks : )https://lab.civicrm.org/dev/core/-/issues/2290Look at REMOVING id column from cache tables2022-12-13T11:58:44ZjitendraLook at REMOVING id column from cache tablesThis is a continuation of the "In Progress" JIRA https://issues.civicrm.org/jira/browse/CRM-19385
which aimed at removing the id from the cache tables but unfortunately was never completed since I see we still have id column in all the ...This is a continuation of the "In Progress" JIRA https://issues.civicrm.org/jira/browse/CRM-19385
which aimed at removing the id from the cache tables but unfortunately was never completed since I see we still have id column in all the cache tables.
```
civicrm_acl_cache
civicrm_acl_contact_cache
civicrm_cache
civicrm_group_contact_cache
civicrm_prevnext_cache
civicrm_relationship_cache
```
Related PRs -
- https://github.com/civicrm/civicrm-core/pull/9743 (Closed)
- https://github.com/civicrm/civicrm-core/pull/9801 (Closed)
- https://github.com/civicrm/civicrm-core/pull/10019 (Merged) - This removed the dependency in the code so think we can start by removing the column directly.
Thoughts @eileen @johnkhttps://lab.civicrm.org/dev/translation/-/issues/61docURL and ts, or how ConfigTaskList.tpl has odd translation strings2021-05-10T20:51:53ZbgmdocURL and ts, or how ConfigTaskList.tpl has odd translation stringsWhen running the string extraction, these strings end up in the .pot files:
```
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviContribute"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid ...When running the string extraction, these strings end up in the .pot files:
```
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviContribute"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviPledge"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviEvent"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviMember"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviMail"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviCampaign"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviCase"
msgstr ""
#: templates/CRM/Admin/Page/ConfigTaskList.tpl
msgid "$componentTitles.CiviGrant"
msgstr ""
```
To test:
```
civistrings templates/CRM/Admin/Page/ConfigTaskList.tpl
```
Is it because of an incorrect use of `ts`, or is it because civistrings should ignore crmURL?
Code:
```
<tr class="even">
<td class="tasklist nowrap" style="width: 10%;">{docURL page="user/contributions/what-is-civicontribute" text=$componentTitles.CiviContribute}</td>
<td>{ts}Online fundraising and donor management, as well as offline contribution processing and tracking.{/ts}</td>
</tr>
```
Example of docURL strings that should be extracted:
```
templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkCustom}{docURL page="user/organising-your-data/custom-fields" text="custom fields"}{/capture}
templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkProfile}{docURL page="user/organising-your-data/profiles" text="profiles"}{/capture}
templates/CRM/Case/Page/ConfigureError.tpl:{capture assign=docLink}{docURL page="user/case-management/set-up" text="CiviCase Setup documentation"}{/capture}
templates/CRM/Contact/Form/OnBehalfOf.tpl: {ts}Latitude and longitude may be automatically populated by enabling a Mapping Provider.{/ts} {docURL page="user/initial-set-up/installation-and-basic-set-up" text="(Refer to the Mapping and Geocoding section in the Installation and Basic Setup Chapter)"}</span>
```
I feel like we should instead use 'ts' in the docURL call, instead of assuming it. There are 22 instances where it would need fixing.
```
grep -r docURL templates/ | grep text | grep -v componentTitle
```
@totten @seamuslee Any thoughts?https://lab.civicrm.org/dev/drupal/-/issues/152Installing CiviCRM on some Distributions causes error Failed to find next ins...2021-01-13T19:55:59ZHeneryHInstalling CiviCRM on some Distributions causes error Failed to find next installable packageOne could argue that since CiviCRM installs of a clean core then it isn't its problem if there are errors on other distributions. But I have had this error when installing on a variety of different distis.
Maybe the root problem is in ...One could argue that since CiviCRM installs of a clean core then it isn't its problem if there are errors on other distributions. But I have had this error when installing on a variety of different distis.
Maybe the root problem is in some module somewhere or maybe the problem is in CiviCRM and it just doesn't manifest itself on a clean install of core.
I am not sure the data that I can help collect on this but I am now seeing it while trying to load CiviCRM on top of the Thunder disti.
Any ideas on what data collection would help?
```
composer create-project thunder/thunder-project $drupal_root --stability dev --no-interaction --no-install
.
.
.
vi composer.json # (to add the path for docroot to the civicrm-asset extras)
composer config extra.enable-patching true
composer -vvv require civicrm/civicrm-asset-plugin:'~1.1'
composer -vvv require civicrm/civicrm-{core,packages,drupal-8}:'~5.33-dev'
.
.
.
.
Writing lock file
Generating autoload files
- CiviCRM asset map
83 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Skip extra file civicrm/civicrm-core:angular
Skip extra file civicrm/civicrm-core:angular-bootstrap
Skip extra file civicrm/civicrm-core:angular-file-upload
Skip extra file civicrm/civicrm-core:angular-jquery-dialog-service
Skip extra file civicrm/civicrm-core:angular-mocks
Skip extra file civicrm/civicrm-core:angular-route
Skip extra file civicrm/civicrm-core:angular-sanitize
Skip extra file civicrm/civicrm-core:angular-ui-sortable
Skip extra file civicrm/civicrm-core:angular-ui-utils
Skip extra file civicrm/civicrm-core:angular-unsavedchanges
Skip extra file civicrm/civicrm-core:angular-xeditable
Skip extra file civicrm/civicrm-core:checklist-model
Skip extra file civicrm/civicrm-core:ckeditor
Skip extra file civicrm/civicrm-core:crossfilter-1.3.x
Skip extra file civicrm/civicrm-core:crossfilter2
Skip extra file civicrm/civicrm-core:css-color-names
Skip extra file civicrm/civicrm-core:d3
Skip extra file civicrm/civicrm-core:d3-3.5.x
Skip extra file civicrm/civicrm-core:datatables
Skip extra file civicrm/civicrm-core:dc-2.1.x
Skip extra file civicrm/civicrm-core:es6-promise
Skip extra file civicrm/civicrm-core:ext-greenwich-bootstrap3
Skip extra file civicrm/civicrm-core:font-awesome
Skip extra file civicrm/civicrm-core:marked
Skip extra file civicrm/civicrm-core:monaco-editor
Skip extra file civicrm/civicrm-core:google-code-prettify
Skip extra file civicrm/civicrm-core:jquery
Skip extra file civicrm/civicrm-core:jquery-ui
Skip extra file civicrm/civicrm-core:jquery-validation
Skip extra file civicrm/civicrm-core:json-formatter
Skip extra file civicrm/civicrm-core:jstree
Skip extra file civicrm/civicrm-core:lodash-compat
Skip extra file civicrm/civicrm-core:phantomjs-polyfill
Skip extra file civicrm/civicrm-core:select2
Skip extra file civicrm/civicrm-core:js-yaml
Skip extra file civicrm/civicrm-core:smartmenus
Executing command (/var/www/thunder/docroot): git ls-files --error-unmatch '/var/www/thunder/docroot//autoload.php'
Executing command (/var/www/thunder): git rev-parse --show-toplevel
[civicrm-asset-plugin] Found drupal/core. Defaults will be based on tarball.
[RuntimeException]
Error: Failed to find next installable package. Remaining: npm-asset/shariff thunder/thunder-distribution thunder/t
hunder-project
Exception trace:
() at /var/www/thunder/vendor/civicrm/composer-compile-plugin/src/PackageSorter.php:103
Civi\CompilePlugin\PackageSorter::sortPackages() at /var/www/thunder/vendor/civicrm/composer-compile-plugin/src/TaskList.php:42
Civi\CompilePlugin\TaskList->load() at /var/www/thunder/vendor/civicrm/composer-compile-plugin/src/Command/CompileCommand.php:60
Civi\CompilePlugin\Command\CompileCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:245
Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:835
Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:185
Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:281
Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:117
Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:113
Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:61
require() at /usr/local/bin/composer:24
compile [--all] [-N|--dry-run] [--soft-options [SOFT-OPTIONS]] [--] [<filterExpr>]...
Subcommand @composer compile returned with error code 1
Installation failed, reverting ./composer.json to its original content.
[RuntimeException]
Subcommand @composer compile returned with error code 1
Exception trace:
() at /var/www/thunder/vendor/civicrm/composer-compile-plugin/src/Util/ComposerPassthru.php:72
Civi\CompilePlugin\Util\ComposerPassthru->run() at /var/www/thunder/vendor/civicrm/composer-compile-plugin/src/CompilePlugin.php:117
Civi\CompilePlugin\CompilePlugin->runTasks() at n/a:n/a
call_user_func() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:164
Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:96
Composer\EventDispatcher\EventDispatcher->dispatchScript() at phar:///usr/local/bin/composer/src/Composer/Installer.php:338
Composer\Installer->run() at phar:///usr/local/bin/composer/src/Composer/Command/RequireCommand.php:248
Composer\Command\RequireCommand->doUpdate() at phar:///usr/local/bin/composer/src/Composer/Command/RequireCommand.php:205
Composer\Command\RequireCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:245
Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:835
Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:185
Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:281
Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:117
Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:113
Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:61
require() at /usr/local/bin/composer:24
require [--dev] [--prefer-source] [--prefer-dist] [--fixed] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--update-with-all-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] [<packages>]...
```https://lab.civicrm.org/dev/core/-/issues/2266Wording beside on-behalf-of checkbox isn't required, but has no default eithe...2023-11-23T07:25:09ZDaveDWording beside on-behalf-of checkbox isn't required, but has no default either, so appears as a mysterious checkboxI'm not sure yet if this is recent. I remember there being a default but it's not a strong memory.
1. Create a contribution page.
1. On the title page there's a choice to "Allow individuals to contribute and / or signup for membership o...I'm not sure yet if this is recent. I remember there being a default but it's not a strong memory.
1. Create a contribution page.
1. On the title page there's a choice to "Allow individuals to contribute and / or signup for membership on behalf of an organization". Check it.
1. In the section that appears there's a box for a label that has no default and is not required. Leave it blank.
1. Finish off the rest of the settings - doesn't matter too much what.
1. Visit the contribution page. It looks like this:
![Untitled](/uploads/4776b6636a1ea3fb9106face184bd545/Untitled.png)
It's easily fixable by adding words in the label box, but it just a seems a wrong default and I don't remember it coming up as a problem before.
I notice the label box is a textarea for some reason. Maybe it used to be a normal textbox and so the default now isn't getting set correctly?
Also ignore the decimal places in the dollar amounts in the screenshot - that's a known windows issue with civi.https://lab.civicrm.org/dev/core/-/issues/2255Proposal, Allow the CiviCRM CKEditor to be disabled for specific components a...2023-06-07T05:38:36Zjustinfreeman (Agileware)Proposal, Allow the CiviCRM CKEditor to be disabled for specific components as there is only a global on/off capability currently. We need CKEditor to be disabled for Message Templates, but not for Mailings, Events etc.Proposal, Allow the CiviCRM CKEditor to be disabled for specific components as there is only a global on/off capability currently. We need CKEditor to be disabled for Message Templates, but not for Mailings, Events etc.
CKEditor is alwa...Proposal, Allow the CiviCRM CKEditor to be disabled for specific components as there is only a global on/off capability currently. We need CKEditor to be disabled for Message Templates, but not for Mailings, Events etc.
CKEditor is always displayed for custom Message Templates which in our experience reliably mangles the HTML and Smarty Tags. CKEditor is NOT disabled for "System" Message Templates and therefore does not have this issue.
Agileware Ref: CIVICRM-1609 CIVICRM-1608https://lab.civicrm.org/dev/core/-/issues/3313Unable to save a membership with a text price field2023-12-19T22:18:09ZDaveDUnable to save a membership with a text price fieldSame problem in 5.28 and master and can reproduce on dmaster.demo.civicrm.org. Or maybe I'm missing something.
1. Create a price set used for memberships.
1. Set financial type to member dues.
1. Add one text field (the default input fi...Same problem in 5.28 and master and can reproduce on dmaster.demo.civicrm.org. Or maybe I'm missing something.
1. Create a price set used for memberships.
1. Set financial type to member dues.
1. Add one text field (the default input field type).
1. Amount doesn't matter - put in some number.
1. Leave other fields at defaults.
1. Create a new membership.
1. Choose the price set.
1. Put in quantity 1.
1. Can leave the rest at defaults.
1. Click Save.
1. ERROR: Select at least one membership option.
It works with a radio field.https://lab.civicrm.org/dev/core/-/issues/2237Provide some way for an extension's database tables to automatically get incl...2022-08-24T18:56:45ZDaveDProvide some way for an extension's database tables to automatically get included when a site runs utf8mb4 conversionThere's an option in the api call / api explorer when running the utf8mb4 conversion to specify some tablename patterns, but this requires the user to know what the tables are that all their extensions create.
One idea is a hook that le...There's an option in the api call / api explorer when running the utf8mb4 conversion to specify some tablename patterns, but this requires the user to know what the tables are that all their extensions create.
One idea is a hook that lets an extension advertise the names of tables it creates. If it wants to manage the charset itself for a table then it can just not list it.
Another is a standard naming like civicrm_ext_FOO, which then core knows not to conflict for its own tables, but which starts with civicrm so gets picked up by default.
Open to other ideas. The status quo is also technically an option. And it's only important if there's some connection between text data in the extension's tables and core tables, or it stores emojis and such.https://lab.civicrm.org/dev/core/-/issues/2225Add a contact.checksum_raw token that does not include "cs="2023-09-24T22:53:45ZherbdoolAdd a contact.checksum_raw token that does not include "cs="Unlike all the other tokens which only include the actual data, such as `{contact.contact_id}`, the `{contact.checksum}` also includes the parameter name. There doesn't seem to be any good reason other than that is how it was always done...Unlike all the other tokens which only include the actual data, such as `{contact.contact_id}`, the `{contact.checksum}` also includes the parameter name. There doesn't seem to be any good reason other than that is how it was always done.
I suppose it's not possible to fix this token at this point since lots of existing links rely on it. But perhaps a new token? A bit messy but I need something like `{contact.checksum.raw}`https://lab.civicrm.org/dev/drupal/-/issues/150Drupal 9 - [RuntimeException] - Error: Failed to find next installable packa...2021-01-15T21:39:04ZRar9Drupal 9 - [RuntimeException] - Error: Failed to find next installable package. Remaining: drupal/chosen drupal/chosen_libUpdating civicrm 5.30.1 on Drupal 9.0.9 with composer 1.10.17 + php 7.4.12 will produce a conflict with drupal chosen module
![Civicrm](/uploads/e3fb0c573f5a1d2bda26e0e0269302ec/Civicrm.jpg)
it brings in these changes and something in ...Updating civicrm 5.30.1 on Drupal 9.0.9 with composer 1.10.17 + php 7.4.12 will produce a conflict with drupal chosen module
![Civicrm](/uploads/e3fb0c573f5a1d2bda26e0e0269302ec/Civicrm.jpg)
it brings in these changes and something in this breaks composer:
- Installing totten/lurkerlite (1.3.0): Loading from cache
- Installing civicrm/composer-compile-plugin (v0.14): Loading from cache
- Updating civicrm/composer-downloads-plugin (v2.1.1 => v3.0.1): Loading from cache
- Installing tubalmartin/cssmin (v4.1.1): Loading from cache
- Installing padaliyajay/php-autoprefixer (1.3): Loading from cache
- Installing scssphp/scssphp (v1.4.0): Loading from cache
- Installing civicrm/composer-compile-lib (v0.4): Loading from cache
- Updating civicrm/civicrm-core (5.30.1 => 5.31.1): Checking out e8825b4e60
[composer.json](https://lab.civicrm.org/-/snippets/60)https://lab.civicrm.org/dev/financial/-/issues/157Proposal - if payment_processor_type does not define url_site_default then do...2020-12-04T08:47:08ZeileenProposal - if payment_processor_type does not define url_site_default then do not present url_site on Processor formWhen you go to create a new processor there is a field for the site_url (& some other urls) which I generally don't think it's good to have users fill in and would rather suppress. I think it should be suppressed based on payment process...When you go to create a new processor there is a field for the site_url (& some other urls) which I generally don't think it's good to have users fill in and would rather suppress. I think it should be suppressed based on payment processor & while I could make a case for using a supportsUserDefinedUrl method I think we could get away with either
1) don't display the field if payment_processor.site_url_default is empty or
2) don't display the field is payment_processor.site_url_default is 'null' or some other magic value
We aren't currently doing any 'supports' checks on the form & it feels like this is probably something used primarily by older processors so I lean towards 1 being enough
@mattwire @KarinG @adixon @artfulrobot @andrewhunt thoughtshttps://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/15Don't copy assets from extensions as an option?2021-11-08T21:43:41ZwouterhDon't copy assets from extensions as an option?We install some CiviCRM extensions via composer.json, for this we use 'composer/installers' in the composer.json to get them in the right place from the vendor to the web root.
```
"installer-paths": {
"web/modules/civicrm/ext...We install some CiviCRM extensions via composer.json, for this we use 'composer/installers' in the composer.json to get them in the right place from the vendor to the web root.
```
"installer-paths": {
"web/modules/civicrm/extensions/{$name}": [
"type:civicrm-extension"
]
},
"custom-installer": {
"web/modules/civicrm/extensions/{$name}": [
"type:civicrm-extension"
]
},
```
So in our case the assets of the extensions do not have to be copied to the libraries folder.
Is there a way to disable copying extension assets?https://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/14Command "composer civicrm: publish" is not executed automatically?2021-12-03T14:43:54ZwouterhCommand "composer civicrm: publish" is not executed automatically?I was upgrading our drupal 8 and CiviCRM installation, as our vendor directory is outside the webroot, as a solution we ran a bash script via composer.json scripts to put all assets in the right place in the webroot.
I recently saw that...I was upgrading our drupal 8 and CiviCRM installation, as our vendor directory is outside the webroot, as a solution we ran a bash script via composer.json scripts to put all assets in the right place in the webroot.
I recently saw that "civicrm-asset-plugin" is available, while implementing this I saw that the command `composer civicrm: publish` was not executed, so I have to run this manually after a composer install/update.
I solved this by adding this in our composer.json:
```
"scripts": {
"post-install-cmd": [
"@composer civicrm:publish"
],
"post-update-cmd": [
"@composer civicrm:publish"
]
}https://lab.civicrm.org/dev/civicrm-asset-plugin/-/issues/12doesn't work with Varbase distribution2021-02-25T19:31:44Zahilliodoesn't work with Varbase distributionNot sure why but CiviCRM installation on Varbase doesn't work the way it's supposed to, it requires some manual interventions:
```
composer create-project Vardot/varbase-project varbase2 --no-dev --no-interaction
composer require civicr...Not sure why but CiviCRM installation on Varbase doesn't work the way it's supposed to, it requires some manual interventions:
```
composer create-project Vardot/varbase-project varbase2 --no-dev --no-interaction
composer require civicrm/civicrm-asset-plugin:'~1.1'
composer require civicrm/civicrm-{core,packages,drupal-8}:'~5.31'
```
After installing the asset plugin, the require civi-core fails in a couple ways:
1) `Applying patches for adrienrn/php-mimetyper
https://patch-diff.githubusercontent.com/raw/adrienrn/php-mimetyper/pull/15.patch (Update gitignore to ensure that sites that manage via git don't miss out on the important db.json file)` has to be done manually, all that patch does is gitignore node_modules, anyway, it fails to apply and stops composer. So, go apply that patch yourselve and then require civicrm-core again...
2) It will run for a long time, and then fail with some messages, saying "reverting composer.json to its original content" but that doesn't actually happen, composer.json doesn't actually get reverted and all the files downloaded are in place.
3) `docroot/libraries/civicrm` is missing, so I copy it from a non-broken installation, and then git commit. And at this point CiviCRM seems to work, but this plugin didn't seem to do what's I believe it's supposed to.
Originally noted at https://www.drupal.org/project/varbase/issues/3181336https://lab.civicrm.org/dev/core/-/issues/2195Custom fields of type money and drop-down list with round numbers don't updat...2023-07-04T12:55:04ZDaveDCustom fields of type money and drop-down list with round numbers don't update existing values when you change the option valueCame up reviewing https://github.com/civicrm/civicrm-core/pull/18959
For example:
1. Edit or create a custom field group for contacts.
1. Add a custom field of type money and make it a drop-down select list.
1. For the values, make cho...Came up reviewing https://github.com/civicrm/civicrm-core/pull/18959
For example:
1. Edit or create a custom field group for contacts.
1. Add a custom field of type money and make it a drop-down select list.
1. For the values, make choice 1 have value 10 and choice 2 have value 20.
1. Create a contact and pick one of the choices. Save.
1. Note that in the database in the civicrm_value_XX table this has been stored as 10.00, with the decimals. Note that in civicrm_option_value that the choice is stored as 10, without the decimals.
1. Go and edit the option value and change the value to anything else.
1. What's supposed to happen is that the contact's custom field values should be updated to match. But because of the mismatch above it doesn't change it in civicrm_value_XX and it now appears blank when viewing the contact.
I don't think this is recent.https://lab.civicrm.org/dev/wordpress/-/issues/81Synchronising WordPress Users and CiviCRM Contacts2020-11-24T15:11:13ZhaystackSynchronising WordPress Users and CiviCRM ContactsWhilst trying to clean up some logic in the CiviCRM-WordPress plugin I have come across a mismatch in how the CiviCRM-Drupal module and the CiviCRM-WordPress plugin synchronises the CMS User to the corresponding CiviCRM Contact. See [thi...Whilst trying to clean up some logic in the CiviCRM-WordPress plugin I have come across a mismatch in how the CiviCRM-Drupal module and the CiviCRM-WordPress plugin synchronises the CMS User to the corresponding CiviCRM Contact. See [this Mattermost thread](https://chat.civicrm.org/civicrm/pl/u95r1msnwinmdpne3kmjrwd8kh) for preliminary discussion.
There are currently two different types of call to `CRM_Core_BAO_UFMatch::synchronize()` happening:
1. In `CiviCRM_For_WordPress::initialize()` (set up the session)
2. In `CiviCRM_For_WordPress::invoke()` and `CiviCRM_For_WordPress_Users::sync_user()` (do a full User->Contact sync)
This is the reason for the behaviour that @totten identified and that I don't think should happen at that point, i.e.:
> If you access a `civicrm/*` page, then it autocreates a Contact.
As per the Mattermost discussion, it seems to me that the types of call should be:
1. In `CiviCRM_For_WordPress::initialize()` and `CiviCRM_For_WordPress::invoke()` (set up the session)
2. In `CiviCRM_For_WordPress_Users::sync_user()` (do a full User->Contact sync)
This pattern reverts the types of calls to their pre-4.6 state. My fault for the change back then :blush:
My proposal is to keep the calls to `CRM_Core_BAO_UFMatch::synchronize()` in both `CiviCRM_For_WordPress::initialize()` and `CiviCRM_For_WordPress::invoke()` but to make the calls indirectly via a new method in the `CiviCRM_For_WordPress_Users` class. The reason for this is that:
1. It is possible that some code calls `civi_wp()->initialize()`, `civicrm_wp_initialize()` or `civicrm_initialize()` before the WordPress User has been properly set up. I've seen this in the wild, though I can't remember where. When this happens, I don't think `CRM_Core_BAO_UFMatch::synchronize()` should be called. The `CiviCRM_For_WordPress_Users` class can keep track of the state of the WordPress User and make sure the call occurs only at the appropriate time.
2. If no calls have succeeded by the time `CiviCRM_For_WordPress::invoke()` runs, then `CRM_Core_BAO_UFMatch::synchronize()` will be called correctly when it's most definitely needed. The `CiviCRM_For_WordPress_Users` class will know if it's been called already.
I don't think this change will have any adverse effects (in fact it should have marginally beneficial effects by only calling `CRM_Core_BAO_UFMatch::synchronize()` when needed) but if anyone knows of code that expects Contacts to be created a `civicrm/*` page then shout here.haystackhaystackhttps://lab.civicrm.org/dev/translation/-/issues/59Broken link and mistranslation in Italian for ACL roles page2021-03-19T15:14:05ZDaveDBroken link and mistranslation in Italian for ACL roles pageIt's just a help text link, but maybe 2 problems:
1. The use of `{docURL}` requires text you pass in to be translated already.
1. Somebody probably noticed it wasn't working and tried to adjust by putting the link into transifex, but it...It's just a help text link, but maybe 2 problems:
1. The use of `{docURL}` requires text you pass in to be translated already.
1. Somebody probably noticed it wasn't working and tried to adjust by putting the link into transifex, but it leads to a broken link: https://lab.civicrm.org/dev/translation/-/blob/9d4c4d9db3535f3816969b541c9bbe00345569a4/po/it_IT/common-base.po#L18128
This is the code:
https://github.com/civicrm/civicrm-core/blob/d1eed91c218f4c285a535275e36732f68463824b/templates/CRM/ACL/Header.tpl#L10-L14
```smarty
{capture assign=docLink}{docURL page='user/initial-set-up/permissions-and-access-control/' text='Access Control Documentation'}{/capture}
<div class="help">
<p>{ts 1=$docLink}ACLs allow you to control access to CiviCRM data. An ACL consists of an <strong>Operation</strong> (e.g. 'View' or 'Edit'), a <strong>set of data</strong> that the operation can be performed on (e.g. a group of contacts), and a <strong>Role</strong> that has permission to do this operation. Refer to the %1 for more info.{/ts}</p>
</div>
```https://lab.civicrm.org/dev/joomla/-/issues/30Smarty setting resets to 0 on upgrade2020-11-09T13:45:59Zjoshjosh@civicrm.orgSmarty setting resets to 0 on upgradeOn upgrade, the smarty setting on lines 308 - 310 referenced below of the civicrm.settings.php in the file located in the joomla directory: components/com_civicrm reverts from "1" to "0"
The corresponding file in: administrator/compone...On upgrade, the smarty setting on lines 308 - 310 referenced below of the civicrm.settings.php in the file located in the joomla directory: components/com_civicrm reverts from "1" to "0"
The corresponding file in: administrator/components/com_civicrm remains unchanged on upgrade.
The expected behavior is that both settings, which appear necessary for smarty to work, would remain regardless of upgrade.
`if (!defined('CIVICRM_MAIL_SMARTY')) {
define( 'CIVICRM_MAIL_SMARTY', 1 );
}
`https://lab.civicrm.org/dev/core/-/issues/2163log_date is missing on logging detail report2023-05-26T16:05:01ZDaveDlog_date is missing on logging detail report1. Turn on logging at Admin - System Settings - Misc.
2. Update a contact.
3. Go to the logging summary civireport.
4. Click on "Update" in the row for your update.
5. At the top of the detail report it will say something like `Change to...1. Turn on logging at Admin - System Settings - Misc.
2. Update a contact.
3. Go to the logging summary civireport.
4. Click on "Update" in the row for your update.
5. At the top of the detail report it will say something like `Change to blah made by somebody on :`
6. It's supposed to show the modified date at the end.
It's coming from [this check](https://github.com/civicrm/civicrm-core/blob/4d660b8e1e6ac980a06b096fbc4cde1e1666e0b9/CRM/Report/Form/Contact/LoggingSummary.php#L193) which decides the log date isn't needed. The comment when that check was added says it can make the report less accurate because of some older data that used to be the way things were logged. So I'm hesitant to just remove that check.
Some other options include passing it but with a different name, and then in the detail report know that that new name is just used in intro text. Or looking it up in the detail report.
TBD.
@VangelisP just FYI.https://lab.civicrm.org/dev/financial/-/issues/155Incorrect deductible shown in contribution summary report2020-11-09T13:37:51ZMonish DebIncorrect deductible shown in contribution summary reportSteps to replicate:
1. Ensure that there are multiple contributions with non-zero non-deductible amount.
2. Go to Contribution Summary Report
3. Select Non-Deductible amount column + Grouping on Receive Date - Month
Result: Total non-d...Steps to replicate:
1. Ensure that there are multiple contributions with non-zero non-deductible amount.
2. Go to Contribution Summary Report
3. Select Non-Deductible amount column + Grouping on Receive Date - Month
Result: Total non-deductible amount is incorrect against each month
On closer look, group function (- SUM) is not applied on non-deductible amount, thus the report column show random amount.
Here's a screencast that explains the issue, where I added two contributions this month w/o non-deductible amount respectively, but the Contribution summary report shows incorrect value:
![yhv](/uploads/e851d5c3b56e46c1de049d12d1f977ff/yhv.gif)
ping @JoeMurray @eileen @mattwire @EdselopezMonish DebMonish Deb