Development issueshttps://lab.civicrm.org/groups/dev/-/issues2019-11-17T19:31:19Zhttps://lab.civicrm.org/dev/financial/-/issues/100Membership form permits creating invalid transactions2019-11-17T19:31:19ZeileenMembership form permits creating invalid transactionsI discovered you can do this... ie choose to add a 'partially paid contribution'
![Screen_Shot_2019-11-07_at_9.21.34_AM](/uploads/a7c343da47e0a01e8c1308a95ba0fc44/Screen_Shot_2019-11-07_at_9.21.34_AM.png)
& all bets are off if you do -...I discovered you can do this... ie choose to add a 'partially paid contribution'
![Screen_Shot_2019-11-07_at_9.21.34_AM](/uploads/a7c343da47e0a01e8c1308a95ba0fc44/Screen_Shot_2019-11-07_at_9.21.34_AM.png)
& all bets are off if you do - certainly in terms of data integrity as no financial_trxn record is created.
We should remove that status - probably the entire field from that screen & just accept 'amount' & maaaayyyybe payment status....5.21.0https://lab.civicrm.org/dev/core/-/issues/1108Unsubscribe broken if mailing sent to previous mailing recipients with an exc...2019-11-17T19:42:12ZRichUnsubscribe broken if mailing sent to previous mailing recipients with an excluded groupI think <https://lab.civicrm.org/dev/core/commit/96fce13bb554201fa9eae10b02160ed7b5644806> broke the unsubscribe in various situations.
The logic is pretty hard to follow because the options create zillions of use cases, however, having...I think <https://lab.civicrm.org/dev/core/commit/96fce13bb554201fa9eae10b02160ed7b5644806> broke the unsubscribe in various situations.
The logic is pretty hard to follow because the options create zillions of use cases, however, having been hit by this I can report that the following situation created it:
1. send a mailing (A) to a mailing group
2. send a second mailing (B) to the recipients of mailing (A), excluding those in a group (C).
Recipients of (B) will not be able to unsubscribe.
This is because (as I have understood so far):
1. The unsubscribe code is supposed to find all the lists of contacts (I'm deliberately using _lists_ to avoid ambiuities with _groups_ -if I say _group_ it means a CiviCRM group as you would see on a contact's record.) that were used to select recipients of the mailing. These "lists" might be groups or previous mailings.
2. After the initial fetch - for the mailing that triggered the unsubscribe - there is a recursive fetch loop that goes back up the tree of mailings that were used to include contacts in the lists, finding all their included groups.
The code introduced by the commit above makes (1) return no records, and therefore the second step is never triggered, resulting in no groups whatsoever being identified as the ones to unsubscribe (remove) contacts from.
This is getting orgs using CiviMail in this way in hot water as you can imagine.5.21.0RichRichhttps://lab.civicrm.org/dev/core/-/issues/680"Date Received" for contributions no longer mandatory, also breaks financial ...2019-11-17T20:57:15Zfabian_SYSTOPIA"Date Received" for contributions no longer mandatory, also breaks financial transactionsThis issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contri...This issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contribution field "Date Received" used to be mandatory which imho had several good and important reasons. It is now possible to create a contribution without a date both via the UI and the Rest API.
Having a contribution without a date messes up views, reports and any function based on the contribution date such as receipts or invoices.
Also it creates a financial transaction without a date which cannot be good. In the UI, financial transactions still require a date.
**How to reproduce**
Create a new contribution via the UI and delete the date and time in the field "Date Received". Contribution date and financial transaction date will be empty.5.10https://lab.civicrm.org/dev/core/-/issues/1394CiviCaseTestCase setup() can make duplicate activity type option values2019-11-18T06:54:19ZDaveDCiviCaseTestCase setup() can make duplicate activity type option valuesSee these lines https://github.com/civicrm/civicrm-core/blob/5.19.1/tests/phpunit/CiviTest/CiviCaseTestCase.php#L57-L71 and note that setup() also uses quickCleanup().
```
$optionValues = array(
'Medical evaluation' => 'Medica...See these lines https://github.com/civicrm/civicrm-core/blob/5.19.1/tests/phpunit/CiviTest/CiviCaseTestCase.php#L57-L71 and note that setup() also uses quickCleanup().
```
$optionValues = array(
'Medical evaluation' => 'Medical evaluation',
'Mental health evaluation' => "Mental health evaluation",
'Secure temporary housing' => 'Secure temporary housing',
'Long-term housing plan' => 'Long-term housing plan',
'ADC referral' => 'ADC referral',
'Income and benefits stabilization' => 'Income and benefits stabilization',
);
foreach ($optionValues as $name => $label) {
$activityTypes = $this->callAPISuccess('option_value', 'Create', array(
'option_group_id' => 2,
'name' => $name,
'label' => $label,
'component_id' => 7,
));
```
So for example if you have a dataprovider that calls your test multiple times, it keeps creating new duplicate activity types with the same `name`.
PR coming
In the option_value table definition maybe these keys should be unique keys, but that's extra.
```
KEY `index_option_group_id_value` (`value`(128),`option_group_id`),
KEY `index_option_group_id_name` (`name`(128),`option_group_id`),
```5.21.0https://lab.civicrm.org/dev/core/-/issues/1377Custom Search: Find Contributors by Aggregate Totals does not can use actions...2019-11-19T23:20:23ZCésarCustom Search: Find Contributors by Aggregate Totals does not can use actions with contactsHello,
I trying on dmaster demo to use the actions when results are displayed but doesn't working. I trying to find the error but only see the param: ```$this->_action = CRM_Core_Action::ADVANCED;``` https://github.com/civicrm/civicrm-c...Hello,
I trying on dmaster demo to use the actions when results are displayed but doesn't working. I trying to find the error but only see the param: ```$this->_action = CRM_Core_Action::ADVANCED;``` https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Form/Search.php#L182 who breaks the actions with this custom report.
In https://dmaster.demo.civicrm.org using custom search: "Find Contributors by Aggregate Totals"
![bug](/uploads/8ea17609ae8a63e729d619cf7bb6851b/bug.png)5.20.0https://lab.civicrm.org/dev/core/-/issues/1406Cannot filter by 'Member Since' in Membership Summary Report2019-11-20T21:46:44Zm robimorgan@palantetech.coopCannot filter by 'Member Since' in Membership Summary Report
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this is...
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this issue as I don't have time to dig into it now.
```
Nov 18 12:10:26 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -19
[message] => DB Error: no such field
[mode] => 16
[debug_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[type] => DB_Error
[user_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[to_string] => [db_error: message="DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']"]
)
```5.19.2https://lab.civicrm.org/dev/core/-/issues/1409Record Refund fails due to thousands separator in amount2019-11-20T22:38:55ZkcristianoRecord Refund fails due to thousands separator in amountOverview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the...Overview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the number
Reproduction steps
----------------------------------------
- Create an event Price set with two fee levels 5,000 and 1,000 $ € currency is not material
- Assign Price set to an event
- Add a Participant at 5,000 level and record payment
- Edit the event and change selections to the 1,000 level
- Go to the Contribution and Record Refund
- Choose Payment Method
- Enter Fee Amount
- Save
Current behaviour
----------------------------------------
The form does not save. A message appaears that the Net Amount should be equal to difference between the payment amount and the fee amount
![image](/uploads/33dc65dcfcbfddbb228f897cb2fbb4ca/image.png)
Expected behaviour
----------------------------------------
This error occurs due to the thousands separator. Remove it and it will save.
Expected behavior would be to either handle the thousands separator properly or not display it.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* Browser: FireFox 70
* CiviCRM: 5.19.1
* PHP: Tested on 7.2 and 7.3 (same behavior)
* CMS:WP 5.3_
* Database: MariaDB 10.1
* Web Server: Apache 2.4
Comments
----------------------------------------
There is a work around here, but this is a regression. Tested in 5.14.2 and it worked fine. I have not tested on 5.18 yet, as I wanted to get the report in.5.19.2https://lab.civicrm.org/dev/core/-/issues/1391Cancelled contributions are not greyed out in contribution lists2019-11-20T22:39:10ZPatrick Figelpfigel@greenpeace.orgCancelled contributions are not greyed out in contribution listsOverview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Sear...Overview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Search for any cancelled contribution or open the contribution tab of a contact with a cancelled contribution.
Current behaviour
----------------------------------------
The contribution is not greyed out and does not show the cancellation date below the contribution status.
Expected behaviour
----------------------------------------
The contribution should be greyed out and show the cancellation date below the contribution status.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.19/5.18_
Comments
----------------------------------------
This seems to have regressed somewhere between 5.13 (where it works) and 5.18 (where it doesn't). I'm thinking it might have to do with the introduction of `cancel_date` in `civicrm_contribution_recur`.5.19.2https://lab.civicrm.org/dev/core/-/issues/1374Save after edit on contribution search results loses search filter2019-11-20T22:39:30ZJoeMurraySave after edit on contribution search results loses search filterOn dmaster just now, I searched for contributions with amount from 800 to 800, got 18 results. Edited one of them and saved. Listing now shows all contributions (93). Opening Search criteria I see that the 800 to 800 criteria are still t...On dmaster just now, I searched for contributions with amount from 800 to 800, got 18 results. Edited one of them and saved. Listing now shows all contributions (93). Opening Search criteria I see that the 800 to 800 criteria are still there. Clicking search button gets back original search results of 18 records.
Seems like when closing edit form, there is a refresh of search, but the refresh is missing the criteria. IIRC, there was a recent fix where only the edited item showed up after saving the edit form. So possible regression. This is an irritation rather than crucial functionality.5.19.2https://lab.civicrm.org/dev/core/-/issues/1410civicrm/case/search?reset=1&force=1&case_subject=test gives php warning2019-11-22T01:47:09ZDaveDcivicrm/case/search?reset=1&force=1&case_subject=test gives php warningI know there's still ongoing work related to force=1 in urls for search, but reporting that `civicrm/case/search?reset=1&force=1&case_subject=test` gives `Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_...I know there's still ongoing work related to force=1 in urls for search, but reporting that `civicrm/case/search?reset=1&force=1&case_subject=test` gives `Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_Common->_getAttrString()`
The results seem correct, there's just the php warning.5.21.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/1383Re-installation of Extension With Custom Fields and Logging Enabled Causes Error2019-11-22T02:26:47ZCamilo RodríguezRe-installation of Extension With Custom Fields and Logging Enabled Causes ErrorOverview
----------------------------------------
If logging is enabled, CiviCRM will create log tables for every table in the CiviCRM Schema. If an extension added custom groups and fields, logging tables for those custom groups will be...Overview
----------------------------------------
If logging is enabled, CiviCRM will create log tables for every table in the CiviCRM Schema. If an extension added custom groups and fields, logging tables for those custom groups will be created. When the extension is uninstalled, custom groups and fields will get deleted. However, logging tables will remain unaffected. This may be desireable behaviour (ie. keeping the loog of tables that used to exist in DB), but if the extension is re-installed, current handling of custom fields will cause a DB error, as fields will try to be added again to the logging tables as duplicates.
Reproduction steps
----------------------------------------
1. Enable DB logging.
1. Install an extension that creates custom groups and fields, and deletes them on uninstallation (ie. https://github.com/compucorp/uk.co.compucorp.manualdirectdebit).
1. Uninstall the extension.
1. Re-install the extension.
1. A DB error is thrown, making it impossible to re-install the extension, and leaving the DB in an inconsistent state, as the extension will be half-way through installation, with some changes already commited to DB.
Current behaviour
----------------------------------------
1. Enable DB logging.
1. Install an extension that creates custom groups and fields, and deletes them on uninstallation (ie. https://github.com/compucorp/uk.co.compucorp.manualdirectdebit).
1. Uninstall the extension.
1. Re-install the extension.
1. A DB error is thrown, making it impossible to install the extension, and leaving the DB in an inconsistent state, as the extension will be half-way through installation, with some changes already commited to DB.
Expected behaviour
----------------------------------------
1. Enable DB logging.
1. Install an extension that creates custom groups and fields, and deletes them on uninstallation (ie. https://github.com/compucorp/uk.co.compucorp.manualdirectdebit).
1. Uninstall the extension.
1. Re-install the extension.
1. The extension is installed successfully.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.20.0/5.19.1/5.19.0
* __PHP:__ _7.0/7.1/7.2/7.3/..._
* __CMS:__ _Drupal 7.30..._
* __Database:__ _MySQL 5.7.7_
* __Web Server:__ _Apache 2.4/Nginx 1.16_
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.20.0https://lab.civicrm.org/dev/core/-/issues/1414Url search with `civicrm/case/search?case_owner=2&force=1` gives an E_NOTICE2019-11-22T02:47:10ZDaveDUrl search with `civicrm/case/search?case_owner=2&force=1` gives an E_NOTICEThis just started in master recently and I can't reproduce in 5.20 but I can on the public demo which is 5.21alpha1.
Running a url search `civicrm/case/search?reset=1&case_owner=2&force=1` gives
`Notice: Undefined index: html in CRM_Co...This just started in master recently and I can't reproduce in 5.20 but I can on the public demo which is 5.21alpha1.
Running a url search `civicrm/case/search?reset=1&case_owner=2&force=1` gives
`Notice: Undefined index: html in CRM_Core_Form_Search->getEntityDefaults() (line 291 of ...\CRM\Core\Form\Search.php)`
ping @seamuslee5.21.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/1384JPATH_BASE calculated incorrectly in a system running under a virtual directo...2019-11-22T15:47:08ZspalmstromJPATH_BASE calculated incorrectly in a system running under a virtual directory under Windows and JoomlaOverview
----------------------------------------
_Please describe your problem or bug in detail._
Reproduction steps
----------------------------------------
CiviCRM is set up under Joomla using a virtual directory under an IIS based w...Overview
----------------------------------------
_Please describe your problem or bug in detail._
Reproduction steps
----------------------------------------
CiviCRM is set up under Joomla using a virtual directory under an IIS based web site, e.g. https://example.com/subdir/
Current behaviour
----------------------------------------
Running say the cron job (cron.php) yields this error.
<disk>:\Web root\libraries/vendor/autoload.php. CiviCRM does not record cron to have run.
Expected behaviour
----------------------------------------
_What should happen._
This should be opened.
<disk>:\Web root\subdir\libraries\vendor\autoload.php"
CiviCRM should record cron to have run.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Edge
* __CiviCRM:__ _Release 5.19.1 (but seen in many earlier versions).
* __PHP:__ _7.2.24...__
* __CMS:__ _Joomla 3.9.6/..._
* __Database:__ _MySQL 5.7.28..._
* __Web Server:__ _IIS under Windows 10..._
Comments
----------------------------------------
_Replacing line 569 in <CMS root>/administrator/components/com_civicrm/civicrm/CRM/Utils/System/Joomla.php
with
define('JPATH_BASE', $joomlaBase . DS. 'administrator'); // to make sure we analyse correctly in the Windows environment
seems to solve the problem. I plan to create a PR, but this just flags the issue as a placeholder. Maybe someone else is working on the same file, and in which case can pick it up.
The issue occurs because line 12 of /administrator/includes/defines.php uses the directory separator to explode JPATH_BASE into its component parts. If, therefore, the separator between subdirectory and administrator directories is not the directory separator, JPATH_BASE won't be analysed correctly.5.21.0https://lab.civicrm.org/dev/release/-/issues/9Automatically tag the drupal-8 repository2019-11-22T21:42:52ZbgmAutomatically tag the drupal-8 repositoryWhen new CiviCRM releases are published, the main core+cms repositories are tagged for that version. Except Drupal8.
This can complicate the version tracking when one wants to track the core version (tag) + CMS version (currently only b...When new CiviCRM releases are published, the main core+cms repositories are tagged for that version. Except Drupal8.
This can complicate the version tracking when one wants to track the core version (tag) + CMS version (currently only branches are available).
Ex: https://github.com/civicrm/civicrm-drupal-8/pull/23https://lab.civicrm.org/dev/drupal/-/issues/95Participant is_test field was missing from drupal views2019-11-22T23:37:05Zmagnolia61Participant is_test field was missing from drupal viewsThe Participant is_test field was missing from drupal views
I used the same approach as the membership is_test field to add it.
https://github.com/civicrm/civicrm-drupal/pull/590The Participant is_test field was missing from drupal views
I used the same approach as the membership is_test field to add it.
https://github.com/civicrm/civicrm-drupal/pull/5905.21.0magnolia61magnolia61https://lab.civicrm.org/dev/core/-/issues/1382'Delivery has not yet begun for this mailing' warning although mails have bee...2019-11-23T03:43:16Zczollli'Delivery has not yet begun for this mailing' warning although mails have been deliveredOverview
----------------------------------------
After 5.19.0 upgrade we are facing this warning![delivery_warning](/uploads/12ff752b5571cd43ec013784c3c9730a/delivery_warning.png)
Reproduction steps
------------------------------------...Overview
----------------------------------------
After 5.19.0 upgrade we are facing this warning![delivery_warning](/uploads/12ff752b5571cd43ec013784c3c9730a/delivery_warning.png)
Reproduction steps
----------------------------------------
1. Click on **Report** of a successfully completed mailing.
Current behaviour
----------------------------------------
```
Delivery has not yet begun for this mailing. If the scheduled delivery date and time is past, ask the system administrator or technical support contact for your site to verify that the automated mailer task ('cron job') is running - and how frequently. (learn more...) ```
Expected behaviour
----------------------------------------
No warning
Environment information
----------------------------------------
* __Browser:__ _Firefox 59.0.1/Chrome 78.0.3904/Safari 13_
* __CiviCRM:__ _5.19.0_
* __PHP:__ _7.1__
* __CMS:__ _Drupal 7.67_
* __Database:__ _MariaDB 10.1.41_
* __Web Server:__ _Nginx 1.10.3_
Comments
----------------------------------------https://lab.civicrm.org/dev/core/-/issues/993Removing 'Transgender' from the gender default options2019-11-23T21:06:29Zolivier-13Removing 'Transgender' from the gender default optionsCiviCRM provides by default three options for the gender of an individual contact : Male, Female, and Transgender. But as a LGBT activist, I learned (from a trans person) that transgender isn't a gender.
As a male, you can be a transgend...CiviCRM provides by default three options for the gender of an individual contact : Male, Female, and Transgender. But as a LGBT activist, I learned (from a trans person) that transgender isn't a gender.
As a male, you can be a transgender male : you're gender identity is different of you're sexual identity (a male who was born female). Or you can be a cisgender male : you're gender identity and you're sexual identity are the same (a male who was born male). The same applies of course for female.
So don't you think 'Transgender' default option should be removed ? It may be replaced with 'Non-binary' (People who don't feel either male or female).https://lab.civicrm.org/dev/core/-/issues/369Deletion of SMS provider caused all scheduled reminders to fail to be sent2019-11-23T21:18:11ZandrewcormickdockeryDeletion of SMS provider caused all scheduled reminders to fail to be sentA user recently deleted an SMS provider. Unfortunately there were live SMS scheduled reminders attached to that provider. This caused the cron call to job.send_reminder to fail with the message "Provider not known or not provided". Th...A user recently deleted an SMS provider. Unfortunately there were live SMS scheduled reminders attached to that provider. This caused the cron call to job.send_reminder to fail with the message "Provider not known or not provided". This is a "fatal" error, meaning that the cron job failed immediately, regardless of the fact that there were many perfectly valid reminders which needed processing.
I have a few points to make about this:
1. An SMS provider should not be able to be deleted with linked active SMS scheduled reminders, or at least a warning ought to be displayed and the affected reminders automatically disabled.
2. The following constraint on the civicrm_action_schedule table looks suspect (I can't see how it could ever lead to anything appropriate happening) - the "ON DELETE SET NULL" directly led to the problem described above: ``CONSTRAINT `FK_civicrm_action_schedule_sms_provider_id` FOREIGN KEY (`sms_provider_id`) REFERENCES `civicrm_sms_provider` (`id`) ON DELETE SET NULL``
3. The "Provider not known or not provided" error ought to be a warning, not a "fatal" error. There is no need for the code to stop proceeding if a provider cannot be found, only that that particular reminder cannot be invoked.5.15.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/1350Ignoring exception thrown by nullHandler: -2, DB Error: syntax error2019-11-23T22:35:45ZmfbIgnoring exception thrown by nullHandler: -2, DB Error: syntax errorAdvanced search can result in DB errors; it appears the bug is in CRM/Core/PrevNextCache/Sql.php
Steps to reproduce:
1. Fire up CiviCRM 5.18.4
1. Visit advanced search @ civicrm/contact/search/advanced
1. Click Address Fields and enter...Advanced search can result in DB errors; it appears the bug is in CRM/Core/PrevNextCache/Sql.php
Steps to reproduce:
1. Fire up CiviCRM 5.18.4
1. Visit advanced search @ civicrm/contact/search/advanced
1. Click Address Fields and enter 1600 under the Street Address field.
1. Click Search; search completes successfully.
1. Check your error log for "$backTrace = #0..." and "Ignoring exception thrown by nullHandler: -2, DB..."
I think what happens is `%` is automatically tacked on to make it a "LIKE" search, and this results in `%1600` in the query.. the %1 parameter is then filled, resulting in invalid SQL.
The DB error is e.g.:
```
1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'civicrm search 9dcac50894b9b820a311612b44525018_1779'600%' ) AND (contact_a.is_' at line 2
```
The query is e.g.:
```
INSERT INTO civicrm_prevnext_cache (cachekey, entity_id1, data)
SELECT DISTINCT 'civicrm search 9dcac50894b9b820a311612b44525018_1779', contact_a.id, contact_a.sort_name FROM civicrm_contact contact_a LEFT JOIN civicrm_address ON ( contact_a.id = civicrm_address.contact_id AND civicrm_address.is_primary = 1 ) WHERE ( civicrm_address.street_address LIKE ''civicrm search 9dcac50894b9b820a311612b44525018_1779'600%' ) AND (contact_a.is_deleted = 0) LIMIT 0, 500
```https://lab.civicrm.org/dev/drupal/-/issues/33Implement userFrameworkFrontend Configuration for Drupal2019-11-24T05:41:04ZseamusleeImplement userFrameworkFrontend Configuration for DrupalThis is to support the concept of Separate frontend and backend themesThis is to support the concept of Separate frontend and backend themes5.16.0