Development issueshttps://lab.civicrm.org/groups/dev/-/issues2024-03-13T05:03:27Zhttps://lab.civicrm.org/dev/core/-/issues/1450Multisite domain group fails on 5.20.02024-03-13T05:03:27ZandyburnsMultisite domain group fails on 5.20.0Overview
----------------------------------------
After an upgrade to 5.20.0, with WP multisite using the Multisite Permissioning extension version 2.7.3 (https://github.com/eileenmcnaughton/org.civicrm.multisite), users roles which rely...Overview
----------------------------------------
After an upgrade to 5.20.0, with WP multisite using the Multisite Permissioning extension version 2.7.3 (https://github.com/eileenmcnaughton/org.civicrm.multisite), users roles which rely on that extension in a domain group that has greater than 20,736 records fail to load contacts in CiviCRM. Any amount above this will return errors. They cannot even view their own contact.
On 5.19.2 and multisite permisisoning ext version 2.7.2 we had 69,713 records in a domain group and it worked.
We tried reverting to the 2.7.2 of this extension but it had no effect.
We know that it is a combination of version 5.20.0 and the multisite extension because we have other user roles at the county level that rely on 2nd degree relationship permissioning only and not the 'view all contact in domain' permission of the multisite extension for instance. Conversely, users who are administrators have no issue using the effected sites that have greater than 20,736 records in the domain group.
We tried to increase the maximum size of temporary tables in MySQL but it had no effect.
I think this is a core issue as the extension worked in 5.19.2. But feel free to move this issue to https://github.com/eileenmcnaughton/org.civicrm.multisite/issues if that makes more sense.
@eileen @kcristiano @seamuslee
Reproduction steps
----------------------------------------
1. Put more than 20736 records into a multisite permission group
2. Make that the multisite domain group
3. Do any search
4. Receive the following errors:
This error occurred after an advanced search
```
Database Error Code: The table 'civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95' is full, 1114
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => INSERT INTO civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95 (user_id, contact_id, operation) SELECT DISTINCT 168522 as user_id, contact_a.id as contact_id, 'Edit' as operation
FROM civicrm_contact contact_a LEFT JOIN my_relationships_168522_75879 permrelationships
ON (contact_a.id = permrelationships.contact_id)
LEFT JOIN civicrm_group_contact multisiteGroupTable ON contact_a.id = multisiteGroupTable.contact_id
WHERE ((multisiteGroupTable.group_id IN (32,133) AND multisiteGroupTable.status IN ('Added') AND contact_a.is_deleted = 0) OR permrelationships.contact_id IS NOT NULL ) AND (contact_a.is_deleted = 0) [nativecode=1114 ** The table 'civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95' is full]
[type] => DB_Error
[user_info] => INSERT INTO civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95 (user_id, contact_id, operation) SELECT DISTINCT 168522 as user_id, contact_a.id as contact_id, 'Edit' as operation
FROM civicrm_contact contact_a LEFT JOIN my_relationships_168522_75879 permrelationships
ON (contact_a.id = permrelationships.contact_id)
LEFT JOIN civicrm_group_contact multisiteGroupTable ON contact_a.id = multisiteGroupTable.contact_id
WHERE ((multisiteGroupTable.group_id IN (32,133) AND multisiteGroupTable.status IN ('Added') AND contact_a.is_deleted = 0) OR permrelationships.contact_id IS NOT NULL ) AND (contact_a.is_deleted = 0) [nativecode=1114 ** The table 'civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95' is full]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="INSERT INTO civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95 (user_id, contact_id, operation) SELECT DISTINCT 168522 as user_id, contact_a.id as contact_id, 'Edit' as operation
FROM civicrm_contact contact_a LEFT JOIN my_relationships_168522_75879 permrelationships
ON (contact_a.id = permrelationships.contact_id)
LEFT JOIN civicrm_group_contact multisiteGroupTable ON contact_a.id = multisiteGroupTable.contact_id
WHERE ((multisiteGroupTable.group_id IN (32,133) AND multisiteGroupTable.status IN ('Added') AND contact_a.is_deleted = 0) OR permrelationships.contact_id IS NOT NULL ) AND (contact_a.is_deleted = 0) [nativecode=1114 ** The table 'civicrm_tmp_e_aclccache_d12b740b9b1f6940027087701e827d95' is full]"]
)
```
Current behavior
----------------------------------------
Unable to find contacts in CiviCRM rendering it unusable for users relying on multisite permissioning extension.
Environment information
----------------------------------------
* __Browser: Any
* __CiviCRM: 5.20.0
* __PHP: 7.2.25-1+ubuntu18.04.1+deb.sury.org+1
* __CMS: WordPress 5.3
* __Database: (Ubuntu) v5.7.28
* __Web Server: Apache/2.4.41 (Ubuntu)https://lab.civicrm.org/dev/core/-/issues/5089WP FormBuilder: u.hoverintent is not a function2024-03-12T23:54:12Zaydunsaidan.saunders@squiffle.ukWP FormBuilder: u.hoverintent is not a function## Overview
On WordPress, going to the FormBuilder page produces the js error `Uncaught TypeError: u.hoverintent is not a function`
## Reproduction steps
1. Log on to https://wpmaster.demo.civicrm.org (or a BuildKit new installation o...## Overview
On WordPress, going to the FormBuilder page produces the js error `Uncaught TypeError: u.hoverintent is not a function`
## Reproduction steps
1. Log on to https://wpmaster.demo.civicrm.org (or a BuildKit new installation of wpmaster)
2. Open your browser's Developer Tools
3. Go to `Administer > Customise Data & Screens > FormBuilder`
4. Observer the console errors:
```
Uncaught TypeError: u.hoverintent is not a function
<anonymous> https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
EventListener.handleEvent* https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
<anonymous> https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
admin-bar.min.js:2:2979
<anonymous> https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
(Async: EventListener.handleEvent)
<anonymous> https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
<anonymous> https://wpmaster.demo.civicrm.org/wp-includes/js/admin-bar.min.js?ver=6.4.3:2
jQuery.Deferred exception: f.find(...).hoverIntent is not a function @https://wpmaster.demo.civicrm.org/wp-admin/js/common.min.js?ver=6.4.3:2:12296
e@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:27028
Deferred/then/l/</t<@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:27330
setTimeout handler*Deferred/then/l/<@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:27594
c@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:25304
fireWith@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:26053
fire@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:26089
c@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:25304
fireWith@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:26053
ready@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:29112
P@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:28884
EventListener.handleEvent*@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:29264
@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:220
@https://wpmaster.demo.civicrm.org/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils&ver=6.4.3:2:225
undefined load-scripts.php:2:28648
downloadable font: Glyph bbox was incorrect (glyph ids 33 55 62 81 82 83 84 87 88 89 90 112 119 120 123 139 159 162 164 166 178 184 185 217 218 272 273 274 275 279 281 284 290 291 292 309 310 319 321 323 326 329 330 331 332 333 334 339 341 347 349 351 352 353 354 357 358 361 366 367 370 371 414 431 436 444 445 458 460 464 465 483 505 508 511 514 516 517 518 520 521 538 539 546 568 574 579 580 585 586 594 596 599 602 603 616 618 622 627 629 630 633 634 638 643 645 651 654 665 675 685 686 688 691) (font-family: "FontAwesome" style:normal weight:400 stretch:100 src index:1) source: https://wpmaster.demo.civicrm.org/wp-content/plugins/civicrm/civicrm/bower_components/font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0
Uncaught TypeError: f.find(...).hoverIntent is not a function
<anonymous> https://wpmaster.demo.civicrm.org/wp-admin/js/common.min.js?ver=6.4.3:2
jQuery 13
common.min.js:2:12296
```
## Current behaviour
Errors
## Expected behaviour
No errors!
## Environment information
* **CiviCRM:** _Master_
* **CMS:** _WordPress 6.4.3 - Does not occur on Drupal_
## Comments
_Anything else you would like the reviewer to note._https://lab.civicrm.org/dev/core/-/issues/5081Event Online Receipt can yield Smarty error2024-03-12T19:26:34ZJonGoldEvent Online Receipt can yield Smarty errorCurrently, the `selfcancelxfer_time` field in Civi can be `NULL`. But if it's set to `NULL` then submitting an online event registration crashes because you can't compare it to an integer in this template line in `event_reg_online`:
```...Currently, the `selfcancelxfer_time` field in Civi can be `NULL`. But if it's set to `NULL` then submitting an online event registration crashes because you can't compare it to an integer in this template line in `event_reg_online`:
```
{capture assign=selfservice_preposition}{if {event.selfcancelxfer_time|boolean} && {event.selfcancelxfer_time} > 0}{ts}before{/ts}{else}{ts}after{/ts}{/if}{/capture}
```https://lab.civicrm.org/dev/core/-/issues/4864Edit contribution Undefined array key on dmaster2024-03-12T17:47:47ZJoeMurrayEdit contribution Undefined array key on dmasterTrying to edit contribution created at https://lab.civicrm.org/dev/core/-/issues/4863 leads to page of php/smarty issues:
Warning: Undefined array key "defaultContribution" in include() (line 86 of /srv/buildkit/build/dmaster/.civibuild...Trying to edit contribution created at https://lab.civicrm.org/dev/core/-/issues/4863 leads to page of php/smarty issues:
Warning: Undefined array key "defaultContribution" in include() (line 86 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "displayLineItemFinancialType" in include() (line 24 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 32 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 37 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 44 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "displayLineItemFinancialType" in include() (line 57 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 70 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 74 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 90 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 102 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 124 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "hookDiscount" in include() (line 151 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).https://lab.civicrm.org/dev/core/-/issues/5037Standalone: installation of CiviCRM in another language2024-03-12T13:23:06ZjaapjansmaStandalone: installation of CiviCRM in another languageThe installer for CiviCRM standalone gives an error message when you select another language then English.
The installer is capable of downloading the translation files however this is not implemented yet in the standalone installer.The installer for CiviCRM standalone gives an error message when you select another language then English.
The installer is capable of downloading the translation files however this is not implemented yet in the standalone installer.jaapjansmajaapjansmahttps://lab.civicrm.org/dev/core/-/issues/3674mailing acl permission check via php api2024-03-12T05:03:17ZAlanDixonmailing acl permission check via php apiWhen trying to send mail via cv api job.process_mailing, or drush (using drush civicrm: https://www.drupal.org/project/civicrm_drush/issues/3290970#comment-14578047), CiviCRM generates an error "API permission check failed for Group/get ...When trying to send mail via cv api job.process_mailing, or drush (using drush civicrm: https://www.drupal.org/project/civicrm_drush/issues/3290970#comment-14578047), CiviCRM generates an error "API permission check failed for Group/get call; insufficient permission: require access CiviCRM"
There are two sort-of work arounds with cv: either of "cv api job.execute" (if that job is enabled) or "cv --user=admin api job.process_mailing" (where admin is the cms username of an admin-permissioned user).
When inserting breakpoints to try and understand what's going on, it appears that the failure is happening here:
https://github.com/civicrm/civicrm-core/blob/8ce670176eac89314f9d593fc5245d62e32e8204/CRM/Mailing/BAO/Mailing.php#L2238
It's unclear to me why the two work-arounds avoid this.
Conclusion: the process_mailing job is demanding too many permissions when invoked via the php api.https://lab.civicrm.org/dev/core/-/issues/3683Not possible to choose primary phone numbers without specific address type2024-03-12T05:03:16ZMariaVNot possible to choose primary phone numbers without specific address typeWe have noticed that it is not possible to choose the primary phone number in a profile:
![grafik](/uploads/694bacb4693b362759835664b0403fd3/grafik.png)
As you can see in the screenshot, it is necessary to choose an address type as wel...We have noticed that it is not possible to choose the primary phone number in a profile:
![grafik](/uploads/694bacb4693b362759835664b0403fd3/grafik.png)
As you can see in the screenshot, it is necessary to choose an address type as well.
For example: Creating an individual search view with the primary number is not working.
If I choose address type "Mobile", only primary numbers of this type will be shown but it could be that other primary numbers have i.e. the type "Work".
While with e-mail adresses I have this option:
![grafik](/uploads/e09c2e45b05fc88ae72bef30fe0a7da2/grafik.png)
There I can choose just primary and I think it should be the same way with phone numbers.
So I am wondering if there is any reason why it is different with phone numbers?
Thanks in advance for any support!https://lab.civicrm.org/dev/core/-/issues/5040Events - Registration Confirmation and Receipt (on-line) template fails to co...2024-03-12T00:54:25ZspalmstromEvents - Registration Confirmation and Receipt (on-line) template fails to compileOverview
----------------------------------------
The default `Events - Registration Confirmation and Receipt (on-line)` fails to compile, giving this error:
`"Syntax error in template "eval:{crmScope extensionKey=""}<!DOCTYPE html..."...Overview
----------------------------------------
The default `Events - Registration Confirmation and Receipt (on-line)` fails to compile, giving this error:
`"Syntax error in template "eval:{crmScope extensionKey=""}<!DOCTYPE html..." on line 471 "{capture assign=selfservice_preposition}{if 0 && > 0}{ts}before{/ts}{else}{ts}after{/ts}{/if}{/capture}" - Unexpected "> ""`
|----------------------------------------------------------|
Reproduction steps
----------------------------------------
1. Attempt to register for an event.
1. Enter details.
1. Click on Review.
1. Click on Register.
1. You get an error message.
Current behaviour
----------------------------------------
This error message is generated internally, but was only visible when debugging because of [Call to SmartyCompilerException fails in <drupal root>/vendor/civicrm/civicrm-packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php on template compiler error.
](https://lab.civicrm.org/dev/core/-/issues/5039)
```
"Syntax error in template "eval:{crmScope extensionKey=""}<!DOCTYPE html..." on line 471 "{capture assign=selfservice_preposition}{if 0 && > 0}{ts}before{/ts}{else}{ts}after{/ts}{/if}{/capture}" - Unexpected "> ""
```
Expected behaviour
----------------------------------------
You get a registration confirmation page.
Environment information
----------------------------------------
* __Browser:__ _MS Edge_ but probably irrelevant
* __CiviCRM:__ _5.70.1_
* __PHP:__ _8.3.1__
* __CMS:__ _Drupal 10.2.3_
* __Database:__ _MySQL 8.0.36_ but probably irrelevant.
* __Web Server:__ _IIS_ but probably irrelevant.
Comments
----------------------------------------
The 'offending' code is somewhere here, I suspect (lines 461 - 471) but I haven't been able to discover it.
```
{if {event.allow_selfcancelxfer|boolean}}
<tr>
<td colspan="2" {$valueStyle}>
{capture assign=selfservice_preposition}{if {event.selfcancelxfer_time|boolean} && {event.selfcancelxfer_time} > 0}{ts}before{/ts}{else}{ts}after{/ts}{/if}{/capture}
{ts 1="{event.selfcancelxfer_time}" 2="$selfservice_preposition"}You may transfer your registration to another participant or cancel your registration up to %1 hours %2 the event.{/ts}
{if {contribution.paid_amount|boolean}}{ts}Cancellations are not refundable.{/ts}{/if}<br/>
{capture assign=selfService}{crmURL p='civicrm/event/selfsvcupdate' q="reset=1&pid={participant.id}&{contact.checksum}" h=0 a=1 fe=1}{/capture}
<a href="{$selfService}">{ts}Click here to transfer or cancel your registration.{/ts}</a>
</td>
</tr>
{/if}
```5.71.0https://lab.civicrm.org/dev/core/-/issues/3669Thank-you letter for soft credit contributions2024-03-11T05:03:25ZmasettoThank-you letter for soft credit contributionsOverview
----------------------------------------
When printing the thank-you letters for soft credits, it does not print all soft credit contributions.
Reproduction steps
----------------------------------------
1. Create a contributio...Overview
----------------------------------------
When printing the thank-you letters for soft credits, it does not print all soft credit contributions.
Reproduction steps
----------------------------------------
1. Create a contribution for Household and create a soft credit for each of household members (I have 2 household relations: Head of Household and Household member).
1. Go to Find contributions and search only "Soft credits only"
1. Check the soft credit contributions just created
2. Select "Thank-you letters" action
3. Choose a Template
4. Click on Preview button o Make Thank-you letters button
Current behaviour
----------------------------------------
Print only one page.
If in search result there are others unselected rows, it prints information about other contributions, not in selection!
Expected behaviour
----------------------------------------
Should print one page for each soft credit.
Environment information
----------------------------------------
* __Browser:__ _Firefox 101.0.1
* __CiviCRM:__ 5.50.3
* __PHP:__ _7.4
* __CMS:__ Drupal 9
* __Database:__ MySQL 8.0.27-0ubuntu0.20.04.1
* __Web Server:__ _Apache 2.4https://lab.civicrm.org/dev/core/-/issues/3692Replace all calls to deprecated method CRM_Core_PseudoConstant::activityType()2024-03-11T05:03:24ZherbdoolReplace all calls to deprecated method CRM_Core_PseudoConstant::activityType()There are calls to `CRM_Core_PseudoConstant::activityType()` (deprecated) in many places such as `$activityTypes = CRM_Core_PseudoConstant::activityType(TRUE, FALSE, FALSE, 'name');` ~~but the actual method accepts no parameters. And cha...There are calls to `CRM_Core_PseudoConstant::activityType()` (deprecated) in many places such as `$activityTypes = CRM_Core_PseudoConstant::activityType(TRUE, FALSE, FALSE, 'name');` ~~but the actual method accepts no parameters. And changes to that method predate the migration from SVN... so some guesswork needs to be done~~.
Update: oops I just noticed it has `func_get_args()` so it is accepting parameters after all.
In some cases it seems that it can be replaced with `CRM_Core_PseudoConstant::getKey('CRM_Activity_BAO_Activity', 'activity_type_id', 'ACTIVITYNAME')` but in other cases it actually does need a list of activity types. And in some cases needs to filter out disabled components, which is what the original method is doing.https://lab.civicrm.org/dev/core/-/issues/3708Feature request - Add link type to case activity setup2024-03-10T05:03:23ZkristinecFeature request - Add link type to case activity setupOverview
----------------------------------------
In CiviCase, create an option to add an internal/external link on the list of activity types.
Example use-case
----------------------------------------
1. Click on **Administer -> CiviC...Overview
----------------------------------------
In CiviCase, create an option to add an internal/external link on the list of activity types.
Example use-case
----------------------------------------
1. Click on **Administer -> CiviCase -> Case Types -> Edit Housing Support**.
2. Click on **Activity Types** tab
Current behaviour
----------------------------------------
Currently, admins can only add activity types in civicrm (using the "Add activity type" dropdown).
Proposed behaviour
----------------------------------------
Admin users could really benefit from an "add link type" setting. I propose two fields: title and path/url. This would allow admins to link to webforms/afforms in the future for additional data entry but leveraging their features (e.g., conditional fields, layout control, etc.). For example, user clicks on a case and in the dropdown, sees "Benefits Evaluation", but this is an internal path link rather than a civicase form.
Comments
----------------------------------------
Not sure if this would be considered an extension or part of civicore. Also, wouldn't mind marking this as a paid issue in case others might be interested in contributing![Link_Type](/uploads/fb77e6502f97f54e0ef323cd6abaf71e/Link_Type.png).https://lab.civicrm.org/dev/core/-/issues/3715vounteer singup form not working properly2024-03-10T05:03:22Zdev@inboundvounteer singup form not working properlyOverview
----------------------------------------
On submission of volunteer signup form. we get a fatal error. "This page isn’t working" and "HTTP ERROR 500" and messages like "www.site.com is currently unable to handle this request."
...Overview
----------------------------------------
On submission of volunteer signup form. we get a fatal error. "This page isn’t working" and "HTTP ERROR 500" and messages like "www.site.com is currently unable to handle this request."
And sometime it gives an eroor like "Could not find valid value for needs"
Reproduction steps
----------------------------------------
1. Click on volunteer now -> selected an opportunity.
1. Entered **First Name** and **Last Name** and clicked **submit**.
1. Got an error "**Fatal error: This page isn’t working and HTTP ERROR 500".
Current behaviour
----------------------------------------
Currently there is fatal error occurred when we submit volunteer signup form. sometime it says the could not find valid value for need.
And when i tried to search for the opportunity it gives an error message like "need 1 bu found 25"
![Screenshot_2022-07-05_at_11.49.27_AM](/uploads/cbe07cd6cfa94e1bf6bb9abcd8e18744/Screenshot_2022-07-05_at_11.49.27_AM.png)
Expected behaviour
----------------------------------------
There should be no error when we submit the volunteer singup form.
And when we search for opportunities then it should display available opportunites list.
And there should be option to check volunteer singup form fields, we should able to add,edit this form fields.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ Version 103.0.5060.53
* __CiviCRM:__ Version 5.17.0 <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __CiviEvent Widget:__ Version 3.2
* __civiVolunteer :__ Version 4.7.31-3.2.3.1
* __CMS:__ WordPress 5.0.15https://lab.civicrm.org/dev/core/-/issues/3696Should MessageTemplate.send support tplParams with Smarty disabled?2024-03-09T05:03:24ZRichShould MessageTemplate.send support tplParams with Smarty disabled?The api3 MessageTemplate.send action has supported `tplParams` since its inception in 2013, exposed explicitly in the api spec since 2015.
They allow a way to specify content for arbitrary email template parameters: `{$paramname}` - whi...The api3 MessageTemplate.send action has supported `tplParams` since its inception in 2013, exposed explicitly in the api spec since 2015.
They allow a way to specify content for arbitrary email template parameters: `{$paramname}` - which are different to `[entity.tokens]`. It's **super useful** for transactional mail where you want to include extra info as a one-off.
The api has done this by assigning the given key value pairs as Smarty variables.
More recently (2020) the api action added support for disabling Smarty, since it wasn't playing nicely with message template content generated by Mosaico.
Without Smarty, `tplParams` does not work.
## I would like to see support for `tplParams` without Smarty.
I think the concept of a message template is that it is a flexible template for emails. (Adding token support for one-off context-sensitive use-cases is very inefficient and is likely to end up with hackish situations where the data that needs to be in the email does not need to be in the database.)
I mistakenly thought that it used to work this way, and so I wrote a PR to fix what I saw as a regression, adding tests to boot. https://github.com/civicrm/civicrm-core/pull/19062 however this stalled, because it turns out it wasn't a regression, and so was felt to need more discussion. Hence this post.
The PR is a minor change and I can't see that it has any negative consequences/side effects (very few people will disable smarty anyway), but it does mean the tplParams feature is supported with/out Smarty, which I think is valuable.
There could be nicer ways to specify such content, but this isn't a proposal about a whole new way of doing things.
Thoughts?https://lab.civicrm.org/dev/core/-/issues/3718Profile listings fail to show email addresses when their location type Name d...2024-03-09T05:03:24ZspalmstromProfile listings fail to show email addresses when their location type Name differs from its Display NameOverview
----------------------------------------
If you create a location type and have different Names and Display Names, then a profile listing uses it fails to display the data.
Reproduction steps
-----------------------------------...Overview
----------------------------------------
If you create a location type and have different Names and Display Names, then a profile listing uses it fails to display the data.
Reproduction steps
----------------------------------------
1. Create a new location type with Name say TestingTesting and Display Name 'Testing Testing'.
2. Create a listing profile to display that location type.
3. Assign an email address of that type to a user.
4. Use the profile to display that user.
Current behaviour
----------------------------------------
Erik Adams detail viewed:
![image](/uploads/f1cda7c22218f4983bad7b1afadbeec6/image.png)
The email address does not show in the listing:
![image](/uploads/bacb9d89a6156a1504a64b7781be4838/image.png)
Expected behaviour
----------------------------------------
_What should happen._
![image](/uploads/c08545abfca4db63e1e3143ac52698b6/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _MS Edge_ but probably not relevant
* __CiviCRM:__ _ 5.52.alpha1._ It is the Demo system<!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP__ _Whatever Demo is running_
* __CMS:__ _Drupal 9_ the version Demo is running.
* __Database:__ _Whatever Demo is running_.
* __Web Server:__ _Whatever runs Demo_
Comments
----------------------------------------
I have spent a few hours attempting to debug on a local system, but haven't been able to discover where the SELECT statement is being created. What appears to be happening is that the SELECT statement is has the Name of the Location Type as a column, whilst the Profile is expecting the Display Name, so when they don't match, the latter displays nothing.
You should note that if the Name is say Testing_Testing and the Display Name is 'Testing Testing', that the data are displayed. This is because somewhere in the Profile display spaces are replaced by underscores. It is how I was able to obtain the expected behaviour.
I am flagging this up in the hope that someone with more expertise than I can more easily identify where the solution lies.https://lab.civicrm.org/dev/core/-/issues/4987standalone: agree distribution format(s)2024-03-08T23:55:45ZRichstandalone: agree distribution format(s)Options:
**OPTION 1** Encourage composer-template
**OPTION 2** Encourage tar-ball (with current structure)
**OPTION 3** Encourage tar-ball (with composer-like structure)
(And is it one of those options -- or two of those options)
Mo...Options:
**OPTION 1** Encourage composer-template
**OPTION 2** Encourage tar-ball (with current structure)
**OPTION 3** Encourage tar-ball (with composer-like structure)
(And is it one of those options -- or two of those options)
Moved from [chat](https://chat.civicrm.org/civicrm/pl/4pwoodpzufd4z8x5wqguwhprbw) to save an unwieldy thread therein.
@totten
> i guess in theory # 1+# 3 sounds better than # 1+ # 2. but
>
> 1. even drupal.org appears to be following a structure like # 1+# 2
> 2. the workflow of "download+extract full tarball for composer-project" is a little weird for upgrades. (you need to delete+reset some folders -- but not other folders)
> 3. i'm not entirely sure how to reconcile # 3 with the regular RC workflow. i'm sure it can be sorted; but it's more of a conversation
>
@demerit (sorry, don't know your handle here)
> tarball tarball tarball
...
@wmortada
> For initial installation, having a tarball that a user can just download and install is preferable because it is easier and lowers the barrier to entry. But is this going to make upgrades more tricky for them? What could we do to make upgrades easier in this scenario?
@artfulrobot
> composer rules out hosting where you dont have shell access. Personally I'm cool with that, because you kinda need shell access to do things properly. Ftp for fun, shell for serious. (What a t shirt slogan!).
>
> I dont like messy things like unpack this tarball, replace directories a, b, c swap out file d.
>
> But I also don't love composer esp when it requires scripts to run. I tend to have my php as not owned by www-data, so the scripts won't run as www-data. Also in staging, where the httpd is in a container, I like to be able to manage the codebase from outside the container, but this will probably use a different php version. I'm happy to change my ways, though
>
> Other projects I work with:
>
> Nextcloud: provides a fairly solid upgrade script, even a web ui for upgrades, though they encourage CLI invocation to avoid timeouts. Files owned by www-data so the code writes the code. The CLI call to upgrade handles everything: checks, downloads, checksum checks, backups, moving files, running db migrations. It's solid and reliable, and there's a 'repair' command, in case something goes wrong (eg you tried your luck on the web ui method...)
>
> Roundcube mail: provides an upgrade script as part of the new release. So you download tar, extract to tmp/ run a script from there like install-to.php /path/to/installation/dir/
>
> I sometimes deploy by git too. I guess I could composer offline, commit, push, pull. I sometimes find composer flaky. There's one package that won't download or such. And it's slow (a zillion http requests) and can't be run offline.
>
> But it let's you add bits to your site, e.g. if you have civi as part of a bigger project. Which is nice.
>
> Tarballs are nice. Can be signed. Single download. Works offline.
>
> Barrier to entry: hmmm. Idk tbh. You need CLI access at mo, and as long as there's a reliable few commands to run that can be copy pasted it makes no difference?
>
> I'd quite like to be able to upgrade by git pull! Is that any more realistic in standalone? Probably red herring :blowfish:
>
> Let's not do this though...
> curl https://civicrn.org/gimmestandalone | sudo bash
@clarkac
> Please don't do anything that rules out hosting without shell access. That would discourage people from getting started with Civi, as I did and I've helped around 15 charities to get Civi - all hosted without shell access. I'm sure there are many in amongst the 4,000 D7 sites that don't have shell access.
>
> # 2 on the list is similar to what I do with upgrades with D7 - after backing up, delete the CiviCRM code folder and unpack the tarballs into it. That's so easy, and adding some more to that would be no problemhttps://lab.civicrm.org/dev/core/-/issues/4793Manage Premiums notices2024-03-08T20:20:54ZJoeMurrayManage Premiums noticesOn dmaster just now (5.69.alpha1), navigating to Administer > CiviContribute > Premiums (Thank-you gifts) https://dmaster.demo.civicrm.org/civicrm/admin/contribute/managePremiums?reset=1 titled Manage Premiums, I get notices:
Warning: U...On dmaster just now (5.69.alpha1), navigating to Administer > CiviContribute > Premiums (Thank-you gifts) https://dmaster.demo.civicrm.org/civicrm/admin/contribute/managePremiums?reset=1 titled Manage Premiums, I get notices:
Warning: Undefined array key "cost" in include() (line 38 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%3F/3F3/3F34E079%%ManagePremiums.tpl.php).
Warning: Undefined array key "financial_type" in include() (line 38 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%3F/3F3/3F34E079%%ManagePremiums.tpl.php).5.69.0https://lab.civicrm.org/dev/core/-/issues/3720CiviCRM 5.50.4, New install on WordPress throws fatal error when installation...2024-03-08T05:03:25Zjustinfreeman (Agileware)CiviCRM 5.50.4, New install on WordPress throws fatal error when installation completes - InstallationCanary.php. Error message: Uncaught CRM_Core_Exception: [0: Found installation canary.CiviCRM 5.50.4, New install on WordPress throws fatal error when installation completes - InstallationCanary.php. Error message: Uncaught CRM_Core_Exception: [0: Found installation canary.
Triggers the WordPress email error: Your Site i...CiviCRM 5.50.4, New install on WordPress throws fatal error when installation completes - InstallationCanary.php. Error message: Uncaught CRM_Core_Exception: [0: Found installation canary.
Triggers the WordPress email error: Your Site is Experiencing a Technical Issue
```
WordPress version 6.0
Active theme: Twenty Twenty-Two (version 1.2)
Current plugin: CiviCRM (version 5.50.4)
PHP version 7.4.30
Error Details
=============
An error of type E_ERROR was caused in line 37 of the file /var/www/vhosts/httpdocs/wp-content/plugins/civicrm/civicrm/Civi/Core/InstallationCanary.php. Error message: Uncaught CRM_Core_Exception: [0: Found installation canary. This suggests that something went wrong with tracking installation process. Please post to forum or JIRA.
```
Agileware Ref: CIVICRM-2010https://lab.civicrm.org/dev/core/-/issues/3698Too many custom groups2024-03-08T05:03:22ZkristinecToo many custom groupsTwo years ago, I reported an issue with "too many custom fields" [Issue #1330](https://lab.civicrm.org/dev/core/-/issues/1330). It seems that I have now surpass the limit for the **custom groups** instead of _custom fields_. If I add cus...Two years ago, I reported an issue with "too many custom fields" [Issue #1330](https://lab.civicrm.org/dev/core/-/issues/1330). It seems that I have now surpass the limit for the **custom groups** instead of _custom fields_. If I add custom group number 94, accessing some cases produces an error "case_id is not valid : 1.". Keeping the number of custom groups at 93 removes the error.https://lab.civicrm.org/dev/core/-/issues/5071TypeError when trying to use checkboxes with default non-membership options i...2024-03-08T04:07:50ZFrancis (Agileware)TypeError when trying to use checkboxes with default non-membership options in the Membership section of Contribution PagesOverview
----------------------------------------
If you have a PriceSet with a checkboxes field, that has default options set that **don't** have a membership type associated with them, trying to use it on a Contribution Page causes th...Overview
----------------------------------------
If you have a PriceSet with a checkboxes field, that has default options set that **don't** have a membership type associated with them, trying to use it on a Contribution Page causes that page to crash.
Observed on PHP 8.0, may not be an issue on 7.4 -
Reproduction steps
----------------------------------------
1. Create a membership price set
2. Include in this price set a Checkboxes fields with a default option that does not select a membership type, e.g.
Membership Type
[ ] General - $100
[ ] Student - $50
Be awesome
[ X ] Donate $150 to save the Northern White Rhino
3. Use this price set in the membership context of a Contribution page
4. View the contribution page on the front-end
Current behaviour
----------------------------------------
Contribution page does not load, crashes with TypeError:
```
PHP Fatal error: Uncaught TypeError: strtolower(): Argument #1 ($string) must be of type string, array given in /.../public_html/ontarget/wp-content/plugins/civicrm/civicrm/CRM/Core/DAO.php:1419
```
Backtrace shows this is called from `CRM_Contribute_Form_Contribution_Main->setDefaultValues()`:
https://github.com/civicrm/civicrm-core/blob/4b75775/CRM/Contribute/Form/Contribution/Main.php#L270
(Ref 4b75775 is master at time of this report)
Expected behaviour
----------------------------------------
Contribution page should load, with defaults for all fields correctly applied
Environment information
----------------------------------------
* __CiviCRM:__ _Master, 5.70.2_
* __PHP:__ _8.0+_
Comments
----------------------------------------
I have a working patch for this, however I'm not sure the approach is entirely correct. The code in question appears to be trying to insinuate a Membership Type ID for, again an option (PriceFieldValue) which doesn't specify a membership type. Perhaps this line could... just be removed?5.72.0https://lab.civicrm.org/dev/core/-/issues/5029sms form missing tokens dropdown and save template section at bottom not hidd...2024-03-08T04:06:42ZDaveDsms form missing tokens dropdown and save template section at bottom not hidden properlyIn a "normal" environment the form isn't borked, but in my environment it seems to come from this change: https://github.com/civicrm/civicrm-core/pull/29429/commits/16b1692e4aebf478f39387ddabc08f1a2c2defae#diff-9a9c24bfd65521aa26fbb9fde3...In a "normal" environment the form isn't borked, but in my environment it seems to come from this change: https://github.com/civicrm/civicrm-core/pull/29429/commits/16b1692e4aebf478f39387ddabc08f1a2c2defae#diff-9a9c24bfd65521aa26fbb9fde3fd54d7a31331abebcb5e8e2a23b1a615bb500eL66
It works again if I put that line back.
The actual error seems to be `Undefined array key "templateSelected" in templates_c\en_US\%%C1\C1C\C1C61753%%InsertTokens.tpl.php on line 34`
This is when you choose the Send Outbound SMS action from the actions dropdown on a contact summary (who has a mobile phone).5.72.0